Update patch set 4

Browse Source

Patch Set 4:

> Patch Set 4:
> 
> > Wouldn't it make to sense to actually check whether a reboot is needed at all before doing so?
> 
> Well, we can but:
> 
> 1. We still need a code for reboot
> 
> 2. The current process assumes reboot before the configuration
> 
> 3. If we keep both scenarios (with and without reboot) in code it will be even more complex

Agreed, but don't we have the same problem by-design also in non-EC2 environments, like people booting outdated systems, installing NGCP CE on it and then only after reboot the kernel matches the system? (And by *always* rebooting means we make our pipeline intentionally slower)

BTW, did you test the code from this review? (Just checking/clarifying)

Patch-set: 4
Reviewer: Gerrit User 1000000 <1000000@85315e57-5f03-49c3-83f8-201ae2313a75>

changes/70/37670/meta

Gerrit User 1000000 7 years ago committed by Gerrit Code Review

parent 78fcbe946b

commit e1114ecd56

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File

Diff Content Not Available