From e1114ecd5626b520f447e1d50b4b758b27801f81 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000000 <1000000@85315e57-5f03-49c3-83f8-201ae2313a75> Date: Wed, 19 Feb 2020 11:00:14 +0100 Subject: [PATCH] Update patch set 4 Patch Set 4: > Patch Set 4: > > > Wouldn't it make to sense to actually check whether a reboot is needed at all before doing so? > > Well, we can but: > > 1. We still need a code for reboot > > 2. The current process assumes reboot before the configuration > > 3. If we keep both scenarios (with and without reboot) in code it will be even more complex Agreed, but don't we have the same problem by-design also in non-EC2 environments, like people booting outdated systems, installing NGCP CE on it and then only after reboot the kernel matches the system? (And by *always* rebooting means we make our pipeline intentionally slower) BTW, did you test the code from this review? (Just checking/clarifying) Patch-set: 4 Reviewer: Gerrit User 1000000 <1000000@85315e57-5f03-49c3-83f8-201ae2313a75>