TT#161150 Refactoring default values and parameter parsing

Sort default values.
Rework cmd parameters parsing - remove some reassign, reformat
to be more clear, etc.
Add some default options CROLE, EADDR, EXTERNAL_NETMASK, ROLE.

Change-Id: I287facafeb53dc5390517424935c8a50932246dc

templates/scripts/includes/deployment.sh

@@ -1270,64 +1270,69 @@ export LANG=C
 unset SHELL
 
 # defaults
+ADDITIONAL_PACKAGES=(git augeas-tools gdisk)
+ADJUST_FOR_LOW_PERFORMANCE=false
+CARRIER_EDITION=false
+CE_EDITION=false
+CROLE=''
+DEBIAN_RELEASE=bullseye
+DEBIAN_REPO_HOST="debian.sipwise.com"
+DEBIAN_REPO_TRANSPORT="https"
+DEBIAN_URL="${DEBIAN_REPO_TRANSPORT}://${DEBIAN_REPO_HOST}"
 DEBUG_MODE=false
 DEFAULT_INTERNAL_DEV=eth1
+DEFAULT_INTERNAL_NETMASK=255.255.255.248
 DEFAULT_IP1=192.168.255.251
 DEFAULT_IP2=192.168.255.252
 DEFAULT_IP_HA_SHARED=192.168.255.250
-DEFAULT_INTERNAL_NETMASK=255.255.255.248
+DHCP=false
-TARGET=/mnt
+DPL_MYSQL_REPLICATION=true
-PRO_EDITION=false
+EADDR=''
-CE_EDITION=false
-CARRIER_EDITION=false
-NGCP_INSTALLER=false
 EATMYDATA=true
+ENABLE_VM_SERVICES=false
+EXTERNAL_NETMASK=''
+FALLBACKFS_SIZE=''
+FILESYSTEM="ext4"
+FILL_APPROX_CACHE=true
+HALT=false
+INTERACTIVE=false
+LOGO=true
+NGCP_INSTALLER=false
+NGCP_PXE_INSTALL=false
+PRO_EDITION=false
 PUPPET=''
-PUPPET_SERVER=puppet.mgm.sipwise.com
-PUPPET_GIT_REPO=''
 PUPPET_GIT_BRANCH=master
+PUPPET_GIT_REPO=''
 PUPPET_LOCAL_GIT="${TARGET}/tmp/puppet.git"
-PUPPET_RESCUE_PATH="/mnt/rescue_drive"
 PUPPET_RESCUE_LABEL="SIPWRESCUE*"
-INTERACTIVE=false
+PUPPET_RESCUE_PATH="/mnt/rescue_drive"
-DHCP=false
+PUPPET_SERVER=puppet.mgm.sipwise.com
-LOGO=true
-RETRIEVE_MGMT_CONFIG=false
-TRUNK_VERSION=false
-DEBIAN_RELEASE=bullseye
-HALT=false
 REBOOT=false
-STATUS_DIRECTORY=/srv/deployment/
+RETRIEVE_MGMT_CONFIG=false
-STATUS_WAIT=0
+ROLE=''
-VAGRANT=false
-ADJUST_FOR_LOW_PERFORMANCE=false
-ENABLE_VM_SERVICES=false
-FILESYSTEM="ext4"
 ROOTFS_SIZE="10G"
-FALLBACKFS_SIZE="${ROOTFS_SIZE}"
+SIPWISE_APT_KEY_PATH="/etc/apt/trusted.gpg.d/sipwise-keyring-bootstrap.gpg"
-SWAPFILE_SIZE_MB_MIN="4096"
-SWAPFILE_SIZE_MB_MAX="16384"
-SWAPFILE_SIZE_MB=""
-SWRAID_DEVICE="/dev/md0"
-SWRAID_DESTROY=false
-DEBIAN_REPO_HOST="debian.sipwise.com"
-DEBIAN_REPO_TRANSPORT="https"
 SIPWISE_REPO_HOST="deb.sipwise.com"
 SIPWISE_REPO_TRANSPORT="https"
-DEBIAN_URL="${DEBIAN_REPO_TRANSPORT}://${DEBIAN_REPO_HOST}"
 SIPWISE_URL="${SIPWISE_REPO_TRANSPORT}://${SIPWISE_REPO_HOST}"
-DPL_MYSQL_REPLICATION=true
+STATUS_DIRECTORY=/srv/deployment/
-FILL_APPROX_CACHE=true
+STATUS_WAIT=0
+SWAPFILE_SIZE_MB=""
+SWAPFILE_SIZE_MB_MAX="16384"
+SWAPFILE_SIZE_MB_MIN="4096"
+SWRAID_DESTROY=false
+SWRAID_DEVICE="/dev/md0"
+TARGET=/mnt
+TRUNK_VERSION=false
+VAGRANT=false
 VLAN_BOOT_INT=2
-VLAN_SSH_EXT=300
-VLAN_WEB_EXT=1718
-VLAN_SIP_EXT=1719
-VLAN_SIP_INT=1720
 VLAN_HA_INT=1721
 VLAN_RTP_EXT=1722
-SIPWISE_APT_KEY_PATH="/etc/apt/trusted.gpg.d/sipwise-keyring-bootstrap.gpg"
+VLAN_SIP_EXT=1719
-NGCP_PXE_INSTALL=false
+VLAN_SIP_INT=1720
-ADDITIONAL_PACKAGES=(git augeas-tools gdisk)
+VLAN_SSH_EXT=300
+VLAN_WEB_EXT=1718
+
 
 # trap signals: 1 SIGHUP, 2 SIGINT, 3 SIGQUIT, 6 SIGABRT, 15 SIGTERM
 trap 'wait_exit;' 1 2 3 6 15 ERR EXIT
@@ -1633,6 +1638,8 @@ fi
 DEBIAN_URL="${DEBIAN_REPO_TRANSPORT}://${DEBIAN_REPO_HOST}"
 SIPWISE_URL="${SIPWISE_REPO_TRANSPORT}://${SIPWISE_REPO_HOST}"
 
+FALLBACKFS_SIZE="${FALLBACKFS_SIZE:-${ROOTFS_SIZE}}"
+
 ## }}}
 
 ## interactive mode {{{
@@ -1646,41 +1653,117 @@ fi
 
 for param in "$@" ; do
   case $param in
-    *-h*|*--help*|*help*) usage ; exit 0;;
+    *enablevmservices*)
-    *ngcpsp1*) ROLE=sp1 ; TARGET_HOSTNAME=sp1; PRO_EDITION=true; CE_EDITION=false ; NGCP_INSTALLER=true ;;
+      ENABLE_VM_SERVICES=true
-    *ngcpsp2*) ROLE=sp2 ; TARGET_HOSTNAME=sp2; PRO_EDITION=true; CE_EDITION=false ; NGCP_INSTALLER=true ;;
+    ;;
-    *ngcppro*) PRO_EDITION=true; CE_EDITION=false ; NGCP_INSTALLER=true ;;
+    *-h*|*--help*|*help*)
-    *ngcpce*) PRO_EDITION=false; CE_EDITION=true ; TARGET_HOSTNAME=spce ; ROLE='' ; NGCP_INSTALLER=true ;;
+      usage
-    *ngcpvers=*) SP_VERSION="${param//ngcpvers=/}";;
+      exit 0
-    *nongcp*) NGCP_INSTALLER=false;;
+    ;;
-    *noinstall*) NGCP_INSTALLER=false;;
+    *lowperformance*)
-    *ngcpinst*) NGCP_INSTALLER=true;;
+      ADJUST_FOR_LOW_PERFORMANCE=true
-    *noeatmydata*) EATMYDATA=false;;
+    ;;
-    *ngcphostname=*) TARGET_HOSTNAME="${param//ngcphostname=/}";;
+    *ngcpce*)
-    *ngcpeaddr=*) EADDR="${param//ngcpeaddr=/}";;
+      CE_EDITION=true
-    *ngcpip1=*) IP1="${param//ngcpip1=/}";;
+      TARGET_HOSTNAME=spce
-    *ngcpip2=*) IP2="${param//ngcpip2=/}";;
+      NGCP_INSTALLER=true
-    *ngcpipshared=*) IP_HA_SHARED="${param//ngcpipshared=/}";;
+    ;;
-    *ngcpnetmask=*) INTERNAL_NETMASK="${param//ngcpnetmask=/}";;
+    *ngcpcrole=*)
-    *ngcpextnetmask=*) EXTERNAL_NETMASK="${param//ngcpextnetmask=/}";;
+      CARRIER_EDITION=true
-    *ngcpcrole=*) CARRIER_EDITION=true; CROLE="${param//ngcpcrole=/}";;
+      CROLE="${param//ngcpcrole=/}"
-    *ngcpnw.dhcp*) DHCP=true;;
+    ;;
-    *ngcphalt*) HALT=true;;
+    *ngcpeaddr=*)
-    *ngcpreboot*) REBOOT=true;;
+      EADDR="${param//ngcpeaddr=/}"
-    *vagrant*) VAGRANT=true;;
+    ;;
-    *lowperformance*) ADJUST_FOR_LOW_PERFORMANCE=true;;
+    *ngcpextnetmask=*)
-    *enablevmservices*) ENABLE_VM_SERVICES=true;;
+      EXTERNAL_NETMASK="${param//ngcpextnetmask=/}"
-    *ngcpvlanbootint*) VLAN_BOOT_INT="${param//ngcpvlanbootint=/}";;
+    ;;
-    *ngcpvlansshext*) VLAN_SSH_EXT="${param//ngcpvlansshext=/}";;
+    *ngcphalt*)
-    *ngcpvlanwebext*) VLAN_WEB_EXT="${param//ngcpvlanwebext=/}";;
+      HALT=true
-    *ngcpvlansipext*) VLAN_SIP_EXT="${param//ngcpvlansipext=/}";;
+    ;;
-    *ngcpvlansipint*) VLAN_SIP_INT="${param//ngcpvlansipint=/}";;
+    *ngcphostname=*)
-    *ngcpvlanhaint*) VLAN_HA_INT="${param//ngcpvlanhaint=/}";;
+      TARGET_HOSTNAME="${param//ngcphostname=/}"
-    *ngcpvlanrtpext*) VLAN_RTP_EXT="${param//ngcpvlanrtpext=/}";;
+    ;;
-    *ngcpppa*) NGCP_PPA="${param//ngcpppa=/}";;
+    *ngcpinst*)
-    *swapfilesize*) SWAPFILE_SIZE_MB="${param//swapfilesize=/}";;
+      NGCP_INSTALLER=true
+    ;;
+    *ngcpip1=*)
+      IP1="${param//ngcpip1=/}"
+    ;;
+    *ngcpip2=*)
+      IP2="${param//ngcpip2=/}"
+    ;;
+    *ngcpipshared=*)
+      IP_HA_SHARED="${param//ngcpipshared=/}"
+    ;;
+    *ngcpnetmask=*)
+      INTERNAL_NETMASK="${param//ngcpnetmask=/}"
+    ;;
+    *ngcpnw.dhcp*)
+      DHCP=true
+    ;;
+    *ngcpppa*)
+      NGCP_PPA="${param//ngcpppa=/}"
+    ;;
+    *ngcppro*)
+      PRO_EDITION=true
+      NGCP_INSTALLER=true
+    ;;
+    *ngcpreboot*)
+      REBOOT=true
+    ;;
+    *ngcpsp1*)
+      ROLE=sp1
+      TARGET_HOSTNAME=sp1
+      PRO_EDITION=true
+      NGCP_INSTALLER=true
+    ;;
+    *ngcpsp2*)
+      ROLE=sp2
+      TARGET_HOSTNAME=sp2
+      PRO_EDITION=true
+      NGCP_INSTALLER=true
+    ;;
+    *ngcpvers=*)
+      SP_VERSION="${param//ngcpvers=/}"
+    ;;
+    *ngcpvlanbootint*)
+      VLAN_BOOT_INT="${param//ngcpvlanbootint=/}"
+    ;;
+    *ngcpvlanhaint*)
+      VLAN_HA_INT="${param//ngcpvlanhaint=/}"
+    ;;
+    *ngcpvlanrtpext*)
+      VLAN_RTP_EXT="${param//ngcpvlanrtpext=/}"
+    ;;
+    *ngcpvlansipext*)
+      VLAN_SIP_EXT="${param//ngcpvlansipext=/}"
+    ;;
+    *ngcpvlansipint*)
+      VLAN_SIP_INT="${param//ngcpvlansipint=/}"
+    ;;
+    *ngcpvlansshext*)
+      VLAN_SSH_EXT="${param//ngcpvlansshext=/}"
+    ;;
+    *ngcpvlanwebext*)
+      VLAN_WEB_EXT="${param//ngcpvlanwebext=/}"
+    ;;
+    *noeatmydata*)
+      EATMYDATA=false
+    ;;
+    *noinstall*)
+      NGCP_INSTALLER=false
+    ;;
+    *nongcp*)
+      NGCP_INSTALLER=false
+    ;;
+    *swapfilesize*)
+      SWAPFILE_SIZE_MB="${param//swapfilesize=/}"
+    ;;
+    *vagrant*)
+      VAGRANT=true
+    ;;
   esac
-  shift
 done
 
 ensure_packages_installed