MT#56693 fix voip_sound_set_handle_parents updates

* on update_sound_set_handle_parents() call delete
  orphaned entries from voip_sound_set_handle_parents
  do not have entries in the voip_sound_sets
* update_sound_set_handle_parents() improvements:
  - when u_sound_set_id is not null:
    = delete only child entries (before, also the parent entries
       were removed)
    = on insert, on duplicate update parent_set_id and parent_chain
      to effectively skip entries that already exist and only
      insert new entries

Change-Id: Id0881d9f79ddd05bc5be67d1f181ea809e43e180

db_scripts/diff/15766.up

@@ -18,6 +18,12 @@ DELIMITER ;;
 CREATE OR REPLACE PROCEDURE update_sound_set_handle_parents(IN u_sound_set_id INT, IN u_handle_id INT)
 BEGIN
     IF u_sound_set_id IS NOT NULL THEN
+        DELETE p FROM voip_sound_set_handle_parents p
+         WHERE set_id = u_sound_set_id
+           AND NOT EXISTS (SELECT id
+                             FROM voip_sound_sets
+                            WHERE id = u_sound_set_id);
+
         DELETE p FROM voip_sound_set_handle_parents p
          WHERE set_id IN (
             WITH RECURSIVE cte as (
@@ -34,23 +40,9 @@ BEGIN
          )
            AND (handle_id = u_handle_id OR 1=1);
 
-        DELETE p FROM voip_sound_set_handle_parents p
-         WHERE set_id IN (
-            WITH RECURSIVE cte as (
-                SELECT s.id, s.parent_id
-                  FROM voip_sound_sets s
-                 WHERE id = u_sound_set_id
-                UNION
-                SELECT s.id, s.parent_id
-                  FROM voip_sound_sets s
-                  JOIN cte ON cte.parent_id = s.id
-            )
-            SELECT id
-              FROM cte
-           )
-           AND (handle_id = u_handle_id OR 1=1);
-
         INSERT INTO voip_sound_set_handle_parents(set_id, handle_id, parent_set_id, parent_chain)
+        SELECT v.set_id, v.handle_id, v.data_set_id, v.parent_chain
+          FROM (
             WITH RECURSIVE cte as (
                 SELECT v.id AS set_id, v.handle_id,
                            v.id AS data_set_id,
@@ -87,7 +79,9 @@ BEGIN
             SELECT set_id, handle_id,
                    IF(data_set_id = set_id, NULL, data_set_id) as data_set_id,
                    parent_chain
-          FROM cte;
+              FROM cte
+        ) as v
+      ON DUPLICATE KEY UPDATE parent_set_id=v.data_set_id, parent_chain=v.parent_chain;
     ELSE
         IF u_handle_id IS NOT NULL THEN
             DELETE FROM voip_sound_set_handle_parents WHERE handle_id = u_handle_id;
@@ -129,9 +123,7 @@ delimiter ;;
 CREATE OR REPLACE TRIGGER voip_sound_sets_create_trig AFTER INSERT ON voip_sound_sets
 FOR each ROW BEGIN
 
-    IF NEW.parent_id IS NOT NULL THEN
     CALL update_sound_set_handle_parents(NEW.id, NULL);
-    END IF;
 
 END;;
 delimiter ;
@@ -170,6 +162,8 @@ CREATE OR REPLACE TRIGGER voip_sound_sets_delete_trig AFTER DELETE ON voip_sound
     END LOOP;
     CLOSE x;
 
+    CALL update_sound_set_handle_parents(OLD.id, NULL);
+
 END;;
 delimiter ;