27139 Commits (a186c9ee3080dc2d8f3b1af8322130c814aa9608)

 

All Branches   

Search

Author	SHA1	Message	Date
Matt Jordan	a186c9ee30	Merge "chan_sip: Do not send all codecs on INVITE."	11 years ago
Joshua Colp	7f30944049	Merge "StatsD: Add user input validation to the application"	11 years ago
tcambron	fdfd0fb488	StatsD: Add user input validation to the application ... Added code to accept user input and validate it before allowing it to be sent to the StatsD server. ASTERISK-25419 Reported By: Ashley Sanders Change-Id: I55c7ce44326a68ad6c5c1514b9575ac50f25bbc3	11 years ago
Joshua Colp	df3aa29100	Merge "res_pjsip: Add "like" processing to pjsip list and show commands"	11 years ago
Joshua Colp	17be8b9c20	Merge "install_prereq: Update repositories before install on Debian systems"	11 years ago
Alexander Traud	d343a25173	chan_sip: Do not send all codecs on INVITE. ... Since version 13, Asterisk sent all allowed codecs as callee, even when the caller did not request/support them. In case of dynamic RTP payloads, this led to the same ID for different codecs, which is not allowed by SIP/SDP. Now, the intersection between the requested and the supported codecs is send again. ASTERISK-24543 #close Change-Id: Ie90cb8bf893b0895f8d505e77343de3ba152a287	11 years ago
Joshua Colp	983cc5dda1	Merge "build: GCC 5.1.x catches some new const, array bounds and missing paren issues"	11 years ago
Matt Jordan	6b1e9fbdcf	Merge "format: Update the maximum packetization time for iLBC 30."	11 years ago
Rodrigo Ramírez Norambuena	88f3dbaec9	install_prereq: Update repositories before install on Debian systems ... When to install packages the indexed local is more old of the version of software on the repository they have been upgraded by security update then get the package will give 404 not found. The patch prevent by update local index to repository for aptitude before install. ASTERISK-25495 #close Reporte by: Rodrigo Ramírez Norambuena Change-Id: I645959e553aac542805ced394cac2dca964051fa	11 years ago
Matt Jordan	b5e5b89e16	Merge "res_pjsip_pubsub: Prevent sending NOTIFY on destroyed dialog."	11 years ago
Matt Jordan	b1fdc6c415	Merge "res_pjsip_pubsub: Ensure dialog lock balance."	11 years ago
Matt Jordan	d1441dfff7	Merge "res_pjsip_pubsub: Prevent crashes on final NOTIFY."	11 years ago
Matt Jordan	d93d4bcc0b	Merge "res_pjsip_pubsub: Remove serializer when sending final NOTIFY."	11 years ago
Matt Jordan	cde1f9728e	Merge "res_pjsip_pubsub: Fix crash on destruction of empty subscription tree."	11 years ago
Matt Jordan	fe52fa5cc3	Merge "res_pjsip_pubsub: Solidify lifetime and ownership of objects."	11 years ago
George Joseph	4328d320c2	build: GCC 5.1.x catches some new const, array bounds and missing paren issues ... Fixed 1 issue in each of the affected files. ASTERISK-25494 #close Reported-by: George Joseph Tested-by: George Joseph Change-Id: I818f149cd66a93b062df421e1c73c7942f5a4a77	11 years ago
George Joseph	a8aee0bbdb	res_pjsip: Add "like" processing to pjsip list and show commands ... Add the ability to filter output from pjsip list and show commands using the "like" predicate like chan_sip. For endpoints, aors, auths, registrations, identifyies and transports, the modification was a simple change of an ast_sorcery_retrieve_by_fields call to ast_sorcery_retrieve_by_regex. For channels and contacts a little more work had to be done because neither of those objects are true sorcery objects. That was just removing the non-matching object from the final container. Of course, a little extra plumbing in the common pjsip_cli code was needed to parse the "like" and pass the regex to the get_container callbacks. Some of the get_container code in res_pjsip_endpoint_identifier was also refactored for simplicity. ASTERISK-25477 #close Reported by: Bryant Zimmerman Tested by: George Joseph Change-Id: I646d9326b778aac26bb3e2bcd7fa1346d24434f1	11 years ago
Joshua Colp	08fe5256a9	Merge "res_pjsip_outbound_registration: registration stops due to fatal 4xx response"	11 years ago
Kevin Harwell	691c0e0b31	res_pjsip_outbound_registration: registration stops due to fatal 4xx response ... During outbound registration it is possible to receive a fatal (any permanent/ non-temporary 4xx, 5xx, 6xx) response from the registrar that is simply due to a problem with the registrar itself. Upon receiving the failure response Asterisk terminates outbound registration for the given endpoint. This patch adds an option, 'fatal_retry_interval', that when set continues outbound registration at the given interval up to 'max_retries' upon receiving a fatal response. ASTERISK-25485 #close Change-Id: Ibc2c7b47164ac89cc803433c0bbe7063bfa143a2	11 years ago
Joshua Colp	429ebae880	Merge "chan_sip: Fix autoframing=yes."	11 years ago
Joshua Colp	d73bd56b0a	Merge topic 'fix_oom_crash' ... * changes: strings.c: Fix __ast_str_helper() to always return a terminated string. Add missing failure checks to ast_str_set_va() callers.	11 years ago
Joshua Colp	52f1b8f385	Merge "res_pjsip: Move URI validation to use time."	11 years ago
Mark Michelson	5dd9e1938a	format_cap: Detect vector allocation failures. ... A crash was seen on a system that ran out of memory due to Asterisk not checking for vector allocation failures in format_cap.c. With this change, if either of the AST_VECTOR_INIT calls fail, we will return a value indicating failure. Change-Id: Ieb9c59f39dfde6d11797a92b45e0cf8ac5722bc8	11 years ago
Mark Michelson	7f9823ff57	res_pjsip_pubsub: Prevent sending NOTIFY on destroyed dialog. ... A certain situation can result in our attempting to send a NOTIFY on a destroyed dialog. Say we attempt to send a NOTIFY to a subscriber, but that subscriber has dropped off the network. We end up retransmitting that NOTIFY until the appropriate SIP timer says to destroy the NOTIFY transaction. When the pjsip evsub code is told that the transaction has been terminated, it responds in kind by alerting us that the subscription has been terminated, destroying the subscription, and then removing its reference to the dialog, thus destroying the dialog. The problem is that when we get told that the subscription is being terminated, we detect that we have not sent a terminating NOTIFY request, so we queue up such a NOTIFY to be sent out. By the time that queued NOTIFY gets sent, the dialog has been destroyed, so attempting to send that NOTIFY can result in a crash. The fix being introduced here is actually a reintroduction of something the pubsub code used to employ. We hold a reference to the dialog and wait to decrement our reference to the dialog until our subscription tree object is destroyed. This way, we can send messages on the dialog even if the PJSIP evsub code wants to terminate earlier than we would like. In doing this, some NULL checks for subscription tree dialogs have been removed since NULL dialogs are no longer actually possible. Change-Id: I013f43cddd9408bb2a31b77f5db87a7972bfe1e5	11 years ago
Mark Michelson	e9e4bc9ece	res_pjsip_pubsub: Ensure dialog lock balance. ... When sending a NOTIFY, we lock the dialog and then unlock the dialog when finished. A recent change made it so that the subscription tree's dialog pointer will be set NULL when sending the final NOTIFY request out. This means that when we attempt to unlock the dialog, we pass a NULL pointer to pjsip_dlg_dec_lock(). The result is that the dialog remains locked after we think we have unlocked it. When a response to the NOTIFY arrives, the monitor thread attempts to lock the dialog, but it cannot because we never released the dialog lock. This results in Asterisk being unable to process incoming SIP traffic any longer. The fix in this patch is to use a local pointer to save off the pointer value of the subscription tree's dialog when locking and unlocking the dialog. This way, if the subscription tree's dialog pointer is NULLed out, the local pointer will still have point to the proper place and the dialog lock will be unlocked as we expect. Change-Id: I7ddb3eaed7276cceb9a65daca701c3d5e728e63a	11 years ago
Mark Michelson	b96267f7a3	res_pjsip_pubsub: Prevent crashes on final NOTIFY. ... The SIP dialog is removed from the subscription tree when the final NOTIFY is sent. However, after the final NOTIFY is sent, the persistence update function still attempts to access the cseq from the dialog, resulting in a crash. This fix removes the subscription persistence at the same time that the dialog is removed from the subscription tree. This way, there is no attempt to update persistence when the subscription is being destroyed. Change-Id: Ibb46977a6cef9c51dc95f40f43446e3d11eed5bb	11 years ago
Mark Michelson	386cd7b2b0	res_pjsip_pubsub: Remove serializer when sending final NOTIFY. ... There have been crashes seen where a taskprocessor's listener is NULL unexpectedly. Looking at backtraces, the problem was specifically seen in PJSIP serializers. Subscriptions make the mistake of removing a serializer from a dialog during subscription tree destruction. Since subscription trees are reference-counted, guaranteeing the circumstances behind the destruction are not possible. This makes it so that the dialog serializer can be removed while not holding the dialog lock. This makes it possible for the distributor to get a pointer to the dialog serializer and have that serializer get freed out from under it. The fix for this is to remove the serializer from a subscription dialog when sending the final NOTIFY. This guarantees that the serializer is removed with the dialog lock held. By doing this, we guarantee that if the distributor gains access to the dialog's serializer, it will not be possible for the serializer to get freed by another thread. Change-Id: I21f5dac33529f65cec45679bdace60670800ff66	11 years ago
Mark Michelson	0b63d011c9	res_pjsip_pubsub: Fix crash on destruction of empty subscription tree. ... If an old persistent subscription is recreated but then immediately destroyed because it is out of date, the subscription tree will have no leaf subscriptions on it. This was resulting in a crash when attempting to destroy the subscription tree. A simple NULL check fixes this problem. Change-Id: I85570b9e2bcc7260a3fe0ad85904b2a9bf36d2ac	11 years ago
Mark Michelson	ac0194dad6	res_pjsip_pubsub: Solidify lifetime and ownership of objects. ... There have been crashes and general instability seen in the pubsub code, so this patch introduces three changes to increase the stability. First, the ownership model for subscriptions has been modified. Due to RLS, subscriptions are stored in memory as a tree structure. Prior to my patch, the PJSIP subscription was the owner of the subscription tree. When the PJSIP subscription told us that it was terminating, we started destroying the subscription tree along with all of the individual leaf subscriptions that belong to the tree. The problem with this model is that the two actors in play here, the PJSIP subscription and the individual leaf subscriptions, need to have joint ownership of the subscription tree. So now, the PJSIP subscription and the individual leaf subscriptions each have a reference to the subscription tree. This way, we will not actually free memory until no players are left that care. The PJSIP subscription is a bigger stakeholder, in that if the PJSIP subscription's reference to the subscription tree is removed, the subscription tree instructs the leaf subscriptions to shut down and drop their references to the subscription tree when possible. The individual leaf subscriptions, upon being told to shut down, can drop their stasis subscriptions or whatever they use to learn of new state, and then drop their reference to the subscription tree once they are ready to die. Second, the lifetime of a PJSIP subscription's reference to our subscription tree has been altered. As I learned from doing a deep dive, the PJSIP evsub code can tell Asterisk multiple times that the subscription has been terminated, and not all of these times are especially helpful. I have altered the message flow that we use for SIP subscriptions such that we will always drop the PJSIP subscription's reference to the subscription tree when we send the NOTIFY that terminates a SIP subscription. This also means that we will now queue NOTIFY requests to be sent after responding to incoming SUBSCRIBEs so that we can have predictable state changes from the PJSIP evsub code. Third, the synchronization of operations has been improved. PJSIP can call into our code from a serializer thread (e.g. upon receiving an incoming request) or from the monitor thread (e.g. when a subscription times out). Because of this, there is the possibility of competing threads stepping on each other. PJSIP attempts to do some synchronization on its own by always keeping the dialog lock held when it calls into us. However, since we end up pushing tasks into the serializer, the result was that serialized operations were not grabbing the dialog lock and could, as a result, step on something that was being attempted by a different thread. Now we ensure that serialized operations grab the dialog lock, then check for extenuating circumstances, then proceed with their operation if they can. Change-Id: Iff2990c40178dad9cc5f6a5c7f76932ec644b2e5	11 years ago
Richard Mudgett	1ce62b2545	strings.c: Fix __ast_str_helper() to always return a terminated string. ... Users of functions which call __ast_str_helper() such as the ones listed below are likely to not check the return value for failure so ensuring that the string is always nil terminated is a good safety measure. ast_str_set_va() ast_str_append_va() ast_str_set() ast_str_append() Change-Id: I36ab2d14bb6015868b49329dda8639d70fbcae07	11 years ago
Richard Mudgett	a04d946eaa	Add missing failure checks to ast_str_set_va() callers. ... Change-Id: I0c2cdcd53727bdc6634095c61294807255bd278f	11 years ago
Joshua Colp	41f9fd56fb	Merge "funcs/func_holdintercept: Actually add the HOLD_INTERCEPT function"	11 years ago
Joshua Colp	5de23256b0	Merge "rest-api-templates: Wikify error code response reasons"	11 years ago
Joshua Colp	27e0430f04	Merge "main/cdr: Allow modules to modify CDR fields before dispatching them"	11 years ago
Joshua Colp	64c172deba	res_pjsip: Move URI validation to use time. ... In a realtime based system with a limited number of threadpool threads it is possible for a deadlock to occur. This happens when permanent endpoint state is updated, which will cause database queries to be done. These queries may result in URI validation being done which is done synchronously using a PJSIP thread. If all PJSIP threads are in use processing traffic they themselves may be blocked waiting to get the permanent endpoint container lock when identifying an endpoint. This change moves URI validation to occur at use time instead of configuration time. While this comes at a cost of not seeing a problem until you use it it does solve the underlying deadlock problem. ASTERISK-25486 #close Change-Id: I2d7d167af987d23b3e8199e4a68f3359eba4c76a	11 years ago
Alexander Traud	f9cbac7321	format: Update the maximum packetization time for iLBC 30. ... In September 2006, the maximum packetization time (ptime) were set to such a low value, packetization was disabled for many codecs actually. This was fixed for many codecs but not for iLBC 30. This enables packetization for iLBC which can be enabled for example via allow=ilbc:60,gsm,alaw,ulaw in the file sip.conf. ASTERISK-7803 Change-Id: I2ef90023d35efb7cb8fe96ed74f53f6846ffad12	11 years ago
Alexander Traud	f3b2b3d1b3	chan_sip: Fix autoframing=yes. ... With Asterisk 13, the structures ast_format and ast_codec changed. Because of that, the paketization timing (framing) of the RTP channel moved away from the formats/codecs. In the course of that change, the ptime of the callee was not honored anymore, when the optional autoframing was enabled. ASTERISK-25484 #close Change-Id: Ic600ccaa125e705922f89c72212c698215d239b4	11 years ago
Matt Jordan	b425850f8b	rest-api-templates: Wikify error code response reasons ... Error response code descriptions may contain wiki markup that need to be escaped. Without this patch, Confluence will reject the document being sent and the responsible script will raise an exception. Change-Id: I21fcb66fee7f6332381f2b99b1b0195dff215ee5	11 years ago
Matt Jordan	7be6194d6f	funcs/func_holdintercept: Actually add the HOLD_INTERCEPT function ... When ab803ec342 was committed, it accidentally forgot to actually *add* the HOLD_INTERCEPT function. This highlights two interesting points: * Gerrit forces you to put the patch as it is going to into the repo up for review, which Review Board did not. Yay Gerrit. * No one apparently bothered to use this feature, or else they don't know about it. I'm going to go with the latter explanation. ASTERISK-24922 Change-Id: Ida38278f259dd07c334a36f9b7d5475b5db72396	11 years ago
Jonh Wendell	77780790e0	main/cdr: Allow modules to modify CDR fields before dispatching them ... This patch adds the functions ast_cdr_modifier_register() ast_cdr_modifier_unregister() That work much like ast_cdr_register() and ast_cdr_unregister(). Modules registered will be given a chance to modify (or to do whatever they want) CDR fields just before they are passed to registered engines. Thus, for instance, if a module change the "userfield" field of a CDR, the modified value will be passed to every registered CDR backend for logging. ASTERISK-25479 #close Change-Id: If11d8fd19ef89b1a66ecacf1201e10fcf86ccd56	11 years ago
Matt Jordan	b9bd249a85	contrib/scripts/autosupport: Update for Asterisk 13 ... This patch adds some minor tweaks for autosupport to update it for Asterisk 13. This includes: * Finally removing most references to Zaptel * Adding support for some additional 'core' commands, and fixing nomenclature that generally hasn't been used for some time * Adding some PJSIP/SIP commands to gather endpoints/peers and active channels Change-Id: Ic997b418cbd9313588b6608e50f47b0ce6f4f1f1 (cherry picked from commit 9fc9777fa3)	11 years ago
Corey Farrell	b19860c03a	res_ari_events: Fix memory leak in mustache template. ... ASTERISK-25308 fixed a memory leak in res_ari_events.c, but this file is regenerated by a template and the template was not fixed. Change-Id: Ied4c6deae89d21f87f9cf99676b1d055aa83b38b	11 years ago
Matt Jordan	2581e460e3	Merge topic 'ASTERISK-25461' ... * changes: config.c: Fix off-nominal memory leak. config.c: Fix potential memory corruption after [section](+). config.c: Fix #include after [section](+).	11 years ago
Joshua Colp	6b1badcb68	Merge "res_config_pgsql.c: Fix deadlock loading realtime configuration."	11 years ago
Joshua Colp	27e506e481	Merge "Build: Add menuselect options for using compiler sanitizers"	11 years ago
Richard Mudgett	d799bcf361	res_config_pgsql.c: Fix deadlock loading realtime configuration. ... On v13, loading several thousand PJSIP endpoints on Asterisk start causes a deadlock most of the time. Thanks to mdu113 for discovering that there was a call to pgsql_exec() not protected by the pgsql_lock reentrancy lock. {quote} I believe a code path exists that attempts to use pgsql connection without locking pgsql_lock. I believe what happens during that deadlock that I see is two concurrent threads are both attempting to send query to pgsql, one of the thread is using a code path without locking pgsql_lock. If they managed to send queries at the same time, it seems postgres ignores one of the queries and replies only to the one of them. If it happens so that the thread holding the lock didn't receive the reply it will wait for it (and hold the lock) forever (or at least for very long time), thus completely blocking all access to db. {quote} * Added missing reentrancy locking around pgsql_exec() in find_table(). * Moved unlock of pgsql_lock in unload_module() to avoid locking inversion between the psql_tables list lock and the pgsql_lock. ASTERISK-25455 #close Reported by: mdu113 Patches: res_config_pgsql.c-connlock2.diff (license #5543) patch uploaded by mdu113 Change-Id: Id9e7cdf8a3b65ff19964b0cf942ace567938c4e2	11 years ago
Matt Jordan	13229037d1	channels/chan_sip: Set cause code to 44 on RTP timeout ... To quote Olle: "When issuing a hangup due to RTP timeouts the cause code is not set. I have selected 44 based on Cisco's implementation..." ASTERISK-25135 #close Reported by: Olle Johansson patches: rtp-timeout-cause-1.8.diff uploaded by Olle Johansson (License 5267) Change-Id: Ia62100c55077d77901caee0bcae299f8dc7375fc	11 years ago
Matt Jordan	da54d3ddd1	Merge "StatsD: Write skeleton Asterisk application"	11 years ago
Richard Mudgett	984f100dab	config.c: Fix off-nominal memory leak. ... Change-Id: I06e346e9a5c63cc5071e7eda537310c4b43bffe0	11 years ago
Richard Mudgett	9951255775	config.c: Fix potential memory corruption after [section](+). ... The memory corruption could happen if the [section](+) is the last section in the file with trailing comments. In this case process_text_line() has left *last_cat is set to newcat and newcat is destroyed. Change-Id: I0d1d999f553986f591becd000e7cc6ddfb978d93	11 years ago