asterisk

Commit Graph

Author	SHA1	Message	Date
Russell Bryant	9d959a040e	Resolve some compiler warnings so that I can build under dev mode git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77770 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	94bef1a256	Merged revisions 77768 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r77768 \| file \| 2007-07-30 11:51:44 -0300 (Mon, 30 Jul 2007) \| 12 lines Merged revisions 77767 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r77767 \| file \| 2007-07-30 11:50:02 -0300 (Mon, 30 Jul 2007) \| 4 lines (closes issue #10334) Reported by: ramonpeek Pass through the return value from macro_exec through the MacroIf application. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77769 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b20ab775d5	minor code rearrangements: + place the link field at the beginning of struct sip_pvt, and not somewhere in the middle; + in __sip_reliable_xmit, remove a duplicate assignment, and put the statements in a more logical order (i.e. first copy the payload and associated info, then copy arguments from the caller, then finish initializing the headers...) nothing to backport. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77766 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	adc28d1e1c	rename handle_request() to handle_incoming(), as the former was misleading - the function deals with all incoming packets, be them requests or responses. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77753 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	6fe18e2403	move some dialog-only flags to proper variables, namely SIP_NOVIDEO, SIP_DIALOG_ANSWEREDELSEWHERE, SIP_PAGE2_NOTEXT, SIP_PAGE2_OUTGOING_CALL These are seldom used so the diff is relatively small. Note that 'OUTGOING_CALL' is dangerously similar to another dialog flag, 'SIP_OUTGOING', so the description will need to clarify the different meaning of the two. Also note that the description of NOTEXT is a bit unclear - does it mean we don't support it, or 'not requested or not supported' ? On passing fix a comment referring to video instead of text. Finally, mark with XXX a possibly misleading debugging message. (maybe the latter is worth backporting). git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77739 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	597421be86	use a function, cli_yesno(), to produce the output Yes or No for CLI lines. This helps maintaining consistency on output, slightly improves readability, and maybe one day will make it easier to translate the output in other languages (though i have a hard time believing that a CLI user who needs 'yes' and 'no' to be translated can actually figure out what he/she is doing!) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77726 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	89f44c573e	move the two remaining peer flags to proper variables. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77725 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	db10bcc41a	move RT_FROMCONTACT to a proper sip_peer field. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77712 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	fd2f3a20bc	Move some global 'flags' to individual variables. Start putting these variables in a single struct (called 'sip_cfg' for the time being, but it could as well be 'global' or some other name) so it is easy, when reading the code, to figure out what they are for. The downside of using struct fields instead of individual global variables is that the compiler cannot tell if there are unused fields. But the advantage of not cluttering the namespace and manilpulating all these variables at once certainly overcome the disadvantagess. Nothing to backport, again. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77711 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	5e35eab5a2	minor simplification of a conditional statement git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77697 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	c19549820e	build the version of sip_tech with no send_digit_begin at load time instead of duplicating the initializer. This should remove the risk of forgetting fields in the initializer. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77684 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	e5f3a6ccdb	remove bit position from description of SIP_* flags. use AST_FORMAT_AUDIO_MASK instead of playing with AST_FORMAT_MAX_AUDIO to determine audio formats. There is a dubious use of AST_FORMAT_MAX_AUDIO in sip_request_call() which surely needs fixing, namely: /* mask request with some set of allowed formats. * XXX this needs to be fixed. * The original code uses AST_FORMAT_AUDIO_MASK, but it is * unclear what to use here. We have global_capabilities, which is * configured from sip.conf, and sip_tech.capabilities, which is * hardwired to all audio formats. */ The latter is possibly something to backport when fixed. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77682 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	692e1fe0c4	back on cleaning up the usage of flags. Move together flags used in the same way (e.g. dialog only, dialog-peer, ...) so it will become easier to deal with them in a more systematic way. This is being done in stages so it will be easier to detect breakage, if any should occur. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77669 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b5c5227804	more documentation on internal representation of incoming SIP messages. Remove definitions for now-unused flags, and add references to print routines for other flags. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77668 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	5ca87effb7	make register_unref() return NULL so it is easy to cleanup the original pointer while calling the function. on passing add some comments on one of the places where it is used, and explain why it is safe there. again, a no-op for practical purposes. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77654 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	9f165b444a	add some documentation to auto_congest(), and some dialog_ref/unref (they are a no-op at the moment). Also clean a pointer after freeing memory to avoid dangling references, and write a for() loop in canonical form. In practice, everything in this commit is a no-op. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77653 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	a6e169c09a	more dialog_ref()/dialog_unref() calls git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77650 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	5dcfd811d7	more dialog_ref()/dialog_unref() calls git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77648 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	d480266797	start introducing hooks for reference counts on dialog descriptors. This commit is, for all practical purposes, a no-op, as it only introduces the dialog_ref() and dialog_unref() methods, and uses them in a few places (not all the places where they would be needed). The goal is to start annotating the code with these calls, so the transition to a proper container will be easier. Nothing to backport. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77647 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	df75ae2285	remove an unused string git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77631 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	800e1a6a03	simplify a conditional expression using S_OR git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77630 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	6d8c6a9961	make use of received= and rport= fields in sip replies. In a nutshell, these fields are used to tell a sip entity the address and port its request came from, and are extremely useful in the presence of NATs, especially with symmetric NATs where STUN is totally ineffective. This patch stores the address and port in the 'ourip' field of the dialog descriptor, so they can be reused in subsequent transactions. As it is, it works well for things like REGISTER requiring authentication, because the second REGISTER request (with auth credentials) will carry the correct address. Maybe it can also be useful, in case of an address change, to do one or both of the following: + propagate the new address to the parent user/peer descriptor so that new dialogs will use the correct address from the beginning. This is trivial to implement, I am just waiting for feedback on this. + re-issue a request in case of an address change. This a lot less trivial, maybe unnecessary, and probably covered by the previous item. I would seriously consider this patch for addition to 1.4 and 1.2. The code is very little intrusive, and it would solve in a correct way the nat traversal problems for which externip/externaddr/stunaddr are only a partial and expensive workaround. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77616 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	7f570a8b3d	Some ODBC drivers don't set the CHAR_OCTET_LENGTH field correctly. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77603 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	08cc64397d	Target asterisk.pdf stopped building when the build was moved to the doc directory. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77602 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	ce3de6a530	Merged revisions 77571 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77571 \| tilghman \| 2007-07-27 13:15:58 -0500 (Fri, 27 Jul 2007) \| 2 lines Missing newline ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77572 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	52099657d5	Merged revisions 77540 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77540 \| file \| 2007-07-27 14:04:08 -0300 (Fri, 27 Jul 2007) \| 6 lines (closes issue #10310) Reported by: prashant_jois Patches: cdr_pgsql.patch uploaded by prashant (license 114) Finish the Postgresql connection after the log messages are printed so we don't access invalid memory. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77541 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	111250f2ae	Turn 4 lines of code into 1 line that does the same thing. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77538 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	f6498f16bb	Merged revisions 77536 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77536 \| file \| 2007-07-27 13:27:16 -0300 (Fri, 27 Jul 2007) \| 6 lines (closes issue #10323) Reported by: julianjm Patches: chan_sip_device_state_hold_fix.v1.diff.txt uploaded by julianjm (license 99) Clear ONHOLD flag when decrementing the onHold peer count. If we did not do this the count may keep decreasing. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77537 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	8f1c914c89	'dialplan save' shouldn't be converting '\|' back to ',' anymore. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77534 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ceca4d97e1	These fixes take care of two problems: a complaint in asterisk-dev that goto's aren't working in trunk, a side effect of the move to commas as arg seps in apps and funcs; and a problem I spotted myself with dial's 'e' option, where gotos were off by one, because I forgot to set the AUTOLOOP flag in the peer channel. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77520 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	d17d9c542b	Merged revisions 77490 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77490 \| mmichelson \| 2007-07-27 09:30:43 -0500 (Fri, 27 Jul 2007) \| 3 lines "re-invite" was misspelled ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77491 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	7bd9b905e4	Merged revisions 77460 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77460 \| file \| 2007-07-26 20:19:04 -0300 (Thu, 26 Jul 2007) \| 4 lines (closes issue #10302) Reported by: litnialex If a DTMF end frame comes from a channel without a begin and it is going to a technology that only accepts end frames (aka INFO) then use the minimum DTMF duration if one is not in the frame already. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77461 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	d0a4fac1b3	Merged revisions 77424,77429 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77424 \| kpfleming \| 2007-07-26 17:14:21 -0500 (Thu, 26 Jul 2007) \| 2 lines use new canonical name for download server ........ r77429 \| kpfleming \| 2007-07-26 17:16:42 -0500 (Thu, 26 Jul 2007) \| 2 lines change protocol for downloads as well ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77432 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c405d98aad	Merged revisions 77410 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77410 \| russell \| 2007-07-26 16:23:23 -0500 (Thu, 26 Jul 2007) \| 10 lines AST_DEVMODE was defined in trunk, but not in 1.4. When Asterisk is compiled under dev mode, AST_DEVMODE will get defined in buildopts.h. Change 1.4 to define it in the same way that trunk does. Also, revert the change that added this define in the Makefile The advantage to doing it this way is that buildopts.h gets installed when you install Asterisk. Then, when building any out of tree modules, or building asterisk-addons, these modules know which options the rest of Asterisk was built with. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77411 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	57d5d489a7	Merged revisions 77380 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77380 \| mmichelson \| 2007-07-26 15:35:17 -0500 (Thu, 26 Jul 2007) \| 7 lines Fixes to get ast_backtrace working properly. The AST_DEVMODE macro was never defined so the majority of ast_backtrace never attempted compilation. The makefile now defines AST_DEVMODE if configure was run with --enable-dev-mode. Also, changes were made to acccomodate 64 bit systems in ast_backtrace. Thanks to qwell, kpfleming, and Corydon76 for their roles in allowing me to get this committed ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77381 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	03c973ab2d	Merged revisions 77350 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77350 \| tilghman \| 2007-07-26 14:32:17 -0500 (Thu, 26 Jul 2007) \| 2 lines Missed one ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77351 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	620a5a11e4	Merged revisions 77348 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77348 \| tilghman \| 2007-07-26 14:27:18 -0500 (Thu, 26 Jul 2007) \| 2 lines Oops, that builtin define should be all-lowercase. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	625410df63	Merged revisions 77318 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77318 \| mmichelson \| 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) \| 8 lines Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice. This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur. Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so I have removed the check for conn's existence from my_unload_module. (closes issue 10295, reported by junky, patched by me with input from prashant_jois) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77319 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f8483a0d04	Do a massive conversion for using the ast_verb() macro (closes issue #10277, patches by mvanbaak) Basically, this changes ... if (option_verbose > 2) ast_verbose(VERBOSE_PREFIX_3, "Something\n"); to ... ast_verb(3, "Something\n"); git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77299 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	51e7035dfe	Merge a big batch of documentation fixes for escaping, marking URLs, places where verbatim text went off the end of the page on the PDF, and various other improvements (closes issue #10307, IgorG) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77284 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	70f140c1d2	Revert some changes to call abs() on the result of ast_random(). * random() is defined to return a positive result, and now ast_random() will always do so as well git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77269 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3ed2deb7df	Ensure that the read from /dev/urandom returns a positive result (closes issue #10308, reported by yehavi, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77268 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	7a97d49914	Things expecting a positive result from ast_random() should not be surprised (closes #10308 ) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77267 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	77a75d46b2	Add a link to the list of assigned RTP payload types for convenience. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77266 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	5a96f8aa72	document how the RTP marker bit is passed for video frames, and why this does not overwrite useful information. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77248 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	f1aadc8161	add an entry for h263plus in an empty slot of the rtp types. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77233 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	f7213d2411	The upgrade of application argument separators to comma has an effect on AEL; I commented out the code that substitutes commas with vertbars, so we can get apps to parse their args correctly. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77218 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	0f326a83c5	Merged revisions 77191 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77191 \| murf \| 2007-07-25 16:39:27 -0600 (Wed, 25 Jul 2007) \| 1 line This fix solves problem with intense squelch noise when someone joins conf in bug 9430; We repro'd the problem with meetme opts of 'CciMo'; Josh Colp supplied this patch, and I'm applying it. It looks like playing the recorded username will louse up the next thing played into the channel. Josh rearranged the code so as to start things over before playing data directly into the conference. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77217 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	1c783e8cfb	Merged revisions 77176 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77176 \| file \| 2007-07-25 19:16:10 -0300 (Wed, 25 Jul 2007) \| 4 lines (closes issue #10303) Reported by: jtodd Add SPEECH_DTMF_TERMINATOR variable so the user can specify the digit to terminate a DTMF string with. If none is specified then no terminator will be used. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77182 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	546c742106	silence a warning in ast-devmode on a potentially uninitialized var. At first sight (but the function is very large so i am not 100% sure) the code seems correct, so maybe my compiler is just not smart enough to figure that out at the optimization level it has. Not worthwhile merging to 1.4 i believe. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77156 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

1 2 3 4 5 ...

12541 Commits (9d959a040ee87ffe2dca9e4556340d4df272b5c5) All Branches Search

12541 Commits (9d959a040ee87ffe2dca9e4556340d4df272b5c5)

All Branches