optimize file reading in pbx_spool (bug #3927)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.2-netsec
Kevin P. Fleming 20 years ago
parent c4ca6bf492
commit 3da361ee77

@ -94,10 +94,8 @@ static int apply_outgoing(struct outgoing *o, char *fn, FILE *f)
char buf[256]; char buf[256];
char *c, *c2; char *c, *c2;
int lineno = 0; int lineno = 0;
while(!feof(f)) { while(fgets(buf, sizeof(buf), f)) {
fgets(buf, sizeof(buf), f);
lineno++; lineno++;
if (!ast_strlen_zero(buf)) {
/* Trim comments */ /* Trim comments */
c = buf; c = buf;
while ((c = strchr(c, '#'))) { while ((c = strchr(c, '#'))) {
@ -186,7 +184,6 @@ static int apply_outgoing(struct outgoing *o, char *fn, FILE *f)
} else } else
ast_log(LOG_NOTICE, "Syntax error at line %d of %s\n", lineno, fn); ast_log(LOG_NOTICE, "Syntax error at line %d of %s\n", lineno, fn);
} }
}
} }
strncpy(o->fn, fn, sizeof(o->fn) - 1); strncpy(o->fn, fn, sizeof(o->fn) - 1);
if (ast_strlen_zero(o->tech) || ast_strlen_zero(o->dest) || (ast_strlen_zero(o->app) && ast_strlen_zero(o->exten))) { if (ast_strlen_zero(o->tech) || ast_strlen_zero(o->dest) || (ast_strlen_zero(o->app) && ast_strlen_zero(o->exten))) {

Loading…
Cancel
Save