You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

George Joseph f6f4cf459f stringfields: Refactor to allow fields to be added to the end of structures ... String fields are great, except that you can't add new ones without breaking ABI compatibility because it shifts down everything else in the structure. The only alternative is to add your own char * field to the end of the structure and manage the memory yourself which isn't ideal, especially since you then can't use the OPT_STRINGFIELD_T type. Background: The reason string fields had to be declared inside the AST_DECLARE_STRING_FIELDS block was to facilitate iteration over all declared fields for initialization, compare and copy. Since AST_DECLARE_STRING_FIELDS declared the pool, then the fields, then the manager, you could use the offsets of the pool and manager and iterate over the sequential addresses in between to access the fields. The actual pool, field allocation and field set operations don't actually care where the field is. It's just iteration over the fields that was the problem. Solution: Extended String Fields An extended string field is one that is declared outside the AST_DECLARE_STRING_FIELDS block but still (anywhere) inside the parent structure. Other than using AST_STRING_FIELD_EXTENDED instead of AST_STRING_FIELD, it looks the same as other string fields. It's storage comes from the pool and it participates in string field compare and copy operations peformed on the parent structure. It's also a valid target for the OPT_STRINGFIELD_T aco option type. Implementation: To keep track of the extended fields and make sure that ABI isn't broken, the existing embedded_pool pointer in the manager structure was repurposed to be a pointer to a separate header structure that contains the embedded_pool pointer plus a vector of fields. The length of the manager structure didn't change and the embedded_pool pointer isn't used in the macros, only the stringfields C code. A side benefit of this is that changing the header structure in the future won't break ABI. ast_string_fields_init initializes the normal string fields and appends them to the vector, and subsequent calls to ast_string_field_init_extended initialize and append the extended fields. Cleanup, ast_string_fields_cmp, and ast_string_fields_copy can now work on the vector instead of sequentially traversing the addresses between the pool and manager. The total size of a structure using string fields didn't change, whether using extended fields or not, nor have the offsets of any structure members, either inside the original block or outside. Adding an extended field to the end of a structure is the same as adding a char *. Details: The stringfield C code was pulled out from utils.c and into stringfields.c. It just made sense. Additional work was done in ast_string_field_init and ast_calloc_with_stringfields to handle the allocation of the new header structure and the vector, and the associated cleanup. In the process some additional NULL pointer checking was added. A lot of work was done in stringfields.h since the logic for compare and copy is there. Documentation was added as well as somne additional NULL checking. The ability to call ast_calloc_with_stringfields with a number of structures greater than 1 never really worked. Well, the calloc worked but there was no way to access the additional structures or clean them up. It was agreed that there was no use case for requesting more than 1 structure so an ast_assert was added to prevent it and the iteration code removed. Testing: The stringfield unit tests were updated to test both normal and extended fields. Tests for ast_string_field_ptr_set_by_fields and ast_calloc_with_stringfields were also added. As an ABI test, 13 was compiled from git and the res_pjsip_* modules, except res_pjsip itself, saved off. The patch was then added and a full compile and install was performed. Then the older res_pjsip_* moduled were copied over the installed versions so res_pjsip was new and the rest were old. No issues. contact->aor, which is a char * at the end of contact, was then changed to an extended string field and a recompile and reinstall was performed, again leaving stock versions of the the res_pjsip_* modules. Again, no issues with the res_pjsip_* modules using the old stringfield implementation and with contact->aor as a char *, and res_pjsip itself using the new stringfield implementation and contact->aor being an extended string field. Finally, several existing string fields were converted to extended string fields to test OPT_STRINGFIELD_T. Again, no issues. Change-Id: I235db338c5b178f5a13b7946afbaa5d4a0f91d61		9 years ago
..
editline	main/editline: Add .gitignore.	10 years ago
stdtime	test_time: Provide a timeout when waiting.	9 years ago
.gitignore	build-system: Allow building with static pjproject	9 years ago
Makefile	pjproject_bundled: Fix use of LDCONFIG for shared library link creation	9 years ago
abstract_jb.c	func_jitterbuffer: fix frame leaks.	11 years ago
acl.c	Fix error with mixed address family ACLs.	11 years ago
adsi.c	Allow Asterisk to compile under GCC 4.10	11 years ago
alaw.c	…
aoc.c	json: Audit ast_json_* usage for thread safety.	9 years ago
app.c	app: Queue hangup if channel is hung up during sub or macro execution.	9 years ago
ast_expr2.c	…
ast_expr2.fl	…
ast_expr2.h	…
ast_expr2.y	…
ast_expr2f.c	…
asterisk.c	Restrict CLI/AMI commands on shutdown.	9 years ago
asterisk.dynamics	Fix error loading res_monitor.	11 years ago
asterisk.exports.in	Add _IO_stdin_used in version-script to fix SIGBUSes on Sparc.	12 years ago
astfd.c	astfd: Fix buffer overflow in DEBUG_FD_LEAKS.	10 years ago
astmm.c	astmm.c: Add more stats to CLI "memory show" commands.	9 years ago
astobj2.c	Astobj2: Fix initialization order of refdebug and AO2_DEBUG.	10 years ago
astobj2_container.c	Astobj2: Ensure all calls to __adjust_lock pass a valid object.	10 years ago
astobj2_container_private.h	astobj2: Additional refactoring to push impl specific code down into the impls.	11 years ago
astobj2_hash.c	Astobj2: Correctly treat hash_fn returning INT_MIN	10 years ago
astobj2_private.h	astobj2: Additional refactoring to push impl specific code down into the impls.	11 years ago
astobj2_rbtree.c	Astobj2: Ensure all calls to __adjust_lock pass a valid object.	10 years ago
audiohook.c	Fix crash in audiohook translate to slin	10 years ago
autochan.c	app_chanspy: Fix occasional deadlock with ChanSpy and Local channels.	9 years ago
autoservice.c	autoservice: stop thread on graceful shutdown	11 years ago
backtrace.c	Fix memory corruption when trying to get "core show locks".	12 years ago
bridge.c	bridge.c: Crash during attended transfer when missing a local channel half	9 years ago
bridge_after.c	Fix some memory leaks.	10 years ago
bridge_basic.c	Merge "bridge_basic: don't play an attended transfer fail sound after target hangs up" into 13	9 years ago
bridge_channel.c	bridge core: Add owed T.38 terminate when channel leaves a bridge.	9 years ago
bridge_roles.c	ARI: bridges/{bridgeID}/addChannel: add roles parameter	12 years ago
bucket.c	A couple minor cleanup tweaks.	10 years ago
buildinfo.c	…
callerid.c	SIP diversion: Fix REDIRECTING(reason) value inconsistencies.	9 years ago
ccss.c	ccss.c: Replace space in taskprocessor name.	9 years ago
cdr.c	main/cdr: Allow setting properties on a finalized CDR if it is the last one	9 years ago
cel.c	cel.c: Fix mismatch in ast_cel_track_event() return type.	9 years ago
channel.c	bridge core: Add owed T.38 terminate when channel leaves a bridge.	9 years ago
channel_internal_api.c	channel api: Create is_t38_active accessor functions.	9 years ago
chanvars.c	res_phoneprov: Refactor phoneprov to allow pluggable config providers	11 years ago
cli.c	Restrict CLI/AMI commands on shutdown.	9 years ago
codec.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
codec_builtin.c	format: Update the maximum packetization time for iLBC 30.	10 years ago
config.c	sorcery/res_pjsip: Refactor for realtime performance	9 years ago
config_options.c	config: fix flags in uint option handler	9 years ago
core_local.c	bridge.c: Crash during attended transfer when missing a local channel half	9 years ago
core_unreal.c	core_unreal.c: Add clarification comment about channel ref.	9 years ago
crypt.c	Fix utils directory breakage.	12 years ago
cygload.c	…
data.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
datastore.c	This is no longer needed.	12 years ago
db.c	AMI: Make AMI actions that generate event lists consistent.	10 years ago
devicestate.c	devicestate: Cleanup engine thread during graceful shutdown.	9 years ago
dial.c	main/dial: Protect access to the format_cap structure of the requesting channel	10 years ago
dns.c	Clean up files that do not end with newlines	11 years ago
dnsmgr.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
dsp.c	res_pjsip: Add an 'auto' option for DTMF Mode	10 years ago
ecdisa.h	…
endpoints.c	stasis_cache_pattern: Backport to 13	9 years ago
enum.c	clang compiler warnings: Fix autological comparisons	10 years ago
event.c	Clang: change previous tautological-compare fixes.	10 years ago
features.c	Remove unneeded uses of optional_api providers.	10 years ago
features_config.c	bridge_basic: don't cache xferfailsound during an attended transfer	9 years ago
file.c	ast_format_cap_get_names: To display all formats, the buffer was increased.	10 years ago
fixedjitterbuf.c	…
fixedjitterbuf.h	…
format.c	format: Register format-attribute module with cached formats.	10 years ago
format_cache.c	format_cache.c: Add missing slin12 format to ast_format_cache_is_slinear().	10 years ago
format_cap.c	ast_format_cap_append_by_type: Resolve codec reference leak.	9 years ago
format_compatibility.c	chan_iax2: Several media format fixes.	11 years ago
frame.c	media formats: re-architect handling of media for performance improvements	11 years ago
framehook.c	clang compiler warnings: Fix format specified in framehook	10 years ago
fskmodem.c	…
fskmodem_float.c	…
fskmodem_int.c	…
global_datastores.c	Detect potential forwarding loops based on count.	10 years ago
hashtab.c	hashtab: Add NULL check when destroying iterator.	10 years ago
heap.c	Fix incorrect usages of ast_realloc().	12 years ago
http.c	AST-2016-001 http: Provide greater control of TLS and set modern defaults.	9 years ago
image.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
indications.c	clang compiler warnings: Fix autological comparisons	10 years ago
io.c	Allow Asterisk to compile under GCC 4.10	11 years ago
jitterbuf.c	clang compiler warnings: Fix -Wabsolute-value warnings	10 years ago
json.c	ARI: Fix crash if integer values used in JSON payload 'variables' object.	10 years ago
libasteriskpj.c	build-system: Allow building with static pjproject	9 years ago
libasteriskssl.c	tcptls: Avoiding ERR_remove_state in OpenSSL.	10 years ago
libasteriskssl.exports.in	…
loader.c	loader: Retry dlopen when loading fails	9 years ago
lock.c	DEBUG_THREADS: Fix regression and lock tracking initialization problems.	11 years ago
logger.c	core/logging: Fix broken syslog levels on older glibc.	9 years ago
manager.c	Restrict CLI/AMI commands on shutdown.	9 years ago
manager_bridges.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
manager_channels.c	AMI: Add Linkedid to the standard channel snapshot AMI event headers.	10 years ago
manager_endpoints.c	res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes	10 years ago
manager_mwi.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
manager_system.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
max_forwards.c	Detect potential forwarding loops based on count.	10 years ago
md5.c	…
media_index.c	media formats: re-architect handling of media for performance improvements	11 years ago
message.c	CHAOS: cleanup possible null vars on msg alloc failure	9 years ago
mixmonitor.c	Removed quotes from svn:keywords props on a few files.	12 years ago
named_acl.c	acl: Fix reloading of configuration if configuration file does not exist at startup.	10 years ago
netsock.c	Move eid functions to utils.c, mark netsock.h deprecated	11 years ago
netsock2.c	Audit ast_sockaddr_resolve() usage for memory leaks.	10 years ago
optional_api.c	Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages	11 years ago
parking.c	res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers	11 years ago
pbx.c	pbx: Deadlock between contexts container and context_merge locks	9 years ago
pbx_app.c	main/pbx: Move dialplan application management routines to pbx_app.c.	9 years ago
pbx_builtins.c	asterisk.h: Add ASTERISK_REGISTER_FILE macro	9 years ago
pbx_functions.c	asterisk.h: Add ASTERISK_REGISTER_FILE macro	9 years ago
pbx_hangup_handler.c	main/pbx: Move hangup handler routines to pbx_hangup_handler.c.	9 years ago
pbx_private.h	main/pbx: Move dialplan application management routines to pbx_app.c.	9 years ago
pbx_switch.c	main/pbx: Move switch routines to pbx_switch.c.	9 years ago
pbx_timing.c	main/pbx: Move timing routines to pbx_timing.c.	9 years ago
pbx_variables.c	main/pbx: Move variable routines to pbx_variables.c.	9 years ago
pickup.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
plc.c	…
poll.c	…
presencestate.c	AMI: Escape string values.	10 years ago
privacy.c	…
rtp_engine.c	Merge "json: Audit ast_json_* usage for thread safety." into 13	9 years ago
say.c	app_voicemail, say: Add support for Japanese Language	11 years ago
sched.c	sched.c: Ensure oldest expiring entry runs first.	9 years ago
sdp_srtp.c	main/sdp_srtp.c: allow SDP crypto tag to be up to 9 digits	10 years ago
security_events.c	Clang: change previous tautological-compare fixes.	10 years ago
sem.c	Various fixes for OS X	10 years ago
sha1.c	…
sip_api.c	…
slinfactory.c	media formats: re-architect handling of media for performance improvements	11 years ago
smoother.c	media formats: re-architect handling of media for performance improvements	11 years ago
sorcery.c	sorcery: Refactor create, update and delete to better deal with caches	9 years ago
sounds_index.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
srv.c	…
stasis.c	Stasis: Create human friendly taskprocessor/serializer names.	9 years ago
stasis_bridges.c	core: Don't create snapshots with locks.	10 years ago
stasis_cache.c	main/stasis: Allow subscriptions to use a threadpool for message delivery	11 years ago
stasis_cache_pattern.c	stasis_cache_pattern: Backport to 13	9 years ago
stasis_channels.c	json: Audit ast_json_* usage for thread safety.	9 years ago
stasis_endpoints.c	main/stasis_endpoints: Fix ContactStatusChange JSON for roundtrip_usec field	10 years ago
stasis_message.c	Stasis: Allow message types to be blocked	11 years ago
stasis_message_router.c	res_pjsip: make it unloadable (take 2)	10 years ago
stasis_system.c	Stasis: Allow message types to be blocked	11 years ago
strcompat.c	…
stringfields.c	stringfields: Refactor to allow fields to be added to the end of structures	9 years ago
strings.c	sorcery/res_pjsip: Refactor for realtime performance	9 years ago
stun.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
syslog.c	main/syslog: Allow dynamic logs, such as security events, to log to the syslog	10 years ago
taskprocessor.c	taskprocessor.c: Increase CLI "core ping taskprocessor" timeout.	9 years ago
tcptls.c	Check for OpenSSL defines before trying to use them.	9 years ago
tdd.c	…
term.c	main: Slight refactor of main. Improve color situation.	10 years ago
test.c	test.c: Add unit test registration checks for summary and description.	10 years ago
threadpool.c	res_pjsip: Deny requests when threadpool queue is backed up.	10 years ago
threadstorage.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
timing.c	Replace most uses of ast_register_atexit with ast_register_cleanup.	10 years ago
translate.c	translate: Avoid a warning message when doing FEC within Opus Codec.	10 years ago
udptl.c	AST-2016-003 udptl.c: Fix uninitialized values.	9 years ago
ulaw.c	…
uri.c	uri: Quiet warning about type qualifiers ignored on function return type	11 years ago
utils.c	stringfields: Refactor to allow fields to be added to the end of structures	9 years ago
uuid.c	Fix printf problems with high ascii characters after r413586 (1.8).	11 years ago
xml.c	Detect and use xsltCleanupGlobals when available	12 years ago
xmldoc.c	xmldoc: Improve xmldoc wrapping of 'core show ...' output.	10 years ago