7648 Commits (f42ada7a25d9c604b26201328ab1c2077eddb13b)

 

All Branches   

Search

Author	SHA1	Message	Date
Tilghman Lesher	f42ada7a25	Fix for AST-2008-012 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@162868 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	84c5074ec3	Fix build errors on FreeBSD (uint -> unsigned int). ... (closes issue #14006) Reported by: alphaque Patches: astobj2.h-patch uploaded by alphaque (license 259) (Slightly modified by seanbright) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@161421 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	932f5ca647	Regression fix for last security fix. Set the iseqno correctly. ... (closes issue #13918) Reported by: ffloimair Patches: 20081119__bug13918.diff.txt uploaded by Corydon76 (license 14) Tested by: ffloimair git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@159245 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	71fdd7d526	Regression fixes for Solaris ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@136945 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	643879cabc	Fix the IAX2 URI for calling Digium ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@133577 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	703220f1f4	This part was not correctly patched for AST-2008-010. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@133360 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	27290e8976	Fixes for AST-2008-010 and AST-2008-011 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@132711 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	ec11516f11	Copy the From header into a variable so that pedantic SIP handling does not try to mess with a NULL pointer. (AST-2008-008) ... (closes issue #12607) Reported by: hooi git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@120109 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	43ea28d8f6	- Instead of only enforcing destination call number checking on an ACK, check ... all full frames except for PING and LAGRQ, which may be sent by older versions too quickly to contain the destination call number. (As suggested by Tim Panton on the asterisk-dev list) - Merge changes from team/russell/iax2-frame-race, which prevents PING and LAGRQ from being sent before the destination call number is known. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@119237 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ef549fe985	Merge changes from team/russell/iax2-another-fix-to-the-fix ... As described in the following post to the asterisk-dev mailing list, only enforce destination call numbers when processing an ACK. http://lists.digium.com/pipermail/asterisk-dev/2008-May/033217.html git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@119008 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	40520cc2a4	Fix a race condition that bbryant just found while doing some IAX2 testing. ... He was running Asterisk trunk running IAX2 calls through a few Asterisk boxes, however, the audio was extremely choppy. We looked at a packet trace and saw a storm of INVAL and VNAK frames being sent from one box to another. It turned out that what had happened was that one box tried to send a CONTROL frame before the 3 way handshake had completed. So, that frame did not include the destination call number, because it didn't have it yet. Part of our recent work for security issues included an additional check to ensure that frames that are supposed to include the destination call number have the correct one. This caused the frame to be rejected with an INVAL. The frame would get retransmitted for forever, rejected every time ... This race condition exists in all versions that got the security changes, in theory. However, it is really only likely that this would cause a problem in Asterisk trunk. There was a control frame being sent (SRCUPDATE) at the _very_ beginning of the call, which does not exist in 1.2 or 1.4. However, I am fixing all versions that could potentially be affected by the introduced race condition. These changes are what bbryant and I came up with to fix the issue. Instead of simply dropping control frames that get sent before the handshake is complete, the code attempts to wait a little while, since in most cases, the handshake will complete very quickly. If it doesn't complete after yielding for a little while, then the frame gets dropped. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@115564 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c5c3cb32f1	Remove remnants of dlinkedlists. I didn't actually use them in the final version ... of my IAX2 improvements. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@115511 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	3ce33b090c	read requires an argument on some non-bash shells ... (closes issue #12593) Reported by: bkruse Patches: getilbc.sh_12593_v1.diff uploaded by bkruse (license 132) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@115421 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f8d551bd2b	Merge changes from team/russell/iax2_find_callno_1.2 ... These changes address a critical performance issue introduced in the latest release. The fix for the latest security issue included a change that made Asterisk randomly choose call numbers to make them more difficult to guess by attackers. However, due to some inefficient (this is by far, an understatement) code, when Asterisk chose high call numbers, chan_iax2 became unusable after just a small number of calls. On a small embedded platform, it would not be able to handle a single call. On my Intel Core 2 Duo @ 2.33 GHz, I couldn't run more than about 16 IAX2 channels. Ouch. These changes address some performance issues of the find_callno() function that have bothered me for a very long time. On every incoming media frame, it iterated through every possible call number trying to find a matching active call. This involved a mutex lock and unlock for each call number checked. So, if the random call number chosen was 20000, then every media frame would cause 20000 locks and unlocks. Previously, this problem was not as obvious since Asterisk always chose the lowest call number it could. A second container for IAX2 pvt structs has been added. It is an astobj2 hash table. When we know the remote side's call number, the pvt goes into the hash table with a hash value of the remote side's call number. Then, lookups for incoming media frames are a very fast hash lookup instead of an absolutely insane array traversal. In a quick test, I was able to get more than 3600% more IAX2 channels on my machine with these changes. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@115296 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	a698166af0	stop script from appending source code if run multiple times ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@114822 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	38419fb811	When we receive a full frame that is supposed to contain our call number, ... ensure that it has the correct one. (closes issue #10078) (AST-2008-006) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@114561 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	8f7422b931	update UPGRADE notes to document usage of the script ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@111125 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	1501383484	add a script to make getting the iLBC source code simple for end users ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@111019 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	3c780866b3	due to licensing restrictions, we cannot distribute the source code for iLBC encoding and decoding... so remove it, and add instructions on how the user can obtain it themselves ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@110869 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	62766834c8	Fix some very broken code that was introduced in 1.2.26 as a part of the security ... fix. The dnsmgr is not appropriate here. The dnsmgr takes a pointer to an address structure that a background thread continuously updates. However, in these cases, a stack variable was passed. That means that the dnsmgr thread would be continuously writing to bogus memory. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@110335 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	53ca368854	Fix character string being treated as format string ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@109488 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	866bf7984a	Do not return with a successful authentication if the From header ends up empty. ... (AST-2008-003) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@109391 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	dd7fd5e641	Change misery.digium.com to pbx.digium.com ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@96931 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	47b472894b	Fix for fix for security fix (third time's the charm?) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@94661 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4208af2204	Fix another potential seg fault ... ... (closes issue #11606) Reported by: dimas git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@94255 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	04e4f3d345	Fix a couple of places where it's possible to dereference a NULL pointer. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@94214 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	0f7afb14e4	Oops, missed this one case ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@93675 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	1e6902b29d	Fixing AST-2007-027 (Closes issue #11119) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@93667 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	1897d857f0	Properly escape src and dst fields (Fixes AST-2007-026) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@90170 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	c58235bed4	clarify the OpenSSL and OpenH323 license exceptions ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@82334 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	0edee75c07	Revert patch committed for issue #9660. It broke E&M trunks. ... (closes issue #10360) (closes issue #10364) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@78370 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	726fa701da	This patch hopefully solves 10141; The user is running with it, and it doesn't appear to harm asterisk's operation, and may prevent a crash. I'll store it in 1.2, as we have shut down support on 1.2, but since I developed the patch before support finished, and it might affect 1.4 and trunk, I'm going ahead with it. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@77942 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	330090142f	This probably isn't super-general, but it's a first stab at using kill -11 to generate a core file instead of gcore. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@77842 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	2cdedcbe94	Revert change in revision 71656, even though it fixed a bug, because many people were depending upon the (broken) behavior. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@77782 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	ea98dd3dfc	(closes issue #10334) ... Reported by: ramonpeek Pass through the return value from macro_exec through the MacroIf application. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@77767 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	32ade7d7fc	this fixes bug 10293, where the error message because defaultzone or loadzone was not defined was confusing ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76978 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	325bfeeda5	Oops, res contains the error code, not errno. I was wondering why a mutex was reporting "No such file or directory"... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76934 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	f95db061fd	Don't create the Asterisk channel until we are starting the PBX on it. ... (ASA-2007-018) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76802 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	a62bba55d8	(closes issue #5866) ... Reported by: tyler Do not force channel format changes when a generator is present. The generator may have changed the formats itself and changing them back would cause issues. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76653 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	2405536de9	(closes issue #10236) ... Reported by: homesick Patches: rpid_1.4_75840.patch uploaded by homesick (license 91) Accept Remote Party ID on guest calls. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76560 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	44b5abf39f	We should not use C++ reserved words in API headers (closes issue #10266) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76409 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	831ebbebb7	Backport a fix for a memory leak that was fixed in trunk in reivision 76221 ... by rizzo. The memory used for the localaddr list was not freed during a configuration reload. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76226 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	a7047b7ed5	(closes issue #10247) ... Reported by: fkasumovic Patches: chan_sip.patch uploaded by fkasumovic (license #101) Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@76080 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	9df29ba46f	When processing full frames, take sequence number wraparound into account when ... deciding whether or not we need to request retransmissions by sending a VNAK. This code could cause VNAKs to be sent erroneously in some cases, and to not be sent in other cases when it should have been. (closes issue #10237, reported and patched by mihai) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75927 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	6b5a7a6f64	When traversing the queue of frames for possible retransmission after ... receiving a VNAK, handle sequence number wraparound so that all frames that should be retransmitted actually do get retransmitted. (issue #10227, reported and patched by mihai) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75757 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	dc4a74f57f	Store prior to copy (closes issue #10193) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75748 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Dwayne M. Hubbard	dd77af3fe3	removed the word 'pissed' from ast_log(...) function call for BE-90 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75657 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	d359de6edb	Properly check for the length in the skinny packet to prevent an invalid memcpy. ... (ASA-2007-016) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75449 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	d0b4144eb4	Ensure that when encoding the contents of an ast_frame into an iax_frame, that ... the size of the destination buffer is known in the iax_frame so that code won't write past the end of the allocated buffer when sending outgoing frames. (ASA-2007-014) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75444 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	d2cb9b0d3b	After parsing information elements in IAX frames, set the data length to zero, ... so that code later on does not think it has data to copy. (ASA-2007-015) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75440 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago