34516 Commits (ea04aadb331c046d2e6334f89d2b829cfbeb650d)

 

All Branches   

Search

Author	SHA1	Message	Date
Tinet-mucw	ea04aadb33	apps/app_chanspy: don't delay spyee Hangup when spy channel has no reverse media ... channel_spy() waited indefinitely on the spy channel, so after the spyee hung up the spy audiohook leaving RUNNING was not noticed until waitfor timed out. That kept an autochan reference on the spyee and delayed its destructor / Hangup. Poll with a short timeout instead. On timeout, only re-check hook status; call ast_read() only when the spy channel is readable. Resolves: #2123	1 month ago
whitetreebug	cecb374d91	res_prometheus: add toggle config for metrics ... In high‑volume call scenarios, Prometheus exports a large number of channels‑related and bridges-related metrics.Not all users require channels_state, channels_duration and bridges_channels.Add conf options to enable or disable channel_details(covering channels_state, channels_duration) and bridge_details(covering bridges_channels). UserNote: Add new config option 'channels_detail_metrics_enabled' to disable export of 'asterisk_channels_state' and 'asterisk_channels_duration_seconds' metrics,It defaults to 'yes' to preserve existing behavior Add new config option 'bridges_detail_metrics_enabled' to disable export of 'asterisk_bridges_channels_count' metric, It defaults to 'yes' to preserve existing behavior Explicitly enable bridges_detail_metrics_enabled for the bridge_to_string unit‑test.	1 month ago
Naveen Albert	62edbf0fc7	chan_dahdi: Make DAHDI device state cacheable to fix device state sync. ... Commit 8fb5bdce9a disabled caching of certain device states that weren't associated with real devices in order to prevent a resource exhaustion attack from guest/unauthenticated connections. In most cases, code was converted to remain cacheable; the few exceptions had mainly to do with certain paths in channel drivers for guest or unauthenticated access. However, everything in chan_dahdi was made uncachable for no apparent reason. This is not harmless, since it prevents device state synchronization from working (e.g. with res_pjsip_publish_asterisk) since device state updates that are marked uncachable result in hints on remote systems always showing "Unavailable" since uncached device state updates are simply discarded. Since DAHDI devices very much correspond to real devices (perhaps more so than in any other channel driver), we can safely cache device state for DAHDI channels, which also ensures that device state synchronization now works properly. Resolves: #2138	1 month ago
Fran Vicente	0db5198b3f	app_confbridge: Add announcements option to disable conference announcements ... Every conference unconditionally created an announcer channel (CBAnn) and a taskprocessor thread to play announcements to the conference as a whole, even on systems that never play any. That costs a channel, a thread and a bridge member per conference. A new bridge profile option, announcements, defaults to yes and preserves the previous behavior. When set to no, no announcer channel is created and nothing is played to the conference as a whole: the join and leave sounds, recorded name intros, the participant count announced to everyone, sound_begin and sound_leader_has_left are all suppressed, and users are never prompted to record their name regardless of the announce_join_leave user profile option. Prompts played only to the participant that caused them are unaffected, since they are played on that participant's own channel. sound_kicked, sound_muted, sound_unmuted, the join sound played back by hear_own_join_sound and the participant count requested from the DTMF menu all still play. The announcer channel exists for the lifetime of the conference, so the value that takes effect is the one from the bridge profile of the channel that creates the conference. Resolves: #2131 UserNote: A new ConfBridge bridge profile option, announcements, can be set to no to stop announcements from being played to the conference as a whole. No announcer channel is then created, which saves a channel and a taskprocessor thread per conference. Prompts played only to the participant that caused them are not affected. It defaults to yes, which is the previous behavior.	1 month ago
Peter Lemenkov	78b7c4e882	Bundled pjproject: Do not discard the ambient CFLAGS ... Commit f82393da0d ("Bundled pjproject: Make it easier to override options in config_site.h") added PJPROJECT_CONFIG_OPTS += CFLAGS="$(PJPROJECT_CFLAGS)" Previously CFLAGS was never passed on the aconfigure command line, so the bundled pjproject inherited the exported CFLAGS from the environment. Passing it explicitly overrides that, and PJPROJECT_CFLAGS contains only the options this file adds (-DPJ_HAS_LINUX_EPOLL=1), so every distribution flag is lost. Appending to the ambient CFLAGS rather than replacing them keeps the new PJPROJECT_CFLAGS override working while restoring inheritance. Resolves: #2132 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>	1 month ago
Mehrdad Seifzadeh	a5b010b6ea	res_resolver_unbound: Include libunbound error reason ... Failures returned by ub_resolve_async() are currently logged without the reason provided by libunbound, making resolver configuration failures difficult to diagnose. Include ub_strerror() in the error message so the underlying libunbound failure reason is available in the Asterisk log. Resolves: #2110	1 month ago
seifzadeh	fcd5d4d03c	app_queue: Update lastpause on realtime pause transition ... Realtime queue members used lastpause to determine whether a member had transitioned from unpaused to paused. However, lastpause also stores the timestamp of the member's most recent pause and should not be cleared when the member is unpaused. Compare the existing paused state with the new realtime value instead, and update lastpause only when the member transitions from unpaused to paused. Resolves: #1760	1 month ago
George Joseph	050332665f	chan_websocket: Add "unbuffered" mode and fix a few bugs. ... Besides the User and Developer notes below, checks have been added to reject a START_MEDIA_BUFFERING buffering command if it's already active and to reject a STOP_MEDIA_BUFFERING command if a corresponding START_MEDIA_BUFFERING command was never issued. Resolves: #2115 UserNote: A new `unbuffered` chan_websocket mode has been added which sends frames to the core as they're received from the WebSocket and your app. It's similar to `passthrough` mode where your app is responsible for proper framing and timing except that, assuming you're not using an unbufferable codec (opus, speex, g729), in unbuffered mode, you can still use START_MEDIA_BUFFERING to send bulk media and have chan_websocket frame and time it. When you send STOP_MEDIA_BUFFERING, the channel will go back into unbuffered mode. Unbuffered mode is most useful when the media your app normally sends to Asterisk is already properly framed and timed but you may occasionally need to send bulk media. The mode is set with the `u` dialstring option. DeveloperNote: Two new fields have been added to the chan_websocket MEDIA_START event for both the plain text and JSON formats: `passthrough: true/false` `unbuffered: true/false` These indicate the mode the channel was created with and correspond to the `p` and `u` dialstring options. DeveloperNote: The MARK_MEDIA chan_websocket command can now be used by an app when in "passthrough" mode.	2 months ago
George Joseph	23cd94fe49	res_geolocation: Create alembic scripts and squash a SEGV. ... If a profile contained a location_reference that pointed to a location that didn't exist, a segfault would occur when running the `geoloc show profiles` command. The command now prints a notice that there was an issue retrieving the profile as well as an ERROR log message with the explanation. UpgradeNote: An Alembic script has been added for res_geolocation that creates the geoloc_location and geoloc_profile tables.	2 months ago
Mike Bradeen	70eff7f8a9	res_rtp_asterisk: Fix reported packet loss to use current report's difference ... The lost packet calculation was using the cumulative number of lost packets instead of the current interval's lost packets. This lead to the MES caculation skewing over time. We now keep track of the last reported value so we can determine the current value vs the cumulative value. Fixes: #2101	2 months ago
Mike Bradeen	25b305203e	res_rtp_asterisk: rtt stored before validation ... The rtcp rtt value was updated before being validated. The calculating function was correctly returning an error, but only after setting the value. This could result in AMI and ARI events being generated with an invalid value. Fixes: #2099	2 months ago
Mike Bradeen	f00427e631	res_rtp_asterisk: Correct effective latency calculation ... The effective latency calculation was using the full round trip time instead of the one-way, which causes the MES score to be worse than it would otherwise. Additionally, the rx jitter calculation was not scaling the normdev and stdev values to milliseconds, essentially disregarding their values in the calculation Fixes: #2097	2 months ago
Mike Bradeen	2cde76d820	res_rtp_asterisk: Change MES calculation to use long-term jitter mean ... The MES score used the reported jitter value instead of the smoothed statistic value, which could cause a single high anomalous RTCP sample to unduly skew the overall score. Fixes: #2095	2 months ago
Gian Diego Javes	7380030f3a	res_websocket_client: Release lock_obj when retries are exhausted ... ast_websocket_client_connect() takes lock_obj at the top of every pass through the retry loop. When the attempts run out it leaves through the break and returns NULL without releasing it, so the calling thread ends up holding it. The other two exits, the ast_calloc failure and the success path, do release it. The retry path also takes the lock again instead of releasing it before sleeping. The header describes lock_obj as "an ao2 object to lock while the connection is being attempted", and the usleep is the wait between attempts rather than an attempt, so that is where it should be released. chan_websocket.c passes the per-call instance as lock_obj, allocated with ao2_alloc and no flags, so it gets the default AO2_ALLOC_OPT_LOCK_MUTEX. When the object is freed, __ao2_ref() reaches ast_mutex_destroy() with the mutex still held and frees the memory anyway. There is no deadlock, Asterisk mutexes are recursive, but every call that fails to connect logs two ERROR lines. With each pass balanced, the lock is held exactly once when the loop breaks, so a single unlock before the return is enough. Fixes: #2121	2 months ago
Jacky W J Li	03b5137ba9	frame: Correct ast_frame_adjust_volume* documentation of 'adjustment' ... The documentation for ast_frame_adjust_volume() and ast_frame_adjust_volume_float() described the 'adjustment' parameter as a dB value. In reality the parameter is a linear gain factor applied directly to the audio samples: a positive value multiplies each sample, a negative value divides each sample, and 0 leaves the audio unchanged. The documentation block has also been reformatted to use the standard ' *' Doxygen style (asterisk in the second column) for consistency with the rest of the file. To convert a dB change to this factor use adjustment = 10^(dB/20) (for example, 2 ~= +6 dB and 10 ~= +20 dB). Resolves: #1167	2 months ago
Jaco Kroon	2015e6f81c	res_config_odbc: Missing SQLFreeHandle in error paths. ... Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2 months ago
George Joseph	cb65043877	res_cdrel_custom: Use extendable ast_str for JSON records. ... Since JSON records include the field names, the actual record size can be quite lengthy and since the thread-local backed ast_str used by the DSV writer can't be extended, we need to use a regular, extendable ast_str. Resolves: #2106	2 months ago
Sean Bright	d43f53820d	res_geolocation: Don't crash on invalid sorcery configuration ... A crash will occur when you've configured object mappings using the realtime wizard but neglect to set up your realtime configuration in `extconfig.conf`. For example, adding the following to `sorcery.conf`: [res_geolocation] location = realtime,geo_location profile = realtime,geo_profile But not defining `geo_location` or `geo_profile` in `extconfig.conf` will cause Asterisk to crash on startup.	2 months ago
Sean Bright	c116d562c6	res_geolocation: Load when explicitly configured in sorcery.conf ... If you've explicitly configured your configuration objects in sorcery.conf, it is normal for `ast_sorcery_apply_default` to return something other than `AST_SORCERY_APPLY_SUCCESS` (e.g. `AST_SORCERY_APPLY_DEFAULT_UNNECESSARY`). This is one of the few places (outside of unit tests) that we actual pay attention to the return value of `ast_sorcery_apply_default` at all.	2 months ago
fsliwenjie	0c43ff2679	res_stasis_recording: Allow recording a channel that is dialing via ARI ... When an ARI application dials a channel with channels.dial, the channel is placed into an internal, invisible holding bridge (the dial bridge) while dialing. record_file() rejected recording for any channel that was in a bridge, so channels.record failed with "Cannot record channel while in bridge" even though the application never joined the channel to a bridge of its own. Narrow the check so it only rejects recording when the channel is in a bridge that is NOT flagged invisible. The internal dial bridge is flagged AST_BRIDGE_FLAG_INVISIBLE (it is created by ARI internally, not by the application), so recording is still permitted there. A "real" bridge created by the application - including a user-created ARI holding bridge - is not invisible, so recording stays rejected. This keeps the fix targeted at the internal dial bridge only, rather than allowing recording in every holding bridge. Resolves: #2044	2 months ago
OMAR.A	9f5c28e83a	alembic: Preserve sub-second precision in the queue_log time column. ... ast_queue_log() formats realtime queue_log timestamps with microseconds ("%F %T.%6q" in main/logger.c), but the queue_log table declares 'time' as a generic SQLAlchemy DateTime. That renders on MySQL and MariaDB as bare DATETIME, which has a fractional-seconds precision of 0, so MariaDB truncates the fraction and MySQL rounds it. Every event of a single queue entry can collapse onto one second, or move to the next one, and neither server warns, not even in strict mode. Once that happens, queue_log rows can no longer be ordered against each other, or against the CEL records that cel_odbc and cel_pgsql do stamp with microseconds. This adds a revision that widens the queue_log column to DATETIME(6) on MySQL and MariaDB. PostgreSQL is unaffected and left untouched: DateTime already renders as TIMESTAMP, which keeps microseconds by default. Fixes: #2072 UpgradeNote: (schema) On MySQL and MariaDB the queue_log 'time' column is widened from DATETIME to DATETIME(6) so that the microsecond timestamps Asterisk already writes are stored rather than discarded. This ALTER rewrites the table, a datetime precision change is neither INSTANT nor INPLACE, so queue_log writes will block for its duration on a large table. PostgreSQL installations are unaffected. Rows already written at whole-second precision will remain as-is and won't be updated.	2 months ago
Jeremy Lainé	ffbc0d6bab	main/file.c: Log the reason a file could not be opened. ... When ast_streamfile() failed to open a file it reported strerror(errno), but errno was not set by anything on that path. The value came from whatever syscall ran last, so the message routinely blamed an unrelated error. Drop errno from that message and log at the point of failure instead: filehelper() now reports the fopen() error, which does carry a meaningful errno, and an allocation failure from get_filestream(). Candidate files whose format does not match the channel are logged at debug level only, since filehelper() walks every registered format and skipping the ones that do not match is normal: a sound installed in several formats would otherwise warn on every successful playback. Failures inside the format module's open callback stay unlogged here, as those callbacks already report their own reason. Resolves: #1629	2 months ago
whitetreebug	6050fe66c7	chore: update .gitignore for clangd ... Ignore clangd generated artifacts: compile_commands.json, .cache Ignores for .clangd, .clang-format, .clang-tidy tooling files	2 months ago
Tinet-mucw	3e1761804c	func_speex: Hold channel lock while updating speex state. ... speex_write() previously unlocked the channel immediately after looking up the speex datastore, then continued to create, modify, or destroy SpeexPreprocessState and related direction data without the lock. speex_callback() runs from the media path with the channel already locked, so concurrent Set(DENOISE)/Set(AGC) could free or mutate that state while preprocess was running and crash inside speex_preprocess_run(). Keep the channel locked for the full configuration update, unlock before ast_audiohook_attach()/detach(), and hold the lock across speex_read() while copying values out of the datastore. Fixes: #2091	2 months ago
Maksym Tushkov	19f98688a3	pjsip_wizard.conf.sample: Add IP authentication and TLS examples. ... The only ITSP example in the file shows a single trunk that registers and authenticates. Many providers, including DIDWW which motivated this change, instead authenticate by IP address, deliver inbound calls from several regional POPs, and terminate outbound calls through a separate gateway that does require digest authentication. Several things about configuring that with the wizard are not obvious from the option reference: * remote_hosts alone generates the per-host identify matches, and is mandatory when registrations are not accepted. * Inbound and outbound need one wizard each, because a wizard has a single remote_hosts list. * A template carrying "type = wizard" is not turned into objects itself, so the two can share one. TLS has a pitfall of its own: the wizard cannot create transport objects, so the transport has to be defined in pjsip.conf and referenced here by name, while media_encryption belongs to the endpoint and needs the endpoint/ prefix. Add commented-out examples for an IP authenticated trunk pair sharing a template, and for a TLS trunk with SRTP. No functional change. UserNote: pjsip_wizard.conf.sample now includes examples for an ITSP that authenticates by IP address and delivers calls from several hosts, and for a TLS trunk with SRTP.	2 months ago
George Joseph	56c0922216	res_http_websocket: Check for client before handling PONG frames. ... websocket_handled_pong_or_close() now checks that session->client is valid before trying to check missed_pong_count. Resolves: #2085	2 months ago
Michal Hajek	67d0900951	res_pjsip_config_wizard: Fix concurrent Named ACL reloads ... Named ACL change notifications reloaded PJSIP sorcery directly from the Stasis callback. Under concurrent ACL, core, and config wizard reloads, that could overlap with config wizard object type observers that compare, prune, destroy, and replace the per-object-type last_config cache. Route the ACL-triggered reload through the PJSIP servant path and track when a Named ACL reload is pending or running so the observer still bypasses the unchanged-file optimization. Also serialize the observer cache update to prevent overlapping reload paths from mutating last_config at the same time. UserNote: Fixes a PJSIP config wizard reload hang during overlapping reloads.	2 months ago
George Joseph	0de805e53b	Prepare master for Asterisk 25	2 months ago
Mehrdad Seifzadeh	8c901de562	res_pjsip_endpoint_identifier_ip: Clarify identify DNS warning ... When two DNS-based identify matches resolve to the same address, the first match makes the resolved address available for identify matching and the second match adds no new match address. The existing warning treated this as a DNS resolution failure and reported that the hostname did not resolve. Clarify the warning path so a hostname that resolves but only returns addresses already present for matching is not reported as unresolved. Fixes: #1723	2 months ago
Maksym Tushkov	68876947f3	res_pjsip_config_wizard: Fix documentation errors. ... The sample configuration and the module's XML documentation contained several errors, two of which actively misled users: * The sample said that sends_auth and accepts_auth require "outbound/username" and "inbound/username". The wizard looks for "outbound_auth/username" and "inbound_auth/username", so a configuration written by following the sample fails to load with "Wizard 'xxx' must have 'outbound_auth/username' if it sends authentication." * The sample claimed that hint_application defaults to "Dial(${HINT})". There is no such default. When hint_application is not specified the wizard removes the priority 1 extension it manages rather than creating one. The remaining corrections are a reversed object/field reference (match/identify), a leftover line in the hint_exten description, an option name (send_registrations), a stray space (remote _hosts), an unbalanced quote in a synopsis, a misspelling (nneds), an unbalanced bracket in the CLI usage text, and a copy/paste error in a log message that referred to the "sangoma wizard" instead of pjsip_wizard. Two "(default = ...)" annotations became "(default: ...)" to match the other fourteen in the same file. No functional change. UserNote: The pjsip_wizard.conf sample documented the wrong option names for sends_auth and accepts_auth, and claimed a default for hint_application that does not exist. Configurations written by following the sample would have failed to load.	2 months ago
Gian Diego Javes	6d383d321d	taskpool: count the in-flight task when selecting an executor ... The taskpool selectors measure load with ast_taskprocessor_size(), which only reports queued tasks. A taskprocessor that is executing a long running task has an empty queue, so it looks identical to an idle one and the least full selector hands it more work while other executors sit free. Add ast_taskprocessor_is_executing() and include the in-flight task in the load the selectors compare. This is not a new semantic. taskprocessor_push() already counts the in-flight task as outstanding work when it notifies the listener: /* The currently executing task counts as still in queue */ was_empty = tps->executing ? 0 : previous_size == 0; The taskpool selectors are the one place that still measures only the queue. This change applies the same rule there. The accessor reads tps->executing without the object lock, the way the CLI already does in main/taskprocessor.c, because taking the lock on every push cost roughly six times the throughput: taskpool push efficiency went from 324438 to 52966 tasks per second and the serializer variant from 217467 to 38313. Without the lock both are back to baseline. A stale read only means one push is routed as if the taskprocessor had just changed state, which the selector already tolerates. Also add a unit test that holds one executor of a four executor pool inside a long task and checks that a task pushed to a different serializer runs on one of the three free executors. It fails on every run without this change. Fixes: #2074 UserNote: Taskpool executors that are running a long task are no longer considered idle when work is distributed, so tasks are routed to free executors instead of queueing behind a busy one.	2 months ago
aabolfazl	fccb7cb367	app_voicemail: Fix crash when VM_INFO reads an unset email address. ... The email member of struct ast_vm_user is a pointer rather than a fixed array, and populate_defaults() leaves it NULL when a mailbox has no email address configured. Every other attribute VM_INFO reads is a fixed array, so only the email attribute is affected. VM_INFO passed vmu->email straight to ast_copy_string(), which dereferences its source unconditionally. Reading the email attribute of a mailbox that has no email address therefore crashed Asterisk from the dialplan. Guard the copy with S_OR() so an unset email address yields an empty string, matching how the language attribute already handles its fallback. The make_email_file() call sites were already guarded and are left alone. Add a regression test for the unset case, and restore the voicemail configuration when the VM_INFO test finishes. That test was the only one in app_voicemail that did not do so, which left its test mailbox in the users list and made the test fail if it ran a second time. Fixes: #2063	2 months ago
Sean Bright	9579b24a0a	res_agi.c: Prevent out-of-bounds array access when parsing arguments ... The `parse_args(...)` function writes to the `argv` array in 2 locations but was only bounds checking in one of them. Moved the bounds check so that it is encountered on each iteration through the parsing loop. Resolves: #2069	2 months ago
Mike Bradeen	f0c1c1a7b7	res_pjsip_sdp_rtp: Fix intermittent call drop on reINVITE sdp change ... A reINVITE that changed the offered codec set (e.g. ulaw+alaw -> alaw only) could lead to call teardown when a bridge write still using the old format occurred during the re-negotiation. This change avoids the termination by making the following changes. First, Asterisk now holds the lock across both the tx payload update and the channel format update so they commit atomically. Second, when processing the sdp on the new incoming offer, merge the new offer with the old until the negotiation is complete. Also adds unit tests for the sdp merge Fixes: #2059	3 months ago
Sven Kube	926a1068f2	chan_websocket: Fix NULL requestor dereference in webchan_request. ... Two log statements in webchan_request() passed `requestor` straight to ast_channel_name(), which dereferences the channel with no NULL check. `requestor` is NULL whenever no originator channel is supplied: ARI POST /channels/externalMedia always passes NULL, and POST /channels/create passes NULL when `originator` is omitted.	3 months ago
Naveen Albert	f6b02c640c	backtrace.c: Include stdbool.h ... stdbool.h is needed now that we use the bool type directly instead of bfd_boolean. See also 1d95b744c06974f0a00c143c6e0fc979af930908. Resolves: #2061	3 months ago
aabolfazl	c46c9945a8	res_musiconhold: Fix mohclass reference leak on answeredonly early return. ... local_ast_moh_start() returns -1 from the answeredonly check without releasing the mohclass reference it holds, unlike every other exit path in the function. Nothing else ever releases that reference, so moh_class_destructor() never runs for the object. With realtime music on hold and cachertclasses disabled, each suppressed request leaks the class object, its monitor thread, the external application process and two file descriptors for the lifetime of Asterisk. For static classes the stale references prevent the class from ever being destroyed after it is replaced by a reload. Release the reference before returning, matching the other exit paths. Fixes: #2051	3 months ago
Naveen Albert	5b59829015	backtrace.c: Avoid removed bfd_boolean type. ... bfd_boolean has been deprecated for some time and has now been removed in gdb, so use bool directly instead. See: 1d95b744c0 Resolves: #2054	3 months ago
Sean Bright	73064ff3bf	app_voicemail.c: Fix may-be-uninitialized error ... A pointer to `new` is passed to `inboxcount(...)` which increments the pointed-to value.	3 months ago
Mike Bradeen	2720b1025e	pjproject: disable building pjsua when a sanitizer is used ... Disable building the pjsua test application when any of the SANITIZER flags are set. Fixes: #2056	3 months ago
George Joseph	b531f71b12	SECURITY.md: Add warning about reporting multiple issues in one advisory.	3 months ago
Mehrdad Seifzadeh	8cd58fd39d	chan_pjsip: Store transport info for outgoing channels ... Outgoing PJSIP channels did not have transport information stored in their session datastore when CHANNEL(pjsip,local_addr) or CHANNEL(pjsip,remote_addr) was read. As a result, the address fields were empty on B-leg channels even though other dialog fields such as call-id and URIs were available. Store the selected local transport address and destination address for outgoing UAC session requests once the request is transmitted and the transport information is known. Fixes: #871	3 months ago
aabolfazl	c05ac3f232	func_strings: Fix misspelling of "occurred" in FIELDNUM documentation. ... The FIELDNUM description misspelled "occurred" as "occured". This text is user-visible: it is rendered on docs.asterisk.org and printed by "core show function FIELDNUM".	3 months ago
Jeremy Lainé	7c60726df1	tcptls: Don't inhibit escalations for outbound client connections. ... handle_tcptls_connection() marks the current thread as inhibiting privilege escalations and as an external user interface so that dialplan functions considered 'dangerous' (STAT, SHELL, ...) cannot be executed on behalf of an external protocol. This is correct for inbound (server) connections, each of which runs on its own dedicated worker thread. However, the outbound (client) path calls handle_tcptls_connection() synchronously on the caller's own thread. When that caller is a channel/PBX thread, the thread-local flags are set and never cleared, permanently tainting the dialplan thread. Examples: - Calling Dial() for an outbound WebSocket and resuming dialplan execution with the "g" flag. - Running ExternalIVR() then continuing dialplan executing. Outbound connections are initiated by Asterisk itself and are not external user interfaces, so the flags should not be set for them. Gate the flag-setting on tcptls_session->client so it applies only to inbound connections. Resolves: #2038	3 months ago
Mike Bradeen	734fb592bd	res_rtp_asterisk: Avoid two lock inversion deadlocks with pj project ... Fixes two related instance, group lock inversion deadlocks. When writing the RTP stream via rtp_sendto, the RTP instance was only unlocked before being passed to pj project when the instance was un-bundled (ie video was not bundled onto the audio stream's ICE transport.) The first change unlocks the instance whether bundled or unbundled to avoid the deadlock, then re-checks the bundled status upon return to know wether or not the transport should be used. For the second change, when an incoming RTCP NACK record was recieved, the parent (transport) and child (instance) locks were both held before the call to rtp_sendto, which is only able to release the child lock. Now in the un-bundled case the parent and child will be unlocked and re-locked in the correct order via a new helper function before and after the call to send_to. Fixes: #1946	3 months ago
Stanislav Abramenkov	05dbd160ea	jansson: Upgrade version to jansson 2.15.1 ... UpgradeNote: jansson has been upgraded to 2.15.1. For more information visit jansson Github page: https://github.com/akheron/jansson/releases/tag/v2.15.1 Resolves: #2033	3 months ago
Jeremy Lainé	b31d3b1d57	file.c: Ensure opening a stream opens at most one file ... The functions used to stream files eventually end up calling into `filehelper(.., ACTION_OPEN)` which takes care of iterating over supported extensions and opening the first existing file. To do this, `filehelper` uses two nested loops: - An outer loop over the supported file formats. - An inner loop over the possible extensions for that format. We need to break out of both loops as soon as a file was successfully opened. Otherwise if a file exists in multiple formats (e.g `foo.wav` and `foo.alaw`) both files will be opened successively. Resolves: #1625	3 months ago
Joshua C. Colp	ad429910c6	pjsip: Eliminate some unique taskprocessors. ... When placing outbound calls each call would get its own taskprocessor for things related to the call. In practice this is overkill as few things actually occur. Inbound calls on the other hand already use one of the fixed number of distributor taskprocessors. This also occurred for OPTIONS requests with each AOR having its own taskprocessor. This change moves both to using a distributor taskprocessor instead.	3 months ago
Roel van Meer	e22687d0bd	bridging: Add support for TOUCH_MIXMONITOR_OPTIONS ... This channel variable can be used to override the default automixmon options (which are 'b' or 'bB(<n>)'). If both TOUCH_MIXMONITOR_OPTIONS and TOUCH_MIXMONITOR_BEEP are set, TOUCH_MIXMONITOR_BEEP is ignored with a warning. It is the responsibility of the user to configure valid options in TOUCH_MIXMONITOR_OPTIONS. Fixes: #1981 UserNote: The TOUCH_MIXMONITOR_OPTIONS channel variable can now be used to configure the options used by the mixmonitor application when it is started via automixmon. If both TOUCH_MIXMONITOR_OPTIONS and TOUCH_MIXMONITOR_BEEP are set, TOUCH_MIXMONITOR_BEEP is ignored with a warning.	3 months ago
George Joseph	1480af1227	res_pjsip_refer: Fix issues with Refer-Sub:false and ARI. ... When an attended transfer is controlled by ARI using PJSIP_TRANSFER_HANDLING()=ari-only, and a REFER request is received with a Refer-Sub: false header to suppress the automatic progress subscription, a segfault occurs in res_pjsip_refer:refer_incoming_ari_request(). However, even if the segfault were prevented, there's another issue... Suppressing the subscription and NOTIFYs to the referer also prevents the ARI app from getting any progress events for the transfer which it's controlling. So... * The segfault has been fixed. * Suppressing the subscription no longer suppress the ARI events from being sent to the controlling ARI app. * A good amount of tracing has also been added. Resolves: #2021	3 months ago