33762 Commits (cd39daaed1a41e1c6ec9b7fc8f772c2088cd831b)

 

All Branches   

Search

Author	SHA1	Message	Date
Sean Bright	cd39daaed1	chan_iax2.c: Ensure all IEs are displayed when dumping frame contents. ... When IAX2 debugging was enabled (`iax2 set debug on`), if the last IE in a frame was one that may not have any data - such as the CALLTOKEN IE in an NEW request - it was not getting displayed. (cherry picked from commit 19507ae160)	2 years ago
Naveen Albert	27f3df7139	chan_dahdi: Warn if nonexistent cadence is requested. ... If attempting to ring a channel using a nonexistent cadence, emit a warning, before falling back to the default cadence. Resolves: #409 (cherry picked from commit cdcdca5199)	2 years ago
Holger Hans Peter Freyther	35281dac6a	stasis: Update the snapshot after setting the redirect ... The previous commit added the caller_rdnis attribute. Make it avialble during a possible ChanngelHangupRequest. (cherry picked from commit 9fd2655d5a)	2 years ago
Holger Hans Peter Freyther	4053abc214	ari: Provide the caller ID RDNIS for the channels ... Provide the caller ID RDNIS when available. This will allow an application to follow the redirect. (cherry picked from commit da0b1ac1c1)	2 years ago
Brad Smith	5fa3c03738	main/utils: Implement ast_get_tid() for OpenBSD ... Implement the ast_get_tid() function for OpenBSD. OpenBSD supports getting the TID via getthrid(). (cherry picked from commit 29a3e5660b)	2 years ago
Brad Smith	3949358ee1	res_rtp_asterisk.c: Fix runtime issue with LibreSSL ... The module will fail to load. Use proper function DTLS_method() with LibreSSL. (cherry picked from commit 1d9c5faeb3)	2 years ago
Naveen Albert	0f33423107	app_directory: Add ADSI support to Directory. ... This adds optional ADSI support to the Directory application, which allows callers with ADSI CPE to navigate the Directory system significantly faster than is possible using the audio prompts. Callers can see the directory name (and optionally extension) on their screenphone and confirm or reject a match immediately rather than waiting for it to be spelled out, enhancing usability. Resolves: #356 (cherry picked from commit 4a356e984c)	2 years ago
Naveen Albert	f6e0478bf4	core_local: Fix local channel parsing with slashes. ... Currently, trying to call a Local channel with a slash in the extension will fail due to the parsing of characters after such a slash as being dial modifiers. Additionally, core_local is inconsistent and incomplete with its parsing of Local dial strings in that sometimes it uses the first slash and at other times it uses the last. For instance, something like DAHDI/5 or PJSIP/device is a perfectly usable extension in the dialplan, but Local channels in particular prevent these from being called. This creates inconsistent behavior for users, since using a slash in an extension is perfectly acceptable, and using a Goto to accomplish this works fine, but if specified through a Local channel, the parsing prevents this. This fixes this by explicitly parsing options from the last slash in the extension, rather than the first one, which doesn't cause an issue for extensions with slashes. ASTERISK-30013 #close Resolves: #248 (cherry picked from commit 65f83311b7)	2 years ago
Mark Murawski	7ea2c5926b	Remove files that are no longer updated ... Fixes: #360 (cherry picked from commit 6ebd820e26)	2 years ago
Naveen Albert	8ad6e6e585	app_voicemail: Add AMI event for mailbox PIN changes. ... This adds an AMI event that is emitted whenever a mailbox password is successfully changed, allowing AMI consumers to process these. UserNote: The VoicemailPasswordChange event is now emitted whenever a mailbox password is updated, containing the mailbox information and the new password. Resolves: #398 (cherry picked from commit 95bc661542)	2 years ago
Sean Bright	4feaf8a880	app_queue.c: Emit unpause reason with PauseQueueMember event. ... Fixes #395 (cherry picked from commit baf3ce25f5)	2 years ago
George Joseph	1972df7b09	bridge_simple: Suppress unchanged topology change requests ... In simple_bridge_join, we were sending topology change requests even when the new and old topologies were the same. In some circumstances, this can cause unnecessary re-invites and even a re-invite flood. We now suppress those. Resolves: #384 (cherry picked from commit 57d31d97dc)	2 years ago
Naveen Albert	1a95cd932b	res_pjsip: Include cipher limit in config error message. ... If too many ciphers are specified in the PJSIP config, include the maximum number of ciphers that may be specified in the user-facing error message. Resolves: #396 (cherry picked from commit d4185ca025)	2 years ago
Mike Bradeen	c28302f839	res_speech: allow speech to translate input channel ... * Allow res_speech to translate the input channel if the format is translatable to a format suppored by the speech provider. Resolves: #129 UserNote: res_speech now supports translation of an input channel to a format supported by the speech provider, provided a translation path is available between the source format and provider capabilites. (cherry picked from commit e8fbdca40b)	2 years ago
Sean Bright	81386086be	res_rtp_asterisk.c: Fix memory leak in ephemeral certificate creation. ... Fixes #386 (cherry picked from commit 74a5c452de)	2 years ago
Sean Bright	7f3a5b2be0	res_pjsip_dtmf_info.c: Add 'INFO' to Allow header. ... Fixes #376 (cherry picked from commit 3af55f14fa)	2 years ago
George Joseph	e571b7c4dd	api.wiki.mustache: Fix indentation in generated markdown ... The '*' list indicator for default values and allowable values for path, query and POST parameters need to be indented 4 spaces instead of 2. Should resolve issue 38 in the documentation repo. (cherry picked from commit 443f94b438)	2 years ago
Sean Bright	b614397206	pjsip_configuration.c: Disable DTLS renegotiation if WebRTC is enabled. ... Per RFC8827: Implementations MUST NOT implement DTLS renegotiation and MUST reject it with a "no_renegotiation" alert if offered. So we disable it when webrtc=yes is set. Fixes #378 UpgradeNote: The dtls_rekey will be disabled if webrtc support is requested on an endpoint. A warning will also be emitted. (cherry picked from commit c7afd5357c)	2 years ago
Samuel Olaechea	3139269b33	configs: Fix typo in pjsip.conf.sample. ... (cherry picked from commit 4c507d31b9)	2 years ago
George Joseph	785cc25519	res_pjsip_exten_state,res_pjsip_mwi: Allow unload on shutdown ... Commit f66f77f last year prevents the res_pjsip_exten_state and res_pjsip_mwi modules from unloading due to possible pjproject asserts if the modules are reloaded. A side effect of the implementation is that the taskprocessors these modules use aren't being released. When asterisk is doing a graceful shutdown, it waits AST_TASKPROCESSOR_SHUTDOWN_MAX_WAIT seconds for all taskprocessors to stop but since those 2 modules don't release theirs, the shutdown hangs for that amount of time. This change allows the modules to be unloaded and their resources to be released when ast_shutdown_final is true. Resolves: #379 (cherry picked from commit b9ee664440)	2 years ago
sungtae kim	39c2f5733e	res_pjsip: Expanding PJSIP endpoint ID and relevant resource length to 255 characters ... This commit introduces an extension to the endpoint and relevant resource sizes for PJSIP, transitioning from its current 40-character constraint to a more versatile 255-character capacity. This enhancement significantly overcomes limitations related to domain qualification and practical usage, ultimately delivering improved functionality. In addition, it includes adjustments to accommodate the expanded realm size within the ARI, specifically enhancing the maximum realm length. Resolves: #345 UserNote: With this update, the PJSIP realm lengths have been extended to support up to 255 characters. UpgradeNote: As part of this update, the maximum allowable length for PJSIP endpoints and relevant resources has been increased from 40 to 255 characters. To take advantage of this enhancement, it is recommended to run the necessary procedures (e.g., Alembic) to update your schemas. (cherry picked from commit 9b70b18dec)	2 years ago
George Joseph	56d568d1d5	.github: PRSubmitActions: Fix adding reviewers to PR ... (cherry picked from commit 79c5845141)	2 years ago
George Joseph	b404679de0	.github: New PR Submit workflows ... The workflows that get triggered when PRs are submitted or updated have been replaced with ones that are more secure and have a higher level of parallelism. (cherry picked from commit 6389654b21)	2 years ago
George Joseph	b01a9f59b5	.github: New PR Submit workflows ... The workflows that get triggered when PRs are submitted or updated have been replaced with ones that are more secure and have a higher level of parallelism. (cherry picked from commit d06bb7f2fe)	2 years ago
Mike Bradeen	054ec2bf4a	res_stasis: signal when new command is queued ... res_statsis's app loop sleeps for up to .2s waiting on input to a channel before re-checking the command queue. This can cause delays between channel setup and bridge. This change is to send a SIGURG on the sleeping thread when a new command is enqueued. This exits the sleeping thread out of the ast_waitfor() call triggering the new command being processed on the channel immediately. Resolves: #362 UserNote: Call setup times should be significantly improved when using ARI. (cherry picked from commit 7ea0e3bfda)	2 years ago
Holger Hans Peter Freyther	849cf31e51	ari/stasis: Indicate progress before playback on a bridge ... Make it possible to start a playback and the calling party to receive audio on a bridge before the call is connected. Model the implementation after play_on_channel and deliver a AST_CONTROL_PROGRESS before starting the playback. For a PJSIP channel this will result in sending a SIP 183 Session Progress. (cherry picked from commit 624c7ac883)	2 years ago
Sean Bright	421924e07c	func_curl.c: Ensure channel is locked when manipulating datastores. ... (cherry picked from commit 8c1491dda9)	2 years ago
George Joseph	6a60ce8eae	.github: Fix job prereqs in PROpenedUpdated ... (cherry picked from commit 9e9037a8aa)	2 years ago
George Joseph	f3561210c2	.github: Block PR tests until approved ... (cherry picked from commit 29e202085d)	2 years ago
George Joseph	a2d71fce2a	.github: Use generic releaser ... (cherry picked from commit ceddfbe7b8)	2 years ago
George Joseph	02b84fa88c	logger.h: Add ability to change the prefix on SCOPE_TRACE output ... You can now define the _TRACE_PREFIX_ macro to change the default trace line prefix of "file:line function" to something else. Full documentation in logger.h. (cherry picked from commit f599114ee3)	2 years ago
George Joseph	cfc6832062	Add libjwt to third-party ... The current STIR/SHAKEN implementation is not currently usable due to encryption issues. Rather than trying to futz with OpenSSL and the the current code, we can take advantage of the existing capabilities of libjwt but we first need to add it to the third-party infrastructure already in place for jansson and pjproject. A few tweaks were also made to the third-party infrastructure as a whole. The jansson "dest" install directory was renamed "dist" to better match convention, and the third-party Makefile was updated to clean all product directories not just the ones currently in use. Resolves: #349 (cherry picked from commit d7a6116681)	2 years ago
Mike Bradeen	893483f915	res_pjsip: update qualify_timeout documentation with DNS note ... The documentation on qualify_timeout does not explicitly state that the timeout includes any time required to perform any needed DNS queries on the endpoint. If the OPTIONS response is delayed due to the DNS query, it can still render an endpoint as Unreachable if the net time is enough for qualify_timeout to expire. Resolves: #352 (cherry picked from commit 323a51fd6c)	2 years ago
Naveen Albert	c58d5e9190	chan_dahdi: Clarify scope of callgroup/pickupgroup. ... Internally, chan_dahdi only applies callgroup and pickupgroup to FXO signalled channels, but this is not documented anywhere. This is now documented in the sample config, and a warning is emitted if a user tries configuring these settings for channel types that do not support these settings, since they will not have any effect. Resolves: #294 (cherry picked from commit 5b89e40541)	2 years ago
Bastian Triller	903c594cef	func_json: Fix crashes for some types ... This commit fixes crashes in JSON_DECODE() for types null, true, false and real numbers. In addition it ensures that a path is not deeper than 32 levels. Also allow root object to be an array. Add unit tests for above cases. (cherry picked from commit 1cbbf36929)	2 years ago
Mike Bradeen	779fb2052a	res_speech_aeap: add aeap error handling ... res_speech_aeap previously did not register an error handler with aeap, so it was not notified of a disconnect. This resulted in SpeechBackground never exiting upon a websocket disconnect. Resolves: #303 (cherry picked from commit e921f5e010)	2 years ago
Naveen Albert	a11885989c	app_voicemail: Disable ADSI if unavailable. ... If ADSI is available on a channel, app_voicemail will repeatedly try to use ADSI, even if there is no CPE that supports it. This leads to many unnecessary delays during the session. If ADSI is available but ADSI setup fails, we now disable it to prevent further attempts to use ADSI during the session. Resolves: #354 (cherry picked from commit 75620616f4)	2 years ago
Eduardo	d8238d0e15	codec_builtin: Use multiples of 20 for maximum_ms ... Some providers require a multiple of 20 for the maxptime or fail to complete calls, e.g. Vivo in Brazil. To increase compatibility, only multiples of 20 are now used. Resolves: #260 (cherry picked from commit ca1ed84820)	2 years ago
George Joseph	75bb76528a	lock.c: Separate DETECT_DEADLOCKS from DEBUG_THREADS ... Previously, DETECT_DEADLOCKS depended on DEBUG_THREADS. Unfortunately, DEBUG_THREADS adds a lot of lock tracking overhead to all of the lock lifecycle calls whereas DETECT_DEADLOCKS just causes the lock calls to loop over trylock in 200us intervals until the lock is obtained and spits out log messages if it takes more than 5 seconds. From a code perspective, the only reason they were tied together was for logging. So... The ifdefs in lock.c were refactored to allow DETECT_DEADLOCKS to be enabled without also enabling DEBUG_THREADS. Resolves: #321 UserNote: You no longer need to select DEBUG_THREADS to use DETECT_DEADLOCKS. This removes a significant amount of overhead if you just want to detect possible deadlocks vs needing full lock tracing. (cherry picked from commit e1050b4add)	2 years ago
George Joseph	fe1bca6a72	asterisk.c: Use the euid's home directory to read/write cli history ... The CLI .asterisk_history file is read from/written to the directory specified by the HOME environment variable. If the root user starts asterisk with the -U/-G options, or with runuser/rungroup set in asterisk.conf, the asterisk process is started as root but then it calls setuid/setgid to set the new user/group. This does NOT reset the HOME environment variable to the new user's home directory though so it's still left as "/root". In this case, the new user will almost certainly NOT have access to read from or write to the history file. * Added function process_histfile() which calls getpwuid(geteuid()) and uses pw->dir as the home directory instead of the HOME environment variable. * ast_el_read_default_histfile() and ast_el_write_default_histfile() have been modified to use the new process_histfile() function. Resolves: #337 (cherry picked from commit fc516f5781)	2 years ago
Tinet-mucw	aadf9d920a	res_pjsip_transport_websocket: Prevent transport from being destroyed before message finishes. ... From the gdb information, ast_websocket_read reads a message successfully, then transport_read is called in the serializer. During execution of pjsip_transport_down, ws_session->stream->fd is closed; ast_websocket_read encounters an error and exits the while loop. After executing transport_shutdown, the transport's reference count becomes 0, causing a crash when sending SIP messages. This was due to pjsip_transport_dec_ref executing earlier than pjsip_rx_data_clone, leading to this issue. In websocket_cb executeing pjsip_transport_add_ref, this we now ensure the transport is not destroyed while in the loop. Resolves: asterisk#299 (cherry picked from commit a38add11e6)	2 years ago
Mike Bradeen	f9efc9c681	cel: add publish user event helper ... Add a wrapper function around ast_cel_publish_event that packs event and extras into a blob before publishing Resolves:#330 (cherry picked from commit 4592f97c36)	2 years ago
Naveen Albert	d01b047de3	chan_console: Fix deadlock caused by unclean thread exit. ... To terminate a console channel, stop_stream causes pthread_cancel to make stream_monitor exit. However, commit 5b8fea93d1 added locking to this function which results in deadlock due to the stream_monitor thread being killed while it's holding the pvt lock. To resolve this, a flag is now set and read to indicate abort, so the use of pthread_cancel and pthread_kill can be avoided altogether. Resolves: #308 (cherry picked from commit 3b027d1e47)	2 years ago
George Joseph	dadbaed6f5	file.c: Add ability to search custom dir for sounds ... To better co-exist with sounds files that may be managed by packages, custom sound files may now be placed in AST_DATA_DIR/sounds/custom instead of the standard AST_DATA_DIR/sounds/<lang> directory. If the new "sounds_search_custom_dir" option in asterisk.conf is set to "true", asterisk will search the custom directory for sounds files before searching the standard directory. For performance reasons, the "sounds_search_custom_dir" defaults to "false". Resolves: #315 UserNote: A new option "sounds_search_custom_dir" has been added to asterisk.conf that allows asterisk to search AST_DATA_DIR/sounds/custom for sounds files before searching the standard AST_DATA_DIR/sounds/<lang> directory. (cherry picked from commit 0e0f99db1d)	2 years ago
Naveen Albert	69338381ea	chan_iax2: Improve authentication debugging. ... Improves and adds some logging to make it easier for users to debug authentication issues. Resolves: #286 (cherry picked from commit f93138bcad)	2 years ago
Vitezslav Novy	e1231fa4ac	res_rtp_asterisk: fix wrong counter management in ioqueue objects ... In function rtp_ioqueue_thread_remove counter in ioqueue object is not decreased which prevents unused ICE TURN threads from being removed. Resolves: #301 (cherry picked from commit 56244a7371)	2 years ago
George Joseph	58c8d60f4b	res_pjsip_pubsub: Add body_type to test_handler for unit tests ... The ast_sip_subscription_handler "test_handler" used for the unit tests didn't set "body_type" so the NULL value was causing a SEGV in build_subscription_tree(). It's now set to "". Resolves: #335 (cherry picked from commit 71d75373f9)	2 years ago
George Joseph	e2c3fd8d41	make_buildopts_h, et. al. Allow adding all cflags to buildopts.h ... The previous behavior of make_buildopts_h was to not add the non-ABI-breaking MENUSELECT_CFLAGS like DETECT_DEADLOCKS, REF_DEBUG, etc. to the buildopts.h file because "it caused ccache to invalidate files and extended compile times". They're only defined by passing them on the gcc command line with '-D' options. In practice, including them in the include file rarely causes any impact because the only time ccache cares is if you actually change an option so the hit occurrs only once after you change it. OK so why would we want to include them? Many IDEs follow the include files to resolve defines and if the options aren't in an include file, it can cause the IDE to mark blocks of "ifdeffed" code as unused when they're really not. So... * Added a new menuselect compile option ADD_CFLAGS_TO_BUILDOPTS_H which tells make_buildopts_h to include the non-ABI-breaking flags in buildopts.h as well as the ABI-breaking ones. The default is disabled to preserve current behavior. As before though, only the ABI-breaking flags appear in AST_BUILDOPTS and only those are used to calculate AST_BUILDOPT_SUM. A new AST_BUILDOPT_ALL define was created to capture all of the flags. * make_version_c was streamlined to use buildopts.h and also to create asterisk_build_opts_all[] and ast_get_build_opts_all(void) * "core show settings" now shows both AST_BUILDOPTS and AST_BUILDOPTS_ALL. UserNote: The "Build Options" entry in the "core show settings" CLI command has been renamed to "ABI related Build Options" and a new entry named "All Build Options" has been added that shows both breaking and non-breaking options. (cherry picked from commit 42f82d55b0)	2 years ago
Mike Bradeen	4799c0eda3	func_periodic_hook: Add hangup step to avoid timeout ... func_periodic_hook does not hangup after playback, relying on hangup which keeps the channel alive longer than necessary. Resolves: #325 (cherry picked from commit 2265eafb3a)	2 years ago
Sean Bright	fd7a35fad8	res_stasis_recording.c: Save recording state when unmuted. ... Fixes #322 (cherry picked from commit b952a8c38d)	2 years ago