32042 Commits (c50f29dfadfe24e7081e7e5ea2ca91c0bfba0776)

 

All Branches   

Search

Author	SHA1	Message	Date
Matt Jordan	c50f29dfad	Add core Prometheus support to Asterisk ... Prometheus is the defacto monitoring tool for containerized applications. This patch adds native support to Asterisk for serving up Prometheus compatible metrics, such that a Prometheus server can scrape an Asterisk instance in the same fashion as it does other HTTP services. The core module in this patch provides an API that future work can build on top of. The API manages metrics in one of two ways: (1) Registered metrics. In this particular case, the API assumes that the metric (either allocated on the stack or on the heap) will have its value updated by the module registering it at will, and not just when Prometheus scrapes Asterisk. When a scrape does occur, the metrics are locked so that the current value can be retrieved. (2) Scrape callbacks. In this case, the API allows consumers to be called via a callback function when a Prometheus initiated scrape occurs. The consumers of the API are responsible for populating the response to Prometheus themselves, typically using stack allocated metrics that are then formatted properly into strings via this module's convenience functions. These two mechanisms balance the different ways in which information is generated within Asterisk: some information is generated in a fashion that makes it appropriate to update the relevant metrics immediately; some information is better to defer until a Prometheus server asks for it. Note that some care has been taken in how metrics are defined to minimize the impact on performance. Prometheus's metric definition and its support for nesting metrics based on labels - which are effectively key/value pairs - can make storage and managing of metrics somewhat tricky. While a naive approach, where we allow for any number of labels and perform a lot of heap allocations to manage the information, would absolutely have worked, this patch instead opts to try to place as much information in length limited arrays, stack allocations, and vectors to minimize the performance impacts of scrapes. The author of this patch has worked on enough systems that were driven to their knees by poor monitoring implementations to be a bit cautious. Additionally, this patch only adds support for gauges and counters. Additional work to add summaries, histograms, and other Prometheus metric types may add value in the future. This would be of particular interest if someone wanted to track SIP response types. Finally, this patch includes unit tests for the core APIs. ASTERISK-28403 Change-Id: I891433a272c92fd11c705a2c36d65479a415ec42	6 years ago
Friendly Automation	e222dc71d5	Merge "conversions.c: Add conversions for largest max sized integer"	6 years ago
Friendly Automation	9ca99ede61	Merge "Fixes for GCC 9"	6 years ago
Friendly Automation	9db0f08901	Merge "build: Pass --fno-partial-inlining to third-party when appropriate"	6 years ago
Friendly Automation	c0640a3033	Merge "pjsip_options.c: Allow immediate qualifies for new contacts."	6 years ago
George Joseph	c5c953c1f1	Fixes for GCC 9 ... Various fixes for issues caught by gcc 9. Mostly snprintf trying to copy to a buffer potentially too small. ASTERISK-28412 Change-Id: I9e85a60f3c81d46df16cfdd1c329ce63432cf32e	6 years ago
Ben Ford	86836e0442	pjsip_options.c: Allow immediate qualifies for new contacts. ... When multiple endpoints try to register close together using the same AOR with qualify_frequency set, one contact would qualify immediately while the other contacts would have to wait out the duration of the timer before being able to qualify. Changing the conditional to check the contact container count for a non-zero value allows all contacts to qualify immediately. Change-Id: I79478118ee7e0d6e76af7c354d66684220db9415	6 years ago
Kevin Harwell	def6bbc96b	conversions.c: Add conversions for largest max sized integer ... Added a conversion for umax (largest maximum sized integer allowed). Adjusted the other current conversion functions (uint and ulong) to be derivatives of the umax conversion since they are simply subsets of umax. Also made the negative check move the pointer on spaces since strtoumax does it anyways. Change-Id: I56c2ef2629d49b524c8df58af12951c181f81f08	6 years ago
agupta	85242a9bb9	stasis: Hangup channel for Local channel No such extension error ... When we use early bridge with create and dial from stasis using Local channel and the dialplan does not any entry the it is returned from core_local.c with No such extension . In such case asterisk locks up till the channel is not hangup with the error Exceptionally long voice queue length * Found that in such case app_control_dial fails on ast_call method and return -1 * Since it is called from stasis_app_send_command_async and return -1 does not cause resources to be freed and since no PBX exist it is not able to read from channel causing exceptionally long queue * After putting this code found that the channel was releasing immediately and resources were freed. ASTERISK-28399 Reported by: Abhay Gupta Tested by: Abhay Gupta Change-Id: I0a55c923fc6995559f808d63b9488762b4489318	6 years ago
George Joseph	089581f20a	build: Pass --fno-partial-inlining to third-party when appropriate ... When the gcc version is >= 8.2.1, we were already setting the --fno-partial-inlining flag for Asterisk source files to get around a gcc bug but we weren't passing the flag down to the bundled builds of pjproject and jansson. ASTERISK-28392 Change-Id: I99ede9bc35408ecd096f7d5369e8192d3dc75704	6 years ago
Friendly Automation	fca9f0a4ad	Merge "app_confbridge: Add "all" variants of REMB behavior."	6 years ago
Joshua Colp	8c1680fce4	Merge "stasis: Only place stasis created and dialed channels into dial bridge."	6 years ago
Friendly Automation	a6d9c4f11a	Merge "stasis: Call callbacks when imparting fails"	6 years ago
Friendly Automation	249be1d7ae	Merge "rtp: Add support for transport-cc in receiver direction."	6 years ago
George Joseph	ef92c69fa8	res_pjsip: Check return from pjsip_parse_uri calls ... Updated ast_sip_create_rdata_with_contact and registrar_find_contact to check the return from pjsip_parse_uri before attempting to use the uri returned. ASTERISK-28402 Reported-by: Ross Beer Change-Id: I9810b3b163c45ed5a56ec743586e5ce107f13ba7	6 years ago
agupta	71040078a3	stasis: Only place stasis created and dialed channels into dial bridge. ... The dial bridge is meant to hold channels which have been created and dialed in stasis. It handles the frames coming from them and raises the appropriate events. It was possible for the code to mistakenly place calls which came from the dialplan into the dial bridge if they were not in an answered state. These channels are not outgoing channels and should not be placed into the dial bridge. The code now checks to ensure that only stasis created channels are placed into the dial bridge by checking that a PBX does not exist on the channel. ASTERISK-27756 Change-Id: Ideee69ff06c9a0b31f7ed61165f5c055f51d21b6	6 years ago
Holger Hans Peter Freyther	3087c82eb6	stasis: Call callbacks when imparting fails ... After a bridge has been deleted the stasis control will depart the channel and might attempt to re-add it to the dial bridge. The later can fail and this can lead to a situation that the stasis control is unlinked but the after_bridge_cb_failed cb is executed trying to access a dangling control object. Fix it by calling the after_cb's before bridge_channel_impart_signal. ASTERISK-26718 Change-Id: Ib4e8f70d7a21bd54afe3cb51cc6717ef7c355496	6 years ago
Joshua Colp	80dba268ea	app_confbridge: Add "all" variants of REMB behavior. ... When producing a combined REMB value the normal behavior is to have a REMB value which is unique for each sender based on all of their receivers. This can result in one sender having low bitrate while all the rest are high. This change adds "all" variants which produces a bridge level REMB value instead. All REMB reports are combined together into a single REMB value that is the same for each sender. ASTERISK-28401 Change-Id: I883e6cc26003b497c8180b346111c79a131ba88c	6 years ago
Joshua Colp	6bb70c93f1	rtp: Add support for transport-cc in receiver direction. ... The transport-cc draft is a mechanism by which additional information about packet reception can be provided to the sender of packets so they can do sender side bandwidth estimation. This is accomplished by having a transport specific sequence number and an RTCP feedback message. This change implements this in the receiver direction. For each received RTP packet where transport-cc is negotiated we store the time at which the RTP packet was received and its sequence number. At a 1 second interval we go through all packets in that period of time and use the stored time of each in comparison to its preceding packet to calculate its delta. This delta information is placed in the RTCP feedback message, along with indicators for any packets which were not received. The browser then uses this information to better estimate available bandwidth and adjust accordingly. This may result in it lowering the available send bandwidth or adjusting how "bursty" it can be. ASTERISK-28400 Change-Id: I654a2cff5bd5554ab94457a14f70adb71f574afc	6 years ago
Friendly Automation	45a9ff8286	Merge "app_queue: Set correct value by default for shared_lastcall"	6 years ago
Friendly Automation	c2326155aa	Merge "mwi core: Move core MWI functionality into its own files"	6 years ago
Friendly Automation	61a8ad8db8	Merge "app_amd: Fix infinite loop on silent calls"	6 years ago
Friendly Automation	3454639055	Merge "stasis: Fix crash at shutdown."	6 years ago
agupta	7ce6d960d4	app_amd: Fix infinite loop on silent calls ... The total time logic will now be executed on calls which do not pass any media. ASTERISK-28143 Change-Id: I24726bd29d7e467fc721ca265363417234b22855	6 years ago
Rodrigo Ramírez Norambuena	ed615afb7e	app_queue: Set correct value by default for shared_lastcall ... There a long history here: In commit dd1e62c095 has introduce by default shared_lastcall = true by default but this now only happen is there not [general] directive in queues.conf After that, the commit 4b50e3f1ee fix the sample file. We'll need to keep the same setting if there a general or not section in configuration file since the shared_lastcall is by a long time in sample files as default value to 'no'. Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c	6 years ago
Ben Ford	dc02d0d9f2	stasis: Fix crash at shutdown. ... When compiling in dev mode, stasis statistics are enabled and can cause a crash at shutdown due to the following: - Containers are freed - Topics and subscriptions remain - When those topics and subscriptions are deallocated, they go to do things with the container This changes the containers to global ao2 objects, and whenever needed in the code, a reference must be obtained and checked before any operations can be done. ASTERISK-28353 #close Change-Id: Ie7d5e907fcfcb4d65bd36d5e4eb923126fde8d33	6 years ago
Antoni Goldstein	8e21c25ce5	app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings ... Added RINGTIME, RINGTIME_MS, PROGRESSTIME, PROGRESSTIME_MS variables filled at the earliest received PROGRESS or RINGING. Added millisecond versions of DIALEDTIME and ANSWEREDTIME. Added millisecond versions of ast_channel_get_up_time and ast_channel_get_duration in channel.c. ASTERISK-28363 Change-Id: If95f1a7d8c4acbac740037de0c6e3109ff6620b1	6 years ago
Kevin Harwell	ff0d0ac23a	mwi core: Move core MWI functionality into its own files ... There is enough MWI functionality to warrant it having its own 'c' and header files. This patch moves all current core MWI data structures, and functions into the following files: main/mwi.h main/mwi.c Note, code was simply moved, and not modified. However, this patch is also in preparation for core MWI changes, and additions to come. Change-Id: I9dde8bfae1e7ec254fa63166e090f77e4d3097e0	6 years ago
Friendly Automation	fbeae922ab	Merge "core/buildsystem: check the actual compiler being version"	6 years ago
Friendly Automation	a9d541ea0f	Merge "main/stasis.c: Added detail info for stasis show app cli"	6 years ago
Guido Falsi	8b7324ed3f	core/buildsystem: check the actual compiler being version ... Make compiler check use the output of the actual compiler being used as reported by the CC variable, instead of unconditionally running the "gcc" binary. Also only run the check if the compiler is gcc or a cross-compile gcc. ASTERISK-28374 Change-Id: Icaacf6d93686ad21076878aa1504a23b4fc9d0f4	6 years ago
Lucas Mendes	4f69ea928a	res_indications: Fix indications remove command autocomplete ... We changed the validation of autocomplete parameter in the "indications remove" command to avoid continue the execution of the command after asking for autocomplete out of range parameters. ASTERISK-28391 Reported by: lmendes86 Change-Id: I92b24131fd02f2e3c7fec966eea6f7a663310d40	6 years ago
Friendly Automation	3c106814d5	Merge "loader: support for permanent dlopen()"	6 years ago
Joshua Colp	9c070a4ae3	Merge "res_pjsip: Added a norefersub configuration setting"	6 years ago
George Joseph	d4e25710f7	res_remb_modifier: Propertly initialize bitrate to 0.0 ... ...and return the frame unaltered if bitrate can't be determined. Change-Id: Ib2175ab84f85a3d7060d31625f5a2c7fbcc2ba4c	6 years ago
Friendly Automation	685223e704	Merge "res_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority"	6 years ago
Dan Cropp	cffa2a74cb	res_pjsip: Added a norefersub configuration setting ... Added a new PJSIP global setting called norefersub. Default is true to keep support working as before. res_pjsip_refer: Configures PJSIP norefersub capability accordingly. Checks the PJSIP global setting value. If it is true (default) it adds the norefersub capability to PJSIP. If it is false (disabled) it does not add the norefersub capability to PJSIP. This is useful for Cisco switches that do not follow RFC4488. ASTERISK-28375 #close Reported-by: Dan Cropp Change-Id: I0b1c28ebc905d881f4a16e752715487a688b30e9	6 years ago
sungtae kim	1d3272d4ed	main/stasis.c: Added detail info for stasis show app cli ... Currently, the "stasis show app" cli doesn't give detail of subscription/subscriber information. Added more printings to show details. ASTERISK-28378 Change-Id: If25a6f14fe4f622bfb37462e891333da1fdf875f	6 years ago
Friendly Automation	0afd6128a7	Merge "pbx.c: Ignore dashes in extensions when using extenpatternmatchnew"	6 years ago
Friendly Automation	3f302e9788	Merge "app_voicemail: Don't split mailbox options on comma"	6 years ago
Sean Bright	e69fcdfd83	res_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority ... Suggested by abelbeck on the issue tracker. ASTERISK~28384 Reported by: abelbeck Change-Id: Icee0fff2b58dbfaa80f2b68270fe69dfb0463fc0	6 years ago
Benjamin Keith Ford	7757b7d6a6	Merge "build: Revise CHANGES and UPGRADE.txt handling."	6 years ago
Joshua Colp	adc8aa8125	Merge "res_ael: Use Gosub in for loop expressions"	6 years ago
Joshua Colp	ababac2393	Merge "ARI: Run 'make ari-stubs'"	6 years ago
Joshua Colp	dd06912dfa	Merge "res_ael: Fix pattern matching against literal '+'"	6 years ago
George Joseph	8a32b68038	CI: Move test group config files to Jenkins ... One of the downaides of having things like test configuration in the git repo is that it can't be changed at runtime. You have to create a review for the changes and merge it mefore it will take effect. This review moves the data currently held in tests/CI/periodic-dailyTestGroups.json and tests/CI/gateTestGroups.json into a Jenkins Config File attached to the job definitions. This allows us to alter it from the Jenkins UI at runtime. The original files stay in the repo as documentation. Change-Id: I14b9702f6285ce1fb2420287ba0e7d3b59109763	6 years ago
Sean Bright	d58d7d4500	app_voicemail: Don't split mailbox options on comma ... Because the per-mailbox options are the last thing on a line, don't look for or stomp on any subsequent commas. ASTERISK-27935 #close Reported by: Sébastien Duthil Change-Id: I07b2eb4a33c303d0c7114d5b906f8c067c60a153	6 years ago
George Joseph	f5e6aa449d	Merge "res_ael: Create consistent label names across reloads"	6 years ago
George Joseph	16c80b5a0d	Merge "pbx.c: Properly parse labels with leading digits"	6 years ago
Sean Bright	7e5709d726	pbx.c: Ignore dashes in extensions when using extenpatternmatchnew ... Because hyphens are not matched literally in Asterisk dialplan, we need to ignore them in our candidate extensions as well. ASTERISK-17695 #close Reported by: test011 Change-Id: I227f02301577b1633e8a55b9fe9dc149935c03f0	6 years ago