28598 Commits (bee55aaf2cc2936100b16f5a4acb87a3ea1235cd)

 

All Branches   

Search

Author	SHA1	Message	Date
George Joseph	bee55aaf2c	build: Execute ldconfig to build cache. (take two) ... On some platforms a multiarch approach is used for libraries. The build system does not take this into account and still places libraries into the lib directory if no --libdir is specified to configure. On initial startup this results in libasteriskssl.so not being found, as it is not in the multiarch lib directory. To make matters worse, options were being passed to ldconfig on both Linux and FreeBSD that actually prevented the rebuild of the cache. * Fedora has a /usr/share/config.site that automatically tells autoconf to use /usr/lib64 but CentOS does not. This logic was copied to configure.ac and modified so systems like Ubuntu, which still use /usr/lib for 64-bit systems, aren't affected. Now that we have them in the correct directory... In order for the system loader to find libasteriskssl and libasteriskpj, one of 3 things has to happen... - The linker cache must be rebuilt including the directory where the libasterisk* libraries were installed. Only root can rebuild the cache. This was busted. - We have to link the asterisk binary with an rpath pointing to the directrory where the libasterisk* libraries were installed. This makes things very complicated and will happen over the collective dead bodies of everyone who's had to package a distribution with an rpath. - Finally, you can start asterisk with LD_LIBRARY_PATH set to the directrory where the libasterisk* libraries were installed. There are no other options. So... * The invokation of ldconfig has been moved from main/Makefile to ASTTOPDIR/Makefile, the options have been removed, and DESTDIR/ASTLIBDIR appended. If you aren't root, you will be warned after the "Asterisk Installation Compete" banner that you must re-run 'make install' as root, manually run 'ldconfig DESTDIR/ASTLIBDIR' as root, or run asterisk with LD_LIBRARY_PATH. ASTERISK-26705 Change-Id: I2a64b7c33a7d3e9bde20f47e3d3ab771977af982	8 years ago
Joshua Colp	803afec45f	Merge "res_config_ldap: Various code improvements" into 13	8 years ago
Sean Bright	f1963c5b8d	res_config_ldap: Various code improvements ... The initial motivation for this patch was to properly handle memory allocation failures - we weren't checking the return values from the various LDAP library allocation functions. In the process, because update_ldap() and update2_ldap() were substantially the same code, they've been consolidated. Change-Id: Iebcfe404177cc6860ee5087976fe97812221b822	8 years ago
Michael L. Young	1ec796ce18	build_tools: Fix download_externals to allow the use of curl or wget ... Not sure if this is really a bug versus an improvement. I can see it being viewed as a bug though by some. The current build_tools/download_externals file depends on wget in order to download external modules. The current build system is able to discover which tool to use for fetching remote files - either wget or curl. This patch takes advantage of this capability by modifying the two calls to the wget binary to instead use what was discovered by the build system. ASTERISK-26812 #close Change-Id: If9411a2554f009274d377445613ae91192d948a1	8 years ago
zuul	debaf377be	Merge "Revert "build: Execute ldconfig to build cache."" into 13	8 years ago
zuul	726e3945c3	Merge "pbx_realtime: Prevent premature extension matching" into 13	8 years ago
Joshua Colp	5c9c097d17	Revert "build: Execute ldconfig to build cache." ... This reverts commit d90430953c. Change-Id: I758fe7ea0408f83a6df8e1774310d69f482700f6	8 years ago
zuul	89e0bf6ddd	Merge "pbx_dundi: DUNDi weight parameter not processed correctly" into 13	8 years ago
Joshua Colp	e9c8514b03	Merge "realtime: Fix ast_load_realtime_multientry handling" into 13	8 years ago
Sean Bright	ca6d001144	pbx_realtime: Prevent premature extension matching ... The patterns provided by pbx_realtime were checked in the order in which they were returned from the realtime backend. If there was overlap between multiple patterns, the first one to correctly match was chosen even though it may not have been the best match. We now sort the patterns descending by their length and compare in that order. There may be cases where this still results in a sub-optimal match, but this patch should improve the overall behavior. ASTERISK-18271 #close Reported by: Charlie Smurthwaite Change-Id: I56d9ac15810eb1775966b669c3028e32cc7bd809	8 years ago
Joshua Colp	c637285419	Merge changes from topic 'ASTERISK-26669' into 13 ... * changes: pjproject: Fixes to resolve DNS SRV crashes. pjproject: Increase SENDER_WIDTH column size for 64-bit system logs.	8 years ago
zuul	4e0dba31cf	Merge "res_pjsip_authenticator_digest.c: Fix sorcery's immutable contract violation." into 13	8 years ago
zuul	0afff51e72	Merge "pjsip_distributor.c: Update some debug messages to get transaction name." into 13	8 years ago
zuul	a3584c6834	Merge "res_pjsip: Record the serializer earlier on the tdata." into 13	8 years ago
zuul	51c9dd3d16	Merge "res_pjsip: Update artificial auth whenever default_realm changes." into 13	8 years ago
zuul	38b04d7dac	Merge "res_pjsip: Update authentication realm documentation." into 13	8 years ago
George Joseph	61172a841b	Merge "realtime: Centralize some common realtime backend code" into 13	8 years ago
Sean Bright	0654bf637c	pbx_dundi: DUNDi weight parameter not processed correctly ... The DUNDi weight field is not always converted from network byte order to host byte order. This can result in incorrect weight values and incorrect selection of DUNDi destinations. ASTERISK-18731 #close Reported by: Peter Racz Patches: dundi_weight.patch (license #6290) patch uploaded by Peter Racz Change-Id: Iba3e1a700ff539db57211a7bbc26f7b22ea9a1be	8 years ago
Joshua Colp	ef105410d8	Merge changes from topic 'ASTERISK-26580' into 13 ... * changes: res_config_ldap: Don't try to delete non-existent attributes res_config_ldap: Remove extraneous line numbers from log messages res_config_ldap: Make memory allocation more consistent res_config_ldap: Fix configuration inheritance from _general	8 years ago
zuul	5333c2782c	Merge "res_config_ldap: Fix erroneous LDAP_MOD_REPLACE in LDAP modify" into 13	8 years ago
Joshua Colp	90f6613033	Merge "build: Execute ldconfig to build cache." into 13	8 years ago
Sean Bright	d5522de597	realtime: Fix ast_load_realtime_multientry handling ... ast_load_realtime_multientry() returns an ast_config structure whose ast_categorys are keyed with the empty strings. Several modules were giving semantic meaning to the category names causing problems at runtime. * app_directory: Treated the category name as the mailbox name, and would fail to direct calls to the appropriate extension after an entry was chosen. * app_queue: Queues, queue members, and queue rules were all affected and needed to be updated. * pbx_realtime: Pattern matching would never succeed because the extension entered by the user was always compared to the empty string. Change-Id: Ie7e44986344b0b76ea8f6ddb5879f5040c6ca8a7	8 years ago
Sean Bright	5eb7875243	realtime: Centralize some common realtime backend code ... All of the realtime backends create artificial ast_categorys to pass back into the core as query results. These categories have no filename or line number information associated with them and the backends differ slightly on how they create them. So create a couple helper macros to help make things more consistent. Also updated the call sites to remove redundant error messages about memory allocation failure. Note that res_config_ldap sets the category filename to the 'table name' but that is not read by anything in the core, so I've dropped it. Change-Id: I3a1fd91e0c807dea1ce3b643b0a6fe5be9002897	8 years ago
zuul	f29ea24d9f	Merge "realtime: Fix LIKE escaping in SQL backends" into 13	8 years ago
Joshua Colp	d90430953c	build: Execute ldconfig to build cache. ... On some platforms a multiarch approach is used for libraries. The build system does not take this into account and still places libraries into the lib directory if no --libdir is specified to configure. On initial startup this results in libasteriskssl.so not being found, as it is not in the multiarch lib directory. This change does the minimally invasive thing and executes ldconfig so that the libraries in the lib directory are found and their location cached. By doing so Asterisk starts up fine. If DESTDIR is specified, however, the old logic is executed as the install process may not have permission to alter the ldconfig cache. ASTERISK-26705 Change-Id: If4eca46ac510c6fea5568256280ffdb3888d7bb4	8 years ago
Richard Mudgett	3b606093d3	res_pjsip_authenticator_digest.c: Fix sorcery's immutable contract violation. ... The inbound authentication object is supposed to be immutable when it is stored in sorcery. However, the immutable property is violated if the authentication object does not have a realm set. The immutable contract violation has a different effect depending upon what sorcery back end is used. If it is the config file back end you would get the same object back until res_pjsip is reloaded. If it is the real-time or AstDB back end you would get a new object on each query. If it is cached you would get the same object back until it is refreshed from the database. Once an inbound authentication object has its realm set it may or may not get updated again if the default_realm changes. If the same authentication object is used for inbound and outbound authentication then the immutable violation can make it very hard to determine why the outbound authentication now fails. The only diagnostic message is a complaint about no realms matching when it had worked earlier. It fails because of the difference in behaviour for an empty realm setting between inbound and outbound authentication objects. * Fixed the sorcery object immutable violation by creating a new object and setting the default_realm on it instead. The new object is a shallow copy for speed. * The auth_store thread storage no longer holds an auth ref. It interferes with the shallow copy and never needed a ref anyway. ASTERISK-26799 #close Change-Id: I2328a52f61b78ed5fbba38180b7f183ee7e08956	8 years ago
Richard Mudgett	6208962b00	res_pjsip: Update artificial auth whenever default_realm changes. ... There was code attempting to update the artificial authentication object whenever the default_realm changed. However, once the artificial authentication object was created it would never get updated. The artificial authentication object would require a system restart for a change to the default_realm to take effect. ASTERISK-26799 Change-Id: Id59036e9529c2d3ed728af2ed904dc36e7094802	8 years ago
Richard Mudgett	9f11da85a2	res_pjsip: Update authentication realm documentation. ... Using the same auth section for inbound and outbound authentication is not recommended. There is a difference in meaning for an empty realm setting between inbound and outbound authentication uses. An empty inbound auth realm represents the global section's default_realm value when the authentication object is used to challenge an incoming request. An empty outgoing auth realm is treated as a don't care wildcard when the authentication object is used to respond to an incoming authentication challenge. ASTERISK-26799 Change-Id: Id3952f7cfa1b6683b9954f2c5d2352d2f11059ce	8 years ago
zuul	557ef67690	Merge "tcptls.c: Add some missing allocation failure checks." into 13	8 years ago
zuul	8287a012b6	Merge "app_voicemail: vm_authenticate accesses uninitialized memory" into 13	8 years ago
Richard Mudgett	473813311b	pjproject: Fixes to resolve DNS SRV crashes. ... * Re #1945 (misc): Don't trigger SRV complete callback when there is a parse error. * srv_resolver.c: Don't try to send query if already considered resolved. ** In resolve_hostnames() don't try to resolve a query that is already considered resolved. ** In resolve_hostnames() fix DNS typo in comments. ** In build_server_entries() move a common expression assigning to cnt earlier. * sip_transport.c: Fix tdata object name to actually contain the pointer. It helps if the logs referencing a tdata object buffer actually have a name that includes the correct pointer as part of the name. Also since the tdata has its own pool it helps if any logs referencing the pool have the same name as the tdata object. This change brings tdata logging in line with how tsx objects are named. ASTERISK-26669 #close ASTERISK-26738 #close Change-Id: I56af2ded25476b3e870ca586ee69ed6954ef75af	8 years ago
Richard Mudgett	d58fdae811	pjsip_distributor.c: Update some debug messages to get transaction name. ... * Removed overloaded unmatched response ignore. We obviously sent the request so we shouldn't ignore it because it isn't new work. ASTERISK-26669 ASTERISK-26738 Change-Id: I55fb5cadc83a8e6699b347c6dc7fa32c5a617d37	8 years ago
Richard Mudgett	eb9ae4f7cb	res_pjsip: Record the serializer earlier on the tdata. ... When PJPROJECT needs to do a DNS resolution and there is not a cached entry available, the SIP request message goes out on the PJSIP monitor thread instead of the original serializer thread. Thus when the response comes back it does not get processed by the original sending serializer. This patch records the serializer on tdata before passing a request message to PJPROJECT where it can in Asterisk code. There are several places in PJPROJECT for outbound registration and publishing support that would need to record the serializer. Unfortunately, without replacing the PJPROJECT DNS resolver as was done in v14 we cannot fix those without modifying PJPROJECT. Even if we backported the DNS resolver from v14, the outbound registration refresh timer does not go out on a serializer thread but the PJSIP monitor thread. Fortunately, Asterisk's outbound publish support doesn't use the auto refresh timer that would also not go out under the serializer thread. This patch is v13 only. ASTERISK-26669 ASTERISK-26738 Change-Id: I9997b9ed6dbcebd2c37d6a67dc6dcee9c78914a4	8 years ago
Richard Mudgett	57f19d6efb	pjproject: Increase SENDER_WIDTH column size for 64-bit system logs. ... ASTERISK-26669 ASTERISK-26738 Change-Id: Ibae6fc8cae69a1f04df0c577c4c11200499d6fe0	8 years ago
zuul	d7433aa796	Merge "pjproject cli: Add object count after object lists" into 13	8 years ago
zuul	d8ae2e053b	Merge "res_config_sqlite3: Properly create missing columns when necessary" into 13	8 years ago
Sean Bright	47daca8a2b	app_voicemail: vm_authenticate accesses uninitialized memory ... vm_authenticate doesn't always set the passed ast_vm_user argument, so we initialize to 0 before passing it in. ASTERISK-25893 #close Reported by: Filip Jenicek Change-Id: Ia3cc0128f93d352ed9add8d5c2f0f7232c2cbe4a	8 years ago
zuul	a6db9c480e	Merge "Revert "build: Execute ldconfig to build cache."" into 13	8 years ago
Joshua Colp	06214173a9	Revert "build: Execute ldconfig to build cache." ... This reverts commit e910dbab90. Change-Id: I242aa0a965a79738dc898299959c6d2e020c86bd	8 years ago
George Joseph	c9ea98f9bf	pjproject cli: Add object count after object lists ... When listing a container, we now print the number of objects in the container at the end of the list. Change-Id: I791cbc3ee9da9a2af9adc655164b5d32953df812	8 years ago
Sean Bright	d8972f50f4	res_config_ldap: Don't try to delete non-existent attributes ... OpenLDAP will raise an error when we try to delete an LDAP attribute that doesn't exist. We need to filter out LDAP_MOD_DELETE requests based on which attributes the current LDAP entry actually has. There is of course a small window of opportunity for this to still fail, but it is much less likely now. Change-Id: I3fe1b04472733e43151563aaf9f8b49980273e6b	8 years ago
Sean Bright	b980cae1f7	res_config_ldap: Remove extraneous line numbers from log messages ... Extraneous line numbers were being output in many log messages. These have been removed. Change-Id: Ice9efa3d252ee87f37fa8f5ea852fda482675431	8 years ago
Sean Bright	011b7be62a	res_config_ldap: Make memory allocation more consistent ... The code in update_ldap() and update2_ldap() was using both Asterisk's memory allocation routines as well as OpenLDAP's. I've changed it so that everything that is passed to OpenLDAP's functions are allocated with their routines. Change-Id: Iafec9c1fd8ea49ccc496d6316769a6a426daa804	8 years ago
Sean Bright	b2836dde7e	res_config_ldap: Fix configuration inheritance from _general ... The "_general" configuration section allows administrators to provide both general configuration options (host, port, url, etc.) as well as a global realtime-to-LDAP-attribute mapping that is a fallback if one of the later sections do not override it. This neglected to exclude the general configuration options from the mapping. As an example, during my testing, chan_sip requested 'port' from realtime, and because I did not have it defined, it pulled in the 'port' configuration option from "_general." We now filter those out explicitly. Change-Id: I1fc61560bf96b8ba623063cfb7e0a49c4690d778	8 years ago
Sean Bright	6d5e9993b2	res_config_ldap: Fix erroneous LDAP_MOD_REPLACE in LDAP modify ... We always treat the first change of our modification batch as a replacement when it sometimes is actually a delete. So we have to pass the correct arguments to the OpenLDAP library. ASTERISK-26580 #close Reported by: Nicholas John Koch Patches: res_config_ldap.c-11.24.1.patch (license #6833) patch uploaded by Nicholas John Koch Change-Id: I0741d25de07c9539f1edc6eff3696165dfb64fbe	8 years ago
zuul	919fe21155	Merge "res_config_sqlite3: Fix crash when loading with invalid config" into 13	8 years ago
Sean Bright	5b7c6678ae	res_config_sqlite3: Fix crash when loading with invalid config ... When ast_config_load() fails with CONFIG_STATUS_FILEINVALID, it has already destroyed the ast_config struct for us. Trying to do it again results in a crash. Change-Id: If6a5c0ca718ad428e01a1fb25beb209a9ac18bc6	8 years ago
Richard Mudgett	096496e13e	tcptls.c: Add some missing allocation failure checks. ... Change-Id: I0ddf01cd3c10d3b6666d7bf68d4e206a37f4fbdb	8 years ago
Sean Bright	047a1e7dcc	pjproject-bundled: Fix checksum verification when using cURL ... ASTERISK-26802 #close Reported by: Michael L. Young Change-Id: Iad293080f55d4d69ab615717a15211d916eed613	8 years ago
Joshua Colp	2b10ba8074	Merge "build: Execute ldconfig to build cache." into 13	8 years ago