8306 Commits (b79e67ba47a5ea0913704c4ca57cda06051c20e7)

Author	SHA1	Message	Date
Sean Bright	38cebc73a3	thread safety: Don't use getprotobyname() ... POSIX does not require getprotobyname() to be thread safe and some implementations use static memory which causes issues when multiple threads are used. Further, our usage of it today is just to ultimately get IPPROTO_TCP for calls to setsockopt(). So instead we just use IPPROTO_TCP directly. Change-Id: I2e14e58674808f7ce99b2f5e900d0f90d0d8da48	8 years ago
Sean Bright	8721d0bf1b	chan_sip: Add rtcp-mux support ... ASTERISK-26846 #close Change-Id: I541a1602ff55ab73684e9f8002edb9e0e745d639	8 years ago
Joshua Colp	701b753a0b	Merge "chan_iax2: Reload of iax peer results in loss of host address/port" into 13	8 years ago
Joshua Colp	947f1ebf86	Merge "chan_pjsip: Don't assume a session will have a channel." into 13	8 years ago
Richard Begg	5389666d6f	chan_iax2: Reload of iax peer results in loss of host address/port ... When using a non-dynamic peer address, build_peer() invalidates the peer address structure by setting the address family to unspecified. However, if dnsmgr is enabled, the subsequent call to ast_dnsmgr_lookup() will not amend the peer address if the cache is still valid, resulting in peer connectivity failures. To fix this, we call ast_dnsmgr_refresh() instead. ASTERISK-26865 Change-Id: Id8a89a2f771ebbaf32255a35fe596a6dcb97a082	8 years ago
Joshua Colp	c8d1b915d7	chan_pjsip: Don't assume a session will have a channel. ... When querying for PJSIP specific information using the dialplan function CHANNEL() it is possible that the underlying session will no longer have a channel associated with it. This is most likely to occur when the RTCP HEP module attempts to get the channel name. If this happens then a crash will occur. This change just adds a check that the channel exists on the session before querying it. ASTERISK-26857 Change-Id: I113479cffff6ae64cf8ed089e9e1565223426f01	8 years ago
Jean Aunis	d3ef833b3b	chan_sip: Call not cancelled after receiving a 422 response ... When receiving a 422 response, the invitestate variable must be reset to INV_CALLING. ASTERISK-26841 Change-Id: Ia0502d6b02192664cefa4e75bafdd2645ce56099	8 years ago
Joshua Colp	8386a38e06	Merge "pjsip/cli_commands: pjsip show channelstats shows wrong codec" into 13	8 years ago
Daniel Journo	67c989ce78	pjsip/cli_commands: pjsip show channelstats shows wrong codec ... * cli_commands.c Fixed CLI output ASTERISK-26822 #close Change-Id: I3889ef6a8f6738fc312fab42db5efacd6e452b01	8 years ago
Richard Mudgett	4271c700f7	core: Cleanup ast_get_hint() usage. ... * manager.c:manager_state_cb() Fix potential use of uninitialized hint[] if a hint does not exist for the requested extension. Ran into this when developing a testsuite test. The AMI event ExtensionStatus came out with the hint header value containing garbage. The AMI event PresenceStatus also had the same issue. * manager.c:action_extensionstate() no need to completely initialize the hint[]. Only initialize the first element. * pbx.c:ast_add_hint() Remove unnecessary assignment. * chan_sip.c: Eliminate an unneeded hint[] local variable. We only care about the return value of ast_get_hint() there. Change-Id: Ia9a8786f01f93f1f917200f0a50bead0319af97b	8 years ago
Vitezslav Novy	d91f61f0b5	chan_sip: Allow DTLS to be disabled when reloading. ... This change fixes a problem where removing the DTLS configuration options and reloading would not disable DTLS. This occurred because the DTLS configuration was not reset to an unconfigured state on reload. ASTERISK-26313 Change-Id: I10952709cc4a7727fb50534b042bce9d64894b39	8 years ago
Igor Goncharovsky	7aa731c1c7	chan_unistim: fix char type to have consistent behavior on ARM ... There is difference exists in behaviour of char type on x86 and ARM. On x86 by default char variable type means signed char, but in ARM unsigned char used. This make binary calculations and negative values works wrong on ARM. This patch change type of char variables used for store negative values and binary calculations to signed char. ASTERISK-26714 Change-Id: Id78716dee9568a58419d4ef63c038affc3dfc7ab	8 years ago
zuul	0d6c99e715	Merge "cli: Fix various CLI documentation and completion issues" into 13	8 years ago
zuul	6958241b3f	Merge "core: Cleanup some channel snapshot staging anomalies." into 13	8 years ago
Sean Bright	ea8a610776	cli: Fix various CLI documentation and completion issues ... * app_minivm: Use built-in completion facilities to complete optional arguments. * app_voicemail: Use built-in completion facilities to complete optional arguments. * app_confbridge: Add missing colons after 'Usage' text. * chan_alsa: Use built-in completion facilities to complete optional arguments. * chan_sip: Use built-in completion facilities to complete optional arguments. Add completions for 'load' for 'sip show user', 'sip show peer', and 'sip qualify peer.' * chan_skinny: Correct and extend completions for 'skinny reset' and 'skinny show line.' * func_odbc: Correct completions for 'odbc read' and 'odbc write' * main/asterisk: Correct and extend completions for 'core show file version.' * main/astmm: Use built-in completion facilities to complete arguments for 'memory' commands. * main/bridge: Correct completions for 'bridge kick.' * main/ccss: Use built-in completion facilities to complete arguments for 'cc cancel' command. * main/cli: Add 'all' completion for 'channel request hangup.' Correct completions for 'core set debug channel.' Correct completions for 'core show calls.' * main/pbx_app: Remove redundant completions for 'core show applications.' * main/pbx_hangup_handler: Remove unused completions for 'core show hanguphandlers all.' * res_sorcery_memory_cache: Add completion for 'reload' argument of 'sorcery memory cache stale' and properly implement. Change-Id: Iee58c7392f6fec34ad9d596109117af87697bbca	8 years ago
zuul	c38cd504ad	Merge "chan_pjsip: Multidomain endpoint finding on call" into 13	8 years ago
Norbert Varga	17030100ca	chan_pjsip: Multidomain endpoint finding on call ... When PJSIP tries to call an endpoint with a domain (e.g. 1000@test.com), the user part is stripped down as it would be a trunk with a specified user, and only the host part is called as a PJSIP endpoint and can't be found. This is not correct in the case of a multidomain SIP account, so the stripping after the @ sign is done only if the whole endpoint (in multidomain case 1000@test.com) can't be found. ASTERISK-26248 Change-Id: I3a2dd6f57f3bd042df46b961eccd81d31ab202e6	8 years ago
Richard Mudgett	2817f87d27	core: Cleanup some channel snapshot staging anomalies. ... We shouldn't unlock the channel after starting a snapshot staging because another thread may interfere and do its own snapshot staging. * app_dial.c:dial_exec_full() made hold the channel lock while setting up the outgoing channel staging. Made hold the channel lock after the called party answers while updating the caller channel staging. * chan_sip.c:sip_new() completed the channel staging on off-nominal exit. Also we need to use ast_hangup() instead of ast_channel_unref() at that location. * channel.c:__ast_channel_alloc_ap() added a comment about not needing to complete the channel snapshot staging on off-nominal exit paths. * rtp_engine.c:ast_rtp_instance_set_stats_vars() made hold the channel locks while staging the channels for the stats channel variables. Change-Id: Iefb6336893163f6447bad65568722ad5d5d8212a	8 years ago
zuul	484e8ed5e3	Merge "debug_utilities: Add ast_logescalator" into 13	8 years ago
George Joseph	456bc3c704	debug_utilities: Add ast_logescalator ... The escalator works by creating a set of startup commands in cli.conf that set up logger channels and issue the debug commands for the subsystems specified. If asterisk is running when it is executed, the same commands will be issued to the running instance. The original cli.conf is saved before any changes are made and can be restored by executing '$prog --reset'. The log output will be stored in... $astlogdir/message.$uniqueid $astlogdir/debug.$uniqueid $astlogdir/dtmf.$uniqueid $astlogdir/fax.$uniqueid $astlogdir/security.$uniqueid $astlogdir/pjsip_history.$uniqueid $astlogdir/sip_history.$uniqueid Some minor tweaks were made to chan_sip, and res_pjsip_history so their history output could be send to a log channel as packets are captured. A minor tweak was also made to manager so events are output to verbose when "manager set debug on" is issued. Change-Id: I799f8e5013b86dc5282961b27383d134bf09e543	8 years ago
Richard Mudgett	ab7a9fc5b2	chan_oss.c: Fix format ref leak in oss_read(). ... Change-Id: I0a5d56c7dcf327d60f86a4c25a23571733709fd0	8 years ago
Joshua Colp	d30bef1de9	Merge "chan_sip: Remember SDP negotiation on SIP_CODEC_INBOUND." into 13	9 years ago
Joshua Colp	fdfa805552	Merge changes from topic 'ASTERISK-26672' into 13 ... * changes: res_rtp_asterisk.c: Fix uninitialized memory crash. chan_rtp.c: Fix uninitialized memory crash.	9 years ago
Alexander Traud	367128e70b	chan_sip: Remember SDP negotiation on SIP_CODEC_INBOUND. ... After a SIP_CODEC_INBOUND in the dialplan, do not continue with cached formats but remember the joint format. Cached formats contain default parameters, often create an empty fmtp line. However, a joint format might have passed format_get_joint(.) in a res_format_attr_* module (like Opus Codec) and contain the resulting format parameters from a SDP negotiation. ASTERISK-26691 #close Change-Id: I35712d98a793d4c3efdd156cec57deab9014b1dc	9 years ago
Joshua Colp	34e728cfb9	chan_pjsip: Use session for retrieving CHANNEL() information. ... The CHANNEL() dialplan function implementation for PJSIP allows querying of PJSIP specific information. This used the channel passed in to get the PJSIP session and associated information. It is possible for this channel to be masqueraded and end up as a different channel type by the time the information request is actually acted upon. This change retrieves the PJSIP session safely and accesses data from it (including channel). This provides a guarantee that the session and channel will not be altered when the request is being acted upon. ASTERISK-26673 Change-Id: I335e12b89e1820cafdd92b3e7526b8ba649eb7e6	9 years ago
Richard Mudgett	0aa5db4b38	chan_rtp.c: Fix uninitialized memory crash. ... unicast_rtp_request() could pass an uninitialized 'us' parameter to ast_ouraddrfor(). If ast_ouraddrfor() returns an error then the 'us' parameter may not get initialized. Thus when the code tries to save the 'us' parameter to the local address we could try to copy a ridiculous sized memory buffer and segfault. * Made pass an initialized 'us' parameter to ast_ouraddrfor() and abort the UnicastRTP channel request if it fails. ASTERISK-26672 Change-Id: I1ef7a7c09f4da4f15dcb6de660d2bcac5f2a95c0	9 years ago
Joshua Colp	2b675ce122	Merge "chan_dahdi.c: Fix bounds check regression." into 13	9 years ago
Corey Farrell	493849dcd7	chan_sip: Reorder unload_module to deal with stuck TCP threads. ... In some situations TCP threads may become frozen. This creates the possibility that Asterisk could segfault if they become unfrozen after chan_sip has been dlclose'd. This reorders the unload_module process to allow abort if threads do not exit within 5 seconds. High level order as follows: 1) Unregister from the core to stop new requests. 2) Signal threads to stop 3) Clear config based tables (but do not free the table itself). 4) Verify that threads have shutdown, cancel unload if not. 5) Clean all remaining resources. ASTERISK-26586 Change-Id: Ie23692041d838fbd35ece61868f4c640960ff882	9 years ago
Richard Mudgett	4b285d226d	chan_dahdi.c: Fix bounds check regression. ... Caused by ASTERISK-25494 Change-Id: I1fc408c1a083745ff59da5c4113041bbfce54bcb	9 years ago
Joshua Colp	791c15942b	Merge "Fix typo in chan_sip" into 13	9 years ago
Joshua Colp	c7eb439953	Merge "chan_sip: Delete unneeded check" into 13	9 years ago
Badalyan Vyacheslav	22820e10fe	chan_sip: Delete unneeded check ... P is always true. We check it before Change-Id: Iee61cda002a9f61aee26b9f66c5f9b59e3389efb	9 years ago
Badalyan Vyacheslav	6aa2c5e5f9	Small code cleanup in chan_sip ... The conditional expressions of the 'if' operators situated alongside each other are identical. Change-Id: I2cf7c317b106ec14440c7f1b5dcfbf03639f748a	9 years ago
Badalyan Vyacheslav	b596fac838	Fix typo in chan_sip ... The conditional expressions of the 'if' operators situated alongside each other are identical. Change-Id: I652b6dcddb3be007e669a6aa8107edb31a1ddafb	9 years ago
Walter Doekes	41c6319c4e	chan_sip: Do not allow non-SP/HTAB between header key and colon. ... RFC says SIP headers look like: HCOLON = *( SP / HTAB ) ":" SWS SWS = [LWS] ; sep whitespace LWS = [*WSP CRLF] 1*WSP ; linear whitespace WSP = SP / HTAB ; from rfc2234 chan_sip implemented this: HCOLON = *( LOWCTL / SP ) ":" SWS LOWCTL = %x00-1F ; CTL without DEL This discrepancy meant that SIP proxies in front of Asterisk with chan_sip could pass on unknown headers with \x00-\x1F in them, which would be treated by Asterisk as a different (known) header. For example, the "To\x01:" header would gladly be forwarded by some proxies as irrelevant, but chan_sip would treat it as the relevant "To:" header. Those relying on a SIP proxy to scrub certain headers could mistakenly get unexpected and unvalidated data fed to Asterisk. This change fixes so chan_sip only considers SP/HTAB as valid tokens before the colon, making it agree on the headers with other speakers of SIP. ASTERISK-26433 #close AST-2016-009 Change-Id: I78086fbc524ac733b8f7f78cb423c91075fd489b	9 years ago
Joshua Colp	fdf0a2afb0	Merge "res_pjsip/chan_sip: Advertise 'ws' in the SIP URI transport parameter" into 13	9 years ago
zuul	eec82c6221	Merge "chan_pjsip: fix switching sending codec when asymmetric_rtp_codec=no" into 13	9 years ago
Matt Jordan	09c36a6535	res_pjsip/chan_sip: Advertise 'ws' in the SIP URI transport parameter ... Per RFC 7118 5.2, the SIP URI 'transport' parameter should advertise 'ws' when WebSockets are to be used as the transport. This applies to both secure and insecure WebSockets. There were two bugs in Asterisk with respect to this: (1) The most egregious occurs in res_pjsip. There, we advertise 'ws' for insecure websockets and 'wss' for secure websockets. While this would seem to make sense - since 'WS' and 'WSS' are used for the Via Transport parameter - this is not the case for the SIP URI. This patch corrects that by registering the secure websockets with pjproject using the shorthand 'WS', and by returning 'ws' when asked for the transport parameter. Note that in pjproject, it is perfectly valid to have multiple transports use the same shorthand. (2) In chan_sip, we return an upper-case version of the transport 'WS' instead of 'ws'. Since we should be strict in what we send and liberal in what we accept (within reason), this patch lower-cases the transport before appending it to the parameter. ASTERISK-24330 #close Reported by: cervajs, Inaki Baz Castillo Change-Id: Iff77b645f8cc3b7cd35168a6676c26b147f22f42	9 years ago
Michael Kuron	0cc8351484	chan_sip: Fix segfault during module unload ... If a TCP/TLS connection was pending (not accepted and not timed out) during unload of chan_sip, Asterisk would segfault when trying to send a signal to a thread whose thread ID hadn't been recorded yet. This commit fixes that by recording the thread ID before calling the blocking connect() syscall. This was a regression introduced by 776a14386a. The above wasn't enough to fix the segfault, which was now delayed to the point where connect() timed out. Therefore, it was necessary to also remove the SA_RESTART flag from the SIGURG sigaction so that pthread_kill() could be used to interruput the connect() syscall. This was a regression introduced by 5d313f51b9. ASTERISK-26586 #close Change-Id: I76fd9d47d56e4264e2629bce8ec15fecba673e7b	9 years ago
Alexei Gradinari	cf6d13180e	chan_pjsip: fix switching sending codec when asymmetric_rtp_codec=no ... The sending codec is switched to the receiving codec and then is switched back to the best native codec on EVERY receiving RTP packets. This is because after call of ast_channel_set_rawwriteformat there is call of ast_set_write_format which calls set_format which sets rawwriteformat to the best native format. This patch adds a new function ast_set_write_format_path which set specific write path on channel and uses this function to switch the sending codec. ASTERISK-26603 #close Change-Id: I5b7d098f8b254ce8f45546e6c36e5d324737f71d	9 years ago
Igor Goncharovskiy	3faca1d4ff	Fix closing rtp ports after call finished in chan_unistim. ... Fix ASTERISK-26565 by adding ast_rtp_instance_stop before rtp instance destroy for chan_unistim. Also several fixes for displayed text translation. Change-Id: If42a03eea09bd1633471406bdc829cf98bf6affc	9 years ago
Kevin Harwell	cb30963d22	Revert "chan_sip: Fix lastrtprx always updated" ... This reverts commit 93332cb1d0. Unfortunately, the aforementioned commit caused a regression (incoming calls would eventually disconnect). Thus it is being removed. ASTERISK-26523 #close ASTERISK-25270 Change-Id: Ibf5586adc303073a8eac667a4cbfdb6be184a64d	9 years ago
Sebastian Gutierrez	714412f6c4	chan_sip: add missing account code ... Added missing account to AMI event of sip show peers ASTERISK-26176 #close Change-Id: Ieb6c2c80a838a1b59c82103eba4c63ba238dc482	9 years ago
Grachev Sergey	b3f10b7b94	chan_sip: Incorrect display option Outbound reg. retry 403 ... If in sip.conf (general section) set option register_retry_403=no, the command "sip show settings" return value: Outbound reg. retry 403:0 If in sip.conf (general section) set option register_retry_403=yes, the command "sip show settings" return value: Outbound reg. retry 403:-1 * In static char "sip show settings" for "Outbound.reg. retry 403" option use AST_CLI_YESNO ASTERISK-26476 #close Change-Id: I3c14272f05f1067bd2aeaa8b3ef9cf8fcb12dcf9	9 years ago
Joshua Colp	e8a3af2629	Merge "pjsip: Fix a few media bugs with reinvites and asymmetric payloads." into 13	9 years ago
Joshua Colp	dc13003dd9	Merge "chan_pjsip: segfault on already disconnected session" into 13	9 years ago
Joshua Colp	e0bc17edff	pjsip: Fix a few media bugs with reinvites and asymmetric payloads. ... When channel format changes occurred as a result of an RTP re-negotiation the bridge was not informed this had happened. As a result the bridge technology was not re-evaluated and the channel may have been in a bridge technology that was incompatible with its formats. The bridge is now unbridged and the technology re-evaluated when this occurs. The chan_pjsip module also allowed asymmetric codecs for sending and receiving. This did not work with all devices and caused one way audio problems. The default has been changed to NOT do this but to match the sending codec to the receiving codec. For users who want asymmetric codecs an option has been added, asymmetric_rtp_codec, which will return chan_pjsip to the previous behavior. The codecs returned by the chan_pjsip module when queried by the bridge_native_rtp module were also not reflective of the actual negotiated codecs. The nativeformats are now returned as they reflect the actual negotiated codecs. ASTERISK-26423 #close Change-Id: I6ec88c6e3912f52c334f1a26983ccb8f267020dc	9 years ago
zuul	ad2dde8106	Merge "chan_sip: Support nat=auto_comedia or nat=force_rport,auto_comedia." into 13	9 years ago
zuul	0384bae66f	Merge "chan_rtp: Set a sane default rtp engine for unicast." into 13	9 years ago
Alexei Gradinari	6d462b9eaf	chan_pjsip: segfault on already disconnected session ... On heavy loaded system the TCP/TLS incoming calls could be disconnected by pjproject while these calls are being processed by asterisk. This patch uses functions pjsip_inv_add_ref/pjsip_inv_dec_ref to inform pjproject that an INVITE session is in use. ASTERISK-26482 #close Change-Id: Ia2e3e2f75358cdb530252a9ce158af3d5d9fdf33	9 years ago