asterisk

Commit Graph

Author	SHA1	Message	Date
Jaco Kroon	b758f2e880	res_musiconhold: Appropriately lock channel during start. This relates to #829 This doesn't sully solve the Ops issue, but it solves the specific crash there. Further PRs to follow. In the specific crash the generator was still under construction when moh was being stopped, which then proceeded to close the stream whilst it was still in use. Signed-off-by: Jaco Kroon <jaco@uls.co.za> (cherry picked from commit `9725811125`)	1 month ago
Asterisk Development Team	f34af39805	Update for 20.15.2	1 month ago
George Joseph	9d7048083b	res_pjsip_authenticator_digest: Fix SEGV if get_authorization_hdr returns NULL. In the highly-unlikely event that get_authorization_hdr() couldn't find an Authorization header in a request, trying to get the digest algorithm would cauase a SEGV. We now check that we have an auth header that matches the realm before trying to get the algorithm from it. Resolves: #GHSA-64qc-9x89-rx5j	1 month ago
Asterisk Development Team	21d22b328a	Update for 20.15.1	1 month ago
ThatTotallyRealMyth	0788c03f92	safe_asterisk: Add ownership checks for /etc/asterisk/startup.d and its files. UpgradeNote: The safe_asterisk script now checks that, if it was run by the root user, the /etc/asterisk/startup.d directory and all the files it contains are owned by root. If the checks fail, safe_asterisk will exit with an error and Asterisk will not be started. Additionally, the default logging destination is now stderr instead of tty "9" which probably won't exist in modern systems. Resolves: #GHSA-v9q8-9j8m-5xwp	1 month ago
George Joseph	53b571ae6e	res_stir_shaken: Test for missing semicolon in Identity header. ast_stir_shaken_vs_verify() now makes sure there's a semicolon in the Identity header to prevent a possible segfault. Resolves: #GHSA-mrq5-74j5-f5cr	1 month ago
George Joseph	ac25398707	.lastclean: Remove from git It never should been versioned in the first place.	1 month ago
Asterisk Development Team	be0642f6ba	Update for 20.15.0	1 month ago
Asterisk Development Team	87b58f398b	Update for 20.15.0-rc3	1 month ago
George Joseph	ca7db896e5	channelstorage: Rename callbacks that conflict with DEBUG_FD_LEAKS. DEBUG_FD_LEAKS replaces calls to "open" and "close" with functions that keep track of file descriptors, even when those calls are actually callbacks defined in structures like ast_channelstorage_instance->open and don't touch file descriptors. This causes compilation failures. Those callbacks have been renamed to "open_instance" and "close_instance" respectively. Resolves: #1287	1 month ago
George Joseph	abdfb5aa87	channelstorage_cpp_map_name_id: Fix callback returning non-matching channels. When the callback() API was invoked but no channel passed the test, callback would return the last channel tested instead of NULL. It now correctly returns NULL when no channel matches. Resolves: #1288	1 month ago
Asterisk Development Team	bd9e6e1e01	Update for 20.15.0-rc2	1 month ago
Michal Hajek	7f7c748762	audiohook.c: Improve frame pairing logic to avoid MixMonitor breakage with mixed codecs This patch adjusts the read/write synchronization logic in audiohook_read_frame_both() to better handle calls where participants use different codecs or sample sizes (e.g., alaw vs G.722). The previous hard threshold of 2 * samples caused MixMonitor recordings to break or stutter when frames were not aligned between both directions. The new logic uses a more tolerant limit (1.5 * samples), which prevents audio tearing without causing excessive buffer overruns. This fix specifically addresses issues with MixMonitor when recording directly on a channel in a bridge using mixed codecs. Reported-by: Michal Hajek <michal.hajek@daktela.com> Resolves: #1276 Resolves: #1279	1 month ago
Sean Bright	aeaeb26438	channelstorage_makeopts.xml: Remove errant XML character. Resolves: #1282	1 month ago
Asterisk Development Team	4665bdcee0	Update for 20.15.0-rc1	1 month ago
George Joseph	00b99494b4	res_stir_shaken.so: Handle X5U certificate chains. The verification process will now load a full certificate chain retrieved via the X5U URL instead of loading only the end user cert. * Renamed crypto_load_cert_from_file() and crypto_load_cert_from_memory() to crypto_load_cert_chain_from_file() and crypto_load_cert_chain_from_memory() respectively. * The two load functions now continue to load certs from the file or memory PEMs and store them in a separate stack of untrusted certs specific to the current verification context. * crypto_is_cert_trusted() now uses the stack of untrusted certs that were extracted from the PEM in addition to any untrusted certs that were passed in from the configuration (and any CA certs passed in from the config of course). Resolves: #1272 UserNote: The STIR/SHAKEN verification process will now load a full certificate chain retrieved via the X5U URL instead of loading only the end user cert.	1 month ago
George Joseph	12337a55a4	res_stir_shaken: Add "ignore_sip_date_header" config option. UserNote: A new STIR/SHAKEN verification option "ignore_sip_date_header" has been added that when set to true, will cause the verification process to not consider a missing or invalid SIP "Date" header to be a failure. This will make the IAT the sole "truth" for Date in the verification process. The option can be set in the "verification" and "profile" sections of stir_shaken.conf. Also fixed a bug in the port match logic. Resolves: #1251 Resolves: #1271	1 month ago
Naveen Albert	eb6808e580	app_record: Add RECORDING_INFO function. Add a function that can be used to retrieve info about a previous recording, such as its duration. This is being added as a function to avoid possibly trampling on dialplan variables, and could be extended to provide other information in the future. Resolves: #548 UserNote: The RECORDING_INFO function can now be used to retrieve the duration of a recording.	1 month ago
Itzanh	2928b876d8	app_sms.c: Fix sending and receiving SMS messages in protocol 2 This fixes bugs in SMS messaging to SMS-capable analog phones that prevented app_sms.c from talking to phones using SMS protocol 2. - Fix MORX message reception (from phone to Asterisk) in SMS protocol 2 - Fix MTTX message transmission (from Asterisk to phone) in SMS protocol 2 One of the bugs caused messages to have random characters and junk appended at the end up to the character limit. Another bug prevented Asterisk from sending messages from Asterisk to the phone at all. A final bug caused the transmission from Asterisk to the phone to take a long time because app_sms.c did not hang up after correctly sending the message, causing the phone to have to time out and hang up in order to complete the message transmission. This was tested with a Linksys PAP2T and with a GrandStream HT814, sending and receiving messages with Telefónica DOMO Mensajes phones from Telefónica Spain. I had to play with both the network jitter buffer and the dB gain to get it to work. One of my phones required the gain to be set to +3dB for it to work, while another required it to be set to +6dB. Only MORX and MTTX were tested, I did not test sending and receiving messages to a TelCo SMSC.	1 month ago
phoneben	76e22b0670	app_queue: queue rules – Add support for QUEUE_RAISE_PENALTY=rN to raise penalties only for members within min/max range This update adds support for a new QUEUE_RAISE_PENALTY format: rN When QUEUE_RAISE_PENALTY is set to rN (e.g., r4), only members whose current penalty is greater than or equal to the defined min_penalty and less than or equal to max_penalty will have their penalty raised to N. Members with penalties outside the min/max range remain unchanged. Example behaviors: QUEUE_RAISE_PENALTY=4 → Raise all members with penalty < 4 (existing behavior) QUEUE_RAISE_PENALTY=r4 → Raise only members with penalty in [min_penalty, max_penalty] to 4 Implementation details: Adds parsing logic to detect the r prefix and sets the raise_respect_min flag Modifies the raise logic to skip members outside the defined penalty range when the flag is active UserNote: This change introduces QUEUE_RAISE_PENALTY=rN, allowing selective penalty raises only for members whose current penalty is within the [min_penalty, max_penalty] range. Members with lower or higher penalties are unaffected. This behavior is backward-compatible with existing queue rule configurations.	1 month ago
George Joseph	63656c1f8f	res_websocket_client: Add more info to the XML documentation. Added "see-also" links to chan_websocket and ARI Outbound WebSocket and added an example configuration for each.	1 month ago
Jaco Kroon	3ef106d3a9	res_odbc: cache_size option to limit the cached connections. Signed-off-by: Jaco Kroon <jaco@uls.co.za> UserNote: New cache_size option for res_odbc to on a per class basis limit the number of cached connections. Please reference the sample configuration for details.	1 month ago
Jaco Kroon	6dbeace0c7	res_odbc: cache_type option for res_odbc. This enables setting cache_type classes to a round-robin queueing system rather than the historic stack mechanism. This should result in lower risk of connection drops due to shorter idle times (the first connection to go onto the stack could in theory never be used again, ever, but sit there consuming resources, there could be multiple of these). And with a queue rather than a stack, dead connections are guaranteed to be detected and purged eventually. This should end up better balancing connection_cnt with actual load over time, assuming the database doesn't keep connections open excessively long from it's side. Signed-off-by: Jaco Kroon <jaco@uls.co.za> UserNote: When using res_odbc it should be noted that back-end connections to the underlying database can now be configured to re-use the cached connections in a round-robin manner rather than repeatedly re-using the same connection. This helps to keep connections alive, and to purge dead connections from the system, thus more dynamically adjusting to actual load. The downside is that one could keep too many connections active for a longer time resulting in resource also begin consumed on the database side.	1 month ago
Sean Bright	5ca12d6cdc	res_pjsip: Fix empty `ActiveChannels` property in AMI responses. The logic appears to have been reversed since it was introduced in `05cbf8df`. Resolves: #1254	1 month ago
George Joseph	f82c7b2694	ARI Outbound Websockets Asterisk can now establish websocket sessions _to_ your ARI applications as well as accepting websocket sessions _from_ them. Full details: http://s.asterisk.net/ari-outbound-ws Code change summary: * Added an ast_vector_string_join() function, * Added ApplicationRegistered and ApplicationUnregistered ARI events. * Converted res/ari/config.c to use sorcery to process ari.conf. * Added the "outbound-websocket" ARI config object. * Refactored res/ari/ari_websockets.c to handle outbound websockets. * Refactored res/ari/cli.c for the sorcery changeover. * Updated res/res_stasis.c for the sorcery changeover. * Updated apps/app_stasis.c to allow initiating per-call outbound websockets. * Added CLI commands to manage ARI websockets. * Added the new "outbound-websocket" object to ari.conf.sample. * Moved the ARI XML documentation out of res_ari.c into res/ari/ari_doc.xml UserNote: Asterisk can now establish websocket sessions _to_ your ARI applications as well as accepting websocket sessions _from_ them. Full details: http://s.asterisk.net/ari-outbound-ws	1 month ago
George Joseph	04a3e854d0	res_websocket_client: Create common utilities for websocket clients. Since multiple Asterisk capabilities now need to create websocket clients it makes sense to create a common set of utilities rather than making each of those capabilities implement their own. * A new configuration file "websocket_client.conf" is used to store common client parameters in named configuration sections. * APIs are provided to list and retrieve ast_websocket_client objects created from the named configurations. * An API is provided that accepts an ast_websocket_client object, connects to the remote server with retries and returns an ast_websocket object. TLS is supported as is basic authentication. * An observer can be registered to receive notification of loaded or reloaded client objects. * An API is provided to compare an existing client object to one just reloaded and return the fields that were changed. The caller can then decide what action to take based on which fields changed. Also as part of thie commit, several sorcery convenience macros were created to make registering common object fields easier. UserNote: A new module "res_websocket_client" and config file "websocket_client.conf" have been added to support several upcoming new capabilities that need common websocket client configuration.	1 month ago
George Joseph	46549fa4e3	asterisk.c: Add option to restrict shell access from remote consoles. UserNote: A new asterisk.conf option 'disable_remote_console_shell' has been added that, when set, will prevent remote consoles from executing shell commands using the '!' prefix. Resolves: #GHSA-c7p6-7mvq-8jq2	1 month ago
George Joseph	07cee24a75	res_pjsip_messaging.c: Mask control characters in received From display name Incoming SIP MESSAGEs will now have their From header's display name sanitized by replacing any characters < 32 (space) with a space. Resolves: #GHSA-2grh-7mhv-fcfw	1 month ago
mkmer	642504c007	frame.c: validate frame data length is less than samples when adjusting volume Resolves: #1230	1 month ago
Sven Kube	3924cdc975	res_audiosocket.c: Add retry mechanism for reading data from AudioSocket The added retry mechanism addresses an issue that arises when fragmented TCP packets are received, each containing only a portion of an AudioSocket packet. This situation can occur if the external service sending the AudioSocket data has Nagle's algorithm enabled.	1 month ago
Sven Kube	2d404f461c	res_audiosocket.c: Set the TCP_NODELAY socket option Disable Nagle's algorithm by setting the TCP_NODELAY socket option. This reduces latency by preventing delays caused by packet buffering.	1 month ago
Thomas B. Clark	c4aad078fb	menuselect: Fix GTK menu callbacks for Fedora 42 compatibility This patch resolves a build failure in `menuselect_gtk.c` when running `make menuconfig` on Fedora 42. The new version of GTK introduced stricter type checking for callback signatures. Changes include: - Add wrapper functions to match the expected `void (*)(void)` signature. - Update `menu_items` array to use these wrappers. Fixes: #1243	1 month ago
Stanislav Abramenkov	ac1fd7ffc1	jansson: Upgrade version to jansson 2.14.1 UpgradeNote: jansson has been upgraded to 2.14.1. For more information visit jansson Github page: https://github.com/akheron/jansson/releases/tag/v2.14.1 Resolves: #1178	1 month ago
Joe Searle	8881655fa2	pjproject: Increase maximum SDP formats and attribute limits Since Chrome 136, using Windows, when initiating a video call the INVITE SDP exceeds the maximum number of allowed attributes, resulting in the INVITE being rejected. This increases the attribute limit and the number of formats allowed when using bundled pjproject. Fixes: #1240	1 month ago
Nathan Monfils	84a7cae3b1	manager.c: Invalid ref-counting when purging events We have a use-case where we generate a lot of events on the AMI, and then when doing `manager show eventq` we would see some events which would linger for hours or days in there. Obviously something was leaking. Testing allowed us to track down this logic bug in the ref-counting on the event purge. Reproducing the bug was not super trivial, we managed to do it in a production-like load testing environment with multiple AMI consumers. The race condition itself: 1. something allocates and links `session` 2. `purge_sessions` iterates over that `session` (takes ref) 3. `purge_session` correctly de-referencess that session 4. `purge_session` re-evaluates the while() loop, taking a reference 5. `purge_session` exits (`n_max > 0` is false) 6. whatever allocated the `session` deallocates it, but a reference is now lost since we exited the `while` loop before de-referencing. 7. since the destructor is never called, the session->last_ev->usecount is never decremented, leading to events lingering in the queue The impact of this bug does not seem major. The events are small and do not seem, from our testing, to be causing meaningful additional CPU usage. Mainly we wanted to fix this issue because we are internally adding prometheus metrics to the eventq and those leaked events were causing the metrics to show garbage data.	1 month ago
Mike Bradeen	131ac4fa14	res_pjsip_nat.c: Do not overwrite transfer host When a call is transfered via dialplan behind a NAT, the host portion of the Contact header in the 302 will no longer be over-written with the external NAT IP and will retain the hostname. Fixes: #1141	1 month ago
Mike Bradeen	c147877eb1	chan_pjsip: Serialize INVITE creation on DTMF attended transfer When a call is transfered via DTMF feature code, the Transfer Target and Transferer are bridged immediately. This opens the possibilty of a race condition between the creation of an INVITE and the bridge induced colp update that can result in the set caller ID being over-written with the transferer's default info. Fixes: #1234	1 month ago
George Joseph	e7d990b66b	Alternate Channel Storage Backends Full details: http://s.asterisk.net/dc679ec3 The previous proof-of-concept showed that the cpp_map_name_id alternate storage backed performed better than all the others so this final PR adds only that option. You still need to enable it in menuselect under the "Alternate Channel Storage Backends" category. To select which one is used at runtime, set the "channel_storage_backend" option in asterisk.conf to one of the values described in asterisk.conf.sample. The default remains "ao2_legacy". UpgradeNote: With this release, you can now select an alternate channel storage backend based on C++ Maps. Using the new backend may increase performance and reduce the chances of deadlocks on heavily loaded systems. For more information, see http://s.asterisk.net/dc679ec3	1 month ago
Naveen Albert	bfbbe28344	sig_analog: Add Call Waiting Deluxe support. Adds support for Call Waiting Deluxe options to enhance the current call waiting feature. As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function. ASTERISK-30373 #close Resolves: #271 UserNote: Call Waiting Deluxe can now be enabled for FXS channels by enabling its corresponding option.	1 month ago
Naveen Albert	6da909283d	app_sms: Ignore false positive vectorization warning. Ignore gcc warning about writing 32 bytes into a region of size 6, since we check that we don't go out of bounds for each byte. This is due to a vectorization bug in gcc 15, stemming from gcc commit 68326d5d1a593dc0bf098c03aac25916168bc5a9. Resolves: #1088	1 month ago
George Joseph	74f50b12b3	lock.h: Add include for string.h when DEBUG_THREADS is defined. When DEBUG_THREADS is defined, lock.h uses strerror(), which is defined in the libc string.h file, to print warning messages. If the including source file doesn't include string.h then strerror() won't be found and and compile errors will be thrown. Since lock.h depends on this, string.h is now included from there if DEBUG_THREADS is defined. This way, including source files don't have to worry about it.	1 month ago
Asterisk Development Team	e487f3813d	Update for 20.14.0	6 months ago
Asterisk Development Team	9e549d533a	Update for 20.14.0-rc1	6 months ago
Naveen Albert	5ebd110830	res_pjsip_caller_id: Also parse URI parameters for ANI2. If the isup-oli was sent as a URI parameter, rather than a header parameter, it was not being parsed. Make sure we parse both if needed so the ANI2 is set regardless of which type of parameter the isup-oli is sent as. Resolves: #1220 (cherry picked from commit `5d82f69b9b`)	6 months ago
Naveen Albert	aa55410b58	app_meetme: Remove inaccurate removal version from xmldocs. app_meetme is deprecated but wasn't removed as planned in 21, so remove the inaccurate removal version. Resolves: #1224 (cherry picked from commit `9070302126`)	6 months ago
Luz Paz	ec6b2091eb	docs: Fix typos in apps/ Found via codespell (cherry picked from commit `b877d20d75`)	6 months ago
Mike Bradeen	27fb18a337	stasis/control.c: Set Hangup Cause to No Answer on Dial timeout Other Dial operations (dial, app_dial) use Q.850 cause 19 when a dial timeout occurs, but the Dial command via ARI did not set an explicit reason. This resulted in a CANCEL with Normal Call Clearing and corresponding ChannelDestroyed. This change sets the hangup cause to AST_CAUSE_NO_ANSWER to be consistent with the other operations. Fixes: #963 UserNote: A Dial timeout on POST /channels/{channelId}/dial will now result in a CANCEL and ChannelDestroyed with cause 19 / User alerting, no answer. Previously no explicit cause was set, resulting in a cause of 16 / Normal Call Clearing. (cherry picked from commit `b4edd3ab7d`)	6 months ago
Naveen Albert	0d71a166e4	chan_iax2: Minor improvements to documentation and warning messages. * Update Dial() documentation for IAX2 to include syntax for RSA public key names. * Add additional details to a couple warnings to provide more context when an undecodable frame is received. Resolves: #1206 (cherry picked from commit `7724e5e6ad`)	6 months ago
Andreas Wehrmann	3d4fd3f6fe	pbx_ael: unregister AELSub application and CLI commands on module load failure This fixes crashes/hangs I noticed with Asterisk 20.3.0 and 20.13.0 and quickly found out, that the AEL module doesn't do proper cleanup when it fails to load. This happens for example when there are syntax errors and AEL fails to compile in which case pbx_load_module() returns an error but load_module() doesn't then unregister CLI cmds and the application. (cherry picked from commit `aca78d4936`)	6 months ago
Albrecht Oster	7ce8720528	res_pjproject: Fix DTLS client check failing on some platforms Certain platforms (mainly BSD derivatives) have an additional length field in `sockaddr_in6` and `sockaddr_in`. `ast_sockaddr_from_pj_sockaddr()` does not take this field into account when copying over values from the `pj_sockaddr` into the `ast_sockaddr`. The resulting `ast_sockaddr` will have an uninitialized value for `sin6_len`/`sin_len` while the other `ast_sockaddr` (not converted from a `pj_sockaddr`) to check against in `ast_sockaddr_pj_sockaddr_cmp()` has the correct length value set. This has the effect that `ast_sockaddr_cmp()` will always indicate an address mismatch, because it does a bitwise comparison, and all DTLS packets are dropped even if addresses and ports match. `ast_sockaddr_from_pj_sockaddr()` now checks whether the length fields are available on the current platform and sets the values accordingly. Resolves: #505 (cherry picked from commit `5f9cd260ac`)	6 months ago

1 2 3 4 5 ...

34168 Commits (b758f2e880071575a514c255a327e68df89d5ccb) All Branches Search

34168 Commits (b758f2e880071575a514c255a327e68df89d5ccb)

All Branches