18316 Commits (b5dbe2e99a66c19bbe120eb24373ca38f17c4c4b)

 

All Branches   

Search

Author	SHA1	Message	Date
Jeff Peeler	b5dbe2e99a	Merged revisions 250481 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r250481 | jpeeler | 2010-03-03 13:06:06 -0600 (Wed, 03 Mar 2010) | 22 lines Merged revisions 250480 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250480 | jpeeler | 2010-03-03 13:04:11 -0600 (Wed, 03 Mar 2010) | 15 lines Make sure to clear red alarm after polarity reversal. From the issue: The automatic overnight line tests (or manual ones) used on UK (BT) lines causes a red alarm on a dahdi / TDM400P connected channel. This is because the line uses voltage tests (battery loss) and polarity reversal. The polarity reversal causes chan_dahdi to initiate v23 CallerID processing but during this the event DAHDI_EVENT_NOALARM is ignored so that the alarm is never cleared. (closes issue #14163) Reported by: jedi98 Patches: chan_dahdi-1.4-inalarm.diff uploaded by jedi98 (license 653) Tested by: mattbrown, Chainsaw, mikeeccleston ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250483 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	07ff0f5769	Merged revisions 250395 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r250395 | dvossel | 2010-03-03 12:03:19 -0600 (Wed, 03 Mar 2010) | 22 lines Merged revisions 250394 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250394 | dvossel | 2010-03-03 12:02:27 -0600 (Wed, 03 Mar 2010) | 16 lines fixes problem with duplicate TXREQ packets When Asterisk receives an IAX2 TXREQ packet, try_transfer() will call store_by_transfercallno() to link the chan_iax2_pvt struct into iax_transfercallno_pvts. If a duplicate TXREQ packet is received for the same call, the pvt struct will be linked into iax_transfercallno_pvts multiple times. This patch fixes this. Thanks rain for debugging this and providing a patch! (closes issue #16904) Reported by: rain Patches: iax2-double-txreq-fix.diff uploaded by rain (license 327) Tested by: rain, dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250397 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	1d34fc12cb	Merged revisions 250246 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r250246 | dvossel | 2010-03-02 18:18:28 -0600 (Tue, 02 Mar 2010) | 2 lines fixes signed to unsigned int comparision issue for FaxMaxDatagram value. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250260 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	a4d311350a	Merged revisions 250051 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r250051 | lmadsen | 2010-03-02 16:09:27 -0500 (Tue, 02 Mar 2010) | 8 lines Update IMAP documentation. Update the IMAP documentation to make it clear that storing voicemails in the same folder as a large number of emails could potentially cause significant slow downs when writing or retrieving voicemails. (issue #16704) Reported by: TimeHider Tested by: lmadsen, TimeHider ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250053 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	4e48910948	Merged revisions 250045 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r250045 | lmadsen | 2010-03-02 15:52:19 -0500 (Tue, 02 Mar 2010) | 15 lines Merged revisions 250043 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250043 | lmadsen | 2010-03-02 15:51:35 -0500 (Tue, 02 Mar 2010) | 7 lines Update documentation to clarify purpose of unanswered option. (closes issue #16267) Reported by: elsto Patches: cdr.conf.sample.patch.txt uploaded by lmadsen (license 10) Tested by: davidw, elsto ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250048 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	704ac49f55	Merged revisions 250037 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r250037 | lmadsen | 2010-03-02 15:36:10 -0500 (Tue, 02 Mar 2010) | 4 lines Update documentation to not imply we support overriding options. (closes issue #16855) Reported by: davidw ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@250039 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Alec L Davis	4a8e6c91bb	revert ability to exit echo app ... caused a regression, as only supported VOICE, not VIDEO etc. (issue #16880) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249949 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	8da2b4c813	Merged revisions 249893 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r249893 | dvossel | 2010-03-02 13:08:38 -0600 (Tue, 02 Mar 2010) | 11 lines fixes adaptive jitterbuffer configuration When configuring the adaptive jitterbuffer, the target_extra value not only could not be set from the configuration, but was not even being set to its proper default. This value is required in order for the adaptive jitterbuffer to work correctly. To resolve this a config option has been added to expose this value to the conf files, and a default value is provided when no config specific value is present. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249896 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Alec L Davis	424ac746d9	fixes ability to exit echo app ... when called from a ISDN channel, null frames prevent '#' exit. Now only echo back VOICE and DTMF frames (issue #16880) Reported by: alecdavis Patches: echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249843 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Sean Bright	c51f7866f6	Merged revisions 249672 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r249672 | seanbright | 2010-03-01 14:36:30 -0500 (Mon, 01 Mar 2010) | 18 lines Merged revisions 249671 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines Fix crash in app_voicemail related to message counting. We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *' causing a segfault. (closes issue #16921) Reported by: whardier Patches: 20100301_issue16921.patch uploaded by seanbright (license 71) Tested by: whardier ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249674 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	6f85fc212b	Merged revisions 249623 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r249623 | tilghman | 2010-03-01 12:36:06 -0600 (Mon, 01 Mar 2010) | 2 lines Constify a bit of app_voicemail, to make ODBC and IMAP compile once again. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jeff Peeler	9c0f709a50	Merged revisions 249538 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r249538 | jpeeler | 2010-03-01 11:11:31 -0600 (Mon, 01 Mar 2010) | 18 lines Merged revisions 249536 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r249536 | jpeeler | 2010-03-01 11:02:03 -0600 (Mon, 01 Mar 2010) | 11 lines Modify queued frames from local channels to not set the other side to up In this case, attended transfers were broken due to ast_feature_request_and_dial detecting the channel being set to up before the answer frame could be read and therefore failing to mark the channel as ready. This fix is a regression fix for 244785, which should continue to work properly as well. (closes issue #16816) Reported by: jamhed Tested by: jamhed, corruptor ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249548 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	86174ae03c	Merged revisions 249491 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r249491 | tilghman | 2010-02-28 14:50:01 -0600 (Sun, 28 Feb 2010) | 5 lines Fix unit test that Alec Davis broke. (closes issue #16927) Reported by: alecdavis ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249492 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	47f49a88fb	Merged revisions 249405 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r249405 | tilghman | 2010-02-28 01:10:22 -0600 (Sun, 28 Feb 2010) | 2 lines Properly document voicemail API documents. Also fix a crash reported via the -dev list. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249406 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Alec L Davis	23fcfd1d29	overlap receiving: automatically send CALL PROCEEDING when dialplan starts ... Following Q.931 5.2.4 When the user has determined that sufficient call information has been received the user shall stop T302 and send CALL PROCEEDING to the network. Previously timeouts were possible if the dialplan took a long time to issue any response back to the network. Verified that our local TELCO also does the same. (issue #16789) Reported by: alecdavis Patches: overlap_receiving_trunk.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Kevin P. Fleming	34b834645f	Merged revisions 249235 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r249235 | kpfleming | 2010-02-27 09:08:35 -0500 (Sat, 27 Feb 2010) | 9 lines Merged revisions 249234 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r249234 | kpfleming | 2010-02-27 09:07:59 -0500 (Sat, 27 Feb 2010) | 1 line add a reference to the now-published IAX2 RFC ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249237 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	fba6229f54	Merged revisions 249187 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r249187 | tilghman | 2010-02-26 12:41:57 -0600 (Fri, 26 Feb 2010) | 18 lines Cleanups to fix bugs in the VM count API functions. - Urgent voicemails were not attached, because the attachment code looked in the wrong folder. - Urgent voicemails were sometimes counted twice when displaying the count of new messages. - Backends were inconsistent as to which voicemails each API counted. (closes issue #15654) Reported by: tomo1657 Patches: 20100225__issue15654.diff.txt uploaded by tilghman (license 14) Tested by: tilghman (closes issue #16448) Reported by: hevad Review: https://reviewboard.asterisk.org/r/525/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249189 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	e972028569	Merged revisions 249101 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r249101 | mmichelson | 2010-02-26 11:04:58 -0600 (Fri, 26 Feb 2010) | 14 lines Merged revisions 249100 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r249100 | mmichelson | 2010-02-26 11:04:29 -0600 (Fri, 26 Feb 2010) | 8 lines For T.38 reINVITEs treat a 606 the same as a 488. (closes issue #16792) Reported by: vrban Patches: t38_606.patch uploaded by vrban (license 756) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@249103 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jeff Peeler	c0e5693e7c	Merged revisions 248952 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r248952 | jpeeler | 2010-02-25 17:09:54 -0600 (Thu, 25 Feb 2010) | 24 lines Merged revisions 248860 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r248860 | jpeeler | 2010-02-25 15:22:06 -0600 (Thu, 25 Feb 2010) | 18 lines Ensure that monitor recordings are written to the correct location (again) This is an extension to 248757. As such the dialplan test has been extended: exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b) exten => 5040, n, dial(sip/5001) exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b) exten => 5041, n, dial(sip/5001) exten => 5042, 1, monitor(wav,monitor_test3,b) exten => 5042, n, dial(sip/5001) exten => 5043, 1, monitor(wav,tmp/jeff/monitor_test3,m) exten => 5043, n, changemonitor(monitor_test4) exten => 5043, n, dial(sip/5001) exten => 5044, 1, monitor(wav,monitor_test4,m) exten => 5044, n, changemonitor(tmp/jeff/monitor_test5) ; this looks to fail by design and emits a warning exten => 5044, n, dial(sip/5001) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248954 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	a25b721665	Merged revisions 248946 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r248946 | mmichelson | 2010-02-25 16:41:48 -0600 (Thu, 25 Feb 2010) | 5 lines Fix incorrect ACL behavior when CIDR notation of "/0" is used. AST-2010-003 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248948 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	5407f8b38d	Merged revisions 248861 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r248861 | tilghman | 2010-02-25 15:22:39 -0600 (Thu, 25 Feb 2010) | 22 lines Merged revisions 248859 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r248859 | tilghman | 2010-02-25 15:21:05 -0600 (Thu, 25 Feb 2010) | 15 lines Some platforms clear /var/run at boot, which makes connecting a remote console... difficult. Previously, we only created the default /var/run/asterisk directory at install time. While we could create it in the init script, that would not work for those who start asterisk manually from the command line. So the safest thing to do is to create it as part of the Asterisk boot process. This also changes the ownership of the directory, because the pid and ctl files are created after we setuid/setgid. (closes issue #16802) Reported by: Brian Patches: 20100224__issue16802.diff.txt uploaded by tilghman (license 14) Tested by: tzafrir ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248863 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jeff Peeler	52b06f1ad8	Merged revisions 248793 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r248793 | jpeeler | 2010-02-25 12:37:56 -0600 (Thu, 25 Feb 2010) | 22 lines Merged revisions 248757 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r248757 | jpeeler | 2010-02-25 12:06:54 -0600 (Thu, 25 Feb 2010) | 15 lines Ensure that monitor recordings are written to the correct location. Recordings should be placed in the monitor directory when a non-absolute path is used. Exact dialplan used for testing: exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b) exten => 5040, n, dial(sip/5001) exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b) exten => 5041, n, dial(sip/5001) exten => 5042, 1, monitor(wav,monitor_test3,b) exten => 5042, n, dial(sip/5001) ABE-2101 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248796 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	c25b47698d	Merged revisions 248584 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r248584 | tilghman | 2010-02-24 15:17:26 -0600 (Wed, 24 Feb 2010) | 14 lines Merged revisions 248582 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r248582 | tilghman | 2010-02-24 15:02:18 -0600 (Wed, 24 Feb 2010) | 7 lines Remove color code sequences from verbose messages that go to logfiles. (closes issue #16786) Reported by: dodo Patches: logger2.patch uploaded by dodo (license 989) Tested by: tilghman ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248641 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	381faf6c54	Merged revisions 248397 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r248397 | dvossel | 2010-02-23 10:34:39 -0600 (Tue, 23 Feb 2010) | 15 lines Merged revisions 248396 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r248396 | dvossel | 2010-02-23 10:26:05 -0600 (Tue, 23 Feb 2010) | 9 lines fixes invite with replaces deadlock (closes issue #16862) Reported by: pwalker Patches: replaces_deadlock_1.4 uploaded by dvossel (license 671) Tested by: pwalker, dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248399 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	16580c731f	Merged revisions 228798 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk (closes issue #16470) Reported by: kjotte ........ r228798 | tilghman | 2009-11-09 01:37:52 -0600 (Mon, 09 Nov 2009) | 14 lines Fix various problems detected with Valgrind. * chan_console accessed pvts after deallocation. * The module loader did not check usecount on shutdown, which led to chan_iax2 reading a timer that was already unloaded. (closes issue #16062) Reported by: alexanderheinz Patches: 20091109__issue16062.diff.txt uploaded by tilghman (license 14) Tested by: tilghman ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@248009 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Richard Mudgett	09e7707ea3	Merged revisions 247914 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247914 | rmudgett | 2010-02-19 11:33:33 -0600 (Fri, 19 Feb 2010) | 62 lines Merged revisions 247910 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r247910 | rmudgett | 2010-02-19 11:18:49 -0600 (Fri, 19 Feb 2010) | 55 lines Merged revision 247904 from https://origsvn.digium.com/svn/asterisk/be/branches/C.2-... .......... r247904 | rmudgett | 2010-02-19 10:49:44 -0600 (Fri, 19 Feb 2010) | 49 lines Make chan_misdn DTMF processing consistent with other channel technologies. The processing of DTMF tones on the receiving side of an ISDN channel is inconsistent with the way it is handled in other channels, especially DAHDI analog. This causes DTMF tones sent from an ISDN phone to be doubled at the connected party. We are using the following 2 options of misdn.conf 1) astdtmf=yes 2) senddtmf=yes Option one is necessary because the asterisk DSP DTMF detection is better than mISDN's internal DSP. Not as many false positives. Option two is necessary to transmit DTMF tones end to end when mISDN channels are connected to SIP channels with out of band DTMF for example. The symptom is that DTMF tones sent by an ISDN phone are doubled on the way through asterisk when two mISDN channels are connected with a Local channel in between or if it is bridged to an analog channel. The doubling of DTMF tones is because DTMF is passed inband to asterisk by the mISDN channel and passed out of band once again after the release of the DTMF tone. Passing it inband is wrong. Neither an analog channel nor SIP channel passes DTMF inband if configured to inband DTMF. Analog and SIP channels filter out the DTMF tones because they use the voice frames returned by ast_dsp_process. But chan_misdn passes the unfiltered input voice frames instead. To overcome one aspect of the problem, the doubling of DTMF tones when two mISDN channels are directly bridged, someone made an 'optimization', where in that case the DTMF tone passed out-of-band to the peer channel is not translated to an inband tone at the transmit side. This optimization is bad because it does not work in general. For example, analog channels or mISDN channels when bridged through an intermediary local channel will generate DTMF tones from out-of-band information. Also, of course, it must not be done when there is no inband DTMF available. This patch fixes the issue. Now chan_misdn will filter the received inband DTMF signal the same as other channel types. Another change included: No need to build an extra translation path because ast_process_dsp does it if required. Patches: misdn-dtmf.patch JIRA ABE-2080 ................ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247946 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	5bc239e4d1	Blocked revisions 247915 via svnmerge ... ........ r247915 | dvossel | 2010-02-19 11:40:26 -0600 (Fri, 19 Feb 2010) | 7 lines handle_request_invite revise comment, fix coding guideline issues I'm working with this code right now trying to analyze a deadlock. This change is just to clean up a few things before I make a more complex patch. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247917 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	9cbb23ea48	Merged revisions 247841 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r247841 | tilghman | 2010-02-18 17:13:46 -0600 (Thu, 18 Feb 2010) | 7 lines Revert an errant part of a previous cleanup, to fix a memory corruption issue. (closes issue #16368) Reported by: thirionjwf Patches: res_speech.c.patch uploaded by thirionjwf (license 955) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247843 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	3df30d972d	Merged revisions 247787 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r247787 | tilghman | 2010-02-18 15:42:53 -0600 (Thu, 18 Feb 2010) | 17 lines If the peer record is from realtime, it could be set to 0, due to MySQL not representing NULL well in integer columns. NULL means the value is not specified for the column, which normally means the driver uses whatever is the default value. However, on MySQL, placing a NULL in either a float or integer column results in a retrieval of the 0 value. Hence, users get an errant error on load. This patch suppresses that error and makes the value as if it was not there. Note that this cannot be done in the realtime driver, because the lack of difference between NULL and 0 can only be intepreted correctly by the driver itself. If we did it in the realtime driver, then it would be effectively impossible to set any realtime field to 0, because it would act as if the field were unspecified and possibly take on a different value. (closes issue #16683) Reported by: wdoekes ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247790 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	c03cb6c8f8	Blocked revisions 247770 via svnmerge ... ........ r247770 | dvossel | 2010-02-18 15:23:48 -0600 (Thu, 18 Feb 2010) | 9 lines fixes confbridge crash when no timing module is loaded. (closes issue #16471) Reported by: kjotte Patches: M16471.diff uploaded by junky (license 177) Tested by: kjotte, junky ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247779 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	2f7e554609	Blocked revisions 247736 via svnmerge ... ........ r247736 | dvossel | 2010-02-18 14:58:41 -0600 (Thu, 18 Feb 2010) | 7 lines fixes Queue with C option crash (closes issue #16475) Reported by: okrief Patches: queue_crash.diff uploaded by dvossel (license 671) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247738 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Matthew Nicholson	b26524c7ce	Merged revisions 247652 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247652 | mnicholson | 2010-02-18 13:39:37 -0600 (Thu, 18 Feb 2010) | 13 lines Merged revisions 247651 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines Copy the calling party's account code to the called party if they don't already have one. (closes issue #16331) Reported by: bluefox Tested by: mnicholson ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247654 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	97243a66a3	Merged revisions 247509 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247509 | lmadsen | 2010-02-18 11:54:43 -0500 (Thu, 18 Feb 2010) | 9 lines Merged revisions 247508 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r247508 | lmadsen | 2010-02-18 11:53:44 -0500 (Thu, 18 Feb 2010) | 1 line Add additional link to best practices document per jsmith. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247511 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Leif Madsen	01d4e55a01	Merged revisions 247503 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247503 | lmadsen | 2010-02-18 11:41:04 -0500 (Thu, 18 Feb 2010) | 18 lines Merged revisions 247502 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r247502 | lmadsen | 2010-02-18 11:38:17 -0500 (Thu, 18 Feb 2010) | 10 lines Add best practices documentation. (issue #16808) Reported by: lmadsen (issue #16810) Reported by: Nick_Lewis Tested by: lmadsen Review: https://reviewboard.asterisk.org/r/507/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247505 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	cefcee5542	Merged revisions 247423 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247423 | russell | 2010-02-17 22:20:11 -0600 (Wed, 17 Feb 2010) | 17 lines Merged revisions 247422 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r247422 | russell | 2010-02-17 22:19:01 -0600 (Wed, 17 Feb 2010) | 10 lines Tweak argument handling for wget in the sounds Makefile. 1) Fix the check to see if we are using wget to not be full of fail. The configure script populates this variable with the absolute path to wget if it is found, so it didn't work. 2) Allow some extra arguments to be passed in for wget. This is just a simple change to allow our Bamboo build script to tell wget to be quiet and not fill up our logs with download status output. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247425 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	478b6ff9ca	Merged revisions 247335 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r247335 | mmichelson | 2010-02-17 15:22:40 -0600 (Wed, 17 Feb 2010) | 20 lines Fix two problems in ast_str functions found while writing a unit test. 1. The documentation for ast_str_set and ast_str_append state that the max_len parameter may be -1 in order to limit the size of the ast_str to its current allocated size. The problem was that the max_len parameter in all cases was a size_t, which is unsigned. Thus a -1 was interpreted as UINT_MAX instead of -1. Changing the max_len parameter to be ssize_t fixed this issue. 2. Once issue 1 was fixed, there was an off-by-one error in the case where we attempted to write a string larger than the current allotted size to a string when -1 was passed as the max_len parameter. When trying to write more than the allotted size, the ast_str's __AST_STR_USED was set to 1 higher than it should have been. Thanks to Tilghman for quickly spotting the offending line of code. Oh, and the unit test that I referenced in the top line of this commit will be added to reviewboard shortly. Sit tight... ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247336 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	f608016788	Merged revisions 247169 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r247169 | mmichelson | 2010-02-17 10:24:54 -0600 (Wed, 17 Feb 2010) | 9 lines Merged revisions 247168 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r247168 | mmichelson | 2010-02-17 10:24:17 -0600 (Wed, 17 Feb 2010) | 3 lines Make sure that when autofill is disabled that callers not in the front of the queue cannot place calls. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247171 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	1423716c8f	Merged revisions 247076 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r247076 | mmichelson | 2010-02-16 17:44:33 -0600 (Tue, 16 Feb 2010) | 12 lines Add va_end calls to __ast_str_helper. According to the man page for stdarg(3), "Each invocation of va_copy() must be matched by a corresponding invocation of va_end() in the same function." There were several cases in __ast_str_helper where va_copy was not matched with a corresponding call to va_end. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@247078 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	2397f1944c	Merged revisions 246985 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246985 | mmichelson | 2010-02-16 15:15:38 -0600 (Tue, 16 Feb 2010) | 3 lines Add some clarifying documentation to the ast_str_set and ast_str_append functions. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246987 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	5091019af0	Merged revisions 246980 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246980 | dvossel | 2010-02-16 14:54:48 -0600 (Tue, 16 Feb 2010) | 8 lines warning message if openssl support is missing while attempting tls connection (closes issue #16673) Reported by: michaesc Patches: tls_error_msg.diff uploaded by dvossel (license 671) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246983 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	8619d1f54f	Merged revisions 246899 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246899 | dvossel | 2010-02-16 11:07:41 -0600 (Tue, 16 Feb 2010) | 16 lines fixes sample rate conversion issue with Monitor application When using ast_seekstream with the read/write streams of a monitor, the number of samples we are seeking must be of the same rate as the stream or the jump calculation will be incorrect. This patch adds logic to correctly convert the number of samples to jump to the sample rate the read/write stream is using. For example, if the call is G722 (16khz) and the read/write stream is recording a 8khz wav, seeking 320 samples of 16khz audio is not the same as seeking 320 samples of 8khz audio when performing the ast_seekstream on the stream. ABE-2044 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246902 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	ddba171f03	Merged revisions 246710 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r246710 | tilghman | 2010-02-15 17:43:28 -0600 (Mon, 15 Feb 2010) | 12 lines Merged revisions 246709 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r246709 | tilghman | 2010-02-15 17:42:33 -0600 (Mon, 15 Feb 2010) | 5 lines Make the menuselect instructions correct by allowing 'make menuselect' to actually solve dependency problems. (Previously, it would fail out again with the same message about running 'make menuselect', which was NOT at all helpful.) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246712 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	85e5e7eb1e	Merged revisions 246546 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r246546 | dvossel | 2010-02-12 17:32:33 -0600 (Fri, 12 Feb 2010) | 21 lines Merged revisions 246545 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r246545 | dvossel | 2010-02-12 17:30:17 -0600 (Fri, 12 Feb 2010) | 16 lines lock channel during datastore removal On channel destruction the channel's datastores are removed and destroyed. Since there are public API calls to find and remove datastores on a channel, a lock should be held whenever datastores are removed and destroyed. This resolves a crash caused by a race condition in app_chanspy.c. (closes issue #16678) Reported by: tim_ringenbach Patches: datastore_destroy_race.diff uploaded by tim ringenbach (license 540) Tested by: dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246548 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jason Parker	f1a4d13647	Fix some silly formatting that made my head hurt. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246463 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	b5edce6a67	Merged revisions 246204 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246204 | tilghman | 2010-02-10 15:24:10 -0600 (Wed, 10 Feb 2010) | 2 lines Fussy compiler on another machine... ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246206 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	27619090b2	Merged revisions 246200 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246200 | tilghman | 2010-02-10 15:19:35 -0600 (Wed, 10 Feb 2010) | 2 lines Fix weird issue with unit tests on optimized build - turned out to be a signing issue. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246202 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
David Vossel	5413868305	Merged revisions 246116 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r246116 | dvossel | 2010-02-10 11:49:34 -0600 (Wed, 10 Feb 2010) | 14 lines Merged revisions 246115 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r246115 | dvossel | 2010-02-10 11:44:20 -0600 (Wed, 10 Feb 2010) | 8 lines fixes random deadlock in app_queue with use_weight during reload (closes issue #16677) Reported by: tim_ringenbach Patches: app_queue_use_weight_deadlock.diff uploaded by tim ringenbach (license 540) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246119 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Jeff Peeler	391be9df5f	Merged revisions 246070 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246070 | jpeeler | 2010-02-10 10:47:37 -0600 (Wed, 10 Feb 2010) | 22 lines Change channel state on local channels for busy,answer,ring. Previously local channels channel state never changed. This became problematic when the state of the other side of the local channel was lost, for example during a masquerade. Changing the state of the local channel allows for the scenario to be detected when the channel state is set to ringing, but the peer isn't ringing. The specific problem scenario is described in 164201. Although this was noted on one of the issues, here is the tested dialplan verified to work: exten => 9700,1,Dial(Local/*9700@default&Local/0009700@default) exten => *9700,1,Set(GLOBAL(TESTCHAN)=${CHANNEL:0:${MATH(${LEN(${CHANNEL})}-1):0:2}}1) exten => *9700,n,wait(3) ;3 works, 1 did not exten => *9700,n,Dial(SIP/5001) exten => 0009700,1,Wait(1) ;1 works, 3 did not exten => 0009700,n,ChannelRedirect(${TESTCHAN},parkedcalls,701,1) (closes issue #14992) Reported by: davidw ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246072 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	b5461c8198	Merged revisions 246022 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r246022 | tilghman | 2010-02-10 09:36:57 -0600 (Wed, 10 Feb 2010) | 2 lines Enable warnings on atypical conditions for the FILTER function (suggested by mmichelson on the -dev list). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@246024 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Tilghman Lesher	31bafc03f3	Merged revisions 245945 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r245945 | tilghman | 2010-02-10 08:06:12 -0600 (Wed, 10 Feb 2010) | 9 lines Merged revisions 245944 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r245944 | tilghman | 2010-02-10 07:37:13 -0600 (Wed, 10 Feb 2010) | 2 lines Include examples of FILTER usage in extension patterns where a "." may be a risk. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@245947 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago