12441 Commits (aa110ad3fd03074f5a893068d55aaacdefa11030)

 

All Branches   

Search

Author	SHA1	Message	Date
Luigi Rizzo	aa110ad3fd	move two per-packet flags to proper variables. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	e603d729a9	minor clarification on the usage of SIP_* flags. ... Also correct some items that were misclassified. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76348 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	0d5e33f2c3	document the way sipdebug works, and implement it through ... variables and not flags. NOTE: The old behaviour (preserved in this commit) is that if sipdebug is set in the config file, it can only be disabled by reloading the config. I am not sure if this is accidental or voluntary, but it is really unconvenient and I think it should be handled in the same way as other options i.e. consider requests from the config file or the cli (or the command line) to be fully equivalent and act on the same status variable. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76330 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	063edd1953	move the SIP_REALTIME flag to a field in the user/peer structure. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	1daf32e474	Add a note to document how the temporary 'pvt' should be initialized ... before using it. I am unclear on the details right now so i hope someone can comment more. The obvious (and lazy) approach would be to bzero() all of it (except for the string pool), but isn't that too much work ? Feedback wanted here... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76313 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	93b72115d1	Add support for using /dev/urandom to get random numbers on systems that support it. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76296 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	ed604a6df8	whoops... was setting needdestroy on the wrong dialog. ... (spotted by a diff with my own branch) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76279 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b11d587ab6	more two more flags to proper variables: ALREADYGONE and NEEDDESTROY. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76278 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	4ce3ee94c3	use explicit variables for things that don't need to ... be stored in ast_flags. First victim is 'SIP_NO_HISTORY' replaced by a 'do_history' field in the sip_pvt structure. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76231 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	10d1b9347c	Use ast_str_append() instead of ast_build_string() to construct ... the sdp messages. Overall the code is slightly more readable (because the string is fully described by a single pointer), and more efficient (because the length is stored explicitly so you don't need to do strlen()). (I have been using this code for almost a year now.) I wish we had infix string operators to do this sort of things! Nothing to backport from this change. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76229 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	94bb75cb7b	Blocked revisions 76227 via svnmerge ... ................ r76227 | russell | 2007-07-20 21:02:54 -0500 (Fri, 20 Jul 2007) | 12 lines Merged revisions 76226 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r76226 | russell | 2007-07-20 21:01:46 -0500 (Fri, 20 Jul 2007) | 4 lines Backport a fix for a memory leak that was fixed in trunk in reivision 76221 by rizzo. The memory used for the localaddr list was not freed during a configuration reload. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76228 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	06a3436375	We have two 'technology' descriptors for a SIP channel, so ... define and use a macro to determine whether we are pointing to one of them, so when one goes away (or a new one appears) we don't have to touch all the code. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76224 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ffd49bc066	One small documentation update made to accompany 10154, the upgrading of the queue ringing to allow periodic announcments ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76222 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	2286afa3af	Enhance NAT support as discussed on the -dev list, i.e.: ... + extensive documentation changes both in sip.conf.sample and in the source; + allow "externip" and "externhost" to include a port number as well; + allow "bindaddr" to have a port number (making bindport unnecessary, even though it is still present for backward compatibility); + introduce the new "stunaddr" parameter to specify an STUN server to be used from the main SIP socket; + extend the "sip show settings" output to show all the above. Internally: + change related data structures from struct in_addr to struct sockaddr_in to store the port numbers as well; + reorganize ast_sip_ouraddrfor() (should also be renamed to sip_ouraddrfor() because it is not a generic API, though it might become so if called with a socket as an additional argument, in which case it can be moved elsewhere). As mentioned in the documentation, media sessions still do not use STUN so the port numbers may still be incorrect when Asterisk is behind a NAT On passing, some of the debugging messages printing media addresses are probably using the wrong values, but this will be checked/fixed in a subsequent commit if needed. Part of the following chunk in the function that handles a "sip reload" is probably needed on previous versions as well, to avoid leaking the memory used for the "localaddr" list: @@ -17244,13 +17274,17 @@ /* Reset IP addresses */ memset(&bindaddr, 0, sizeof(bindaddr)); + memset(&stunaddr, 0, sizeof(stunaddr)); + memset(&internip, 0, sizeof(internip)); + /* Free memory for local network address mask */ + ---> ast_free_ha(localaddr); <----- memset(&localaddr, 0, sizeof(localaddr)); memset(&externip, 0, sizeof(externip)); memset(&default_prefs, 0 , sizeof(default_prefs)); git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76221 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	5c6d509591	This update was supplied in 10154; to allow announcemnts if the 'r' option (ringing) is provided. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76220 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	b928d1a0f3	Add support for default "say mode" (whether to use the "old" method or "new" method. "new" method being config file) ... Add support for autocomplete of "say load" CLI command. Patch by IgorG (closes issue #10243) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76216 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	bb1cdfebb3	Merged revisions 76211 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76211 | murf | 2007-07-20 15:36:05 -0600 (Fri, 20 Jul 2007) | 1 line This patch from 10249 is worth applying! It prevents downloading sound files if they are already downloaded. Darn Practical, if you ask me ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76213 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	a618f771e6	Blocked revisions 76178 via svnmerge ... ........ r76178 | qwell | 2007-07-20 16:03:57 -0500 (Fri, 20 Jul 2007) | 7 lines Allow getting a call from an existing "sub" channel. Cancel ringing if endpoint hangs up before answering. Fixes were backported from trunk (there was apparently a bit of confusion during merge of a previous patch). (closes issue #10241) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76179 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	70c076a9de	Blocked revisions 76176 via svnmerge ... ........ r76176 | qwell | 2007-07-20 15:54:10 -0500 (Fri, 20 Jul 2007) | 2 lines Eliminate a compiler warning with gcc 4.2 by constifying a char * ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76177 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	4a023add58	Merged revisions 76174 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76174 | qwell | 2007-07-20 15:32:55 -0500 (Fri, 20 Jul 2007) | 2 lines It's possible for sub->owner to be NULL here if you cancel the call immediately after/during sending a digit. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76175 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	51bf714319	Merged revisions 76139 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76139 | mmichelson | 2007-07-20 13:42:27 -0500 (Fri, 20 Jul 2007) | 6 lines When using users.conf for the entries in the directory, if multiple users had the same last name, only the first user listed would be available in the directory. (closes issue #10200, reported by mrskippy, patched by me) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76140 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d5b4fde291	Merged revisions 76132 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76132 | russell | 2007-07-20 13:22:24 -0500 (Fri, 20 Jul 2007) | 6 lines Use the define that specifies the default length of an artificially created DTMF digit in the ast_senddigit() function. The define is set to 100ms by default, which is the same thing that this function was using. But, using the define lets changes take effect in this case, as well as the others where it was already used. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76138 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	989b93143a	Merged revisions 76087 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r76087 | file | 2007-07-20 14:20:09 -0300 (Fri, 20 Jul 2007) | 14 lines Merged revisions 76080 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r76080 | file | 2007-07-20 14:16:48 -0300 (Fri, 20 Jul 2007) | 6 lines (closes issue #10247) Reported by: fkasumovic Patches: chan_sip.patch uploaded by fkasumovic (license #101) Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76091 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2c2af928fe	Merged revisions 76067 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76067 | file | 2007-07-20 14:10:17 -0300 (Fri, 20 Jul 2007) | 6 lines (closes issue #10246) Reported by: fkasumovic Patches: res_conver.patch uploaded by fkasumovic (license #101) Use the last occurance of . to find the extension, not the first occurance. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76070 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	66cae9269b	It is impossible for the externhost variable to not exist, it is however possible for it to be empty. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76056 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2e40a9c083	Blocked revisions 76054 via svnmerge ... ........ r76054 | file | 2007-07-20 13:49:13 -0300 (Fri, 20 Jul 2007) | 2 lines Move makeannouncement variable declaration to proper place. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76055 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	bfc782f4e9	Don't use a field size for the last argument of printf format, ... because in this case the string is left-aligned and it is not truncated anyways. Omitting the field size prevents the generation of trailing whitespace, which makes the string fit in smaller windows. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76037 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b2fec9ad16	Extend the 'network settings' section with indication on the ... localnet settings (requires the change in SVN 76034), and also give an indication on whether/why/how the remapping of addresses in SIP message is done or not. I think this is especially useful for debugging the configuration, as the address remapping depends on a combination of at least 3 parameters (localnet, externhost, externip) and successful DNS lookup. An example of the output of this section is below: Network Settings: --------------------------- SIP address remapping: Enabled using externhost Externhost: foo.dyndns.net Externip: 80.64.128.23:0 Externrefresh: 10 Internal IP: 12.34.56.78:5060 Localnet: 192.168.0.0/255.255.0.0 10.0.0.0/255.0.0.0 I leave to the community the judgement if the above info is a useful addition for 1.4. It is not a bugfix, but it is neither a new feature, only a useful diagnostic tool. Note that I would like to move there also the bindaddress/port information, in the usual addr:port format e.g. Bindaddress: 0.0.0.0:5060 so that network information is all in one place. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76035 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	925ebbb2b3	expose struct ast_ha so external code can do things such as printing it ... (e.g. chan_sip.c in a subsequent commit). Obviously exposing the internals of a data structure is far from ideal (especially in a case like this where the implementation is very inefficient and will need to be changed at some point). On the other hand, it was also unclear what additional APIs should we provide instead, and because exposing the stucture has no impact on source and binary compatibility, this seemed to me the best option at this time. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76034 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	4af3f12b29	Reduce some logging contention by switching several locks over to rwlocks ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76015 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	0e969271ae	After some study, thought, comparing, etc. I've backed out the previous universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75983 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	7756ba6619	This repairs a 'warning: ISO C90 forbids mixed declarations and code' message that cripples my dev-mode enabled build ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75982 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	7111c8e382	Blocked revisions 75980 via svnmerge ... ........ r75980 | qwell | 2007-07-19 15:36:06 -0500 (Thu, 19 Jul 2007) | 2 lines Remove some duplicate code. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75981 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	51fa94c6f5	Merged revisions 75978 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75978 | mmichelson | 2007-07-19 13:59:30 -0500 (Thu, 19 Jul 2007) | 3 lines The diff on this looks pretty big but all I did was remove a pointless if statement (always evaluates true). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75979 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	3dcce46f69	Merged revisions 75969 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75969 | mmichelson | 2007-07-19 11:26:10 -0500 (Thu, 19 Jul 2007) | 10 lines Changes in handling return values of several functions in app_queue. This all started as a fix for issue #10008 but now includes all of the following changes: 1. Simplifying the code to handle positive return values from ast API calls. 2. Removing the background_file function. 3. The fix for issue #10008 (closes issue #10008, reported and patched by dimas) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75977 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a971b4bfc4	(closes issue #10210, reported and patched by juggie) ... This merges the trunk only part of the patches from this issue. In 1.4, res_agi will issue a warning if you try to use DeadAGI on a channel that is not hung up. Now, in trunk, it just plain won't let you do it. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75930 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	7b09e738f0	Merged revisions 75928 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r75928 | russell | 2007-07-19 10:53:15 -0500 (Thu, 19 Jul 2007) | 14 lines Merged revisions 75927 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75927 | russell | 2007-07-19 10:49:42 -0500 (Thu, 19 Jul 2007) | 6 lines When processing full frames, take sequence number wraparound into account when deciding whether or not we need to request retransmissions by sending a VNAK. This code could cause VNAKs to be sent erroneously in some cases, and to not be sent in other cases when it should have been. (closes issue #10237, reported and patched by mihai) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75929 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f3b1eab2f3	Remove some debug code that was added in revision 75894, which removed some ... other debug code. :) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75911 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	20448013df	comment out some terribly expensive debugging code ... in the body of ast_apply_ha() git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75894 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	d60c5ee296	print more of the network settings (externip, externhost etc.) ... in the "sip show settings" cli output. I have put these in a separate section, probably even bindaddr and SIP port should go there. There are more things to add here e.g. localnet and so on. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75878 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	192ac53c3f	document the use of externip, externhost and other nat-related options, ... as well as the handling of the sip socket. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75875 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	fddd5b557c	ast_sip_ouraddrfor() never fails, so make it void ... and remove the code that would never be called. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75874 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	00d9a3e7a0	portability fix: use %f instead of %lf when printing double. ... The l is useless. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75873 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	16fe42c536	Allow chan_misdn to build in dev-mode ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75857 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	24935c0304	Fix trunk where I broke it earlier (for ast_strftime branch) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75841 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	204743a820	Merged revisions 75807 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75807 | qwell | 2007-07-18 17:59:18 -0500 (Wed, 18 Jul 2007) | 1 line Need to make sure we set milliseconds and timestamp - pointed out by the recent ast_ time stuff from Tilghman ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75808 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5272289355	I thought I noticed a memory leak earlier when I saw that the contents of this ... list were not destroyed when the module is unloaded. However, after reading the code related to the use of this list a lot today, I realized that it isn't necessary. So, I have added a comment to explain why it isn't necessary. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75806 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	9c99cba373	Change IAX variables to use datastores (closes issue #9315) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75805 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4681316959	Merged revisions 75759 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r75759 | russell | 2007-07-18 16:09:46 -0500 (Wed, 18 Jul 2007) | 13 lines Merged revisions 75757 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75757 | russell | 2007-07-18 16:09:13 -0500 (Wed, 18 Jul 2007) | 5 lines When traversing the queue of frames for possible retransmission after receiving a VNAK, handle sequence number wraparound so that all frames that should be retransmitted actually do get retransmitted. (issue #10227, reported and patched by mihai) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75761 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	5f39ac2b03	Merged revisions 75749 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r75749 | tilghman | 2007-07-18 15:40:18 -0500 (Wed, 18 Jul 2007) | 10 lines Merged revisions 75748 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75748 | tilghman | 2007-07-18 15:31:36 -0500 (Wed, 18 Jul 2007) | 2 lines Store prior to copy (closes issue #10193) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago