31325 Commits (a9b24a3ddf9764eacca449cf76fee713c7d043a5)

 

All Branches   

Search

Author	SHA1	Message	Date
Joshua Colp	a9b24a3ddf	Merge "app_queue: Update realtime queuemembers after wait_a_bit(), not before" into 15	8 years ago
Sean Bright	9624cbff4f	res_pjproject: Add utility functions to convert between socket structures ... Currently, to convert from a pj_sockaddr to an ast_sockaddr, the address needs to be rendered to a string and then parsed into the correct structure. This also involves a call to getaddrinfo(3). The same is true for the inverse operation. Instead, because we know the internal structure of both ast_sockaddr and pj_sockaddr, we can translate directly between the two without the need for an intermediate string. Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761	8 years ago
George Joseph	205c2d1776	Merge "http.c: Give HTTP error response when received lines are too long." into 15	8 years ago
lvl	feb9e72b04	app_queue: Update realtime queuemembers after wait_a_bit(), not before ... This ensures the most up-to-date information is used for the next call attempt. ASTERISK-28032 Change-Id: I02fc17c6ffb50bb60ea97c2d2e6023e8061815ce	8 years ago
George Joseph	fcd94c29f5	Merge "app_dial: set the comment for OPT_ARG_ANNOUNCE to really what is done" into 15	8 years ago
George Joseph	432f65fb19	Merge "res_pjsip: Fix mwi_subscribe_replaces_unsolicited type mismatch" into 15	8 years ago
George Joseph	64526af273	Merge "iostream.c: Fix ast_iostream_gets() needlessly returning failure." into 15	8 years ago
Rodrigo Ramírez Norambuena	dc307a67d8	app_dial: set the comment for OPT_ARG_ANNOUNCE to really what is done ... Change-Id: I08f88adb09f7e5813f37e70fecd787468cdb32c8	8 years ago
Chris-Savinovich	ce99f0c692	pbx_config.c: Fix reloading module if initially declined to load ... Added decline if extensions.conf file not available when loading pbx_config, and also made sure everything gets properly unregistered and/or destroyed on unload. Change-Id: Ib00665106043b1be5148ffa7a477396038915854	8 years ago
Richard Mudgett	bf530e032d	http.c: Give HTTP error response when received lines are too long. ... Added a check when we receive a HTTP request line or header line that is too long. We now return an error response to the sender because we are not able to process the request. Change-Id: I6df2705435fd7dde4d5d3bdf7acec859cfb7c12d	8 years ago
Richard Mudgett	781e78fe0e	iostream.c: Fix ast_iostream_gets() needlessly returning failure. ... Providing a buffer larger than the internal buffer of ast_iostream_gets() fails to get lines longer than the internal buffer. * Made ast_iostream_gets() fill the supplied buffer with read data until either a '\n' is found or the supplied buffer is filled just like fgets(). Change-Id: If18b3f6ee500e22f0633a68779ed09f7e0f305ed	8 years ago
Jenkins2	8144aae6ca	Merge "make config: os-release output error." into 15	8 years ago
Joshua Colp	304859d151	Merge "res_fax: Handle fax gateway being started more than once." into 15	8 years ago
Joshua Colp	59d92e96a9	Merge "res_pjsip_transport_websocket: Properly set src_name for IPv6" into 15	8 years ago
Richard Mudgett	4f30cd4b52	res_pjsip: Fix mwi_subscribe_replaces_unsolicited type mismatch ... ASTERISK-27988 Change-Id: Iccafdd0552ea8aaed647620fb14499f1bf341843	8 years ago
Rodrigo Ramírez Norambuena	0dab630533	make config: os-release output error. ... Fix not show the error "/bin/sh: /etc/os-release: No such file or directory" when the command 'make config' is run in a System without systemv. The instruction 'make config' pre execute the syntax "$(shell . /etc/os-release && echo $$ID)" to identified if system is a Slackware and Opensuse. This change prevent show the message and is send to the /dev/null Change-Id: I7f43e281a8d9405b2519fc653de82d9b8b645fdf	8 years ago
Joshua Colp	b844477683	Merge "Create --disable-binary-modules option." into 15	8 years ago
Joshua Colp	58968366fc	res_fax: Handle fax gateway being started more than once. ... The T.38 fax gateway state machine can cause the fax gateway to be started more than once on a channel depending on the responses of the remote endpoint. This would previously leak the channel name, channel unique id, and underlying fax engine state. This change instead makes it so that if the fax gateway session is already present and not reserved the fax gateway is not started again. ASTERISK-27981 Change-Id: I552d95086860cb18f2522ee40ef47b13b6da2e0e	8 years ago
Jenkins2	66f31f7c68	Merge "alembic: increase uri column size" into 15	8 years ago
Sean Bright	7ec4f0cb6a	res_pjsip_transport_websocket: Properly set src_name for IPv6 ... SIP responses over WebSockets when the client is using IPv6 have invalid Via headers according to RFC 3261. The 'received' header parameter should not be wrapped in brackets if it is an IPv6 address. When src_name is populated by the built-in PJSIP transports, the code uses pj_sockaddr_print() with 'flags' set to 0, meaning that the brackets are not rendered around IPv6 addresses. This may be related to ASTERISK~27101. See also: https://github.com/onsip/SIP.js/pull/594 ASTERISK-28020 #close Change-Id: I8ea9d289901b837512bee2ca2535e3dc14f04d77	8 years ago
Corey Farrell	588e4ecf50	Create --disable-binary-modules option. ... This new option can be passed for ./configure or ./tests/CI/buildAsterisk.sh to prevent download/install of binary modules. Normally enabling the categories MENUSELECT_CODECS or MENUSELECT_RES will result in binary modules being enabled even if the build target is incompatible with those modules. This includes CI scripts which enable categories before disabling specific modules. If more binary modules are offered in the future this will help avoid accidentally downloading them if unwanted or incompatible. Adding a binary module will only require creating a new menuselect entry similar to the existing ones, it will not be necessary to modify the CI scripts. Change-Id: I6b1bd1c75a2e48f05b8b8a45b7a7a2d00a079166	8 years ago
neutrino88	b4e1a2c8fe	res/res_rtp_asterisk: remove debug traces generated by an empty frame ... The realtime text timer pops regularly and sends text frames even if the buffer is empty. This causes a lot of unecessary debug logging. * Made red_write() test if we need to send a frame before calling ast_rtp_write() ASTERISK-28002 Reported by: Emmanuel BUU Tested by: Emmanuel BUU Change-Id: Icf81310c3b8080b615a42060afc02ab41f9523dd	8 years ago
Jenkins2	bbdaa6d31c	Merge "chan_sip: improved ip:port finding of peers for non-UDP transports." into 15	8 years ago
George Joseph	33d94bedb1	Merge "sample_configs: noload res_hep.so by default" into 15	8 years ago
Joshua Colp	33e5bfdab0	Merge "AMI: be less verbose when adding HTTP headers to AMI/HTTP messages." into 15	8 years ago
George Joseph	d7f05f88c4	Merge "chan_sip: remove unnecessary ast_channel_unlock(peer) as RAII looks after it" into 15	8 years ago
Jaco Kroon	e30c1c0f76	chan_sip: improved ip:port finding of peers for non-UDP transports. ... Also remove function peer_ipcmp_cb since it's not used (according to rmudgett). Prior to b2c4e8660a (ASTERISK_27457) insecure=port was the defacto standard. That commit also prevented insecure=port from being applied for sip/tcp or sip/tls. Into consideration there are three sets of behaviour: 1. "previous" - before the above commit. 2. "current" - post above commit, pre this one. 3. "new" - post this commit. The problem that the above commit tried to address was guests over TCP. It succeeded in doing that but broke transport!=udp with host!=dynamic. This commit attempts to restore sane behaviour with respect to transport!=udp for host!=dynamic whilst still retaining the guest users over tcp. It should be noted that when looking for a peer, two passes are made, the first pass doesn't have SIP_INSECURE_PORT set for the searched-for peer, thus looking for full matches (IP + Port), the second pass sets SIP_INSECURE_PORT, thus expecting matches on IP only where the matched peer allows for that (in the author's opinion: UDP with insecure=port, or any TCP based, non-dynamic host). In previous behaviour there was special handling for transport=tcp|tls whereby a peer would match during the first pass if the utilized transport was TCP|TLS (and the peer allowed that specific transport). This behaviour was wrong, or dubious at best. Consider two dynamic tcp peers, both registering from the same IP (NAT), in this case either peer could match for connections from an IP. It's also this behaviour that prevented SIP guests over tcp. The above referenced commit removed this behaviour, but kept applying the SIP_INSECURE_PORT only to WS|WSS|UDP. Since WS and WSS is also TCP based, the logic here should fall into the TCP category. This patch updates things such that the previously non-explicit (TCP behaviour) transport test gets performed explicitly (ie, matched peer must allow for the used transport), as well as the indeterministic source-port nature of the TCP protocol is taken into account. The new match algorithm now looks like: 1. As per previous behaviour, IP address is matched first. 2. Explicit filter with respect to transport protocol, previous behaviour was semi-implied in the test for TCP pure IP match - this now made explicit. 3. During first pass (without SIP_INSECURE_PORT), always match on port. 4. If doing UDP, match if matched against peer also has SIP_INSECURE_PORT, else don't match. 5. Match if not a dynamic host (for non-UDP protocols) 6. Don't match if this is WS|WSS, or we can't trust the Contact address (presumably due to NAT) 7. Match (we have a valid Contact thus if the IP matches we have no choice, this will likely only apply to non-NAT). To logic-test this we need a few different scenarios. Towards this end, I work with a set number of peers defined in sip.conf: [peer1] host=1.1.1.1 transport=tcp [peer2] host=1.1.1.1 transport=udp [peer3] host=1.1.1.1 port=5061 insecure=port transport=udp [peer4] host=1.1.1.2 transport=udp,tcp [peer5] host=dynamic transport=udp,tcp Test cases for UDP: 1 - incoming UDP request from 1.1.1.1: - previous: - pass 1: * peer1 or peer2 if from port 5060 (indeterminate, depends on peer ordering) * peer3 if from port 5061 * peer5 if registered from 1.1.1.1 and source port matches - pass 2: * peer3 - current: as per previous. - new: - pass 1: * peer2 if from port 5060 * peer3 if from port 5061 * peer5 if registered from 1.1.1.1 and source port matches - pass 2: * peer3 2 - incoming UDP request from 1.1.1.2: - previous: - pass 1: * peer5 if registered from 1.1.1.2 and port matches * peer4 if source port is 5060 - pass 2: * no match (guest) - current: as previous. - new as previous (with the variation that if peer5 didn't have udp as allowed transport it would not match peer5 whereas previous and current code could). 3 - incoming UDP request from anywhere else: - previous: - pass 1: * peer5 if registered from that address and source port matches. - pass 2: * peer5 if insecure=port is additionally set. * no match (guest) - current - as per previous - new - as per previous Test cases for TCP based transports: 4 - incoming TCP request from 1.1.1.1 - previous: - pass 1 (indeterministic, depends on ordering of peers in memory): * peer1; or * peer5 if peer5 registered from 1.1.1.1 (irrespective of source port); or * peer2 if the source port happens to be 5060; or * peer3 if the source port happens to be 5061. - pass 2: cannot happen since pass 1 will always find a peer. - current: - pass 1: * peer1 or peer2 if from source port 5060 * peer3 if from source port 5060 * peer5 if registered as 1.1.1.1 and source port matches - pass 2: * no match (guest) - new: - pass 1: * peer 1 if from port 5060 * peer 5 if registered and source port matches - pass 2: * peer 1 5 - incoming TCP request from 1.1.1.2 - previous (indeterminate, depends on ordering): - pass 1: * peer4; or * peer5 if peer5 registered from 1.1.1.2 - pass 2: cannot happen since pass 1 will always find a peer. - current: - pass 1: * peer4 if source port is 5060 * peer5 if peer5 registered as 1.1.1.2 and source port matches - pass 2: * no match (guest). - new: - pass 1: * peer4 if source port is 5060 * peer5 if peer5 registered as 1.1.1.2 and source port matches - pass 2: * peer4 6 - incoming TCP request from anywhere else: - previous: - pass 1: * peer5 if registered from that address - pass 2: cannot happen since pass 1 will always find a peer. - current: - pass 1: * peer5 if registered from that address and port matches. - pass 2: * no match (guest) - new: as per current. It should be noted the test cases don't make explicit mention of TLS, WS or WSS. WS and WSS previously followed UDP semantics, they will now enforce source port matching. TLS follow TCP semantics. The previous commit specifically tried to address test-case 6, but broke test-cases 4 and 5 in the process. ASTERISK-27881 #close Change-Id: I61a9804e4feba9c7224c481f7a10bf7eb7c7f2a2	8 years ago
Jaco Kroon	4dff996e88	AMI: be less verbose when adding HTTP headers to AMI/HTTP messages. ... All HTTP/AMI message headers are being sent to the verbose channel. There are multiple places this is happening. Consolidate the loop into a function. Drop the debug/verbose message. Convert to using ast_asprintf to perform the length calculation, memory allocation and snprintf all in one step. Change-Id: Ic45e673fde05bd544be95ad5cdbc69518207c1a1	8 years ago
Matthew Fredrickson	e2ca78cdea	sample_configs: noload res_hep.so by default ... Change disables loading of res_hep.so in default installation. Loading res_hep has a performance impact whether it's used or not. This disables loading of it in sample config files. Change-Id: I5ec150cf941634fabc72973e5bf1a965cb0ef9d0 (cherry picked from commit c8bacd45f1)	8 years ago
Florian Floimair	40416ccaa7	alembic: increase uri column size ... When mobile SIP clients register with Asterisk that use some sort of push notifications, the URI can get quite lengthy due to the additional push-service annotations (things like tokens, pn-type, etc.) contained in it. ASTERISK-28022 #close Change-Id: I4e5cfa3318da98deff223d613f82ffc92c9c387c	8 years ago
Sean Bright	b022c81434	app_queue: Silence GCC 8 compiler warning ... I'm only seeing an error in 14+, so I assume it is due to different compiler options: app_queue.c: In function ‘handle_queue_add_member’: app_queue.c:10234:19: error: ‘%d’ directive writing between 1 and 11 bytes into a region of size 3 [-Werror=format-overflow=] sprintf(num, "%d", state); ^~ app_queue.c:10234:18: note: directive argument in the range [-2147483648, 99] sprintf(num, "%d", state); ^~~~ Compiler: gcc version 8.0.1 20180414 (experimental) [trunk revision 259383] (Ubuntu 8-20180414-1ubuntu2) Change-Id: I18577590da46829c1ea7d8b82e41d69f105baa10	8 years ago
alecdavis	de40ba0e02	chan_sip: remove unnecessary ast_channel_unlock(peer) as RAII looks after it ... Otherwise console output (get_refer_info): mutex 'peer' freed more times than we've locked! (get_refer_info): Error releasing mutex: Operation not permitted or (get_refer_info): attempted unlock mutex 'peer' without owning it! (__ast_read): 'peer' was locked here. ...dump_backtrace (get_refer_info): Error releasing mutex: Operation not permitted (__ast_read): mutex 'chan' freed more times than we've locked! ASTERISK-28011 #close Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893	8 years ago
Joshua Colp	b2acf127eb	Merge "AMI: Remove docs for nonexistent AMI ContactStatus event headers" into 15	8 years ago
Joshua Colp	ced69e2b58	Merge "pbx_dundi.c: Misc memory management fixes when destroying peers" into 15	8 years ago
Joshua Colp	7e75e2c73e	Merge "pbx_dundi.c: Handle thread shutdown better." into 15	8 years ago
Joshua Colp	98349b6e1d	Merge "pbx_dundi: Fix debug frame decode string." into 15	8 years ago
Richard Mudgett	4253d387a7	AMI: Remove docs for nonexistent AMI ContactStatus event headers ... Change-Id: I5736965c64c44338f7330e85a24bb46818607f19	8 years ago
George Joseph	8c09e32b05	Merge "res_sorcery_realtime.c: Fix unqualified fetch warning." into 15	8 years ago
George Joseph	47ff8a7b12	Merge "pbx_dundi: Update sample config documentation." into 15	8 years ago
George Joseph	2dc3795cb3	Merge "res_pjsip_t38.c: Fix crash if already saw a final T.38 reINVITE response." into 15	8 years ago
Richard Mudgett	49c06adc9d	res_pjsip_t38.c: Fix crash if already saw a final T.38 reINVITE response. ... We were still getting crashes after the first fix. Somehow we receive a non-2xx final response before we get a 200 final response. With the failure response we had already cleaned up and destroyed some data structures. When the unexpected 200 response comes in we crash. * Add protection code to prevent processing another final T.38 reINVITE response. ASTERISK-27944 Change-Id: I8b5baba8d07fe4d63f0d7d05d3eb9a3d27d40a74	8 years ago
Richard Mudgett	3f98f49e43	res_sorcery_realtime.c: Fix unqualified fetch warning. ... The allow_unqualified_fetch option for the sorcery realtime backend blocked actually fetching all rows when the option is set to warn. * Made issue a warning and actually do the request when allow_unqualified_fetch=warn is set. Change-Id: I74456c80a03a62dce66fc3dc3cb0cf2351ac4312	8 years ago
Richard Mudgett	050d12514a	pbx_dundi.c: Misc memory management fixes when destroying peers ... * In destroy_peer(), fixed memory leaks of lookup history strings and qualify transactions when destroying peers. * In destroy_peer(), fixed leaving the registerexpire scheduled callback active when a peer is destroyed on a reload. The reload marks and sweeps peers so any peers not explicitly configured get destroyed. Peers created dynamically from the '*' peer will not exist until they re-register after the reload. These destroyed peers caused memory corruption when the registerexpire timer expired. * Made build_peer() not schedule any callbacks on the '*' peer (empty_eid). It is a special peer that is cloned to dynamically created peers so it doesn't actually get involved in any message transactions. * Made do_register_expire() remove the dundi/dpeers AstDB entry when a peer registration expires. * Fix deep_copy_peer() to not copy some things that cannot be copied to the cloned peer structure. Timers, message transactions, and lookup history are specific to a peer instance. * Made set_config() lock around processing the mappings configuration. * Reordered unload_module() to handle load_module() declining the load due to error. Change-Id: Ib846b2b60d027f3a2c2b3b563d9a83a357dce1d6	8 years ago
Richard Mudgett	f10feed7d5	pbx_dundi.c: Handle thread shutdown better. ... Change-Id: Id52f99bd6a948fe6dd82acc0a28b2447a224fe87	8 years ago
Richard Mudgett	60d61a42f8	pbx_dundi: Fix debug frame decode string. ... * Fixed a typo in the name of the REGREQ frame decode string array. * Fixed off by one range check indexing into the frame decode string array. * Removed some unneeded casts associated with the decode string array. Change-Id: I77435e81cd284bab6209d545919bf236ad7933c2	8 years ago
Richard Mudgett	66ffda284b	pbx_dundi: Update sample config documentation. ... Change-Id: I33d0ad0611c2124ca3440f0f811fa0f45e4e2849	8 years ago
Richard Mudgett	ef9ef0f856	res_rtp_asterisk.c: Fix unused variable warnings ... Compiling without SRTP support installed resulted in some unused variable warnings. These warnings also showed that the srtp variable was obtained and passed around some functions but not really used even when a system has SRTP installed. Change-Id: I6daad34be3e89b19adef6e2fbe738018975155fc	8 years ago
Joshua Colp	cfbb6a3816	Merge "CI: Disable res_odbc if REF_DEBUG is requested." into 15	8 years ago
Joshua Colp	e814fb406c	Merge "res_resolver_unbound: Fix leak of config nameserver strings." into 15	8 years ago
Joshua Colp	d983b0c470	Merge "res_pjsip: Resolve transport management leak at shutdown." into 15	8 years ago