11474 Commits (9a118809b45d25bb2ebbcc21587b72d032391cef)

 

All Branches   

Search

Author	SHA1	Message	Date
Kevin P. Fleming	9a118809b4	report the actual channel number that was unregistered, instead of assuming that the interface list consists of channels 1 through <x> with no gaps in the sequence ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80501 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a44c1d55a2	Fix some code where it was possible for a reference to a peer to not get ... released when it should. Thank you to Marta Carbone for pointing this out! git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80499 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b2c65cf51d	This is a hack to maintain old behavior of chan_iax2. This ensures that if ... the peers and users are being stored in a linked list, that they go in the list in the same order that the older code used. This is necessary to maintain the behavior of which peers and users get matched when traversing the container. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80497 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	fa1bc2a13b	Revert res_agi fix that didn't quite work until we get it right ... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80469 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e8c2f715b5	Add some more documentation on iterating ao2 containers. The documentation ... implies that is possible to miss an object or see an object twice while iterating. After looking through the code and talking with mmichelson, I have documented the exact conditions under which this can happen (which are rare and harmless in most cases). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80426 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	851b4e474c	When converting this code to use the list macros, I changed it so objects are ... added to the head of a bucket instead of the tail. However, while looking over code with mmichelson, we noticed that the algorithm used in ao2_iterator_next requires that items are added to the tail. This wouldn't have caused any huge problem, but it wasn't correct. It meant that if an object was added to a container while you were iterating it, and it was added to the same bucket that the current element is in, then the new object would be returned by ao2_iterator_next, and any other objects in the bucket would be bypassed in the traversal. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80424 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c5cf1e50ac	Don't crash when using realtime in chan_sip without an insecure setting in the database. ... (closes issue #10348, reported by link55, fixed by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80390 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	566371bd50	Merge changes from team/russell/iax_refcount. ... This set of changes fixes problems with the handling of iax2_user and iax2_peer objects. It was very possible for a thread to still hold a reference to one of these objects while a reload operation tries to delete them. The fix here is to ensure that all references to these objects are tracked so that they can't go away while still in use. To accomplish this, I used the astobj2 reference counted object model. This code has been in one of Luigi Rizzo's branches for a long time and was primarily developed by one of his students, Marta Carbone. I wanted to go ahead and bring this in to 1.4 because there are other problems similar to the ones fixed by these changes, so we might as well go ahead and use the new astobj if we're going to go through all of the work necessary to fix the problems. As a nice side benefit of these changes, peer and user handling got more efficient. Using astobj2 lets us not hold the container lock for peers or users nearly as long while iterating. Also, by changing a define at the top of chan_iax2.c, the objects will be distributed in a hash table, drastically increasing lookup speed in these containers, which will have a very big impact on systems that have a large number of users or peers. The use of the hash table will be made the default in trunk. It is not the default in 1.4 because it changes the behavior slightly. Previously, since peers and users were stored in memory in the same order they were specified in the configuration file, you could influence peer and user matching order based on the order they are specified in the configuration. The hash table does not guarantee any order in the container, so this behavior will be going away. It just means that you have to be a little more careful ensuring that peers and users are matched explicitly and not forcing chan_iax2 to have to guess which user is the right one based on secret, host, and access list settings, instead of simply using the username. If you have any questions, feel free to ask on the asterisk-dev list. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80362 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	99adc3f020	Juggie in #asterisk-dev was reporting problems where fgets would return ... without reading the whole line when using fastagi. When this happens, errno was set to EINTR or EAGAIN. This patch accounts for the possibility and lets fgets continue in that case. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80360 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	9b23ab95aa	Fix a few build issues in Solaris (and likely others). ... Use GREP and ID variables from autoconf. Reported to me in #asterisk-dev I forgot who reported this - sorry. :( git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80330 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	a7583cd240	Change a syntax that the GNU make in Solaris dislikes. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80304 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	a2787080d9	Fix a bashism (we explicitly request /bin/sh). ... Remove some oddly placed quotes I found in passing. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80302 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	55bedc87b6	Honor the contents of the COPTS variable as custom target CFLAGS. Apparently ... this is what openwrt does. (reported by Brian Capouch on the asterisk-dev list, patch by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80257 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	d13b192018	(closes issue #10526) ... Reported by: sinistermidget Revert commit from issue #10355 and return timestamp skew to 640. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80255 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3c2eae9ab4	Don't record SIP dialog history if it's not turned on. Also, put an upper ... limit on how many history entires will be stored for each SIP dialog. It is currently set to 50, but can be increased if deemed necessary. (closes issue #10421, closes issue #10418, patches suggested by jmoldenhauer, patches updated by me) (Security implications documented in AST-2007-020) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80183 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	b84f9590a0	ugh. removing the diffs from ulaw.h and alaw.h for now; accidentally added them in 80166 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80167 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	4b5a9ae533	This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80166 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	db1f93048f	Don't try to dereference the owner channel when it may not exist ... (issue #10507, maxper) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80132 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	8eda8a5fa6	(issue #10510) ... Reported by: casper Patches: cdr.conf.diff uploaded by casper (license 55) Fix a few errors in sample cdr config file. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80130 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	108326e3d1	Fix the build of app_queue ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80088 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6268d2d7ec	After a discussion on #asterisk-dev, it was decided that this should be in 1.4 as well. ... (issue #10424, reported and patched by irroot) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	d66e174242	Found a pointless ternary if. member->dynamic was set to 1 and has no opportunity to change ... between then and this line, so "dynamic" will ALWAYS be output. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80049 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	46bc382bcc	(issue #10499) ... Reported by: casper Patches: extensions.conf.sample.diff uploaded by casper (license 55) Update CLI examples in extensions.conf.sample to reflect command changes. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80047 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7c7ec6a1da	Ukrainian language voicemail support. ... (closes issue #10458, reported and patched by Oleh) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80044 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	e6768adf1b	Missing curly braces. Oops. (Reported by snuffy via IRC) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79998 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	d0469e3c42	Don't allocate vmu for messagecount when we could just use the stack instead (closes issue #10490) ... Also, remove a useless (and leaky) SQLAllocHandle (closes issue #10480) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79947 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	467ceebc82	Avoid a crash in the handling of DTMF based Caller ID. It is valid for ... ast_read to return NULL in the case that the channel has been hung up. (crash reported by anonymouz666 on IRC in #asterisk-dev) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79912 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	403ee9194c	Patch allows for more seamless transition from file storage voicemail to ODBC storage voicemail. ... If a retrieval of a greeting from the database fails, but the file is found on the file system, then we go ahead an insert the greeting into the database. The result of this is that people who switch from file storage to ODBC storage do not need to rerecord their voicemail greetings. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79906 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	f1cb3f70b7	Don't send a semicolon over the wire in sip notify messages. ... Caused by fix for issue 9938. I basically took the code that existed before 9938 was fixed, and copied it into a new function - ast_unescape_semicolon There should be very few places this will be needed (pbx_config does NOT need this (see issue 9938 for details)) Issue 10430, patch by me, with help/ideas from murf (thanks murf). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79904 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	e9ab13fa81	Re-add the setting of callerid name and number. ... Issue 10485, reported by and fix explained by paradise. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79902 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9be377d89f	Fix some crashes in chan_sip. This patch changes various places that add items ... to the scheduler to ensure that they don't overwrite the ID of a previously scheduled item. If there is one, it should be removed. (closes issue #10391, closes issue #10256, probably others, patch by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79857 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Christian Richter	c71c5098b7	sometimes we don't need to signal dtmf tones to asterisk, we just want them to go through as inband. Otherwise they might be generated by the other channel partner and then there is a double tone. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79833 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e24788d06f	Fix a little race condition that could cause a crash if two channels had MOH ... stopped at the same time that were using a class that had been marked for deletion when its use count hits zero. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79792 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3301d70848	This patch fixes a bug where reloading the module with "module reload" did not ... delete classes from memory that were no longer in the config. This patch fixes that problem as well as another one. Previously, if you reloaded MOH using the "moh reload" CLI command, which behaved differently than "module reload ...", MOH had to be stopped on every channel and started again immediately. However, there was no way to tell what class was being used, so they would all fall back to the default class. (closes issue #10139) Reported by: blitzrage Patches: asterisk-10139-advanced.diff.txt uploaded by jamesgolovich (license 176) Tested by: jamesgolovich git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79778 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	0dbd8e04af	Fix more deadlocks in chan_iax2 that were introduced by making frame handling ... and scheduling multi-threaded. Unfortunately, we have to do some expensive deadlock avoidance when queueing frames on to the ast_channel owner of the IAX2 pvt struct. This was already handled for regular frames, but ast_queue_hangup and ast_queue_control were still used directly. Making these changes introduced even more places where the IAX2 pvt struct can disappear in the context of a function holding its lock due to calling a function that has to unlock/lock it to avoid deadlocks. I went through and fixed all of these places to account for this possibility. (issue #10362, patch by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79756 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6ec280adfc	Fixes a problem where agents would get stuck busy due to their wrapuptime being longer than the queue's wrapuptime and ... ringinuse=no for the queue. (closes issue #10215, reported by Doug, repaired by me) Special thanks to fkasumovic for pointing out the source of the problem and to bweschke for helping to come up with a solution! git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79748 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ec2f24b901	base_encode is not trying to open a log file, so we should not call it a log file in the warning. ... (related to issue #10452, reported by bcnit) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79690 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	c6365f5138	A fix for two critical problems detected while working with Daniel ... McKeehan in issue #10184. Upon priority change, the resource list is not NULL terminated when moving an item to the end of the list. This makes Asterisk endlessy loop whenever it needs to read the list. Jids with different resource and priority values, like in Gmail's and GoogleTalk's jabber clients put that problem in evidence. Upon reception of a 'from' attribute with an empty resource string, Asterisk crashes when trying to access the found->cap pointer if the resource list for the given buddy is not empty. This situation is perfectly valid and must be handled. The Gizmoproject's jabber client put that problem in evidence. Also added a few comments in the code as well as a handle for the capabilities from Gmail's jabber client, which are stored in a caps:c tag rather than the usual c tag. Closes issue #10184. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79665 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Christian Richter	6d6a045cc0	0x80 + protocol is wrong for USERUSER when we want to send IA5 Chars. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79642 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	6dbbfcdc25	(closes issue #10440) ... Reported by: irroot (closes issue #10454) Reported by: flo_turc Increase maximum timestamp skew to 120. 20 was apparently far too low. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79553 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	176f95680b	Fixed an error in the Russian language voicemail intro. ... (issue #10458, reported and patched by Oleh) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79527 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	e856a6fb34	(closes issue #10456) ... Reported by: irroot Patches: sip_timeout.patch uploaded by irroot (license 52) Change hardcoded timer value to defined value. I'm doing this in 1.4 as well so if it needs to be changed in the future this place would not have been forgotten. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79523 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e3ecc74dc1	Fix another spot where an iax2_peer would be leaked if realtime was in use. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79470 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a713275c1b	Fix some memory leaks throughout chan_iax2 related to the use of realtime. ... I found these while working on iax2_peer object reference tracking. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79436 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	784d5f32c0	(closes issue #10415) ... Reported by: atis Revert fix for #10327 as it causes more issues then it solves. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79397 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	7d83255ef8	memset really, really needs to be used here. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	924c88d3d0	Instead of accepting a single DTMF character accept a full string. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79334 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f2de04d1d1	Don't call find_peer in registry_authrequest with the pvt lock held to avoid a ... deadlock. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79301 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	68faf63811	Release the pvt lock before calling find_peer in register_verify to avoid a ... deadlock. Also, remove some unnecessary locking in auth_fail that was only done recursively. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79276 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c06aba4c8a	Don't call find_peer within update_registry with a pvt lock held. This can ... cause a deadlock as the code will eventually call find_callno. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79274 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago