18015 Commits (8dd2ce2ace2fe8dadc7c7eaa306ae9b93accdf0e)

 

All Branches   

Search

Author	SHA1	Message	Date
David Vossel	8dd2ce2ace	Merged revisions 225650 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r225650 | dvossel | 2009-10-23 09:41:50 -0500 (Fri, 23 Oct 2009) | 3 lines Fixes an iterator memory leak and uninitialized memory ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225652 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	e5f4dceb6a	Merged revisions 225582 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225582 | kpfleming | 2009-10-23 09:02:42 -0500 (Fri, 23 Oct 2009) | 17 lines Merged revisions 225581 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225581 | kpfleming | 2009-10-23 09:00:01 -0500 (Fri, 23 Oct 2009) | 10 lines Don't force menuselect.makeopts to be rebuilt on every build. For some reason the menuselect.makeopts file was listed as PHONY in the Makefile, resulting in 'make' needing to rebuild it for every build. This then resulted in the embedded module rules being rebuilt on every build, which can be slow and is unnecessary. This patch fixes the problem by properly allowing 'make' to know when the menuselect.makeopts file needs to be rebuilt (defining the proper dependencies). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225584 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	4672e2805b	Merged revisions 225445 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r225445 | dvossel | 2009-10-22 14:55:51 -0500 (Thu, 22 Oct 2009) | 50 lines SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes. What this patch fixes 1.Moves sip TCP/TLS connection setup into the TCP helper thread: Connection setup takes awhile and before this it was being done while holding the monitor lock. 2.Moves TCP/TLS writing to the TCP helper thread: Through the use of a packet queue and an alert pipe, the TCP helper thread can now be woken up to write data as well as read data. 3.Locking error: sip_xmit returned an XMIT_ERROR without giving up the tcptls_session lock. This lock has been completely removed from sip_xmit and placed in the new sip_tcptls_write() function. 4.Memory leak: When creating a tcptls_client the tls_cfg was alloced but never freed unless the tcptls_session failed to start. Now the session_args for a sip client are an ao2 object which frees the tls_cfg on destruction. 5.Pointer to stack variable: During sip_prepare_socket the creation of a client's ast_tcptls_session_args was done on the stack and stored as a pointer in the newly created tcptls_session. Depending on the events that followed, there was a slight possibility that pointer could have been accessed after the stack returned. Given the new changes, it is always accessed after the stack returns which is why I found it. Notable code changes 1.I broke tcptls.c's ast_tcptls_client_start() function into two functions. One for creating and allocating the new tcptls_session, and a separate one for starting and handling the new connection. This allowed me to create the tcptls_session, launch the helper thread, and then establish the connection within the helper thread. 2.Writes to a tcptls_session are now done within the helper thread. This is done by using an alert pipe to wake up the thread if new data needs to be sent. The thread's sip_threadinfo object contains the alert pipe as well as the packet queue. 3.Since the threadinfo object contains the alert pipe, it must now be accessed outside of the helper thread for every write (queuing of a packet). For easy lookup, I moved the threadinfo objects from a linked list to an ao2_container. (closes issue #13136) Reported by: pabelanger Tested by: dvossel, whys (closes issue #15894) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/380/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225490 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Leif Madsen	09cd0f9b0d	Merged revisions 225485 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225485 | lmadsen | 2009-10-22 16:52:30 -0500 (Thu, 22 Oct 2009) | 19 lines Merged revisions 225484 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225484 | lmadsen | 2009-10-22 16:51:52 -0500 (Thu, 22 Oct 2009) | 11 lines Clean valgrind output by suppressing false errors. Update valgrind.txt documentation and add valgrind.supp file in order to allow those who are creating valgrind output to have less false errors in the logfile. (closes issue #16007) Reported by: atis Patches: valgrind.txt.diff uploaded by atis (license 242) asterisk2.supp uploaded by atis (license 242) Tested by: atis, amorsen ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225487 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	ae34805b65	Merged revisions 225360 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225360 | tilghman | 2009-10-22 12:11:23 -0500 (Thu, 22 Oct 2009) | 11 lines Merged revisions 225105 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225105 | tilghman | 2009-10-21 11:02:12 -0500 (Wed, 21 Oct 2009) | 4 lines Fix documentation for ast_softhangup() and correct the misuse thereof. (closes issue #16103) Reported by: majorbloodnok ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225362 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	c64aca3b91	Merged revisions 225307 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225307 | dvossel | 2009-10-21 16:58:46 -0500 (Wed, 21 Oct 2009) | 20 lines Merged revisions 225243 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225243 | dvossel | 2009-10-21 15:58:08 -0500 (Wed, 21 Oct 2009) | 13 lines IAX2: VNAK loop caused by signaling frames with no destination call number It is possible for the PBX thread to queue up signaling frames before a destination call number is received. This can result in signaling frames being sent out with no destination call number. Since recent versions of Asterisk require accurate destination callnumbers for all Full Frames, this can cause a VNAK loop to occur. To resolve this no signaling frames are sent until a destination callnumber is received, and destination call numbers are now only required for iax_pvt matching when the frame is an ACK. Review: https://reviewboard.asterisk.org/r/413/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225309 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	219e2238a9	Merged revisions 225033 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225033 | dvossel | 2009-10-21 09:39:10 -0500 (Wed, 21 Oct 2009) | 27 lines Merged revisions 225032 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225032 | dvossel | 2009-10-21 09:37:04 -0500 (Wed, 21 Oct 2009) | 20 lines IAX/SIP shrinkcallerid option The shrinking of caller id removes '(', ' ', ')', non-trailing '.', and '-' from the string. This means values such as 555.5555 and test-test result in 555555 and testtest. There are instances, such as Skype integration, where a specific value is passed via caller id that must be preserved unmodified. This patch makes the shrinking of caller id optional in chan_sip and chan_iax in order to support such cases. By default this option is on to preserve previous expected behavior. (closes issue #15940) Reported by: dimas Patches: v2-15940.patch uploaded by dimas (license 88) 15940_shrinkcallerid_trunk.c uploaded by dvossel (license 671) Tested by: dvossel Review: https://reviewboard.asterisk.org/r/408/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@225062 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	a3784591a1	Merged revisions 224932 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224932 | russell | 2009-10-20 22:09:04 -0500 (Tue, 20 Oct 2009) | 12 lines Merged revisions 224931 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224931 | russell | 2009-10-20 21:59:54 -0500 (Tue, 20 Oct 2009) | 5 lines Isolate frames returned from a DSP instance or codec translator. The reasoning for these changes are the same as what I wrote in the commit message for rev 222878. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224935 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	e88e6c5f6b	Merged revisions 224856 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224856 | tilghman | 2009-10-20 17:09:07 -0500 (Tue, 20 Oct 2009) | 12 lines Merged revisions 224855 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224855 | tilghman | 2009-10-20 17:07:11 -0500 (Tue, 20 Oct 2009) | 5 lines Pay attention to the return value of the manipulate function. While this looks like an optimization, it prevents a crash from occurring when used with certain audiohook callbacks (diagnosed with SVN trunk, backported to 1.4 to keep the source consistent across versions). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224858 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	e3fcd88f87	Merged revisions 224774 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224774 | file | 2009-10-20 14:47:34 -0300 (Tue, 20 Oct 2009) | 12 lines Merged revisions 224773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224773 | file | 2009-10-20 14:46:37 -0300 (Tue, 20 Oct 2009) | 5 lines Add support for relaying early media in the features attended transfer option. (closes issue #14828) Reported by: licedey ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224776 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	7d732d4b3a	Merged revisions 224671 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224671 | kpfleming | 2009-10-19 18:47:39 -0500 (Mon, 19 Oct 2009) | 14 lines Merged revisions 224670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224670 | kpfleming | 2009-10-19 18:44:07 -0500 (Mon, 19 Oct 2009) | 7 lines Correct timestamp calculations when RTP sample rates over 8kHz are used. While testing some endpoints that support 16kHz and 32kHz sample rates, some log messages were generated due to calc_rxstamp() computing timestamps in a way that produced odd results, so this patch sanitizes the result of the computations. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224673 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	eb20b22f65	Merged revisions 224567 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224567 | file | 2009-10-19 16:49:09 -0300 (Mon, 19 Oct 2009) | 12 lines Merged revisions 224565 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224565 | file | 2009-10-19 16:47:50 -0300 (Mon, 19 Oct 2009) | 5 lines Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it. (closes issue #14763) Reported by: cupotka ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224570 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	53ab988b4d	git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224450 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	9d34d37a4b	fix typo, sorry ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224336 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	7593e10437	Merged revisions 224331 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224331 | jpeeler | 2009-10-16 20:36:08 -0500 (Fri, 16 Oct 2009) | 20 lines Merged revisions 224330 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224330 | jpeeler | 2009-10-16 20:32:47 -0500 (Fri, 16 Oct 2009) | 13 lines Fix stale caller id data from being reported in AMI NewChannel event The problem here is that chan_dahdi is designed in such a way to set certain values in the dahdi_pvt only once. One of those such values is the configured caller id data in chan_dahdi.conf. For PRI, the configured caller id data could be overwritten during a call. Instead of saving the data and restoring, it was decided that for all non-analog channels it was simply best to not set the configured caller id in the first place and also clear it at the end of the call. (closes issue #15883) Reported by: jsmith ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224333 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Richard Mudgett	6c68619844	Merged revisions 224261 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224261 | rmudgett | 2009-10-16 15:40:57 -0500 (Fri, 16 Oct 2009) | 25 lines Merged revisions 224260 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224260 | rmudgett | 2009-10-16 15:25:23 -0500 (Fri, 16 Oct 2009) | 18 lines Never released PRI channels when using Busy() or Congestion() dialplan apps. When the Busy() or Congestion() application is used towards ISDN (an ISDN progress is sent), the responding ISDN Disconnect or Release may contain the ISDN cause user busy or one of the congestion causes. In chan_dahdi.c these causes will only set the needbusy or needcongestion flags and not activate the softhangup procedure. Unfortunately only the latter can interrupt the endless wait loop of Busy()/Congestion(). Result: PRI channels staying in state busy for the rest of asterisk life or until the other end times out and forces the call to clear. (in issue 0014292) Reported by: tomaso Patches: disc_rel_userbusy.patch uploaded by tomaso (license 564) (This patch is unrelated to the issue.) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224263 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	6d9eb7a727	Merged revisions 224178 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r224178 | jpeeler | 2009-10-15 10:57:14 -0500 (Thu, 15 Oct 2009) | 11 lines Readd removed ability to allow listening to one side of the call in app_chanspy (Option o) (closes issue #15675) Reported by: john8675309 Patches: issue15675patchtrunk.txt uploaded by dbrooks (license 790) Tested by: jgutierrez on users list: http://lists.digium.com/pipermail/asterisk-users/2009-October/239155.html ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@224180 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	445d7f7e50	Merged revisions 223832 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223832 | jpeeler | 2009-10-12 18:48:09 -0500 (Mon, 12 Oct 2009) | 15 lines Merged revisions 223804 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223804 | jpeeler | 2009-10-12 18:12:50 -0500 (Mon, 12 Oct 2009) | 8 lines Ensure ringing continues for branched calls after progress is received While waiting for an answer, don't send progress for branched calls for which ringing was sent. (closes issue #15028) Reported by: fnordian ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223834 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	2c5df9ffd4	Merged revisions 223756 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223756 | dvossel | 2009-10-12 15:58:27 -0500 (Mon, 12 Oct 2009) | 5 lines Clarifies trunkmaxsize, trunkfreq, and trunkmtu iax2 options SWP-151 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223758 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	1b54dbccc7	Merged revisions 223652 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223652 | kpfleming | 2009-10-12 09:25:29 -0500 (Mon, 12 Oct 2009) | 13 lines Remove automatic switching from T.38 to voice mode in chan_sip. chan_sip has some code to automatically switch from T.38 mode to voice mode when a voice frame is written to the channel while it is in T.38 mode; this was intended to handle the situation when a FAX transmission has ended and the channel is not yet hung up, but is causing problems at the beginning of FAX sessions as well when there are still voice frames 'in flight' at the time the T.38 negotiation completes. This patch removes the automatic switchover, and changes app_fax to explicitly switch off T.38 mode when the FAX transmission process ends. (closes issue #16025) Reported by: jamicque ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223654 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	591d496f0e	Merged revisions 223487 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223487 | russell | 2009-10-11 12:25:42 -0500 (Sun, 11 Oct 2009) | 17 lines Merged revisions 223485-223486 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223485 | russell | 2009-10-11 12:22:52 -0500 (Sun, 11 Oct 2009) | 6 lines Don't use data outside of its scope. The purpose of this code was to have a hangup frame put on the list of deferred frames. However, the code that read the hangup frame was outside of the scope of where the hangup frame was declared. ........ r223486 | russell | 2009-10-11 12:25:06 -0500 (Sun, 11 Oct 2009) | 2 lines Remove some unnecessary code. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223489 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	9f1bf0f9bd	Fix interpretation of PRIREDIRECTIONREASON set by chan_sip. ... This commit is the simplest way to solve a problem that has already been solved in trunk with the "COLP/CONP and Redirecting party information into Asterisk" commit. In trunk the redirection reason is translated into a generic redirect reason. I would have had to do the same fix except chan_sip never reads PRIREDIRECTREASON. So both chan_dahdi and chan_h323 have been modified to interpret the one different redirect reason of "no-answer" properly and set the ISDN reason code 2 of "no reply". (closes issue #15033) Reported by: steinwej git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223405 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	435f1593ae	Merged revisions 223330 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223330 | kpfleming | 2009-10-09 15:58:44 -0500 (Fri, 09 Oct 2009) | 10 lines Initiate T.38 switchover when acting as called party, regardless of FAX direction. SendFAX() and ReceiveFAX() can be given options to indicate whether they should act as the calling or called party; this mode should be used to decide whether to initiate a switchover to T.38, not the direction that the FAX transfer will take place. (closes issue #16039) Reported by: jamicque ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223332 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	698cc31adc	Merged revisions 223273 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223273 | mnicholson | 2009-10-09 13:34:08 -0500 (Fri, 09 Oct 2009) | 14 lines Merged revisions 223225 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223225 | mnicholson | 2009-10-09 13:20:11 -0500 (Fri, 09 Oct 2009) | 8 lines Signal timeouts by returning AST_CONTROL_RINGING when originating calls. (closes issue #15104) Reported by: nblasgen Patches: manager-timeout1.diff uploaded by mnicholson (license 96) Tested by: nblasgen, mnicholson ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223277 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	0fd3ac4508	Merged revisions 223215 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223215 | mmichelson | 2009-10-09 13:17:34 -0500 (Fri, 09 Oct 2009) | 9 lines Recorded merge of revisions 223213 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223213 | mmichelson | 2009-10-09 13:17:12 -0500 (Fri, 09 Oct 2009) | 3 lines Fix potential memory leak in app_dial.c ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223241 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	b0e38e816d	Merged revisions 223206 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223206 | dvossel | 2009-10-09 12:53:37 -0500 (Fri, 09 Oct 2009) | 16 lines Merged revisions 223205 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223205 | dvossel | 2009-10-09 12:52:35 -0500 (Fri, 09 Oct 2009) | 10 lines fixes sip registration using authuser in user.conf (closes issue #14954) Reported by: tornblad Tested by: mmichelson, tornblad, dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223209 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	7c091310e6	Merged revisions 223136 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223136 | mnicholson | 2009-10-09 12:14:38 -0500 (Fri, 09 Oct 2009) | 8 lines Don't close the sqlite database when reloading. Only close the database when unloading. (closes issue #15953) Reported by: frawd Patches: sqlite3_rev220097.diff uploaded by frawd (license 610) Tested by: frawd ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223171 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	003220b57f	Merged revisions 223132 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223132 | dvossel | 2009-10-09 11:54:02 -0500 (Fri, 09 Oct 2009) | 9 lines 'auth=' did not parse md5 secret correctly (closes issue #15949) Reported by: ebroad Patches: authparsefix.patch uploaded by ebroad (license 878) 15949_trunk.diff uploaded by dvossel (license 671) Tested by: ebroad ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223134 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	5ed75bc87c	Merged revisions 223088 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r223088 | dvossel | 2009-10-09 10:49:30 -0500 (Fri, 09 Oct 2009) | 14 lines p->peerauth is always empty in transmit_register() When using callbackextension or specifing the peer name in a registration string, the peer's specific auth settings set by the "auth=" strings within the peer definition are not used by the registration. Thanks to ebroad for reporting the issue and providing the patch. (closes issue #15955) Reported by: ebroad Patches: regauthfix.patch uploaded by ebroad (license 878) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@223090 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	82a615905c	Merged revisions 222880 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222880 | russell | 2009-10-08 14:52:03 -0500 (Thu, 08 Oct 2009) | 51 lines Merged revisions 222878 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222878 | russell | 2009-10-08 14:45:47 -0500 (Thu, 08 Oct 2009) | 44 lines Make filestream frame handling safer by isolating frames before returning them. This patch is related to a number of issues on the bug tracker that show crashes related to freeing frames that came from a filestream. A number of fixes have been made over time while trying to figure out these problems, but there re still people seeing the crash. (Note that some of these bug reports include information about other problems. I am specifically addressing the filestream frame crash here.) I'm still not clear on what the exact problem is. However, what is _very_ clear is that we have seen quite a few problems over time related to unexpected behavior when we try to use embedded frames as an optimization. In some cases, this optimization doesn't really provide much due to improvements made in other areas. In this case, the patch modifies filestream handling such that the embedded frame will not be returned. ast_frisolate() is used to ensure that we end up with a completely mallocd frame. In reality, though, we will not actually have to malloc every time. For filestreams, the frame will almost always be allocated and freed in the same thread. That means that the thread local frame cache will be used. So, going this route doesn't hurt. With this patch in place, some people have reported success in not seeing the crash anymore. (SWP-150) (AST-208) (ABE-1834) (issue #15609) Reported by: aragon Patches: filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2) Tested by: aragon, russell (closes issue #15817) Reported by: zerohalo Tested by: zerohalo (closes issue #15845) Reported by: marhbere Review: https://reviewboard.asterisk.org/r/386/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222882 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	8225729b80	Merged revisions 222873 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222873 | dvossel | 2009-10-08 14:35:30 -0500 (Thu, 08 Oct 2009) | 6 lines fixes an ast_netsock_list memory leak. ABE-1998 Review: https://reviewboard.asterisk.org/r/395/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222875 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Richard Mudgett	9a349cd41f	Merged revisions 222799 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222799 | rmudgett | 2009-10-08 11:44:33 -0500 (Thu, 08 Oct 2009) | 19 lines Merged revisions 222797 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222797 | rmudgett | 2009-10-08 11:33:06 -0500 (Thu, 08 Oct 2009) | 12 lines Fix memory leak if chan_misdn config parameter is repeated. Memory leak when the same config option is set more than once in an misdn.conf section. Why must this be considered? Templates! Defining a template with default port options and later adding to or overriding some of them. Patches: memleak-misdn.patch JIRA ABE-1998 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222801 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Richard Mudgett	3be2fa60b3	Merged revisions 222692 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222692 | rmudgett | 2009-10-07 16:56:36 -0500 (Wed, 07 Oct 2009) | 21 lines Merged revisions 222691 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222691 | rmudgett | 2009-10-07 16:51:24 -0500 (Wed, 07 Oct 2009) | 14 lines chan_misdn.c:process_ast_dsp() memory leak misdn.conf: astdtmf must be set to "yes". With "no", buffer loss does not occur. The translated frame "f2" when passing through ast_dsp_process() is not freed whenever it is not used further in process_ast_dsp(). Then in the end it is never ever freed. Patches: translate.patch JIRA ABE-1993 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222694 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	939c90b1bd	Merged revisions 222543 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222543 | dvossel | 2009-10-07 12:44:52 -0500 (Wed, 07 Oct 2009) | 14 lines Merged revisions 222542 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222542 | dvossel | 2009-10-07 12:41:21 -0500 (Wed, 07 Oct 2009) | 8 lines crash on transfer handle_invite_replaces() attempts to uplock a pvt's owner channel without first verifing that it exists. (issue #16027) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222545 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	2371977ff9	Merged revisions 222463 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222463 | jpeeler | 2009-10-06 18:56:01 -0500 (Tue, 06 Oct 2009) | 14 lines Merged revisions 222462 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222462 | jpeeler | 2009-10-06 18:51:19 -0500 (Tue, 06 Oct 2009) | 8 lines Add missing unlock(s) in dahdi_read (two cases in trunk) (closes issue #15683) Reported by: alecdavis ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222465 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	09051408df	Fix potential crash when entire span request is received. ... The variable index used in this scenario for accessing the dahdi_pvts was wrong and was most likely copied from the several other places it is used correctly. (closes issue #15998) Reported by: tsearle Patches: dahdi_reset_crash.patch uploaded by tsearle (license 373) Modified: branches/1.4/channels/chan_dahdi.c git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222396 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	9ec8e8e960	Merged revisions 222351 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222351 | jpeeler | 2009-10-06 15:35:19 -0500 (Tue, 06 Oct 2009) | 9 lines Fix 222298 (crash during destruction of second channel when variable set with setvar). I mistakenly reasoned that setvar would be used on all channels. Since it can be set per channel, give each dahdi channel a copy of the variable. (related to #15899) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222353 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	ab99a3d648	Recorded merge of revisions 222309 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222309 | tilghman | 2009-10-06 14:31:39 -0500 (Tue, 06 Oct 2009) | 10 lines Change schema query to involve the use of an optional schema parameter. This change is done in such a way as to allow the driver to continue to function with older databases which don't have these features. (closes issue #16000) Reported by: jamicque Patches: 20091002__issue16000.diff.txt uploaded by tilghman (license 14) 20091002__issue16000__1.6.1.diff.txt uploaded by tilghman (license 14) Tested by: jamicque ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222310 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	9c980313a1	Merged revisions 222298 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222298 | jpeeler | 2009-10-06 14:24:59 -0500 (Tue, 06 Oct 2009) | 9 lines Fix crash during destruction of second channel when variable set with setvar. The setvar line in chan_dahdi.conf is shared among all the channels, so make sure to only free the resources only when the last channel is destroyed. (closes issue #15899) Reported by: tzafrir ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222303 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	8c256183ce	Merged revisions 222273 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222273 | tilghman | 2009-10-06 14:17:11 -0500 (Tue, 06 Oct 2009) | 5 lines When we call a gosub routine, the variables should be scoped to avoid contaminating the caller. This affected the ~~EXTEN~~ hack, where a subroutine might have changed the value before it was used in the caller. Patch by myself, tested by ebroad on #asterisk ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222282 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	0d04372afa	Merged revisions 222176 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222176 | kpfleming | 2009-10-05 20:24:24 -0500 (Mon, 05 Oct 2009) | 27 lines Recorded merge of revisions 222152 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222152 | kpfleming | 2009-10-05 20:16:36 -0500 (Mon, 05 Oct 2009) | 20 lines Fix ao2_iterator API to hold references to containers being iterated. See Mantis issue for details of what prompted this change. Additional notes: This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK has become an enum instead of a macro, with a name that fits our naming policy; also, it is now necessary to call ao2_iterator_destroy() on any iterator that has been created. Currently this only releases the reference to the container being iterated, but in the future this could also release other resources used by the iterator, if the iterator implementation changes to use additional resources. (closes issue #15987) Reported by: kpfleming Review: https://reviewboard.asterisk.org/r/383/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222186 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	d605a00c13	Merged revisions 222110 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222110 | kpfleming | 2009-10-05 14:45:00 -0500 (Mon, 05 Oct 2009) | 25 lines Allow non-compliant T.38 endpoints to be supportable via configuration option. Many T.38 endpoints incorrectly send the maximum IFP frame size they can accept as the T38FaxMaxDatagram value in their SDP, when in fact this value is supposed to be the maximum UDPTL payload size (datagram size) they can accept. If the value they supply is small enough (a commonly supplied value is '72'), T.38 UDPTL transmissions will likely fail completely because the UDPTL packets will not have enough room for a primary IFP frame and the redundancy used for error correction. If this occurs, the Asterisk UDPTL stack will emit log messages warning that data loss may occur, and that the value may need to be overridden. This patch extends the 't38pt_udptl' configuration option in sip.conf to allow the administrator to override the value supplied by the remote endpoint and supply a value that allows T.38 FAX transmissions to be successful with that endpoint. In addition, in any SIP call where the override takes effect, a debug message will be printed to that effect. This patch also removes the T38FaxMaxDatagram configuration option from udptl.conf.sample, since it has not actually had any effect for a number of releases. In addition, this patch cleans up the T.38 documentation in sip.conf.sample (which incorrectly documented that T.38 support was passthrough only). (issue #15586) Reported by: globalnetinc ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222112 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	21901f0e8e	Merged revisions 222030 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222030 | dvossel | 2009-10-02 12:34:07 -0500 (Fri, 02 Oct 2009) | 9 lines Merged revisions 222026 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222026 | dvossel | 2009-10-02 12:32:13 -0500 (Fri, 02 Oct 2009) | 3 lines Removes unnecessary unlock, clarifies a memcpy. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@222035 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	6a8847d42c	Merged revisions 221971 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221971 | tilghman | 2009-10-02 11:59:57 -0500 (Fri, 02 Oct 2009) | 9 lines Merged revisions 221970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221970 | tilghman | 2009-10-02 11:58:03 -0500 (Fri, 02 Oct 2009) | 2 lines Ensure the result of the hash function is positive. Negative array offsets suck. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221973 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	47accdc345	Hash needs to return a positive integer ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221969 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	a8c4a62791	Revert XML docs that ended up in the 1.6.0 and 1.6.1 branches during a merge. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221964 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	8f34ae7e0f	Merged revisions 221920 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r221920 | tilghman | 2009-10-01 22:04:34 -0500 (Thu, 01 Oct 2009) | 4 lines Initialize a variable that we check immediately upon startup. (closes issue #15973) Reported by: atis ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221922 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Richard Mudgett	6687a0a617	Merged revisions 221844 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221844 | rmudgett | 2009-10-01 20:09:31 -0500 (Thu, 01 Oct 2009) | 33 lines Merged revisions 221769 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221769 | rmudgett | 2009-10-01 18:18:28 -0500 (Thu, 01 Oct 2009) | 26 lines Occasionally losing use of B channels in chan_misdn. I have not been able to reproduce the problem of losing channels. However, I have seen in the code a reentrancy problem that might give these symptoms. The reentrancy patch does several things: 1) Guards B channel and B channel structure allocation. 2) Makes the B channel structure find routines more precise in locating records. 3) Never leave a B channel allocated if we received cause 44. The last item may cause temporary outgoing call problems, but they should clear when the line becomes idle. (closes issue #15490) Reported by: slutec18 Patches: issue15490_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664) Tested by: rmudgett, slutec18 (closes issue #15458) Reported by: FabienToune Patches: issue15458_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664) Tested by: FabienToune, rmudgett, slutec18 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221871 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	e669471e75	Merged revisions 221777 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221777 | tilghman | 2009-10-01 18:59:15 -0500 (Thu, 01 Oct 2009) | 9 lines Merged revisions 221776 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221776 | tilghman | 2009-10-01 18:53:12 -0500 (Thu, 01 Oct 2009) | 2 lines Fix a bunch of off-by-one errors ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221779 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	c8553b7634	Merged revisions 221705 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r221705 | tilghman | 2009-10-01 15:09:46 -0500 (Thu, 01 Oct 2009) | 2 lines Revision 220906 (a merge from 1.4) was not merged correctly, causing a problem with non-dynamic peers. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@221743 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago