asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	8da4e28a81	res_ari.c: Prefer exact handler match over wildcard Given the following request path and 2 handler paths... Request: /channels/externalMedia Handler: /channels/{channelId} "wildcard" Handler: /channels/externalmedia "non-wildcard" ...if /channels/externalMedia was registered as a handler after /channels/{channelId} as shown above, the request would automatically match the wildcard handler and attempt to parse "externalMedia" into the channelId variable which isn't what was intended. It'd work if the non-wildard entry was defined in rest-api/api-docs/channels.json before the wildcard entry but that makes the json files order-dependent which isn't a good thing. To combat this issue, the search loop saves any wildcard match but continues looking for exact matches at the same level. If it finds one, it's used. If it hasn't found an exact match at the end of the current level, the wildcard is used. Regardless, after searching the current level, the wildcard is cleared so it won't accidentally match for a different object or a higher level. BTW, it's currently not possible for more than 1 wildcard entry to be defined for a level. For instance, there couldn't be: Handler: /channels/{channelId} Handler: /channels/{channelName} We wouldn't know which one to match. Change-Id: I574aa3cbe4249c92c30f74b9b40e750e9002f925	6 years ago
Alexei Gradinari	15624d9a7a	app_voicemail/IMAP: check mailstream not NULL in leave_voicemail The function leave_voicemail checks if expungeonhangup is set, but does not check if IMAP stream is closed, so it could call imap function with NULL stream. This leads to segfault. ASTERISK-28505 #close Change-Id: Ib66c57c1f1ba97774e447b36349198e2626a8d7c	6 years ago
Sean Bright	e40f248fac	menuselect: Fix curses build on Gentoo Linux Because keypad() is exported by libtinfo, it needs to be explicitly added to the linker options. ASTERISK-28487 #close Change-Id: I6c2ad5b95f422c263d078b5c0e84c111807dffc6	6 years ago
Friendly Automation	bcc0b85da8	Merge "srtp: Fix possible race condition, and add NULL checks"	6 years ago
George Joseph	b859dd450a	Merge "cdr / cel: Use event time at event creation instead of processing."	6 years ago
George Joseph	446bac733d	CI: Escape backslashes in printenv/sort/tr Change-Id: I52be64c8f6af2bbe15148a856d1f10cb113e1e94 (cherry picked from commit `c6558e09af`)	6 years ago
Kevin Harwell	b805e1237d	srtp: Fix possible race condition, and add NULL checks Somehow it's possible for the srtp session object to be NULL even though the Asterisk srtp object itself is valid. When this happened it would cause a crash down in the srtp code when attempting to protect or unprotect data. After looking at the code there is at least one spot that makes this situation possible. If Asterisk fails to unprotect the data, and after several retries it still can't then the srtp->session gets freed, and set to NULL while still leaving the Asterisk srtp object around. However, according to the original issue reporter this does not appear to be their situation since they found no errors logged stating the above happened (which Asterisk does for that situation). An issue was found however, where a possible race condition could occur between the pjsip incoming negotiation, and the receiving of RTP packets. Both places could attempt to create/setup srtp for the same rtp instance at the same time. This potentially could be the cause of the problem as well. Given the above this patch adds locking around srtp setup for a given rtp, or rtcp instance. NULL checks for the session have also been added within the protect and unprotect functions as a precaution. These checks should at least stop Asterisk from crashing if it gets in this situation again. This patch also fixes one other issue noticed during investigation. When doing a replace the old object was freed before creating the replacement. If the new replacement object failed to create then the rtp/rtcp instance would now point to freed srtp data which could potentially cause a crash as well when the next attempt to reference it was made. This is now fixed so the old srtp object is kept upon replacement failure. Lastly, more logging has been added to help diagnose future issues. ASTERISK-28472 Change-Id: I240e11cbb1e9ea8083d59d50db069891228fe5cc	6 years ago
George Joseph	be6130607d	CI: Add "throttle" label and "skip_gate" capability To make throttling by label fully active, the "throttle" option has to be specified with a specific label. You can now specify "skip_gate" in the Gerrit comments when you do a +2 code review to tell Jenkins not to actually run the gate. You'd do this if you plan to manually merge the change. Also updated the "printenv" debug output to better sort multi-line comments. Change-Id: I4c0b1085acec4805f2ca207eebac50aad81f27e2	6 years ago
George Joseph	53c9e7962f	Merge "app_voicemail: Remove extra menuselect build options"	6 years ago
Friendly Automation	55022bc778	Merge "CI: Make node labels job-specific"	6 years ago
Joshua Colp	261646c1c4	cdr / cel: Use event time at event creation instead of processing. When updating times on CDR or CEL records using the time at which it is done can result in times being incorrect if the system is heavily loaded and stasis message processing is delayed. This change instead makes it so CDR and CEL use the time at which the stasis messages that drive the systems are created. This allows them to be backed up while still producing correct records. ASTERISK-28498 Change-Id: I6829227e67aefa318efe5e183a94d4a1b4e8500a	6 years ago
George Joseph	4b14b86114	Merge "various modules: json integer overflow"	6 years ago
George Joseph	c01dd2a41a	CI: Make node labels job-specific Originally, the eligible nodes for a job were labelled only by "swdev-docker". So basically any node could run any job. We had found that allowing a node to run more than 1 gate at a time was problematic so we limited the nodes to processing 1 job at a time. With the creation of the Asterisk 17 branches however, we now have so many active branches that getting checks and gates through in a timely manner is problematic when a node can run only 1 job at a time. Now the nodes are also labelled by the job type they can run. For instance: "asterisk-check", "asterisk-gate", etc. With the "Throttle Concurrent Builds" plugin, we can now allow a node to run more than 1 job BUT throttle by job type. For instance: Allow 2 jobs but only 1 asterisk-gate at a time. Now a node can run 2 checks or 1 check and 1 gate or 1 gate but not 2 gates at a time. Change-Id: I2032bf6afbcec5c341d9b852214c0c812d3d6db5	6 years ago
Friendly Automation	e5ee1b04c9	Merge "res_musiconhold: Use a vector instead of custom array allocation"	6 years ago
George Joseph	97fd008562	Merge "main/udptl.c: correctly handle udptl sequence wrap around"	6 years ago
Sean Bright	9d07d5a6d6	app_voicemail: Remove extra menuselect build options You now select voicemail backends like normal dialplan applications, so there is no longer a need for their own menuselect category. Reported by snuff-work in #asterisk-dev Change-Id: Idfa4c9c8349726074318a9e6b68d24c374521005	6 years ago
Kevin Harwell	3656c42cb0	various modules: json integer overflow There were still a few places in the code that could overflow when "packing" a json object with a value outside the base type integer's range. For instance: unsigned int value = INT_MAX + 1 ast_json_pack("{s: i}", value); would result in a negative number being "packed". In those situations this patch alters those values to a ast_json_int_t, which widens the value up to a long or long long. ASTERISK-28480 Change-Id: Ied530780d83e6f1772adba0e28d8938ef30c49a1	6 years ago
Sean Bright	1f8ae708a0	res_musiconhold: Use a vector instead of custom array allocation Change-Id: Ic476a56608b1820ca93dcf68d10cd76fc0b94141	6 years ago
Joshua Colp	86452c9fa4	res_pjsip: Fix multiple of the same contact in "pjsip show contacts". The code for gathering contacts could result in the same contact being retrieved and added to the list multiple times. The container which stores the contacts to display will now only allow a contact to be added to it once instead of multiple times. ASTERISK-28228 Change-Id: I805185cfcec03340f57d2b9e6cc43c49401812df	6 years ago
Friendly Automation	4018e88369	Merge "res_musiconhold: Use ast_pipe_nonblock() wrapper"	6 years ago
Friendly Automation	ae2ddaa496	Merge "manager: Send fewer packets"	6 years ago
Torrey Searle	084901d548	main/udptl.c: correctly handle udptl sequence wrap around incorrect handling of UDPTL squence number wrap arounds causes loss of packets every time the wrap around occurs ASTERISK-28483 #close Change-Id: I33caeb2bf13c574a1ebb81714b58907091d64234	6 years ago
Friendly Automation	f983b80605	Merge "loader.c: Fix possible SEGV when a module fails to register"	6 years ago
Sean Bright	5f66fb5139	manager: Send fewer packets The functions that build manager message headers do so in a way that results in a single messages being split across multiple packets. While this doesn't matter to the remote end, it makes network captures noisier and harder to follow, and also means additional system calls. With this patch, we build up more of the message content into the TLS buffer before flushing to the network. This change is completely internal to the manager code and does not affect any of the existing API's consumers. Change-Id: I50128b0769060ca5272dbbb5e60242d131eaddf9	6 years ago
Asterisk Development Team	5e6e1175d5	Update CHANGES and UPGRADE.txt for 17.0.0	6 years ago
George Joseph	8d10028b98	Update master for Asterisk 18 Change-Id: I8b8ed97001446fab0c14d7c89391ee572fb29dd6	6 years ago
Sean Bright	7ce9ee7f2e	res_musiconhold: Use ast_pipe_nonblock() wrapper Change-Id: Ib0a4b41e5ececbe633079e2d8c2b66c031d2d1f2	6 years ago
George Joseph	8e44d823c1	loader.c: Fix possible SEGV when a module fails to register When a module fails to register itself (usually a coding error in the module), dlerror() can return NULL. We weren't checking for that in load_dlopen() before trying to strdup the error message so a SEGV was thrown. dlerror() is now surrounded with an S_OR so we don't SEGV. Change-Id: Ie0fb9316f08a321434f3f85aecf3c7d2ede8b956	6 years ago
George Joseph	32642b83ea	Merge "contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible"	6 years ago
George Joseph	dd80db10a9	Merge "CI: Don't enable non-core modules in Certified branches"	6 years ago
George Joseph	03813e51f0	CI: Don't enable non-core modules in Certified branches We don't support non-core modules for Certified releases but we were enabling them for CI builds which was causing lots of test failures. Now we don't. Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766	6 years ago
Sean Bright	2424ecaf66	res_config_sqlite3: Only join threads that we started ASTERISK-28477 #close Reported by: Dennis ASTERISK-28478 #close Reported by: Dennis Change-Id: I77347ad46a86dc5b35ed68270cee56acefb4f475	6 years ago
Friendly Automation	7646f4196b	Merge "openr2(6/6): Set hangup cause"	6 years ago
George Joseph	96a2ce1a0d	Merge "openr2(5/6): added cli command -- mfcr2 destroy link <index>"	6 years ago
George Joseph	64b6d0fc28	Merge "openr2(4/6): added new cli command -- mfcr2 show links"	6 years ago
Friendly Automation	d24d94beba	Merge "openr2(3/6): Convert r2links to standard Asterisk AST_LIST*"	6 years ago
George Joseph	8c3ed46829	Merge "openr2(2/6): Stop polling channels when DAHDI returns -ENODEV (e.g: plug-out)"	6 years ago
George Joseph	497308b5d9	Merge "openr2(1/6): bugfix in configuration saving"	6 years ago
George Joseph	799c4cf494	Merge "chan_pjsip: Transmit REFER waits for the REFER result setting TRANSFERSTATUS"	6 years ago
Leonid Fainshtein	098797628e	openr2(6/6): Set hangup cause Change-Id: I94dc38920e6e77cc73062648f62fdd613d0d1452 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	f67094503d	openr2(5/6): added cli command -- mfcr2 destroy link <index> Change-Id: I452d6a853bcd8c6e194455b19e5e017713e9c0fe Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	64bf3e3e82	openr2(4/6): added new cli command -- mfcr2 show links * This command show the MFC/R2 links Change-Id: I213822e1b7ef9c05bd89a2ba62df8e0856ce9f84 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	f61adf2cf5	openr2(3/6): Convert r2links to standard Asterisk AST_LIST* Change-Id: Ibcb2401515a58782a1488c0b9efbed201c3f3a17 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	97d2549bb1	openr2(2/6): Stop polling channels when DAHDI returns -ENODEV (e.g: plug-out) Otherwise, OpenR2 threads go crazy and consume almost all CPU resources Change-Id: I10a41f617613fe7399c5bdced5c64a2751173f28 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Tzafrir Cohen	2f0a8e12f9	openr2(1/6): bugfix in configuration saving Details: - The memcpy() call copied part of "dahdi_conf" and not "dahdi_conf.mfcr2" - As a result, the memcmp() in dahdi_r2_get_link() always fails - This cause dahdi_r2_get_link() to create new link for every channel (instead of a new link for every ~30 channels) - With the fix, far less links are generated -- so we use far less threads Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132 Signed-off-by: Oron Peled <oron.peled@xorcom.com>	6 years ago
Walter Doekes	4304c6534a	contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible Change-Id: Ica182a891743017ff3cda16de3d95335fffd9a91	6 years ago
George Joseph	be8d41bd24	CI: Add cleanWs to cleanup steps in jenkinsfiles We're at the point where there are enough Jenkins jobs for Asterisk branches than even cleaned checkouts of Asterisk will add up to more disk space than is available on the in-memory workspace mount. Since we archive all relevent artifacts anyway, there's no need to keep the workspace around after the job finishes, whether it succeeds or fails. Change-Id: I1cd3b73ebb045a987df0f62526d152a510210c39	6 years ago
George Joseph	2ba7d3c2b9	Merge "CI: Add install-headers to the install make targets"	6 years ago
George Joseph	960e6dd065	Merge "README.md: Update year"	6 years ago
George Joseph	5167555f8e	Merge "sched: Don't allow ast_sched_del to deadlock ast_sched_runq from same thread"	6 years ago

1 2 3 4 5 ...

32175 Commits (8da4e28a81e46eb1e5be0702849e1304fce2764f) All Branches Search

32175 Commits (8da4e28a81e46eb1e5be0702849e1304fce2764f)

All Branches