26431 Commits (87263b47b51bf727e04f352f988acb508924e423)

 

All Branches   

Search

Author	SHA1	Message	Date
Ivan Poddubny	87263b47b5	app_queue: Fix queue_log EXITWITHTIMEOUT containing only 1 parameter ... This patch fixes EXITWITHTIMEOUT queue_log entry to always come with 3 parameters: position, original position and waiting time. ASTERISK-25038 #close Reported by: Etienne Lessard Change-Id: I0c62045922e26bee2125e93aee1dee17eee79618	10 years ago
Matt Jordan	2d9081b5ec	Merge "stasis: Fix dial masquerade datastore lifetime" into 13	10 years ago
Matt Jordan	8ca25dfd7e	Merge "vector: Traversal, retrieval, insert and locking enhancements" into 13	10 years ago
Joshua Colp	181ae3b8d9	stasis: Fix dial masquerade datastore lifetime ... A recent change went into Asterisk which added reference counts to the channels stored in a dial masquerade datastore. Unfortunately this included a reference to the caller in a dialing operation. While all of the dialed targets have the datastore removed from them upon dialing completion this did not occur for the caller, causing it to have a reference to itself that could go never go away (as it depended on the destruction of the datastore which only happened when the channel was destroyed). This resulted in the caller channel remaining on the system despite it having hung up. This change does the following to fix this issue: 1. The dial masquerade datastore is now removed from the caller upon dialing completion, just like the dialed targets. 2. Upon destruction of the caller all the dialed targets are also removed from the dial masquerade datastore (just in case). 3. The reference to the caller has been removed as it should not be possible for the datastore to now be valid/useful after the lifetime of the caller has ended. ASTERISK-25025 #close Change-Id: I1ef4ca5ca04980028604cc2af5d2992ac3431b3f	10 years ago
George Joseph	7a7e9733c2	vector: Traversal, retrieval, insert and locking enhancements ... Renamed AST_VECTOR_INSERT to AST_VECTOR_REPLACE because it really does replace not insert. The few users of AST_VECTOR_INSERT were refactored. Because these are macros, there should be no ABI compatibility issues. Added AST_VECTOR_INSERT_AT that actually inserts an element into the vector at a specific index pushing existing elements to the right. Added AST_VECTOR_GET_CMP that can retrieve from the vector based on a user-provided compare function. Added AST_VECTOR_CALLBACK function that will execute a function for each element in the vector. Similar to ao2_callback and ao2_callback_data functions although the vector callback can take a variable number of arguments. This should allow easy migration to a vector where a container might be too heavy. Added read/write locked vector and lock manipulation macros. Added unit tests. ASTERISK-25045 #close Change-Id: I2e07ecc709d2f5f91bcab8904e5e9340609b00e0	10 years ago
Corey Farrell	040d2f8558	main/test.c: Add test to verify there were no registration errors. ... This adds a test that will fail if any test failed to register. Also fail if any test registration produced a warning about missing a leading or trailing slash. ASTERISK-25053 #close Reported by: Corey Farrell Change-Id: I93e50b8fcbcfa7f1f5b41b2c44a51685c09529c3	10 years ago
Matt Jordan	626bffc4c2	Merge "contrib/ast-db-manage: Add Postgres ENUM type support in auto DTMF mode update" into 13	10 years ago
Matt Jordan	87fb7fc165	Merge "cdr/cdr_csv.c: Add a new option to enable columns added in Asterisk 1.8" into 13	10 years ago
Matt Jordan	81c27127aa	Merge "Format Interfaces: Prevent unload except by shutdown." into 13	10 years ago
Matt Jordan	743fed71fc	Merge "res_odbc: Use negative connection cache for all connections" into 13	10 years ago
Martin Tomec	3dcec04ab5	res_odbc: Use negative connection cache for all connections ... Apply the negative connection cache setting to all connections, even those that are not pooled. This ensures that the connection will not be re-established before the negative connection cache time is met. ASTERISK-22708 #close Change-Id: I431cc2e8584ab0b6908b3523d0a0e18c9a527271	10 years ago
Matt Jordan	74799b3fe2	Merge "Remove unneeded uses of optional_api providers." into 13	10 years ago
Matt Jordan	78c02f8e88	Merge "Update configure.ac/Makefile for clang" into 13	10 years ago
Corey Farrell	f38066fcad	Format Interfaces: Prevent unload except by shutdown. ... Format interfaces cannot be unregistered, so the modules that provide them need to be held open except by shutdown. ASTERISK-25054 #close Reported by: Corey Farrell Change-Id: Iadbd9675bf0d30b8fded5a739b163db3ea2db8f3	10 years ago
Matt Jordan	e76a6a97bf	contrib/ast-db-manage: Add Postgres ENUM type support in auto DTMF mode update ... The upgrade script for auto DTMF mode (31cd4f4891ec) added in 88b0fa7755 failed to add ENUM support for Postgres databases. This requires a specific import from the sqlalchemy.dialects.postgresql package. This patch corrects this error, which allows for Postgres update scripts to be generated. ASTERISK-24706 Change-Id: I4742ac8efa533cd6f18e0bdd907b339a9aedf015	10 years ago
D Tucny	92120247e9	term: send proper reset sequence when black background is forced ... When using the force black background command-line option or configuration option an invalid reset sequence is sent following a coloured output item in the CLI, the result is that the colour is not 'turned off' and continues until the next non-default coloured text output. A reset sequence is already defined in term.c, but the ast_term_reset function doesn't use it, instead building it's own invalid sequence and returning that. This patch changes that behaviour, removing the building of a reset sequence and instead using the pre-built constant 'enddata' which is a suitable reset sequence for this purpose. ASTERISK-24896 #close Reported by: Dan Tucny Change-Id: I56323899123ae3264900389cae1f5b252aa3bf43	10 years ago
Matt Jordan	13819a34c4	Merge "Build System: Prevent unneeded changes to asterisk/buildopts.h." into 13	10 years ago
Matt Jordan	b518ba1c6c	Merge "res_pjsip_dlg_options: Fix MODULEINFO section." into 13	10 years ago
Corey Farrell	ad6ea29697	Remove unneeded uses of optional_api providers. ... A few cases exist where headers of optional_api provders are included but not needed. This causes unneeded calls to ast_optional_api_use. * Don't include optional_api.h from sip_api.h. * Move 'struct ast_channel_monitor' to channel.h. * Don't include monitor.h from chan_sip.c, channel.c or features.c. The move of struct ast_channel_monitor is needed since channel.c depends on it. This has no effect on users of monitor.h since channel.h is included from monitor.h. ASTERISK-25051 #close Reported by: Corey Farrell Change-Id: I53ea65a9fc9693c89f8bcfd6120649bfcfbc3478	10 years ago
Matt Jordan	9888562c8c	Merge "include/asterisk/channel.h: Fix typo" into 13	10 years ago
Matt Jordan	b4000f2d44	Merge "Astobj2: Fix initialization order of refdebug and AO2_DEBUG." into 13	10 years ago
Rodrigo Ramírez Norambuena	525c8c8689	include/asterisk/channel.h: Fix typo ... Change-Id: Ie584b85e16a94c255e60d0b1732ef9686464fef3	10 years ago
Corey Farrell	63196a8256	res_pjsip_dlg_options: Fix MODULEINFO section. ... Removed the extra space before "MODULEINFO" in res_pjsip_dlg_options. This extra space prevented any of the dependencies from being seen by menuselect, so building with default options would fail if PJSIP was not installed. This also makes the tool that extracts information for menuselect tolerant of multiple spaces in the future. ASTERISK-25033 #close Reported by: Peter Whisker Change-Id: Iccd54846f70c4a7a50cb5bf70b7bb5cb4bab3698	10 years ago
Corey Farrell	ac1f0090eb	Build System: Prevent unneeded changes to asterisk/buildopts.h. ... * Add AST_DEVMODE to BUILDOPTS * Remove CFLAGS that do not effect ABI from BUILDOPTS. * Use BUILDOPTS to generate AST_BUILDOPT_SUM. * Remove loop that defined AST_MODULE_* These changes ensure that only ABI effecting options are considered for AST_BUILDOPT_SUM. This also reduces unneeded full system rebuilds caused by enabling or disabling one module that another is dependent on. ASTERISK-25028 Reported by: Corey Farrell Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2	10 years ago
Corey Farrell	5875bf183c	Astobj2: Fix initialization order of refdebug and AO2_DEBUG. ... This ensures that refdebug is initialized before AO2_DEBUG if both are enabled, since AO2_DEBUG allocates a container. This change also makes AO2_DEBUG initialization critical, a failure will abort Asterisk startup. This is needed since the failure would be caused by reg_containers allocation failure, and that would result in a segmentation fault by ao2_container_register later in startup. ASTERISK-25048 #close Reported by: Corey Farrell Change-Id: I9a243ea3fc5653b48b931ba6d61971cb2e530244	10 years ago
Matt Jordan	1b19c15f17	main/pbx: Improve performance of dialplan reloads with a large number of hints ... The PBX core maintains two hash tables for hints: a container of the actual hints (hints), along with a container of devices that are watching that hint (hintdevices). When a dialplan reload occurs, each hint in the hints container is destroyed; this requires a lookup in the container of devices to find the device => hint mapping object. In the current code, this performs an ao2_callback, iterating over each of the device to hint objects in the hintdevices container. For a large number of hints, this is extremely expensive: dialplan reloads with 20000 hints could take several minutes in just this phase. This patch improves the performance of this step in the dialplan reloads by caching which devices are watching a hint on the hint object itself. Since we don't want to create a circular reference, we just cache the name of the device. This allows us to perform a smarter ao2_callback on the hintdevices container during hint removal, hashing on the name of the device and returning an iterator to the matching names. The overall performance improvement is rather large, taking this step down to a number of seconds as opposed to minutes. In addition, this patch also registers the hint containers in the PBX core with the astobj2 library. This allows for reasonable debugging to hash collisions in those containers. ASTERISK-25040 #close Reported by: Matt Jordan Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360	10 years ago
Matt Jordan	ec0f80b6e8	Merge "res_pjsip_outbound_authenticator_digest: Add missing outbound authenticator callback." into 13	10 years ago
Matt Jordan	ed51fbbe9c	Merge "Prevent potential crash on blond transfer." into 13	10 years ago
Corey Farrell	3efe0df044	Sample Configs: Fix syntax error in pjsip.conf ... The sample pjsip.conf has a few comment lines that are missing the semicolons at the start of the comment, causing the config to fail load. Change-Id: I776a38c916a7df7ee3e072fd0b21dbf4cc457352	10 years ago
Mark Michelson	077979618b	Prevent potential crash on blond transfer. ... Scenario: Alice calls Bob. Bob performs a blond transfer to Carol. Carol rejects the incoming call (or some other immediate circumstance causes Carol not to answer the call) What occurs in this case is that when the bridge between Alice and Bob breaks, Alice is told to masquerade into Bob's channel that had placed the call to Carol. The actual masquerade goes down without a hitch. However, a channel fixup callback that attempts to publish dial events over Stasis has a crash. The reason for this crash is that the datastore on Bob's channel that placed the outbound call to Carol only had a bare pointer to Carol's channel. Since Carol rejected the incoming call, Carol's channel has been hung up and freed, meaning accessing her channel results in a crash. The fix here is simple. The dial fixup code has been altered to hold references to the involved channels and to drop those references when freeing data. ASTERISK-25025 #close Reported by Chet Stevens Change-Id: I54eedda207b8ec7a69263353b43abe5746aea197	10 years ago
Mark Michelson	4b8cddfb36	res_pjsip_outbound_authenticator_digest: Add missing outbound authenticator callback. ... The Asterisk 13 version of the fix for outbound registration was missing a key component that set the outbound authenticator's callback that creates an authenticated request based on an old request. This was picked up by some outbound registration tests failing in the testsuite. Change-Id: I5ca9379698c606da36bc38eaffccedaf64211ce3	10 years ago
Joshua Colp	415a0d0745	res_ari_device_states: Fix dependency on res_stasis_device_state. ... The res_ari_device_states module depends on res_stasis_device_state, not res_stasis_device_states. Change-Id: I26e02ad37f9e36bcc859867e2fad1b90452ec3de	10 years ago
Mark Michelson	e0c6f88010	Merge "chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option." into 13	10 years ago
Matt Jordan	d1bc86fc99	Merge "res_pjsip_outbound_registration: Add virtual line support." into 13	10 years ago
Richard Mudgett	d3c310a28c	chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option. ... Some telco switches occasionally ignore ISDN RESTART requests. The fix for ASTERISK-19608 added an escape clause for B channels in the restarting state if the telco ignores a RESTART request. If the telco fails to acknowledge the RESTART then Asterisk will assume the telco acknowledged the RESTART on the second call attempt requesting the B channel by the telco. The escape clause is good for dealing with RESTART requests in general but it does cause the next call for the restarting B channel to be rejected if the telco insists the call must go on that B channel. chan_dahdi doesn't really need to issue a RESTART request in response to receiving a cause 44 (Requested channel not available) code. Sending the RESTART in such a situation is not required (nor prohibited) by the standards. I think chan_dahdi does this for historical reasons to deal with buggy peers to get channels unstuck in a similar fashion as the chan_dahdi.conf resetinterval option. * Add the chan_dahdi.conf force_restart_unavailable_chans compatability option that when disabled will prevent chan_dahdi from trying to RESTART the channel in response to a cause 44 code. ASTERISK-25034 #close Reported by: Richard Mudgett Change-Id: Ib8b17a438799920f4a2038826ff99a1884042f65	10 years ago
Rodrigo Ramírez Norambuena	7f611fa0e8	cdr/cdr_csv.c: Add a new option to enable columns added in Asterisk 1.8 ... This patch adds a new option to cdr.conf, 'newcdrcolumns', that will handle CDR columns added in Asterisk 1.8. The columns are: * peeraccount * linkedid * sequence When enabled, the columns in the database entry will be populated with the data from the CDR. ASTERISK-24976 #close Change-Id: I51a57063f4ae5e194a9d933a8df45dc8a4534f0b	10 years ago
Joshua Colp	e332c7ed5e	res_pjsip_outbound_registration: Fix double unref on error return. ... When the PJSIP pjsip_regc_send function is invoked and an error status returned the caller currently decrements the reference count of the client state that it just incremented, assuming the registration callback would not have been invoked. In practice this is not correct. If the failure happens after the transaction has been set up the callback will still be invoked. This will cause the reference count to be incorrectly decremented twice, once by the registration callback and second by the caller of pjsip_regc_send. This change makes it so that whether the callback is invoked or not is known by the caller of pjsip_regc_send. Depending on this it can know whether it is responsible for decrementing the reference count of the client state or not. ASTERISK-25037 #close Reported by: Joshua Colp Change-Id: I749dc12f3a22115c49c5d7d95ff42a5fa45319de	10 years ago
Diederik de Groot	9c3ed42875	Update configure.ac/Makefile for clang ... Created autoconf/ast_check_raii.m4: contains AST_CHECK_RAII which checks compiler requirements for RAII: gcc: -fnested-functions support clang: -fblocks (and if required -lBlocksRuntime) The original check was implemented in configure.ac and now has it's own file. This function also sets C_COMPILER_FAMILY to either gcc or clang for use by makefile Created autoconf/ast_check_strsep_array_bounds.m4 (contains AST_CHECK_STRSEP_ARRAY_BOUNDS): which checks if clang is able to handle the optimized strsep & strcmp functions (linux). If not, the standard libc implementation should be used instead. Clang + the optimized macro's work with: strsep(char *, char []), but not with strsepo(char *, char *). Instead of replacing all the occurences throughout the source code, not using the optimized macro version seemed easier See 'define __strcmp_gc(s1, s2, l2) in bits/string2.h': llvm-comment: Normally, this array-bounds warning are suppressed for macros, so that unused paths like the one that accesses __s1[3] are not warned about. But if you preprocess manually, and feed the result to another instance of clang, it will warn about all the possible forks of this particular if statement. Instead of switching of this optimization, another solution would be to run the preproces- sing step with -frewrite-includes, which should preserve enough information so that clang should still be able to suppress the diag- nostic at the compile step later on. See also "https://llvm.org/bugs/show_bug.cgi?id=20144" See also "https://llvm.org/bugs/show_bug.cgi?id=11536" Makefile.rules: If C_COMPILER_FAMILY=clang then add two warning suppressions: -Wno-unused-value -Wno-parentheses-equality In an earlier review (reviewboard: 4550 and 4554), they were deemed a nuisace and less than benefitial. configure.ac: Added AST_CHECK_RAII() see earlier Added AST_CHECK_STRSEP_ARRAY_BOUNDS() see earlier Removed moved content ASTERISK-24917 Change-Id: I12ea29d3bda2254ad3908e279b7effbbac6a97cb	10 years ago
Matt Jordan	37a193da18	Merge "ARI: Fix missing dependencies." into 13	10 years ago
Matt Jordan	6a86b3555b	Merge "res_fax: allow 2400 transmission rate according to v.27ter standard" into 13	10 years ago
Matt Jordan	d4e207e27e	main/rtp_engine: Fix DTLS double-free introduced by 0b6410c4f8 ... The patch in 0b6410c4f8 did correctly fix a memory leak of the DTLS structures in the RTP engine. However, when a 'core reload' is issued, a double free of the memory pointed to by the char *'s in the DTLS configuration struct can occur, as ast_rtp_dtls_cfg_free does not set the pointers to NULL when they are freed. This patch sets those pointers to NULL, preventing a second call to ast_rtp_dtls_cfg_free from corrupting memory. ASTERISK-25022 Change-Id: I820471e6070a37e3c26f760118c86770e12f6115	10 years ago
Kevin Harwell	3fb6daeb55	res_fax: allow 2400 transmission rate according to v.27ter standard ... A previous set of patches (see: ASTERISK-22790 & ASTERISK-23231) made it so a v.27 modem was not allowed to have a minimum transmission rate of 2400 bits per second. This reverts all or some of those patches since according to the v.27ter standard a rate of 2400 bits per second is also supported. One of the original patches also added 9600 bits per second support for v.27. This patch also removes that since v.27ter only supports 2400/4800 bits per second. Also, since Asterisk specifically supports v.27ter the enum was renamed to better reflect this. ASTERISK-24955 #close Reported by: Matt Jordan Change-Id: I4b9dfb6bf7eff08463ab47ee1a74224f27cae733	10 years ago
Joshua Colp	49ef81c15c	res_sorcery_config: Fix build issue due to syntax error. ... Change-Id: Ic8322f04e37842848ad72cf2871bd0378f67c4ac	10 years ago
Ashley Sanders	3278fe5327	chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR ... Sections Exist in pjsip.conf This patch modifies the current loading strategy of the pjsip configuration. If duplicate sections (e.g. sections containing the same [id/type]) are defined in [pjsip.conf], the loader will consider the configuration for the given type as invalid when the duplicate section is encountered. The entire configuration (including what was previously loaded) for the duplicate [id/type] sections will be rejected and destroyed, an error message is logged and the load processing for the given stops. ASTERISK-24996 Reported By: Ashley Sanders Change-Id: I35090ca4cd40f1f34881dfe701a329145c347aef	10 years ago
Joshua Colp	89f6719f7a	res_pjsip_outbound_registration: Add virtual line support. ... Virtual line support establishes a relationship between messages related to an outbound registration and a local endpoint. This is accomplished by attaching a parameter to the Contact of the outbound registration and looking for it on any received requests. If the parameter exists and can be matched to an outbound registration the configured endpoint is associated with the request. ASTERISK-24949 #close Reported by: Joshua Colp Change-Id: I7df909d2625479110a83fdd354c21ac539e8615d	10 years ago
Corey Farrell	d61f03c4f9	ARI: Fix missing dependencies. ... ARI modules that are generated by 'make ari-stubs' are all dependent on res_ari_model. Additionally some of the same modules depend on one or more res_stasis_* modules. ASTERISK-25027 #close Reported by: Corey Farrell Change-Id: I8e07fe7e81fedacb87232f2b6f8b5f47927b4153	10 years ago
Corey Farrell	3e4624ad21	res_pjsip: Remove incorrect MODULEINFO from presence_xml.c. ... Remove incorrect MODULEINFO block and unneeded header includes from presence_xml.c. ASTERISK-25027 Reported by: Corey Farrell Change-Id: I977c609ab9d1fe05373027c4138900f6985990eb	10 years ago
Corey Farrell	fed9faab8d	Git Migration: Create doc/rest-api when needed. ... Create the directory './doc/rest-api' at the start of 'make ari-stubs' to prevent an error when documentation is generated. The directory is also added to git ignores. ASTERISK-25027 Reported by: Corey Farrell Change-Id: Iaccc7f0138501c23aa78feaca2f3cce9e68cbc1b	10 years ago
Joshua Colp	df23c8a86b	res_pjsip_outbound_registration: Fix build due to removal of transaction. ... Change-Id: I7a8a7beec3334cec304943f2dd7597eabe2e3150	10 years ago
Joshua Colp	95ab9fdb1a	Merge "res_pjsip_outbound_registration: Add debugging messages." into 13	10 years ago