24340 Commits (8263f21cbae4db1a4573c120283874bda2783a83)

 

All Branches   

Search

Author	SHA1	Message	Date
Alexander Traud	8263f21cba	BuildSystem: Avoid 'ar cru' and use 'ar cr' instead. ... In several internal library projects, the files are archived with the help of 'ar cr'. Only the projects editline and the Objective Open H.323 stack implementation in C (ooh323c) use 'ar cru' instead. Recently, some platforms changed the default parameters of AR which creates "/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')". For consistency and to avoid this message all projects use 'ar cr' now. ASTERISK-26091 #close Change-Id: I710a9b1c01c1b5a1931a646098c044c8161ead40	10 years ago
zuul	99efb23d11	Merge "Makefile: remove OSARCH check for init install" into 11	10 years ago
Tzafrir Cohen	9a9e34ea81	Makefile: remove OSARCH check for init install ... There are more specific checks for the platform. Specifically this allows installing OS/X init scripts. ASTERISK-26038 #close Change-Id: If08933621145b10362a0cfe73c079301d9c13f50 Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>	10 years ago
Ivan Poddubny	7e44c80715	func_curl: Don't trim response text on non-ASCII characters ... The characters 0x80-0xFF were trimmed as well as 0x00-0x20 because of a signed comparison. ASTERISK-25669 #close Reported by: Jesper patches: strings.curl.trim.patch submitted by Jesper (License 5518) Change-Id: Ia51e169f24e3252a7ebbaab3728630138ec6f60a	10 years ago
zuul	73bbe8afc0	Merge "udptl: Don't eat sequence numbers until OK is received" into 11	10 years ago
George Joseph	1cd2f25943	udptl: Don't eat sequence numbers until OK is received ... Scenario: Local fax -> Asterisk w/ firewall -> Provider -> Remote fax * Local fax starts rtp call to remote fax * Remote fax starts t38 call back to local fax. * Local fax sends t38 no-signal to Asterisk before sending an OK. * udptl processes the frame and increments the expected sequence number. * chan_sip drops the frame because the call isn't up so nothing goes out the external interface to open the port for incoming packets. * Local fax sends OK and Asterisk sends OK to the remote fax. * Remote fax sends t38 packets which are dropped by the firewall. * Local fax re-sends t38 no-signal with the same sequence number. * udptl drops the frame because it thinks it's a dup. * Still no outgoing packets to open the firewall. * t38 negotiation fails. The patch drops frames t38 received before udptl sequence processing when the call hasn't been answered yet. The second no-signal frame is then seen as new and is relayed out the external interface which opens the port and allows negotiation to continue. ASTERISK-26034 #close Change-Id: I11744b39748bd2ecbbe8ea84cdb4f3c5943c5af9	10 years ago
George Joseph	76787842dd	chan_sip: Prevent extra Session-Expires headers from being added ... When chan_sip does a re-INVITE to refresh a session and authentication is required, the INVITE with the Authorization header containes a second Session-Expires header without the ";refersher=" parameter. This is causing some proxies to return a 400. Also, when Asterisk is the uas and the refresher, it is including the Session-Expires and Min-SE headers in OPTIONS messages which is not allowed per RFC4028. This patch (based on the reporter's) Checks to see if a Session-Expires header is already in the message before adding another one. It also checks that the method is INVITE or UPDATE. ASTERISK-26030 #close Change-Id: I58a7b07bab5a3177748d8a7034fb8ad8e11ce1d9	10 years ago
zuul	2a00dec2bc	Merge "logger: Add PID to syslog messages." into 11	10 years ago
Tzafrir Cohen	120dcdd3df	followme: delete the right recorded name file ... FollowMe with the option a records the name of the caller and plays it to the callee. However it has failed to clean up that recorded file as it tried to delete the file name without the '.sln' extension. ASTERISK-26008 #close Change-Id: I79d7b1be7d5cde57bf076d9389e2a8a4422776ec Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>	10 years ago
Alexei Gradinari	d2a2677c8d	logger: Add PID to syslog messages. ... During refactoring of this support the addition of the PID to messages was removed. This change adds it back in. ASTERISK-25538 #close Change-Id: Ie2d43b0652e59b7ac319a7dba94501540d70ba36	10 years ago
Alexei Gradinari	987ec85681	res_fax/t38_gateway: Peer V.21 session is created on wrong channel ... The channel and peer V.21 sessions are created on the same channel now. The peer V.21 session should be created only on peer channel when one of channel can handle T.38. Also this patch enable debug for T.38 gateway session if global fax debug enabled. ASTERISK-25982 Change-Id: I78387156ea521a77eb0faf170179ddd37a50430e	10 years ago
Andrew Nagy	42ab8d8ef3	app_voicemail: always copy dynamic struct to avoid race condition ... Voicemail email addresses can be corrupt or voicemail emails can end up being sent to the wrong email address if asterisk is reading voicemail.conf during a reload and processing an email at the same time. This patch always copies the struct that would otherwise only be copied once. ASTERISK-24463 #close Reported by: John Campbell Tested by: Etienne Lessard Tested by: Andrew Nagy Change-Id: I3a0643813116da84e2617291903d0d489b7425fb	10 years ago
Joshua Colp	0936913275	Merge "config: Fix ast_config_text_file_save writability check for missing files" into 11	10 years ago
zuul	6ae9a22e14	Merge "Fix case sensitive actions in AMI QueueSummary and QueueStatus" into 11	10 years ago
George Joseph	bd050e2782	config: Fix ast_config_text_file_save writability check for missing files ... A patch I did back in 2014 modified ast_config_text_file_save to check the writability of the main file and include files before truncating and re-writing them. An unintended side-effect of this was that if a file doesn't exist, the check fails and the write is aborted. This patch causes ast_config_text_file_save to check the writability of the parent directory of missing files instead of checking the file itself. This allows missing files to be created again. A unit test was also added to test_config to test saving of config files. The regression was discovered when app_voicemail's passwordlocation=spooldir feature stopped working. ASTERISK-25917 #close Reported-by: Jonathan Rose Change-Id: Ic4dbe58c277a47b674679e49daed5fc6de349f80	10 years ago
DarkS	d8c85768c0	Fix case sensitive actions in AMI QueueSummary and QueueStatus ... ASTERISK-25954 #close Reported by: Javier Acosta Change-Id: I00be83d45cc7e8385de2523012bd196aafeeb256 (cherry picked from commit c0688a6398)	10 years ago
Kevin Harwell	79d7284b8b	app_queue: queue members can receive multiple calls ... It was possible for a queue member that is a member of at least 2 or more queues to receive mulitiple calls at the same time. This happened because of a race between when a member was being rung and when the device state notified the other queue(s) member object of the state change. This patch makes it so when a queue member is being rung it gets added to a global pool of queue members. If that same member is tried again, e.g. from another queue, and it is found to already exist in the pending member container then it will not ring that member. ASTERISK-16115 #close Change-Id: Ice45a1c95b9f6f15d8a9fa709c5e5c84ffd29780	10 years ago
Diederik de Groot	0cc0839f49	lock.c: Check *lt before dereferencing it ... *lt is NULL if t->tracking == 0 ASTERISK-25948 #close Change-Id: I4a81af28f9c82a74aa82413d772a7dc8fa6f45ba	10 years ago
Joshua Colp	7c0f986329	Merge "app_queue: Frequent segfaults in function can_ring_entry()" into 11	10 years ago
Jaco Kroon	b8bfb8f072	chan_sip: Don't verify table if rtupdate=no ... If rtupdate=no do not verify sipregs/peers table has updatable fields. ASTERISK-25934 #close Change-Id: Iaa2c53037b93daccc7e7333c40d61861847b856d	10 years ago
ibercom	32b4320d62	app_queue: Frequent segfaults in function can_ring_entry() ... ASTERISK-25888 #close Change-Id: I007a2f2dd99823e04fb5be3ff01f02b0a2956117	10 years ago
Alexei Gradinari	981ed6091e	app_voicemail/IMAP: function 'save_to_folder' creates wrong folder ... If try to move message to Cust1 (number 5) the function 'save_to_folder' tries to create Greeting folder instead of Cust1. This patch fixed it by setting GREETINGS_FOLDER = -1 ASTERISK-24927 #close Change-Id: I03d1a761894bcc2d130ec9b003bbcddc28e25c51	10 years ago
Joshua Colp	1dc00f5077	app_voicemail: Fix test_voicemail_notify_endl test. ... The test_voicemail_notify_endl test checks the end-of-line characters of an email message to confirm that they are consistent. The test wrongfully assumed that reading from the email message into a buffer will always result in more than 1 character being read. This is incorrect. If only 1 character was read the test would go outside of the buffer and access other memory causing a crash. The test now checks to ensure that 2 or more characters are read in ensuring the test stays within the buffer. ASTERISK-25874 #close Change-Id: Ic2c89cea6e90f2c0bc2d8138306ebbffd4f8b710	10 years ago
zuul	1335aaa579	Merge "chan_local: Fix hangupcauses not getting set on Local channels" into 11	10 years ago
Jaco Kroon	7be8c6bec9	chan_local: Fix hangupcauses not getting set on Local channels ... ASTERISK-25912 #close Change-Id: I9ec0d40bd0e8ff16ba9c3cfc4c1b52cc575f421b	10 years ago
Alexei Gradinari	628b613a6a	app_voicemail/IMAP: IMAP access FATAL error: Out of memory ... Sometimes uw-imap function 'mail_fetchbody' returns huge len which then pass to uw-imap function 'rfc822_base64'. uw-imap tries to allocate huge memory and abort() on fail. This patch check the len. If the len more than max size (128 Mbytes) log error. This patch also set variables len, newlen to avoid uninizialezed len. This patch also check pointer returned by rfc822_base64. ASTERISK-25899 #close Change-Id: I4a0e7d655f11abef6a5224e2169df6d5c1f1caca	10 years ago
zuul	c9a580807d	Merge "core/logging: Fix broken syslog levels on older glibc." into 11	10 years ago
Walter Doekes	7878141198	musiconhold: Only warn if music class is not found in memory and database. ... The log message when a MusicOnHold music class was not found was changed from debug level to WARNING level in Asterisk 11.19 and 13.5. For those using realtime musiconhold, this message is wrong because it warns before checking the database. This changeset delays the warning until after the database has been checked. Reported-by: Conrad de Wet ASTERISK-25444 #close Change-Id: I6cfb2db2f9cfbd2bb3d30566ecae361c4abf6dbf	10 years ago
Walter Doekes	70ca50d96a	core/logging: Fix broken syslog levels on older glibc. ... The fix to ASTERISK-25407 introduced the usage of LOG_MAKEPRI. However this macro is broken in older glibc (< 2.17); it would left-shift the facility a second time, causing the resultant priority to become invalid. The syslog manpage mentions nothing about LOG_MAKEPRI and suggests this: The priority argument is formed by ORing the facility and the level values [...]. ASTERISK-25510 #close Reported by: Michael Newton Change-Id: Ia89debe7fac5ad090c7ef595c0707f31bb1e3d03	10 years ago
Francesco Castellano	d5fcd74fb5	chan_sip.c: Space after port causes unnecessary resolution attempt ... check_via() already skips leading blanks where the sent-by address (with the optional port) should be placed. Since RFC 3261 allows for blanks between the port ant the Via parameters: > https://tools.ietf.org/html/rfc3261#section-20.42 (actually it allows a lot of blanks more ;-)). I just switched from ast_skip_blanks() to ast_strip() on the local copy of the string. ASTERISK-21301 #close Change-Id: Ie5b8fe5a07067b7c0dc9bcdd1707e99b23b02b06	10 years ago
Gianluca Merlo	613fdff543	config: fix flags in uint option handler ... The configuration unsigned integer option handler sets flags for the parser as if the option should be a signed integer (PARSE_INT32), leading to errors on "out of range" values. Fix flags (PARSE_UINT32). ASTERISK-25612 #close Change-Id: I96b539336275e0e72a8e8033487d2c3344debd3e	10 years ago
Gianluca Merlo	91bdaa9251	func_aes: fix misuse of strlen on binary data ... The encryption code for AES_ENCRYPT evaluates the length of the data to be encoded in base64 using strlen. The data is binary, thus the length of it can be underestimated at the first NULL character. Reuse the write pointer offset to evaluate it, instead. ASTERISK-25857 #close Change-Id: If686b5d570473eb926693c73461177b35b13b186	10 years ago
zuul	c016556aaa	Merge "chan_sip.c: Simplify sip_pvt destructor call levels." into 11	10 years ago
Richard Mudgett	1d87a4dc4b	chan_sip.c: Simplify sip_pvt destructor call levels. ... Remove destructor calling destroy_it calling really_destroy_it for no benefit. Just make the destructor the really_destroy_it function. Change-Id: Idea0d47b27dd74f2488db75bcc7f353d8fdc614a	10 years ago
Richard Mudgett	33b56c90c6	chan_sip.c: Made sip_reinvite_retry() call sip_pvt_lock_full(). ... Change-Id: I90f04208a089f95488a2460185a8dbc3f6acca12	10 years ago
Walter Doekes	d4c3b62fd2	app_chanspy: Fix occasional deadlock with ChanSpy and Local channels. ... Channel masquerading had a conflict with autochannel locking. When locking autochannel->channel, the channel is fetched from the autochannel and then locked. During the fetch, the autochannel -- which has no locks itself -- can be modified by someone who owns the channel lock. That means that the value of autochan->channel cannot be trusted until you hold the lock. In practice, this caused problems with Local channels getting masqueraded away while the ChanSpy attempted to get info from that channel. The old channel which was about to get removed got locked, but the new (replaced) channel got unlocked (no-op). Because the replaced channel was now locked (and would never get unlocked), it couldn't get removed from the channel list in a timely manner, and would now cause deadlocks when iterating over the channel list. This change checks the autochannel after locking the channel for changes to the autochannel. If the channel had been changed, the lock is reobtained on the new channel. In theory it seems possible that after this fix, the lock attempt on the old (wrong) channel can be on an already destroyed lock, maybe causing a crash. But that hasn't been observed in the wild and is harder induce than the current deadlock. Thanks go to Filip Frank for suggesting a fix similar to this and especially to IRC user hexanol for pointing out why this deadlock was possible and testing this fix. And to Richard for catching my rookie while loop mistake ;) ASTERISK-25321 #close Change-Id: I293ae0014e531cd0e675c3f02d1d118a98683def	10 years ago
zuul	de067e35d7	Merge "chan_sip.c: Suppress T.38 SDP c= line if addr is the same." into 11	10 years ago
Richard Mudgett	5a9853c113	chan_sip.c: Suppress T.38 SDP c= line if addr is the same. ... Use the correct comparison function since we only care if the address without the port is the same. Change-Id: Ibf6c485f843a1be6dee58a47b33d81a7a8cbe3b0	10 years ago
Christof Lauber	8ba5eb42f5	res_config_sqlite3: Fix crashes when reading peers from sqlite3 tables ... Introduced realloaction of ast_str buf in sqlite3_escape functions in case the returned buffer from threadstorage was actually too small. Change-Id: I3c5eb43aaade93ee457943daddc651781954c445	10 years ago
Joshua Colp	3d4e5400fa	Merge "app_queue: fix Calculate talktime when is first call answered" into 11	10 years ago
Rodrigo Ramírez Norambuena	ab11e72ce5	app_queue: fix Calculate talktime when is first call answered ... Fix calculate of average time for talktime is wrong when is completed the first call beacuse the time for talked would be that call. ASTERISK-25800 #close Change-Id: I94f79028935913cd9174b090b52bb300b91b9492	10 years ago
Richard Mudgett	369981e5be	cel.c: Fix mismatch in ast_cel_track_event() return type. ... The return type of ast_cel_track_event() is not large enough to return all 64 potential bits of the event enable mask. Fortunately, the defined CEL events do not really need all 64 bits and the return value is only used to determine if the requested CEL event is enabled. * Made the ast_cel_track_event() return 0 or 1 only so the return value can fit inside an int type instead of zero or a truncated 64 bit non-zero value. Change-Id: I783d932320db11a95c7bf7636a72b6fe2566904c	10 years ago
Corey Farrell	95e76368eb	main/asterisk.c: Reverse #if statement in listener() to fix code folding. ... listener() opens the same code block in two places (#if and #else). This confuses some folding editors causing it to think that an extra code block was opened. Folding in 'geany' causes all code after listener() to be folded as if it were part of that procedure. ASTERISK-24813 #close Change-Id: I4b8c766e6c91e327dd445e8c18f8a6f268acd961	10 years ago
Sean Bright	9c83062c31	func_iconv: Ensure output strings are properly terminated. ... ASTERISK-25272 #close Reported by: Etienne Lessard patches: AST-25272.patch submitted by Etienne Lessard (license #6394) Change-Id: Id75ad202300960a1e91afe15e319d992936ecc17	10 years ago
zuul	fddd8a8ef0	Merge "Build: Fix menuselect USAN conflicts" into 11	10 years ago
Badalyan Vyacheslav	3fdeb5a140	Build: Added testing compiler to support the system sanitizes ... In older versions of the compiler was not sanitizes. Compilers other than GCC can not support the Usan and TSAN or have other options for *FLAGS. ASTERISK-25767 #close Reported by: Badalyan Vyacheslav Tested by: Badalyan Vyacheslav Change-Id: Iefce6608221fa87884b82ae3cb5649b7b1804916	10 years ago
Badalyan Vyacheslav	598685f8a5	Build: Fix menuselect USAN conflicts ... USAN can be used together with other sanitizers. Reported by: Badalyan Vyacheslav Tested by: Badalyan Vyacheslav Change-Id: I3bffa350d70965c3026651dba3a12414d0aaa45f	10 years ago
Corey Farrell	afb4a93280	Simplify and fix conditional in FD_SET. ... FD_SET contains a conditional statement to protect against buffer overruns. The statement was overly complicated and prevented use of the last array element of ast_fdset. We now just verify the fd is less than ast_FDMAX. Change-Id: I41895c0b497b052aef5bf49d75c817c48b326f40	10 years ago
George Joseph	26fdf8a77e	chan_misdn: Fix a few issues causing compile errors ... Change-Id: I54b48c24d7ca88ed80496fdfd142d08772a7ab98	10 years ago
Joshua Colp	cc510376ec	Merge topic 'ASTERISK-20987' into 11 ... * changes: app_confbridge.c: Update CONFBRIDGE and CONFBRIDGE_INFO documentation. app_confbridge: Make non-admin users join a muted conference muted.	10 years ago