599 Commits (645af85225ad0611e6130250819a3502fe3b2173)

Author	SHA1	Message	Date
Olle Johansson	044aa79799	Bug fixes to tdd support in zaptel. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89042 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	712b337863	closes issue #8786 - where the [catname](!) and [catname](othercat1,othercat2,...) notation gets dropped across a ConfigUpdate (or any other thing that would cause a config file to be written). While I was at it, I also cleaned up some of the destroy routines to free up comments, which was not being done. Made sure the new struct I introduced is also cleaned up properly at destruction time. My code handles multiple template inclusions. Many thanks to ssokol for his patch, which, while not literally used in the final merge, served as a foundation for the fix. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89036 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7b59a194a5	Reworked deadlock avoidance in __ast_read. Restored audio to ... callback agents. (closes issue #11071, reported by callguy, patched by me, tested by callguy and Ted Brown) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88826 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	34002d567b	After seeing crashes related to channel variables, I went looking around at the ... ways that channel variables are handled. In general, they were not handled in a thread-safe way. The channel _must_ be locked when reading or writing from/to the channel variable list. What I have done to improve this situation is to make pbx_builtin_setvar_helper() and friends lock the channel when doing their thing. Asterisk API calls almost all lock the channel for you as necessary, but this family of functions did not. (closes issue #10923, reported by atis) (closes issue #11159, reported by 850t) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88805 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5d140cb9c2	Merge changes from asterisk/team/kpfleming/SRV-priority-handling ... Previously, the SRV record support in Asterisk was broken. There was no guarantee on what record Asterisk would choose to actually use. This set of changes improves the situation by ensuring that Asterisk will choose the highest priority record. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88719 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9cb94c7cde	Merge the last bit of changes from asterisk/team/russell/readq-1.4 ... The issue here is that the channel frame readq handling got broken when the code was converted to use the linked list macros. It caused corruption of the list head and tail pointers. So, I fixed up the usage of the linked list macros and in passing, simplified the code. I also documented what the code is doing, as it was a bit difficult to figure out at first. This bug showed itself with crashes showing messed up head/tail pointers for the readq. However, there are a couple of crashes that aren't quite as obvious, but I think may be related. So, if your bug gets closed by this commit, but you still have a problem, please reopen or create a new bug report. (closes issue #10936) (closes issue #10595) (closes issue #10368) (closes issue #11084) (closes issue #10040) (closes issue #10840) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88709 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a3af50b67d	Fix up datastore handling in ast_do_masquerade(). The code is intended to move ... any channel datastores from the old channel to the new one. However, it did not use the linked list macros properly to accomplish the task. The existing code would only work if there was only a single datastore on the old channel. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	a0edff2477	Rename ast_string_field_free_pool to ast_string_field_free_memory, ... and ast_string_field_free_all to ast_string_field_reset_all to avoid misuse (due to too similar names and an error in documentation). Fix two related memory leaks in app_meetme. No need to merge to trunk, different fix already applied there. Not applicable to 1.2 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88471 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	fc0439dde4	We need to make sure to specify a language to ast_fileexists, otherwise it may fail for anything besides en ... Issue 11147, fix discovered by both citats and myself (independently), with input from Corydon76 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@88283 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	4df0c83be7	Fix build of editline on Solaris. ... Issue 11113, patch by snuffy. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87567 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	f0c0dfe1f1	clean up (and ignore) assembler and preprocessor intermediate files if any are created during the build ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87463 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b2382349dc	Add some more details to the output of "core show locks". When a thread ... is waiting for a lock, this will now show the details about who currently has it locked. (inspired by issue #11100) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87396 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	fd7bc75ce9	Remove a lock that doesn't make any sense. The regions lock needs to be held ... when traversing the list of allocated chunks so that they can be printed out to the CLI. (Thanks to eliel on #asterisk-dev for pointing this out!) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87373 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	7fc2c32a92	Fix issue with ast_unescape_semicolon going into an endless loop. ... (closes issue #10550) Reported by: ramonpeek Patches: unescape-85177-1.patch uploaded by IgorG (license 20) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87294 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	214a5ca25e	appending one list to another should leave the first list empty, and not require the user to do that ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87069 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ea4525e780	this update to Makefile corrects how ast_expr2f.c should be generated ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86881 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	0f7198f227	This should get rid of a really, really irritating warning generated by some 64-bit platforms from libc, where free(0) is frowned upon ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86880 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	992f4d1aeb	Minor FreeBSD build fix ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86787 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	20ce142d01	Don't leak a frame in the case that an END frame is received and the time since ... the BEGIN is less than that of the defined minimum DTMF duration. (closes issue #11051) Reported by: casper Patches: channel.c.86664.diff uploaded by casper (license 55) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0e9071a2e3	Move log message to before the frame it references is freed. ... (closes issue #11050) Reported by: slavon Patches: channel.c.86662.diff uploaded by casper (license 55) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86663 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	fb53e2a7f5	Fixes for building under OpenSolaris. ... (closes issue #11047) Reported by: snuffy Patches: 11047-fixes.diff uploaded by snuffy (license 35) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86630 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	e2dcbeda0c	When returning a DTMF digit from ast_control_streamfile cast it as a char so that 0 does not overlap with the success return code. ... (closes issue #11023) Reported by: cfc git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86502 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9df6ebe9b9	The channel needs to stay locked while running timer callbacks, as they access ... and modify channel data that may change elsewhere. I went through every timer callback in the source tree to make sure that none of them did any additional locking that could introduce deadlocks, and all is well. (closes issue #10765) Reported by: Ivan Patches: ast_1_4_11_svn_patch_channel_rc.diff uploaded by Ivan (license 229) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86330 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9fcc010cce	Revert a change that I made for issue #10979 which, as has been pointed out to ... me in issue #11018, doesn't really make sense. There is no reason to have the base64 decode function force a '\0' terminated buffer, when the result is almost always binary, anyway. In fact, this caused some breakage, as some code in res_crypto passed in a buffer exactly the right size to get its binary result, which got stomped on by this patch. (closes issue #11018, reported by dimas) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86237 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	d2c10c49fa	When runuser/rungroup is specified, a remote console could only be attained by root ... (Closes issue #9999) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@86066 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	17ee21bf18	Also set up gmtoff (this is used in the %z gnu extension to strftime) ... Reported and fixed by jcmoore Closes issue #11002 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85921 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	3a935a35a0	Fix memory allocation issue in threadstorage. ... (closes issue #10995) Reported by: snuffy Patches: new-patch.diff uploaded by snuffy (license 35) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d47ebb492f	Add a small fix for the tw version of saying dates. ... (closes issue #7827) Reported by: sharkey Patches: say.nits.patch uploaded by sharkey (license 172) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85686 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	02bb2bcbaa	Be pedantic about handling memory allocation failure. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85649 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9c47228dff	The loop in the handler for the "core show locks" could potentially block for ... some amount of time. Be a little bit more careful and prepare all of the output in an intermediary buffer while holding a global resource. Then, after releasing it, send the output to ast_cli(). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85647 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0f3e461074	Bring both DTMF begin and end frames up through to the core for DTMF feature handling. ... (closes issue #10826) Reported by: dimas git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85559 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	3cc997694d	If Monitor or a spy was added to a P2P or native bridged channel bring the channel back to the generic bridging core so the monitor or spy operations work. ... (closes issue #10943) Reported by: julianjm git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85552 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b5addcd9a5	Suppress a LOG_DEBUG message if debug is not enabled. ... (closes issue #10980) Reported by: casper Patches: db.c.84633.diff uploaded by casper (license 55) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85548 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	39f5611898	Make sure remote consoles unmute themselves again after reconnecting. ... (closes issue #10847) Reported by: atis Patches: console_unmute_on_reconnect.patch uploaded by atis (license 242) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85545 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9b382ca76f	Make sure that the base64 decoder returns a terminated string. ... (closes issue #10979) Reported by: ys Patches: util.c.diff uploaded by ys (license 281) - small mods by me git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85543 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	bad30446a6	Fix an issue with console verbosity when running asterisk -rx to execute a command ... and retrieve its output. The issue was that there was no way for the main Asterisk process to know that the remote console was connecting in the -rx mode. The way that James has fixed this is to have all remote consoles muted by default. Then, regular remote consoles automatically execute a CLI command to unmute themselves when they first start up. (closes issue #10847) Reported by: atis Patches: asterisk-consolemute.diff.txt uploaded by jamesgolovich (license 176) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85533 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	6c18b111b9	Properly handle the case where read() may return the text for more than one ... CLI command at once for a remote console. (closes issue #10888) Reported by: jamesgolovich Patches: asterisk-climultiple.diff.txt uploaded by jamesgolovich (license 176) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85532 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	18fa561af4	A dollar sign by itself, not indicating a start of a variable or expression prematurely ends substitution (closes issue #10939) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85356 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	30b6db4bcf	The thread ID should be unsigned. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85315 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	96d11d3e02	This commit fixes the following issues: ... - Deadlock in ast_write (issue #10406) - Deadlock in ast_read (issue #10406) - Possible mutex initialization error in lock.h (issue #10571) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	ba0bb743e6	Only update codec information if the channel has a technology private structure. ... (issue #10915) Reported by: ramonpeek git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85057 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	3dcf938f73	Update codec information as well as address when doing hold reinvites. ... (issue #10868) Reported by: mavince git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85023 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2baeb29ae4	Don't keep trying to native bridge if either of the channels are involved in a masquerade operation to be done. ... (closes issue #10696) Reported by: tbelder git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84990 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	9ae23cba31	Log exactly why we can't open the database, if we fail (closes issue #10887) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84851 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	35ed1f7148	Update the remembered RTP peer information when putting an endpoint on hold or taking it off hold so that the RTP stack does not initiate a needless reinvite. ... (closes issue #10868) Reported by: mavince git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	2c757f0747	Fix a copy/paste error in the description of UpdateConfig that was pointed ... out by JerJer on #asterisk-dev git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84742 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	1e9edf1338	When an RFC 2833 event is sent that we don't recognize, ignore it, don't queue a NULL digit (closes issue #10877) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84581 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	bae4135759	moved get_base_channel() code from action_redirect to ast_channel_masquerade() for issue 7706 and BE-160 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84274 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5fdc354155	Fulfull a feature request from Qwell on the "core show locks" output. It will ... now note the lock type for each lock that a thread holds. (mutex, rdlock, or wrlock) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84271 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	b1f26cfcdf	Correct pronunciations of numbers for .nl (Closes issue #10837) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84078 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago