29430 Commits (60cfe00c4e191ce3c83a2ed492311a55c4763e2f)

 

All Branches   

Search

Author	SHA1	Message	Date
Sean Bright	60cfe00c4e	res_pjsip_transport_websocket: Give transport a meaningful description ... We were not \0 terminating this string, so any attempt to print it would in the best case show an empty string and in the worst case potentially crash. Change-Id: I63d96ef8f7516ac02a0f91e22dfa8acdc615042c	8 years ago
Joshua Colp	71c0478a04	Merge "ast_coredumper: Add ability to use directory other than /tmp" into 13	8 years ago
Joshua Colp	8d55b132b9	Merge "sorcery: Add ast_sorcery_retrieve_by_prefix()" into 13	8 years ago
Jenkins2	9fb2da7963	Merge "pjsip / hep: Provide correct local address for Websockets." into 13	8 years ago
Jenkins2	cb74309a51	Merge "chan_pjsip.c: Improve answer failure log messages." into 13	8 years ago
Joshua Colp	5df5f3e86d	Merge "audiohook.c: Fix freeing a frame and still using it." into 13	8 years ago
Richard Mudgett	8a7dd5cc44	chan_pjsip.c: Improve answer failure log messages. ... * Balanced the session->inv_session refs on answer failure. Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8	8 years ago
Richard Mudgett	7f916d621a	audiohook.c: Fix freeing a frame and still using it. ... Memory corruption happened to the media frame caches when an audio hook freed a frame when it shouldn't. I think the freed frame was because a jitter buffer interpolated a missing frame and the audio hook unconditionally freed it. * Made audiohook.c:audio_audiohook_write_list() not free an interpolated frame if it is the same frame as what was passed into the routine. * Made plc.c:normalise_history() use memmove() instead of memcpy() on a memory block that could overlap. Found by valgrind investigating this issue. ASTERISK-27238 ASTERISK-27412 Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde	8 years ago
George Joseph	7e874eae7a	app_record: Don't set RECORD_STATUS chan var until file is closed ... We've been calling pbx_builtin_setvar_helper to set the RECORD_STATUS variable before actually closing the recorded file. If a client is watching VarSet events and tries to do something with the file when a RECORD_STATUS event is seen, they might attempt to do so while the file it's still open. We now delay calling pbx_builtin_setvar_helper until after we close the file. ASTERISK-27423 Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254	8 years ago
George Joseph	062a4390ac	ast_coredumper: Add ability to use directory other than /tmp ... The OUTPUTDIR environment variable can now be set either in the environment itself or in ast_debug_tools.conf. If set, it's used for all work products instead of /tmp. Also added the --tarball-config option that includes the contents of /etc/asterisk when either --tarball-coredumps or --tarball-results are used. Change-Id: I66b2553319df61caea5b313d084f51978f730b4c	8 years ago
Joshua Colp	e25ec49b62	Merge "bundled_pjproject: Update to 2.7.1" into 13	8 years ago
Jenkins2	57fe717471	Merge "bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg" into 13	8 years ago
Jenkins2	d74b50ecf7	Merge "core: Fix configuration of remote console socket path." into 13	8 years ago
Jenkins2	d7303f6337	Merge "pjsip: Add patch to allow all transports to be destroyed." into 13	8 years ago
Joshua Colp	f233e421dd	Merge "core: Add cache_media_frames debugging option." into 13	8 years ago
Joshua Colp	c2dddb001a	pjsip / hep: Provide correct local address for Websockets. ... Previously for PJSIP the local address of WebSocket connections was set to the remote address. For logging purposes this is not particularly useful. The WebSocket API has been extended to allow the local address to be queried and this is used in PJSIP to set the local address to the correct value. The PJSIP HEP support has also been tweaked so that reliable transports always use the local address on the transport and do not try to (wrongly) guess. As they are connection based it is impossible for the source to be anything else. ASTERISK-26758 ASTERISK-27363 Change-Id: Icd305fd038ad755e2682ab2786e381f6bf29e8ca	8 years ago
Corey Farrell	b8209a1273	alertpipe: Correct documented return of ast_alertpipe_write. ... Change-Id: I4ea49c441890a81384144479dc93ab5a3989486d	8 years ago
Jenkins2	4aadd2e495	Merge "vectors: Add new macro and a string vector definition." into 13	8 years ago
Corey Farrell	9c6d4ec022	core: Fix configuration of remote console socket path. ... The remote console socket path is the combination of asterisk.conf settings astrundir from [directories] and astctl from [files]. Unconditionally combine the two strings after processing all values to ensure we end up with the correct socket path. ASTERISK-27415 Change-Id: Ib1e2805d55d6b0955c6430a1a2a93acbf9b091e8	8 years ago
Jenkins2	c7b7aefbc7	Merge "menuselect: Delete and ignore aclocal.m4." into 13	8 years ago
George Joseph	b5f2779a23	bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg ... The default return code for pjsip_find_msg was PJ_SUCCESS so if a Content-Length header wasn't found at all, pjsip_find_msg was returning PJ_SUCCESS instead of PJSIP_EMISSINGHDR. Also added the volatile keyword to a few variables that are used both inside and outside the PJ_TRY/PJ_CATCH block. Partial fix for ASTERISK_27408 Change-Id: If82ba9de921e3d57df9c68cf96ee45ccc1491f7a	8 years ago
Ben Ford	e6ada55430	bundled_pjproject: Update to 2.7.1 ... Update from 2.7 to 2.7.1 for bundled pjproject. Changed version and removed patch files included in the update. Change-Id: I55cea8e734b318c2df9daf86aa0802c559ec8357	8 years ago
Sean Bright	cf062303e3	sorcery: Add ast_sorcery_retrieve_by_prefix() ... Some consumers of the sorcery API use ast_sorcery_retrieve_by_regex only so that they can anchor the potential match as a prefix and not because they truly need regular expressions. Rather than using regular expressions for simple prefix lookups, add a new operation - ast_sorcery_retrieve_by_prefix - that does them. Patches against 13 and 15 have a compatibility layer needed to maintain ABI that is not needed in master. Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79	8 years ago
Corey Farrell	2ad6210dd7	vectors: Add new macro and a string vector definition. ... * AST_VECTOR_STEAL_ELEMENTS - steal the array of elements for use with non-vector code. * struct ast_vector_string - a vector of 'char *'. Change-Id: I104d1b204be03fccf67e02a195596adcb5ab1e42	8 years ago
Joshua Colp	b1743cb3c7	Merge "Build System: Disable parallel make in the root Makefile." into 13	8 years ago
Jenkins2	bcd2241c47	Merge "res_pjsip_pubsub: Ensure remote URI contains URI only." into 13	8 years ago
Corey Farrell	b03d389bec	menuselect: Delete and ignore aclocal.m4. ... This file is temporary output from the bootstrap.sh command, it does not need to be committed. Change-Id: Ie0fd113aff6eac44924c0bd0c900833c6c86a6d9	8 years ago
Richard Mudgett	507d9b5f9e	core: Add cache_media_frames debugging option. ... The media frame cache gets in the way of finding use after free errors of media frames. Tools like valgrind and MALLOC_DEBUG don't know when a frame is released because it gets put into the cache instead of being freed. * Added the "cache_media_frames" option to asterisk.conf. Disabling the option helps track down media frame mismanagement when using valgrind or MALLOC_DEBUG. The cache gets in the way of determining if the frame is used after free and who freed it. NOTE: This option has no effect when Asterisk is compiled with the LOW_MEMORY compile time option enabled because the cache code does not exist. To disable the media frame cache simply disable the cache_media_frames option in asterisk.conf and restart Asterisk. Sample asterisk.conf setting: [options] cache_media_frames=no ASTERISK-27413 Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00	8 years ago
Richard Mudgett	bb2173275a	frame.c: Make ast_frame_free()/ast_frfree() NULL tolerant ... Change-Id: Ic49d821ef88ada38a31bdd835b9531443c55d793	8 years ago
Jenkins2	1250b7c664	Merge "chan_pjsip.c: Fix uninitialized cause value on failure." into 13	8 years ago
Joshua Colp	360d50d74c	pjsip: Add patch to allow all transports to be destroyed. ... If a transport is created with the same transport type, source IP address, and source port as one that already exists the old transport is moved into a linked list called "tp_list". If this old transport is later shutdown it will not be destroyed as the process checks whether the transport is valid or not. This check does not look at the "tp_list" when making the determination causing the transport to not be destroyed. This change updates the logic to query not just the main storage method for transports but also the "tp_list". Upstream issue https://trac.pjsip.org/repos/ticket/2061 ASTERISK-27411 Change-Id: Ic5c2bb60226df0ef1c8851359ed8d4cd64469429	8 years ago
Corey Farrell	211f5d8dd4	core: Remove disabled code. ... handle_quit has been disabled since 2003, remove it. Change-Id: Idc3aaa6c81676160547078f9b71e8aa43de2db18	8 years ago
Jenkins2	6cce744401	Merge "stasis_bridges.c: Fix off-nominal json memory leaks." into 13	8 years ago
Corey Farrell	d12be40750	Build System: Disable parallel make in the root Makefile. ... This ensures that the root Makefile runs only a single target at a time. SUBMAKE will still honor requested parallelism, so 'make -j8' will build one directory at a time but allow 8 jobs at once when building a sub directory. This will fix some display glitches related to rebuild of XML documentation. It will also prevent some edge case errors where bundled pjproject needs to be rebuild before other parts of Asterisk. Change-Id: I4f2ec6fbbec1ada0ccb1109a28ea303524239b1e	8 years ago
Kevin Harwell	e3bc8f7815	Merge "res_pjsip_registrar.c: Fix named AOR and pjproject group deadlock." into 13	8 years ago
Richard Mudgett	32042c6c3c	chan_pjsip.c: Fix uninitialized cause value on failure. ... Change-Id: I3f9dd3c31bd582e54a30381500077de2319d8cc3	8 years ago
Joshua Colp	7296d3e5af	Merge "res_pjsip_history: Fix multiple leaks on vector append failure." into 13	8 years ago
Jenkins2	88d3773330	Merge "res_pjsip_pubsub: Fix multiple leaks on failure to append vectors." into 13	8 years ago
George Joseph	67d12d1437	Merge "AST-2017-009: pjproject: Add validation of numeric header values" into 13	8 years ago
George Joseph	62e70c70a5	Merge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected" into 13	8 years ago
George Joseph	b2fbf1afd7	Merge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun" into 13	8 years ago
Jenkins2	936a85419e	Merge "res_pjproject.c: Fix ast_strdup() alloc failure." into 13	8 years ago
Jenkins2	cdafec0f7a	Merge "res_pjsip_outbound_registration: Fix leak on vector add failure." into 13	8 years ago
Kevin Harwell	4b3e03ae87	AST-2017-011 - res_pjsip_session: session leak when a call is rejected ... A previous commit made it so when an invite session transitioned into a disconnected state destruction of the Asterisk pjsip session object was postponed until either a transport error occurred or the event timer expired. However, if a call was rejected (for instance a 488) before the session was fully established the event timer may not have been initiated, or it was canceled without triggering either of the session finalizing states mentioned above. Really the only time destruction of the session should be delayed is when a BYE is being transacted. This is because it's possible in some cases for the session to be disconnected, but the BYE is still transacting. This patch makes it so the session object always gets released (no more memory leak) when the pjsip session is in a disconnected state. Except when the method is a BYE. Then it waits until a transport error occurs or an event timeout. ASTERISK-27345 #close Reported by: Corey Farrell Change-Id: I1e724737b758c20ac76d19d3611e3d2876ae10ed	8 years ago
Richard Mudgett	2b85799512	AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun ... cdr_object_update_party_b_userfield_cb() could overrun the fixed buffer if the supplied string is too long. The long string could be supplied by external means using the CDR(userfield) function. This may seem reminiscent to AST-2017-001 (ASTERISK_26897) and it is. The earlier patch fixed the buffer overrun for Party A's userfield while this patch fixes the same thing for Party B's userfield. ASTERISK-27337 Change-Id: I0fa767f65ecec7e676ca465306ff9e0edbf3b652	8 years ago
George Joseph	2faa3e3bab	AST-2017-009: pjproject: Add validation of numeric header values ... Parsing the numeric header fields like cseq, ttl, port, etc. all had the potential to overflow, either causing unintended values to be captured or, if the values were subsequently converted back to strings, a buffer overrun. To address this, new "strto" functions have been created that do range checking and those functions are used wherever possible in the parser. * Created pjlib/include/limits.h and pjlib/include/compat/limits.h to either include the system limits.h or define common numeric limits if there is no system limits.h. * Created strto*_validate functions in sip_parser that take bounds and on failure call the on_str_parse_error function which prints an error message and calls PJ_THROW. * Updated sip_parser to validate the numeric fields. * Fixed an issue in sip_transport that prevented error messages from being properly displayed. * Added "volatile" to some variables referenced in PJ_CATCH blocks as the optimizer was sometimes optimizing them away. * Fixed length calculation in sip_transaction/create_tsx_key_2543 to account for signed ints being 11 characters, not 9. ASTERISK-27319 Reported by: Youngsung Kim at LINE Corporation Change-Id: I48de2e4ccf196990906304e8d7061f4ffdd772ff	8 years ago
Joshua Colp	4e8271c2a5	Merge "res_stasis: Fix multiple leaks." into 13	8 years ago
Jenkins2	fe78531d5e	Merge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure." into 13	8 years ago
Corey Farrell	16df0e9786	res_pjsip_pubsub: Fix multiple leaks on failure to append vectors. ... Change-Id: I68ece0073ea79667ca41eb10405f516f1d30d482	8 years ago
Corey Farrell	cf91dde509	res_pjsip_history: Fix multiple leaks on vector append failure. ... Change-Id: I41e8d5183ace284095cc721f3b1fb32ade3f940f	8 years ago