31176 Commits (5aee4f76550dffa37c21f95f3583c3ff0be44d46)

 

All Branches   

Search

Author	SHA1	Message	Date
George Joseph	5aee4f7655	channel.c: Resolve issue with receiving SIP INFO packets for DTMF ... The problem is essentially the same as in ASTERISK~28245. Besides the direct media scenario we have an additional scenario where a special client is involved. This device mutes audio by default in transmit direction (no rtp frames) and activates audio only by a foot switch. In this situation dtmf input (pin for conferences, transfer features codes , etc) using SIP INFO mode is not understood properly especially when SIP INFO messages are sent quickly. This patch ensures that SIP INFO frames are properly queued and processed in the above scenario. The patch also corrects situations where successive dtmf events are received quicker than the signalled event duration (plus minimum gap/pause) allows, i.e. DTMF events have to be buffered in the ast channel read queue and emulation has to be processed asynchronously at slower speed. Reported by: Thomas Arimont patches: trigger_dtmf_emulation.patch submitted by Thomas Arimont (license 5525) Change-Id: I309bf61dd065c9978c8e48f5b9a936ab47de64c2	6 years ago
Benjamin Keith Ford	2652720df4	Merge "res_pjsip_session.c: Check for port of zero on incoming SDP." into 13	6 years ago
Friendly Automation	80e9e986ad	Merge "manager.c: Prevent the Originate action from running the Originate app" into 13	6 years ago
Ben Ford	c2279540ba	chan_sip.c: Prevent address change on unauthenticated SIP request. ... If the name of a peer is known and a SIP request is sent using that peer's name, the address of the peer will change even if the request fails the authentication challenge. This means that an endpoint can be altered and even rendered unusuable, even if it was in a working state previously. This can only occur when the nat option is set to the default, or auto_force_rport. This change checks the result of authentication first to ensure it is successful before setting the address and the nat option. ASTERISK-28589 #close Change-Id: I581c5ed1da60ca89f590bd70872de2b660de02df	6 years ago
George Joseph	1b9281a5de	manager.c: Prevent the Originate action from running the Originate app ... If an AMI user without the "system" authorization calls the Originate AMI command with the Originate application, the second Originate could run the "System" command. Action: Originate Channel: Local/1111 Application: Originate Data: Local/2222,app,System,touch /tmp/owned If the "system" authorization isn't set, we now block the Originate app as well as the System, Exec, etc. apps. ASTERISK-28580 Reported by: Eliel Sardañons Change-Id: Ic4c9dedc34c426f03c8c14fce334a71386d8a5fa	6 years ago
Ben Ford	c257794330	res_pjsip_session.c: Check for port of zero on incoming SDP. ... If a re-invite comes in initiating T.38, but there is no c line in the SDP and the port is also 0, a crash can occur. A check is now done on the port to see if the steam is already declined, preventing the crash. The logic was moved to res_pjsip_session.c because it is handled in a similar manner in later versions of Asterisk. ASTERISK-28612 Reported by: Salah Ahmed Change-Id: Ifc4a0d05b32c7f2156e77fc8435a6ecaa6abada0	6 years ago
George Joseph	bb732e4292	Merge "app_senddtmf: Add receive mode to AMI Action PlayDTMF" into 13	6 years ago
Friendly Automation	955e331174	Merge "chan_dahdi: PRI span status may stay "Down, Active" after a short alarm" into 13	6 years ago
Kevin Harwell	e00381d8d0	Merge "res_pjsip_registrar: Fix uninitlized variable warning" into 13	6 years ago
Friendly Automation	7bcfcd3433	Merge "app_amd: Fixed timeout issue" into 13	6 years ago
Friendly Automation	243c1af2b9	Merge "func_curl.c: Support custom http headers" into 13	6 years ago
George Joseph	95213b01d2	CI: Fix missing script block in jenkinsfiles ... Change-Id: I9f44a3d5085ea7880fad1a3883a4820907e29ea3	6 years ago
Sean Bright	b03af8ba3c	res_pjsip_registrar: Fix uninitlized variable warning ... Fixes: error: ‘domain_name’ may be used uninitialized in this function Found with gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 Change-Id: I44413b49ea1205aa25538142161deb73883c79e8	6 years ago
George Joseph	d60f23ecbd	CI: Fix missing script block in jenkinsfiles ... Change-Id: Ib4b6e4887695f230ea7a5b0c879b29fc5a13be4f	6 years ago
George Joseph	7702ea986e	CI: Increase clone depth and do better cleanup ... The original clone depth of 10 was causing the need to rebase changes whose parent was older than the 10 commits. The clone depth has been increased to 100. Workspace cleanup was only happening for successful builds which wasn't enough to keep the 8G workspace in-memory drives on the docker slaves from filling up. Now the workspaces are cleaned up after every build regardless of success/failure. If you need to preserve builds temporarily, you can log into Jenkins/Manage Jenkins/Configure System and change the CLEANUP_WS_* environment variable for the job type you're troubleshooting to "FALSE". Change-Id: I0d7366e87cea714e5dbc9488caf718802fce75ca	6 years ago
Friendly Automation	8508a06706	Merge "serializer: set high/low alert levels on whole pool" into 13	6 years ago
George Joseph	c79db42573	Merge "parking: Fix case where we can't get the parker." into 13	6 years ago
Frederic LE FOLL	ad50410568	chan_dahdi: PRI span status may stay "Down, Active" after a short alarm ... Upon a short PRI disconnection, libpri may maintain Q.921 layer 'up' and may thus not send PRI_EVENT_DCHAN_DOWN / PRI_EVENT_DCHAN_UP events. If pri_event_alarm() clears DCHAN_UP status bit upon alarm detection and no Q.921 reconnection sequence occurs, chan_dahdi will keep seeing span status "Down" at the end of alarm. This patch modifies pri_event_alarm() in order to keep DCHAN_UP bit unchanged. libpri will send a PRI_EVENT_DCHAN_DOWN event if it detects a disconnection of Q.921 layer and this will clear DCHAN_UP if required. ASTERISK-28615 Change-Id: Ibe27df4971fd4c82cc6850020bce4a8b2692c996	6 years ago
lvl	17c393377e	app_senddtmf: Add receive mode to AMI Action PlayDTMF ... ASTERISK-28614 Change-Id: I183501297ae1dc294ae56b34acac9b0343eb2664	6 years ago
Alexei Gradinari	26fc3a3127	serializer: set high/low alert levels on whole pool ... The current code sets alert levels starting from index 1. Need to set on whole pool starting from index 0. Change-Id: I5decbb43160954fb9a512f04302637fc666b6f5d	6 years ago
George Joseph	ab28da7c9d	Merge "func_env: Prevent FILE() from reading garbage at end-of-file" into 13	6 years ago
Friendly Automation	a42f3ff3b7	Merge "res_rtp_asterisk: Always return provided DTLS packet length." into 13	6 years ago
Friendly Automation	803bc786f6	Merge "various files - fix some alerts raised by lgtm code analysis" into 13	6 years ago
Friendly Automation	e82a91ee1c	Merge "bridge_softmix: clear hold when joining a softmix bridge" into 13	6 years ago
Martin Tomec	f032b8c158	func_curl.c: Support custom http headers ... When user wants to send json data, the default Content-Type header is incorect (application/x-www-form-urlencoded). This patch allows to set any custom headers so the Content-Type header can be overriden. User can set multiple headers by multiple calls of curlopt(). This approach is not consistent with other parameters, but is more readable in dialplan than one call with multiple headers. ASTERISK-28613 Change-Id: I4dd68c3f4e25362ef941d73a3861f58348dcfbf9	6 years ago
Joshua Colp	eb3b49928e	parking: Fix case where we can't get the parker. ... ASTERISK-28616 Change-Id: Iabe31ae38d01604284fcc5c2438d44e29a32ea4d	6 years ago
George Joseph	7a236ed20d	stasis: Don't hold app_registry and session locks unnecessarily ... resource_events:app_handler() was locking the session, then attempting to determine if the app had debug enabled which locked the app_registry container. res_stasis:__stasis_app_register was locking the app_registry container then calling app_update which caused app_handler (which locks the session) to run. The result was a deadlock. * Updated resource_events:app_handler() to determine if debug was set (which locks the app_registry) before obtaining the session lock. * Updated res_stasis:__stasis_app_register to release the app_registry container lock before calling app_update (which locks the sesison). ASTERISK-28423 Reported by Ross Beer Change-Id: I58c69d08cb372852a63933608e4d6c3e456247b4	6 years ago
Michael Cargile	9361e32bed	app_amd: Fixed timeout issue ... ASTERISK_28143 attempted to fix an issue where calls with no audio would never timeout. It did so by adding AST_FRAME_NULL as a frame type to process in its calculations. Unfortunately these frames seem to show up at irregular time intervals. This resulted in app_amd returning prematurely most of the time. * Removed AST_FRAME_NULL from the calculations * Added a check to see how much time has actually passed since app_amd began ASTERISK-28608 Change-Id: I642a21b02d389b17e40ccd5357754b034c3daa42	6 years ago
Joshua Colp	6856cdc6ba	res_rtp_asterisk: Always return provided DTLS packet length. ... OpenSSL can not tolerate if the packet sent out does not match the length that it provided to the sender. This change lies and says that each time the full packet was sent. If a problem does occur then a retransmission will occur as appropriate. ASTERISK-28576 Change-Id: Id42455b15c9dc4eb987c8c023ece6fbf3c22a449	6 years ago
Kevin Harwell	300e21662c	bridge_softmix: clear hold when joining a softmix bridge ... MOH continues to play to a channel if that channel was on hold prior to entering a softmix bridge. MOH will not stop even if the original "holder" attempts an unhold. For the most part a softmix bridge ignores holds, so a participating channel shouldn't join while on hold. This patch checks to see if the channel joining the softmix bridge is currently on hold. If so then it indicates an unhold. ASTERISK-28618 Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b	6 years ago
Joshua Colp	3b94982b4f	parking: Use channel snapshot instead of channel. ... There exists a scenario where a thread can hold a lock on the channels container while trying to lock a bridge. At the same time another thread can hold the lock for said bridge while attempting to retrieve a channel. This causes a deadlock. This change fixes this scenario by retrieving a channel snapshot instead of a channel, as information present in the snapshot is all that is needed. ASTERISK-28616 Change-Id: I68ceb1d62c7378addcd286e21be08a660a7cecf2	6 years ago
Sean Bright	e5d0add8c6	func_env: Prevent FILE() from reading garbage at end-of-file ... If the last line of a file does not have a terminating EOL sequence, we potentially add garbage to the value returned from the FILE() function. There is no overflow potential here as we are reading from a buffer of a known size, we are just reading too much of it. ASTERISK-26481 #close Change-Id: I50dd4fcf416fb3c83150040a1a79a59d9eb1ae01	6 years ago
Kevin Harwell	6ca76798e1	various files - fix some alerts raised by lgtm code analysis ... This patch fixes several issues reported by the lgtm code analysis tool: https://lgtm.com/projects/g/asterisk/asterisk Not all reported issues were addressed in this patch. This patch mostly fixes confirmed reported errors, potential problematic code points, and a few other "low hanging" warnings or recommendations found in core supported modules. These include, but are not limited to the following: * innapropriate stack allocation in loops * buffer overflows * variable declaration "hiding" another variable declaration * comparisons results that are always the same * ambiguously signed bit-field members * missing header guards Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25	6 years ago
George Joseph	7a85a947af	cdr_mysql: Fix missing use of 'my_bool' with MySql >= 8.0.1 ... MySql 8.0.1 replaced the "my_bool" type with "bool" so an #if was added to use "bool" with MYSQL_VERSION_ID >= 80001. ASTERISK-28604 Change-Id: I66a28d8f0011e33774edee13a6f8efd2302bb920	6 years ago
Joshua Colp	9c8424a97b	res_pjsip_outbound_registration: Extend documentation for "max_retries". ... If the "max_retries" option is set to 0 then upon failure no further attemps are made, so explicitly document the behavior. ASTERISK-28602 Change-Id: I1e30daae9dd6c49ce18744164214d3def505acbf	6 years ago
Friendly Automation	854a8014ce	Merge "res_calendar: Resolve memory leak on calendar destruction" into 13	6 years ago
Sean Bright	27fc662cf2	res_calendar: Resolve memory leak on calendar destruction ... Calling ne_uri_parse allocates memory that needs to be freed with a corresponding call to ne_uri_free. ASTERISK-28572 #close Change-Id: I8a6834da27000a6807d89cb7a157b2a88fcb5e61	6 years ago
Joshua Colp	50feafe9b8	res_ari_events: Add module reference when a WebSocket is open. ... This change ensures that the module isn't unloaded when a WebSocket is open. Previously it was possible to unload the module manually or during shutdown which could cause a crash when any active WebSockets were terminated. ASTERISK-28585 Change-Id: I85c71ab112f99875b586419a34c08c8b34c14c5c	6 years ago
Friendly Automation	6f2431cb13	Merge "utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN" into 13	6 years ago
Sean Bright	f1e3a13579	utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN ... ASTERISK-28590 #close Change-Id: I51abce00c04d0a06550bda5205580705185b9c1c	6 years ago
Friendly Automation	8e42a55ebd	Merge "app_voicemail.c: Support multiple file formats for forwarded messages." into 13	6 years ago
Friendly Automation	c56663b2cf	Merge "Crash during "pjsip show channelstats" execution" into 13	6 years ago
Sean Bright	0cccfcba9e	README-SERIOUSLY.bestpractices.md: Speling correetions. ... ASTERISK-28586 #close Change-Id: I43dc4e8bd9dc685b17695b215a5360314074734f	6 years ago
Salah Ahmed	414eebcbc9	Crash during "pjsip show channelstats" execution ... During execution "pjsip show channelstats" cli command by an external module asterisk crashed. It seems this is a separate thread running to fetch and print rtp stats. The crash happened on the ao2_lock method, just before it going to read the rtp stats on a rtp instance. According to gdb backtrace log, it seems the session media was already cleaned up at that moment. ASTERISK-28578 Change-Id: Ia918bfa3c8119060633e39b14852e8d983e0417e	6 years ago
cmaj	c8e38f8550	app_voicemail.c: Support multiple file formats for forwarded messages. ... If you specify multiple formats in voicemail.conf, eg. "format = gsm|wav" and are using realtime ODBC backend, only the first format gets stored in the database. So when you forward a message later on, there is a bug generating the email, related to the stored format (GSM) being different than the desired email format (WAV) specified for the user. Sox can handle this, but Asterisk needs to tell sox exactly what to do. ASTERISK-22192 Change-Id: I7321e7f7e7c58adbf41dd4fd7191c887b9b2eafd	6 years ago
Friendly Automation	78ad383837	Merge "res_pjsip_mwi: potential double unref, and potential unwanted double link" into 13	6 years ago
Friendly Automation	59487acfb8	Merge "pbx: deadlock when outgoing dialed channel hangs up too quickly" into 13	6 years ago
Joshua Colp	337e4ed671	Merge "cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12" into 13	6 years ago
Christoph Moench-Tegeder	a7749f4fcd	cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12 ... PostgreSQL 12 finally removed column adsrc from table pg_catalog.pg_attrdef (column default values), which has been deprecated since version 8.0. Since then, the official/correct/supported way to retrieve the column default value from the catalog is function pg_catalog.pg_get_expr(). This change breaks compatibility with pre-8.0 PostgreSQL servers, but has reached end-of-support more than a decade ago. cdr_pgsql and res_config_pgsql still have support for pre-7.3 servers, but cleaning that up is perhaps a topic for a major release, not this bugfix. ASTERISK-28571 Change-Id: I834cb3addf1937e19e87ede140bdd16cea531ebe	6 years ago
George Joseph	91d5094464	Merge "pjproject_bundled: Replace earlier reverts with official fixes." into 13	6 years ago