asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	503d8cc2c6	Add libjwt to third-party The current STIR/SHAKEN implementation is not currently usable due to encryption issues. Rather than trying to futz with OpenSSL and the the current code, we can take advantage of the existing capabilities of libjwt but we first need to add it to the third-party infrastructure already in place for jansson and pjproject. A few tweaks were also made to the third-party infrastructure as a whole. The jansson "dest" install directory was renamed "dist" to better match convention, and the third-party Makefile was updated to clean all product directories not just the ones currently in use. Resolves: #349 (cherry picked from commit `733ab35848`)	2 years ago
Mike Bradeen	d6592f038d	res_pjsip: update qualify_timeout documentation with DNS note The documentation on qualify_timeout does not explicitly state that the timeout includes any time required to perform any needed DNS queries on the endpoint. If the OPTIONS response is delayed due to the DNS query, it can still render an endpoint as Unreachable if the net time is enough for qualify_timeout to expire. Resolves: #352 (cherry picked from commit `7369de127a`)	2 years ago
George Joseph	6415562a14	lock.c: Separate DETECT_DEADLOCKS from DEBUG_THREADS Previously, DETECT_DEADLOCKS depended on DEBUG_THREADS. Unfortunately, DEBUG_THREADS adds a lot of lock tracking overhead to all of the lock lifecycle calls whereas DETECT_DEADLOCKS just causes the lock calls to loop over trylock in 200us intervals until the lock is obtained and spits out log messages if it takes more than 5 seconds. From a code perspective, the only reason they were tied together was for logging. So... The ifdefs in lock.c were refactored to allow DETECT_DEADLOCKS to be enabled without also enabling DEBUG_THREADS. Resolves: #321 UserNote: You no longer need to select DEBUG_THREADS to use DETECT_DEADLOCKS. This removes a significant amount of overhead if you just want to detect possible deadlocks vs needing full lock tracing. (cherry picked from commit `04183eb246`)	2 years ago
Mike Bradeen	a669ccbc3d	cel: add publish user event helper Add a wrapper function around ast_cel_publish_event that packs event and extras into a blob before publishing Resolves:#330 (cherry picked from commit `5c58a6fd56`)	2 years ago
George Joseph	ed02f1c737	file.c: Add ability to search custom dir for sounds To better co-exist with sounds files that may be managed by packages, custom sound files may now be placed in AST_DATA_DIR/sounds/custom instead of the standard AST_DATA_DIR/sounds/<lang> directory. If the new "sounds_search_custom_dir" option in asterisk.conf is set to "true", asterisk will search the custom directory for sounds files before searching the standard directory. For performance reasons, the "sounds_search_custom_dir" defaults to "false". Resolves: #315 UserNote: A new option "sounds_search_custom_dir" has been added to asterisk.conf that allows asterisk to search AST_DATA_DIR/sounds/custom for sounds files before searching the standard AST_DATA_DIR/sounds/<lang> directory. (cherry picked from commit `7b42ebb90d`)	2 years ago
George Joseph	ddd78228f5	make_buildopts_h, et. al. Allow adding all cflags to buildopts.h The previous behavior of make_buildopts_h was to not add the non-ABI-breaking MENUSELECT_CFLAGS like DETECT_DEADLOCKS, REF_DEBUG, etc. to the buildopts.h file because "it caused ccache to invalidate files and extended compile times". They're only defined by passing them on the gcc command line with '-D' options. In practice, including them in the include file rarely causes any impact because the only time ccache cares is if you actually change an option so the hit occurrs only once after you change it. OK so why would we want to include them? Many IDEs follow the include files to resolve defines and if the options aren't in an include file, it can cause the IDE to mark blocks of "ifdeffed" code as unused when they're really not. So... * Added a new menuselect compile option ADD_CFLAGS_TO_BUILDOPTS_H which tells make_buildopts_h to include the non-ABI-breaking flags in buildopts.h as well as the ABI-breaking ones. The default is disabled to preserve current behavior. As before though, only the ABI-breaking flags appear in AST_BUILDOPTS and only those are used to calculate AST_BUILDOPT_SUM. A new AST_BUILDOPT_ALL define was created to capture all of the flags. * make_version_c was streamlined to use buildopts.h and also to create asterisk_build_opts_all[] and ast_get_build_opts_all(void) * "core show settings" now shows both AST_BUILDOPTS and AST_BUILDOPTS_ALL. UserNote: The "Build Options" entry in the "core show settings" CLI command has been renamed to "ABI related Build Options" and a new entry named "All Build Options" has been added that shows both breaking and non-breaking options. (cherry picked from commit `8d506370f5`)	2 years ago
Mike Bradeen	5e8702f557	func_periodic_hook: Add hangup step to avoid timeout func_periodic_hook does not hangup after playback, relying on hangup which keeps the channel alive longer than necessary. Resolves: #325 (cherry picked from commit `cf623753a9`)	2 years ago
George Joseph	4e606d018b	func_periodic_hook: Don't truncate channel name func_periodic_hook was truncating long channel names which causes issues when you need to run other dialplan functions/apps on the channel. Resolves: #319 (cherry picked from commit `2e59f9fd6a`)	2 years ago
George Joseph	32bb90e11f	safe_asterisk: Change directory permissions to 755 If the safe_asterisk script detects that the /var/lib/asterisk directory doesn't exist, it now creates it with 755 permissions instead of 770. safe_asterisk needing to create that directory should be extremely rare though because it's normally created by 'make install' which already sets the permissions to 755. Resolves: #316 (cherry picked from commit `4e43b9d308`)	2 years ago
Joshua C. Colp	ce130d74e3	variables: Add additional variable dialplan functions. Using the Set dialplan application does not actually delete channel or global variables. Instead the variables are set to an empty value. This change adds two dialplan functions, GLOBAL_DELETE and DELETE which can be used to delete global and channel variables instead of just setting them to empty. There is also no ability within the dialplan to determine if a global or channel variable has actually been set or not. This change also adds two dialplan functions, GLOBAL_EXISTS and VARIABLE_EXISTS which can be used to determine if a global or channel variable has been set or not. Resolves: #289 UserNote: Four new dialplan functions have been added. GLOBAL_DELETE and DELETE have been added which allows the deletion of global and channel variables. GLOBAL_EXISTS and VARIABLE_EXISTS have been added which checks whether a global or channel variable has been set. (cherry picked from commit `405a08aaed`)	2 years ago
George Joseph	db0594af83	ari-stubs: Fix more local anchor references Also allow CreateDocs job to be run manually with default branches. (cherry picked from commit `3d01cbaae9`)	2 years ago
George Joseph	2809429b08	ari-stubs: Fix more local anchor references Also allow CreateDocs job to be run manually with default branches. (cherry picked from commit `2f1d12b7dc`)	2 years ago
George Joseph	3de5740fbf	ari-stubs: Fix broken documentation anchors All of the links that reference page anchors with capital letters in the ids (#Something) have been changed to lower case to match the anchors that are generated by mkdocs. (cherry picked from commit `e54d867f25`)	2 years ago
George Joseph	cd95c0f9c9	rest-api: Updates for new documentation site The new documentation site uses traditional markdown instead of the Confluence flavored version. This required changes in the mustache templates and the python that generates the files. (cherry picked from commit `d2172582f7`)	2 years ago
George Joseph	4cd5e2cc37	.github: Update workflow-application-token-action to v2 (cherry picked from commit `56e592248d`)	2 years ago
Mike Bradeen	f9c52ea676	app_voicemail: Fix for loop declarations Resolve for loop initial declarations added in cli changes. Resolves: #275 (cherry picked from commit `8f5fb2af23`)	2 years ago
George Joseph	c8373ce5e4	download_externals: Fix a few version related issues * Fixed issue with the script not parsing the new tag format for certified releases. The format changed from certified/18.9-cert5 to certified-18.9-cert5. * Fixed issue where the asterisk version wasn't being considered when looking for cached versions. Resolves: #263 (cherry picked from commit `bebf843253`)	2 years ago
George Joseph	34acfac3b8	Remove .lastclean and .version from source control Historically these were checked in for certified releases but since the move to github and the unified release process, they are no longer needed and cause issues. (cherry picked from commit `87773dc11f`)	2 years ago
George Joseph	ed7a57c959	.github: Use generic releaser (cherry picked from commit `a95f98f8bb`)	2 years ago
Joshua C. Colp	b0ec10f9da	manager: Tolerate stasis messages with no channel snapshot. In some cases I have yet to determine some stasis messages may be created without a channel snapshot. This change adds some tolerance to this scenario, preventing a crash from occurring. (cherry picked from commit `c83c14ba2d`)	2 years ago
Joshua C. Colp	e14b1d7a3c	audiohook: Unlock channel in mute if no audiohooks present. In the case where mute was called on a channel that had no audiohooks the code was not unlocking the channel, resulting in a deadlock. Resolves: #233 (cherry picked from commit `b37b28e071`)	2 years ago
Joshua C. Colp	034ac1a407	app_queue: Add support for applying caller priority change immediately. The app_queue module provides both an AMI action and a CLI command to change the priority of a caller in a queue. Up to now this change of priority has only been reflected to new callers into the queue. This change adds an "immediate" option to both the AMI action and CLI command which immediately applies the priority change respective to the other callers already in the queue. This can allow, for example, a caller to be placed at the head of the queue immediately if their priority is sufficient. Resolves: #202 UserNote: The 'queue priority caller' CLI command and 'QueueChangePriorityCaller' AMI action now have an 'immediate' argument which allows the caller priority change to be reflected immediately, causing the position of a caller to move within the queue depending on the priorities of the other callers. (cherry picked from commit `82c0971e6e`)	2 years ago
George Joseph	fc64d2a8da	.github: Fix cherry-pick reminder issues (cherry picked from commit `8aba4a4f88`)	2 years ago
George Joseph	cf31de0d9b	app.h: Move declaration of ast_getdata_result before its first use The ast_app_getdata() and ast_app_getdata_terminator() declarations in app.h were changed recently to return enum ast_getdata_result (which is how they were defined in app.c). The existing declaration of ast_getdata_result in app.h was about 1000 lines after those functions however so under certain circumstances, a "use before declaration" error was thrown by the compiler. The declaration of the enum was therefore moved to before those functions. Resolves: #200 (cherry picked from commit `e46f7892a6`)	2 years ago
George Joseph	e4cbf94170	doc: Remove obsolete CHANGES-staging and UPGRADE-staging (cherry picked from commit `7c84bf40e0`)	2 years ago
Sean Bright	f144a772fa	res_geolocation: Ensure required 'location_info' is present. Fixes #189 (cherry picked from commit `836f0bed18`)	2 years ago
Mike Bradeen	3e762943fb	Adds manager actions to allow move/remove/forward individual messages in a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a VoicemailBoxSummarry, required to retrieve message ID's. Resolves: #181 UserNote: The following manager actions have been added VoicemailBoxSummary - Generate message list for a given mailbox VoicemailRemove - Remove a message from a mailbox folder VoicemailMove - Move a message from one folder to another within a mailbox VoicemailForward - Copy a message from one folder in one mailbox to another folder in another or the same mailbox. (cherry picked from commit `4929a2c419`)	2 years ago
Mike Bradeen	c0ed7b023b	app_voicemail: add CLI commands for message manipulation Adds CLI commands to allow move/remove/forward individual messages from a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a show mailbox, required to retrieve message ID's. Resolves: #170 UserNote: The following CLI commands have been added to app_voicemail voicemail show mailbox <mailbox> <context> Show contents of mailbox <mailbox>@<context> voicemail remove <mailbox> <context> <from_folder> <messageid> Remove message <messageid> from <from_folder> in mailbox <mailbox>@<context> voicemail move <mailbox> <context> <from_folder> <messageid> <to_folder> Move message <messageid> in mailbox <mailbox>&<context> from <from_folder> to <to_folder> voicemail forward <from_mailbox> <from_context> <from_folder> <messageid> <to_mailbox> <to_context> <to_folder> Forward message <messageid> in mailbox <mailbox>@<context> <from_folder> to mailbox <mailbox>@<context> <to_folder> (cherry picked from commit `8f8413b494`)	2 years ago
George Joseph	673d3ef945	.github: Minor tweak to Asterisk Releaser (cherry picked from commit `3bb5cef959`)	2 years ago
George Joseph	4850ab66e7	.github: Suppress cherry-pick reminder for some situations In PROpenedOrUpdated, the cherry-pick reminder will now be suppressed if there are already valid 'cherry-pick-to' comments in the PR or the PR contained a 'cherry-pick-to: none' comment. (cherry picked from commit `e1e294a5e3`)	2 years ago
George Joseph	a168011319	Cleanup deleted files	2 years ago
Asterisk Development Team	b5979e2cb4	Update for certified-18.9-cert7	2 years ago
George Joseph	390a994e6c	res_rtp_asterisk: Fix regression issues with DTLS client check * Since ICE candidates are used for the check and pjproject is required to use ICE, res_rtp_asterisk was failing to compile when pjproject wasn't available. The check is now wrapped with an #ifdef HAVE_PJPROJECT. * The rtp->ice_active_remote_candidates container was being used to check the address on incoming packets but that container doesn't contain peer reflexive candidates discovered during negotiation. This was causing the check to fail where it shouldn't. We now check against pjproject's real_ice->rcand array which will contain those candidates. * Also fixed a bug in ast_sockaddr_from_pj_sockaddr() where we weren't zeroing out sin->sin_zero before returning. This was causing ast_sockaddr_cmp() to always return false when one of the inputs was converted from a pj_sockaddr, even if both inputs had the same address and port. Resolves: #500 Resolves: #503 Resolves: #505	2 years ago
Asterisk Development Team	35e0c6c0f4	Update for certified-18.9-cert6	2 years ago
Gitea	22ae979dfc	res_pjsip_header_funcs: Duplicate new header value, don't copy. When updating an existing header the 'update' code incorrectly just copied the new value into the existing buffer. If the new value exceeded the available buffer size memory outside of the buffer would be written into, potentially causing a crash. This change makes it so that the 'update' now duplicates the new header value instead of copying it into the existing buffer.	2 years ago
George Joseph	096819ec8a	res_rtp_asterisk.c: Check DTLS packets against ICE candidate list When ICE is in use, we can prevent a possible DOS attack by allowing DTLS protocol messages (client hello, etc) only from sources that are in the active remote candidates list. Resolves: GHSA-hxj9-xwr8-w8pq	2 years ago
Ben Ford	11e772c642	manager.c: Prevent path traversal with GetConfig. When using AMI GetConfig, it was possible to access files outside of the Asterisk configuration directory by using filenames with ".." and "./" even while live_dangerously was not enabled. This change resolves the full path and ensures we are still in the configuration directory before attempting to access the file.	2 years ago
Mike Bradeen	c4c0007b70	res_pjsip: disable raw bad packet logging Add patch to split the log level for invalid packets received on the signaling port. The warning regarding the packet will move to level 2 so that it can still be displayed, while the raw packet will be at level 4.	2 years ago
Asterisk Development Team	b2a1aa2d10	Update for certified-18.9-cert5	2 years ago
Sean Bright	58b865a6f3	apply_patches: Use globbing instead of file/sort. This accomplishes the same thing as a `find ... \| sort` but with the added benefit of clarity and avoiding a call to a subshell. Additionally drop the -s option from call to patch as it is not POSIX.	2 years ago
George Joseph	3a045074ff	apply_patches: Sort patch list before applying The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193	2 years ago
George Joseph	7aaa1884ac	bundled_pjproject: Backport security fixes from pjproject 2.13.1 Merge-pull-request-from-GHSA-9pfh-r8x4-w26w.patch Merge-pull-request-from-GHSA-cxwq-5g9x-x7fr.patch Locking-fix-so-that-SSL_shutdown-and-SSL_write-are-n.patch Don-t-call-SSL_shutdown-when-receiving-SSL_ERROR_SYS.patch Resolves: #188	2 years ago
George Joseph	72310e6b5d	.github: Updates for AsteriskReleaser	2 years ago
Mike Bradeen	9a4a097b37	res_musiconhold: avoid moh state access on unlocked chan Move channel unlock to after moh state access to avoid potential unlocked access to state. Resolves: #133	2 years ago
Mike Bradeen	2915ce3cb9	utils: add lock timestamps for DEBUG_THREADS Adds last locked and unlocked timestamps as well as a counter for the number of times the lock has been attempted (vs locked/unlocked) to debug output printed using the DEBUG_THREADS option. Resolves: #110	2 years ago
George Joseph	a46456ef44	.github: Back out triggering PROpenedOrUpdated by label	2 years ago
George Joseph	03c83527e5	.github: Move publish docs to new file CreateDocs.yml	2 years ago
George Joseph	5cc2629bf2	.github: Remove result check from PROpenUpdateGateTests	2 years ago
George Joseph	1e020207d1	.github: Fix use of 'contains'	2 years ago
George Joseph	ac53428da1	.github: Add recheck label test to additional jobs	2 years ago

1 2 3 4 5 ...

33285 Commits (503d8cc2c6b78a643ecc24cf6acba7baf93586f0) All Branches Search

33285 Commits (503d8cc2c6b78a643ecc24cf6acba7baf93586f0)

All Branches