26557 Commits (478fb4a388afcb56e7e50184c996f0838d609a66)

 

All Branches   

Search

Author	SHA1	Message	Date
Corey Farrell	478fb4a388	MALLOC_DEBUG: Replace WRAP_LIBC_MALLOC with ASTMM_LIBC. ... There are 3 ways that calls directly to standard allocator functions can be dealt with: 1. Block their use, cause them to generate an error. This is the default. 2. Replace them with the Asterisk equivalent function calls. 3. Leave them alone. This change allows one of these 3 options to be selected by any source. The source just needs to define ASTMM_LIBC to ASTMM_BLOCK, ASTMM_REDIRECT, or ASTMM_IGNORE to use option 1, 2 or 3 respectively. Normally ASTMM_BLOCK is the correct option, so it is default when ASTMM_LIBC is not defined. In some cases when building 3rd party code it is desirable to have it use Asterisk functions, without changing the whole source - ASTMM_REDIRECT accomplishes this. When using 3rd party libraries sometimes a static inline function will make use of malloc or free. In these cases it may be unsafe to replace the allocator in the header, as it's possible the memory could be freed by the library using standard allocators. For those cases ASTMM_IGNORE is needed. Change-Id: I8afef4bc7f3b93914263ae27d3a5858b69663fc7	10 years ago
Joshua Colp	3858e67dd5	Merge "Allow command-line options to override asterisk.conf."	10 years ago
Joshua Colp	29513333e1	Merge "cdr: standardizes tab for options of AST_MODULE_INFO"	10 years ago
Corey Farrell	57386dcb67	Allow command-line options to override asterisk.conf. ... Previous versions of Asterisk processed command-line options before processing asterisk.conf. This meant that if an option was set in asterisk.conf, it could not be overridden with the equivelent command line option. This change causes Asterisk to process the command-line twice. First it processes options that are needed to load asterisk.conf, then it processes the remaining options after the config is read. This changes the function of -X slightly. Previously using -X without disabling execincludes in asterisk.conf caused #exec to be usable in any config. Now -X only enables #exec for the load of asterisk.conf, if it is wanted in the rest of the system it must be enabled with execincludes in asterisk.conf. Updated 'asterisk -h' and 'man asterisk' to reflect the limited function of -X. ASTERISK-25042 #close Reported by: Corey Farrell Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7	10 years ago
Corey Farrell	cc853dcf90	Fix processing of asterisk.conf debug=yes. ... The code which reads asterisk.conf supports processing the debug option with ast_true, but ast_true returns -1. This causes debug to still be off, convert to 1 so debug will be on as requested. ASTERISK-25042 Reported by: Corey Farrell Change-Id: I3c898b7d082d914b057e111b9357fde46bad9ed6	10 years ago
Joshua Colp	58d0db347e	Merge "vector: Add REMOVE, ADD_SORTED and RESET macros"	10 years ago
Joshua Colp	9bb9d22563	Merge "pbx/pbx_spool: Fix issue when call files were executed too early"	10 years ago
Joshua Colp	4f84142c94	Merge "dns_srv: Fix SRV sorting when records with priority zero exist with non-zero."	10 years ago
George Joseph	87d8b36755	vector: Add REMOVE, ADD_SORTED and RESET macros ... Based on feedback from Corey Farrell and Y Ateya, a few new macros have been added... AST_VECTOR_REMOVE which takes a parameter to indicate if order should be preserved. AST_VECTOR_ADD_SORTED which adds an element to a sorted vector. AST_VECTOR_RESET which cleans all elements from the vector leaving the storage intact. Change-Id: I41d32dbdf7137e0557134efeff9f9f1064b58d14	10 years ago
Ivan Poddubny	e6ebddd9ae	pbx/pbx_spool: Fix issue when call files were executed too early ... pbx_spool used to delete/move the call file upon successful outgoing call completion, but did not delete it from in-memory list of files (dirlist, used only when compiled with inotify/kqueue support). That resulted in an extra attempt to process that filename after retrytime seconds. Then, if a new file with the same name appears that is scheduled in future further than the completed one plus its retrytime, then it gets executed earlier than expected. This patch fixes remove_from_queue function to also remove the entry from the dirlist. ASTERISK-17069 #close Reported by: Jeremy Kister ASTERISK-24442 #close Reported by: tootai Change-Id: If9ec9b88073661ce485d6b008fd0b2612e49a28b	10 years ago
Joshua Colp	4da2934592	Merge "main/asterisk.c: Update Asterisk copyright year"	10 years ago
Joshua Colp	4907209823	Merge "utils: Remove trailing whitespace"	10 years ago
Joshua Colp	7b7bef722c	Merge "Fix error's produced by astmm.h when standard allocators are used."	10 years ago
Joshua Colp	f82bd76e3c	dns_srv: Fix SRV sorting when records with priority zero exist with non-zero. ... The DNS SRV sorting code currently has an issue when records with a priority of zero exist with records of a non-zero priority. This occurs because the sorting code considers zero to mean unset when in reality is a valid value. If the current priority is zero it will get replaced with any remaining record that has a priority of non-zero, until no records of those exist after which the records of priority zero are handled. This change makes it so that the priority of the first remaining record is the current starting priority. There is also a small optimization to prevent iterating records when the starting priority is already zero. Change-Id: I103511f35b50428f770bd4db3ffef70fb6f82d35	10 years ago
Joshua Colp	4f0d2320d0	Merge "configs/basic-pbx: Modified main IVR to play new Allison prompt."	10 years ago
Matt Jordan	32eb812b28	Merge "Fix crash in codec_lpc10 when MALLOC_DEBUG is enabled."	10 years ago
Rusty Newton	5e361e1476	configs/basic-pbx: Modified main IVR to play new Allison prompt. ... The main IVR was playing demo-congrats. I've switched it over to the basic-pbx-ivr-main file that we added in core sounds 1.4.27. This prompt has Allison prompting the user with the actual IVR menu. ASTERISK-24892 #close Change-Id: Ifb749616ff8e156a1031ddaddfcc9244767a095d	10 years ago
Corey Farrell	2d4dc0c963	Fix error's produced by astmm.h when standard allocators are used. ... astmm.h includes defines that are meant to cause error's when standard allocators (malloc, calloc, free, etc) are used. It actually only causes a warning, which is not always caught on certain sources. In modules this unknown symbol is not detected until runtime, where the module fails to load. This modifies the define's so that using one of the blocked functions will cause a compile error regardless of CFLAGS. Moved spandsp header includes to before asterisk.h so the static inline functions can continue using malloc and free. Although these functions are never called and optimized away, the updated replacement macro's would still cause a failure. Change-Id: I532640aca0913ba9da3b18c04a0f010ca1715af5	10 years ago
Sean Bright	63c71c9f4a	res_rtp_asterisk: Issue ERROR if res_srtp is not found. ... While trying to get WebRTC working with chan_pjsip, I was running into the following error: Attempted to set an invalid DTLS-SRTP configuration on RTP instance... Josh helpfully pointed out that res_srtp.so might not be loaded, and sure enough, it wasn't. This patch adds a ERROR indiciating as much to hopefully help others having a similar problem. Change-Id: I13aa477b47b299876728a21b130998a0ea6cd19f	10 years ago
Matt Jordan	f2d147a838	Merge "sounds: Add Swedish sounds to Makefile and XML"	10 years ago
Rusty Newton	60bf9ed91a	sounds: Add Swedish sounds to Makefile and XML ... Added the necessary lines to the Makefile and sounds.xml so we'll have the Swedish sounds in all available formats in menuselect. See also: Swedish sounds were added into the core sounds release 1.4.27. ASTERISK-24744 #close Reported by: Tove Hjelm Tested by: Rusty Newton Change-Id: Ib6f4fd177afd1667b2402735034001d4d055a908	10 years ago
Corey Farrell	f93b3a22d6	Fix crash in codec_lpc10 when MALLOC_DEBUG is enabled. ... This switches codecs/lpc10/lpcini.c back to including "asterisk.h" instead of <stdlib.h>. lpcini.c allocates memory that is freed by codec_lpc10.c, so it is important to use MALLOC_DEBUG allocator. Added #define WRAP_LIBC_MALLOC to the start of the source to prevent runtime symbol link error's. Change-Id: I74f63fd09fdeb673ee7753122c3bb4722ab6e1ac	10 years ago
George Joseph	cf637f2510	doc: Make progdocs play nice with git ... Moved contrib/asterisk-ng-doxygen to doc/asterisk-ng-doxygen.in Changed /Makefile to copy asterisk-ng-doxygen.in to asterisk-ng-doxygen then modify it with version instead of modifying asterisk-ng-doxygen directly. Updated clean targets as well. Updated /.gitignore and doc/.gitignore. Change-Id: I38712d3e334fa4baec19d30d05de8c6f28137622	10 years ago
Joshua Colp	009b44172d	Merge "res_pjsip_exten_state: Fix race condition between sending NOTIFY and termination"	10 years ago
Ivan Poddubny	b885f719bf	contrib/editors: Fix vim syntax highlighting of comments in config files ... * Added a lookbehind to one-line comment matcher to skip escaped semicolons. * Added support for block comments. Change-Id: Id17dfaeda8ed4be572e8107a0c010066584aaee7	10 years ago
Matt Jordan	6bb80e7657	Merge "vector: Additional enhancements and fixes"	10 years ago
Joshua Colp	e33682cae2	res_pjsip_exten_state: Fix race condition between sending NOTIFY and termination ... The res_pjsip_exten_state module currently has a race condition between processing the extension state callback from the PBX core and processing the subscription shutdown callback from res_pjsip_pubsub. There is currently no synchronization between the two. This can present a problem as while the SIP subscription will remain valid the tree it points to may not. This is in particular a problem as a task to send a NOTIFY may get queued which will try to use the tree that may no longer be valid. This change does the following to fix this problem: 1. All access to the subscription tree is done within the task that sends the NOTIFY to ensure that no other thread is modifying or destroying the tree. This task executes on the serializer for the subscriptions. 2. A reference to the subscription serializer is kept to ensure it remains valid for the lifetime of the extension state subscription. 3. The NOTIFY task has been changed so it will no longer attempt to send a NOTIFY if the subscription has already been terminated. ASTERISK-25057 #close Reported by: Matt Jordan Change-Id: I0b3cd2fac5be8d9b3dc5e693aaa79846eeaf5643	10 years ago
Joshua Colp	200493d9cc	Merge "tcptls: Avoiding ERR_remove_state in OpenSSL."	10 years ago
Matt Jordan	d679f1d9b5	Merge "cdr/cdr_csv.c: Refactor, function to write content of csv file."	10 years ago
Matt Jordan	f451af65c4	Merge topics 'ASTERISK-25049', 'ASTERISK-25056' ... * changes: CLI: Enable automatic references to modules. Modules: Make ast_module_info->self available to auxiliary sources.	10 years ago
Matt Jordan	1bf91fbc73	Merge "chan_dahdi: Improve force_restart_unavailable_chans option description."	10 years ago
Matt Jordan	fa59e23ddf	Merge "res_stasis_snoop: Spying on a single direction continually increases CPU"	10 years ago
Joshua Colp	7462207694	Merge "features: Fix crash when transferee hangs up during DTMF attended transfer."	10 years ago
George Joseph	c886be5df2	vector: Additional enhancements and fixes ... After using the new vector stuff for real I found... A bug in AST_VECTOR_INSERT_AT that could cause a seg fault. The callbacks needed to be closer to ao2_callback in behavior WRT to CMP_MATCH and CMP_STOP behavior and the ability to return a vector of matched entries. A pre-existing issue with APPEND and REPLACE was also fixed. I also added a new macro to test.h that acts like ast_test_validate but also accepts a return code variable and a cleanup label. As well as printing the error, it sets the rc variable to AST_TEST_FAIL and does a goto to the specified label on error. I had a local version of this in test_vector so I just moved it. ASTERISK-25045 Change-Id: I05e5e47fd02f61964be13b7e8942bab5d61b29cc	10 years ago
Kevin Harwell	1f5db1c7e3	res_stasis_snoop: Spying on a single direction continually increases CPU ... Creating a snoop channel in ARI and spying only on a single direction (in or out) results in CPU utilization continually increasing until the CPU is fully consumed. This occurs because frames are being put in the opposing direction's slin factory queue, but not being removed. Fixed the problem by always reading and disposing of frames from the opposite queue of the direction selected. ASTERISK-24938 #closes Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60	10 years ago
Richard Mudgett	7103b374ef	chan_dahdi: Improve force_restart_unavailable_chans option description. ... ASTERISK-25034 Reported by: Richard Mudgett Change-Id: I1ff8f02124d2f4abd632a050da52c64285bb7f30	10 years ago
Joshua Colp	a4d16c1822	Merge "app_queue: Fix queue_log EXITWITHTIMEOUT containing only 1 parameter"	10 years ago
Matt Jordan	54e83b594a	Merge "manager: Fix build due to missing variable usage."	10 years ago
Matt Jordan	b2a77db74a	Merge "res_ari_bridges: Add missing dependencies."	10 years ago
Joshua Colp	d2e2271874	manager: Fix build due to missing variable usage. ... Change-Id: I26d4d2cb9cee924632ff59ef0b30a7e6a1e2b00d	10 years ago
Matt Jordan	725cb294db	Merge "pbx_config: Register manager actions with module version of macro."	10 years ago
Richard Mudgett	6c4d1c3223	features: Fix crash when transferee hangs up during DTMF attended transfer. ... A crash happens with this sequence of steps: 1) Party A is connected to party B. 2) Party B starts a DTMF attended transfer. 3) Party A hangs up while party B is dialing party C. When party A hangs up the bridge that party A and party B are in is dissolved and party B is kicked out of the bridge. When party B finishes dialing party C he attempts to move to the new bridge with party C. Since party B is no longer in a bridge the attempted move dereferences a NULL bridge_channel pointer and crashes. * Made the hold(), unhold(), ringing(), and the bridge_move() functions tolerant of the channel not being in a bridge. The assertion that party B is always in a bridge is not true if the bridged peer of party B hangs up and dissolves the bridge. Being tolerant of not being in a bridge allows the peer hangup stimulus to be processed by the FSM. * Made the bridge_move() function return void since where the return value for a failed move was checked generated a FSM coding ERROR message for a normal off-nominal condition. * Eliminated most uses of RAII_VAR in bridge_basic.c. ASTERISK-25003 #close Reported by: Artem Volodin Change-Id: Ie2c1b14e5e647d4ea6de300bf56d69805d7bcada	10 years ago
Ivan Poddubny	90bfc02e84	app_queue: Fix queue_log EXITWITHTIMEOUT containing only 1 parameter ... This patch fixes EXITWITHTIMEOUT queue_log entry to always come with 3 parameters: position, original position and waiting time. ASTERISK-25038 #close Reported by: Etienne Lessard Change-Id: I0c62045922e26bee2125e93aee1dee17eee79618	10 years ago
Joshua Colp	bebf0b9b27	chan_unistim: Fix build failure due to ACL changes. ... Change-Id: I57081045c72b9fcf12d5c84493278f9272c31b32	10 years ago
Matt Jordan	bc8dcbdfbc	Merge "stasis: Fix dial masquerade datastore lifetime"	10 years ago
Matt Jordan	f36f271c8e	Merge "vector: Traversal, retrieval, insert and locking enhancements"	10 years ago
Alexander Traud	247fef6653	tcptls: Avoiding ERR_remove_state in OpenSSL. ... ERR_remove_state was deprecated with OpenSSL 1.0.0 and was replaced by ERR_remove_thread_state. ERR_load_SSL_strings and ERR_load_BIO_strings were called by SSL_load_error_strings already and got removed. These changes allow OpenSSL forks like BoringSSL to be used with Asterisk. ASTERISK-25043 #close Reported by: Alexander Traud patches: asterisk_with_BoringSSL.patch uploaded by Alexander Traud (License 6520) Change-Id: If1c0871ece21a7e0763fafbd2fa023ae49d4d629	10 years ago
Joshua Colp	f45833c9ad	Merge "Restrict functionality when ACLs are misconfigured."	10 years ago
Corey Farrell	c541923ac3	res_ari_bridges: Add missing dependencies. ... Missed this module in the previous commit. res_ari_bridges uses symbols from res_stasis_playback and res_stasis_recording. ASTERISK-25027 #close Reported by: Corey Farrell Change-Id: I90bf756abd25adfc4920d2869ebe7feb636b8c5f	10 years ago
Corey Farrell	8a3e93a349	pbx_config: Register manager actions with module version of macro. ... Switch manager actions in pbx_config to use the registration macro that passes the module pointer, allowing pbx_config reference to be bumped while the manager actions run. ASTERISK-25061 #close Reported by: Corey Farrell Change-Id: I422c50dd74814616ac10c5e9c6598a0b1bc2c44e	10 years ago