asterisk

Commit Graph

Author	SHA1	Message	Date
Naveen Albert	42ca53c6a9	loader.c: Allow dependent modules to be unloaded recursively. Because of the (often recursive) nature of module dependencies in Asterisk, hot swapping a module on the fly is cumbersome if a module is depended on by other modules. Currently, dependencies must be popped manually by unloading dependents, unloading the module of interest, and then loading modules again in reverse order. To make this easier, the ability to do this recursively in certain circumstances has been added, as an optional extension to the "module refresh" command. If requested, Asterisk will check if a module that has a positive usecount could be unloaded safely if anything recursively dependent on it were unloaded. If so, it will go ahead and unload all these modules and load them back again. This makes hot swapping modules that provide dependencies much easier. Resolves: #474 UserNote: In certain circumstances, modules with dependency relations can have their dependents automatically recursively unloaded and loaded again using the "module refresh" CLI command or the ModuleLoad AMI command. (cherry picked from commit `e634da7108`)	1 year ago
Henrik Liljedahl	e27f88ed03	res_pjsip_sdp_rtp.c: Initial RTP inactivity check must consider the rtp_timeout setting. First rtp activity check was performed after 500ms regardless of the rtp_timeout setting. Having a call in ringing state for more than rtp_timeout and the first rtp package is received more than 500ms after sdp negotiation and before the rtp_timeout, erronously caused the call to be hungup. Changed to perform the first rtp inactivity check after the timeout setting preventing calls to be disconnected before the rtp_timeout has elapsed since sdp negotiation. Fixes #710 (cherry picked from commit `9cf8678112`)	1 year ago
George Joseph	c9439c8ad7	tcptls/iostream: Add support for setting SNI on client TLS connections If the hostname field of the ast_tcptls_session_args structure is set (which it is for websocket client connections), that hostname will now automatically be used in an SNI TLS extension in the client hello. Resolves: #713 UserNote: Secure websocket client connections now send SNI in the TLS client hello. (cherry picked from commit `9e1a6fa0a7`)	1 year ago
George Joseph	824b4ce855	stir_shaken: Fix memory leak, typo in config, tn canonicalization * Fixed possible memory leak in tn_config:tn_get_etn() where we weren't releasing etn if tn or eprofile were null. * We now canonicalize TNs before using them for lookups or adding them to Identity headers. * Fixed a typo in stir_shaken.conf.sample. Resolves: #716 (cherry picked from commit `9c1b98e577`)	1 year ago
George Joseph	3bbdad0191	make_buildopts_h: Always include DETECT_DEADLOCKS Since DETECT_DEADLOCKS is now split from DEBUG_THREADS, it must always be included in buildopts.h instead of only when ADD_CFLAGS_TO_BUILDOPTS_H is defined. A SEGV will result otherwise. Resolves: #719 (cherry picked from commit `af3dd9e2e3`)	1 year ago
Spiridonov Dmitry	2e0999f6ef	sorcery.c: Fixed crash error when executing "module reload" Fixed crash error when cli "module reload". The error appears when compiling with res_prometheus and using the sorcery memory cache for registrations (cherry picked from commit `726abbb949`)	1 year ago
Naveen Albert	51b0ca2db0	callerid.c: Parse previously ignored Caller ID parameters. Commit `f2f397c1a8` previously made it possible to send Caller ID parameters to FXS stations which, prior to that, could not be sent. This change is complementary in that we now handle receiving all these parameters on FXO lines and provide these up to the dialplan, via chan_dahdi. In particular: * If a redirecting reason is provided, the channel's redirecting reason is set. No redirecting number is set, since there is no parameter for this in the Caller ID protocol, but the reason can be checked to determine if and why a call was forwarded. * If the Call Qualifier parameter is received, the Call Qualifier variable is set. * Some comments have been added to explain why some of the code is the way it is, to assist other people looking at it. With this change, Asterisk's Caller ID implementation is now reasonably complete for both FXS and FXO operation. Resolves: #681 (cherry picked from commit `44381b2fe9`)	1 year ago
George Joseph	665a10b9a2	logger.h: Add SCOPE_CALL and SCOPE_CALL_WITH_RESULT If you're tracing a large function that may call another function multiple times in different circumstances, it can be difficult to see from the trace output exactly which location that function was called from. There's no good way to automatically determine the calling location. SCOPE_CALL and SCOPE_CALL_WITH_RESULT simply print out a trace line before and after the call. The difference between SCOPE_CALL and SCOPE_CALL_WITH_RESULT is that SCOPE_CALL ignores the function's return value (if any) where SCOPE_CALL_WITH_RESULT allows you to specify the type of the function's return value so it can be assigned to a variable. SCOPE_CALL_WITH_INT_RESULT is just a wrapper for SCOPE_CALL_WITH_RESULT and the "int" return type. (cherry picked from commit `2dc89afb2c`)	1 year ago
Sean Bright	c78d46fb56	app_queue.c: Properly handle invalid strategies from realtime. The existing code sets the queue strategy to `ringall` but it is then immediately overwritten with an invalid one. Fixes #707 (cherry picked from commit `9de1bc7204`)	1 year ago
Naveen Albert	e53bc85b1d	file.c, channel.c: Don't emit warnings if progress received. Silently ignore AST_CONTROL_PROGRESS where appropriate, as most control frames already are. Resolves: #696 (cherry picked from commit `59f7e3d0e4`)	1 year ago
Sean Bright	24ad313536	alembic: Correct NULLability of PJSIP id columns. Fixes #695 (cherry picked from commit `07debc3b91`)	1 year ago
George Joseph	e658cdd618	rtp_engine and stun: call ast_register_atexit instead of ast_register_cleanup rtp_engine.c and stun.c were calling ast_register_cleanup which is skipped if any loadable module can't be cleanly unloaded when asterisk shuts down. Since this will always be the case, their cleanup functions never get run. In a practical sense this makes no difference since asterisk is shutting down but if you're in development mode and trying to use the leak sanitizer, the leaks from both of those modules clutter up the output. (cherry picked from commit `c31d3dfd18`)	1 year ago
George Joseph	985a2fbee2	manager.c: Add missing parameters to Login documentation * Added the AuthType and Key parameters for MD5 authentication. * Added the Events parameter. Resolves: #689 (cherry picked from commit `8b1502e4ed`)	1 year ago
Naveen Albert	0abe9e60b1	func_callerid: Emit warning if invalid redirecting reason set. Emit a warning if REDIRECTING(reason) is set to an invalid reason, consistent with what happens when REDIRECTING(orig-reason) is set to an invalid reason. Resolves: #683 (cherry picked from commit `c16e3c2ac5`)	1 year ago
Naveen Albert	c510d91cec	chan_dahdi: Add DAHDIShowStatus AMI action. * Add an AMI action to correspond to the "dahdi show status" command, allowing span information to be retrieved via AMI. * Show span number and sig type in "dahdi show channels". Resolves: #673 (cherry picked from commit `676c7d6ae0`)	1 year ago
Sperl Viktor	68a4912825	res_pjsip_endpoint_identifier_ip: Add endpoint identifier transport address. Add a new identify_by option to res_pjsip_endpoint_identifier_ip called 'transport' this matches endpoints based on the bound ip address (local) instead of the 'ip' option, which matches on the source ip address (remote). UserNote: set identify_by=transport for the pjsip endpoint. Then use the existing 'match' option and the new 'transport' option of the identify. Fixes: #672 (cherry picked from commit `7c3e2cfda9`)	1 year ago
George Joseph	6389c743a9	res_stir_shaken: Fix compilation for CentOS7 (openssl 1.0.2) * OpenSSL 1.0.2 doesn't support X509_get0_pubkey so we now use X509_get_pubkey. The difference is that X509_get_pubkey requires the caller to free the EVP_PKEY themselves so we now let RAII_VAR do that. * OpenSSL 1.0.2 doesn't support upreffing an X509_STORE so we now wrap it in an ao2 object. * OpenSSL 1.0.2 doesn't support X509_STORE_get0_objects to get all the certs from an X509_STORE and there's no easy way to polyfill it so the CLI commands that list profiles will show a "not supported" message instead of listing the certs in a store. Resolves: #676 (cherry picked from commit `af6002564b`)	1 year ago
George Joseph	b5865aef32	Fix incorrect application and function documentation references There were a few references in the embedded documentation XML where the case didn't match or where the referenced app or function simply didn't exist any more. These were causing 404 responses in docs.asterisk.org. (cherry picked from commit `3fb9d89586`)	1 year ago
Sean Bright	8bd33d49ac	cli.c: `core show channels concise` is not really deprecated. Fixes #675 (cherry picked from commit `fbb5b7c2ae`)	1 year ago
Sperl Viktor	bd3c3bf821	res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI Add ability to match against PJSIP request URI. UserNote: this new feature let users match endpoints based on the indound SIP requests' URI. To do so, add 'request_uri' to the endpoint's 'identify_by' option. The 'match_request_uri' option of the identify can be an exact match for the entire request uri, or a regular expression (between slashes). It's quite similar to the header identifer. Fixes: #599 (cherry picked from commit `136bd5c892`)	1 year ago
Naveen Albert	98aa70cd38	chan_dahdi: Don't retry opening nonexistent channels on restart. Commit `729cb1d390` added logic to retry opening DAHDI channels on "dahdi restart" if they failed initially, up to 1,000 times in a loop, to address cases where the channel was still in use. However, this retry loop does not use the actual error, which means chan_dahdi will also retry opening nonexistent channels 1,000 times per channel, causing a flood of unnecessary warning logs for an operation that will never succeed, with tens or hundreds of thousands of open attempts being made. The original patch would have been more targeted if it only retried on the specific relevant error (likely EBUSY, although it's hard to say since the original issue is no longer available). To avoid the problem above while avoiding the possibility of breakage, this skips the retry logic if the error is ENXIO (No such device or address), since this will never succeed. Resolves: #669 (cherry picked from commit `4e244528b3`)	1 year ago
Joshua Elson	855ed6c168	Implement Configurable TCP Keepalive Settings in PJSIP Transports This commit introduces configurable TCP keepalive settings for both TCP and TLS transports. The changes allow for finer control over TCP connection keepalives, enhancing stability and reliability in environments prone to connection timeouts or where intermediate devices may prematurely close idle connections. This has proven necessary and has already been tested in production in several specialized environments where access to the underlying transport is unreliable in ways invisible to the operating system directly, so these keepalive and timeout mechanisms are necessary. Fixes #657 (cherry picked from commit `3d40d34271`)	1 year ago
Martin Tomec	378ce2d87f	res_pjsip_refer.c: Allow GET_TRANSFERRER_DATA There was functionality in chan_sip to get REFER headers, with GET_TRANSFERRER_DATA variable. This commit implements the same functionality in pjsip, to ease transfer from chan_sip to pjsip. Fixes: #579 UserNote: the GET_TRANSFERRER_DATA dialplan variable can now be used also in pjsip. (cherry picked from commit `f3de77f91f`)	1 year ago
Martin Nystroem	2c5a1b44f6	res_ari.c: Add additional output to ARI requests when debug is enabled When ARI debug is enabled the logs will now output http method and the uri. Fixes: #666 (cherry picked from commit `15f68a836e`)	1 year ago
Sean Bright	396cc55965	alembic: Fix compatibility with SQLAlchemy 2.0+. SQLAlchemy 2.0 changed the way that commits/rollbacks are handled causing the final `UPDATE` to our `alembic_version_<whatever>` tables to be rolled back instead of committed. We now use one connection to determine which `alembic_version_<whatever>` table to use and another to run the actual migrations. This prevents the erroneous rollback. This change is compatible with both SQLAlchemy 1.4 and 2.0. (cherry picked from commit `8715a700e2`)	1 year ago
jonatascalebe	2680d5be35	manager.c: Add new parameter 'PreDialGoSub' to Originate AMI action manager.c: Add new parameter 'PreDialGoSub' to Originate AMI action The action originate does not has the ability to run an subroutine at initial channel, like the Aplication Originate. This update give this ability for de action originate too. For example, we can run a routine via Gosub on the channel to request an automatic answer, so the caller does not need to accept the call when using the originate command via manager, making the operation more efficient. UserNote: When using the Originate AMI Action, we now can pass the PreDialGoSub parameter, instructing the asterisk to perform an subrouting at channel before call start. With this parameter an call initiated by AMI can request the channel to start the call automaticaly, adding a SIP header to using GoSUB, instructing to autoanswer the channel, and proceeding the outbuound extension executing. Exemple of an context to perform the previus indication: [addautoanswer] exten => _s,1,Set(PJSIP_HEADER(add,Call-Info)=answer-after=0) exten => _s,n,Set(PJSIP_HEADER(add,Alert-Info)=answer-after=0) exten => _s,n,Return() (cherry picked from commit `97c0388830`)	1 year ago
Naveen Albert	77b95404d0	menuselect: Minor cosmetic fixes. Improve some of the formatting from `dd3f17c699` (#521). (cherry picked from commit `f38fc7639e`)	1 year ago
Naveen Albert	94269cad45	pbx_variables.c: Prevent SEGV due to stack overflow. It is possible for dialplan to result in an infinite recursion of variable substitution, which eventually leads to stack overflow. If we detect this, abort substitution and log an error for the user to fix the broken dialplan. Resolves: #480 UpgradeNote: The maximum amount of dialplan recursion using variable substitution (such as by using EVAL_EXTEN) is capped at 15. (cherry picked from commit `6991d36332`)	1 year ago
Holger Hans Peter Freyther	081240cf9a	res_prometheus: Fix duplicate output of metric and help text The prometheus exposition format requires each line to be unique[1]. This is handled by struct prometheus_metric having a list of children that is managed when registering a metric. In case the scrape callback is used, it is the responsibility of the implementation to handle this correctly. Originally the bridge callback didn't handle NULL snapshots, the crash fix lead to NULL metrics, and fixing that lead to duplicates. The original code assumed that snapshots are not NULL and then relied on "if (i > 0)" to establish the parent/children relationship between metrics of the same class. This is not workerable as the first bridge might be invisible/lacks a snapshot. Fix this by keeping a separate array of the first metric by class. Instead of relying on the index of the bridge, check whether the array has an entry. Use that array for the output. Add a test case that verifies that the help text is not duplicated. Resolves: #642 [1] https://prometheus.io/docs/instrumenting/exposition_formats/#grouping-and-sorting (cherry picked from commit `d11eba69a6`)	1 year ago
Naveen Albert	55fdf1947e	manager.c: Add CLI command to kick AMI sessions. This adds a CLI command that can be used to manually kick specific AMI sessions. Resolves: #485 UserNote: The "manager kick session" CLI command now allows kicking a specified AMI session. (cherry picked from commit `3b9f3c0bbf`)	1 year ago
Naveen Albert	c67efe174e	chan_dahdi: Allow specifying waitfordialtone per call. The existing "waitfordialtone" setting in chan_dahdi.conf applies permanently to a specific channel, regardless of how it is being used. This rather restrictively prevents a system from simultaneously being able to pick free lines for outgoing calls while also allowing barge-in to a trunk by some other arrangement. This allows specifying "waitfordialtone" using the CHANNEL function for only the next call that will be placed, allowing significantly more flexibility in the use of trunk interfaces. Resolves: #472 UserNote: "waitfordialtone" may now be specified for DAHDI trunk channels on a per-call basis using the CHANNEL function. (cherry picked from commit `8dd77df69b`)	1 year ago
Naveen Albert	2bd3d00412	res_parking: Fail gracefully if parking lot is full. Currently, if a parking lot is full, bridge setup returns -1, causing dialplan execution to terminate without TryExec. However, such failures should be handled more gracefully, the same way they are on other paths, as indicated by the module's author, here: http://lists.digium.com/pipermail/asterisk-dev/2018-December/077144.html Now, callers will hear the parking failure announcement, and dialplan will continue, which is consistent with existing failure modes. Resolves: #624 (cherry picked from commit `b05865d8e9`)	1 year ago
Sean Bright	b314934e71	res_config_mysql.c: Support hostnames up to 255 bytes. Fixes #654 (cherry picked from commit `18ed610d4e`)	1 year ago
Sean Bright	1acd188e7d	res_pjsip: Fix alembic downgrade for boolean columns. When downgrading, ensure that we don't touch columns that didn't actually change during upgrade. (cherry picked from commit `4ecbac98d8`)	1 year ago
Stanislav Abramenkov	40eecb019e	Upgrade bundled pjproject to 2.14.1 Fixes: asterisk#648 UserNote: Bundled pjproject has been upgraded to 2.14.1. For more information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.14.1 (cherry picked from commit `83a4d37d9f`)	1 year ago
Sean Bright	f6fa72390f	alembic: Quote new MySQL keyword 'qualify.' Fixes #651 (cherry picked from commit `1965574944`)	1 year ago
Maximilian Fridrich	4c10d95529	res_pjsip_session: Reset pending_media_state->read_callbacks In handle_negotiated_sdp the pending_media_state->read_callbacks must be reset before they are added in the SDP handlers in handle_negotiated_sdp_session_media. Otherwise, old callbacks for removed streams and file descriptors could be added to the channel and Asterisk would poll on non-existing file descriptors. Resolves: #611 (cherry picked from commit `3d71b494d8`)	1 year ago
Sean Bright	c89e91c8d0	res_monitor.c: Don't emit a warning about 'X' being unrecognized. Code was added in `030f7d41` to warn if an unrecognized option was passed to an application, but code in Monitor was taking advantage of the fact that the application would silently accept an invalid option. We now recognize the invalid option but we don't do anything if it's set. Fixes #639 (cherry picked from commit `6938b7f962`)	1 year ago
George Joseph	e4af0eaa47	.github: Add PAT to PRSubmitActions/Add Reviewers (cherry picked from commit `12d2bd23d5`)	1 year ago
Asterisk Development Team	af5acc405d	Update for 20.7.0	1 year ago
Asterisk Development Team	9b6c74e82a	Update for 20.7.0-rc2	1 year ago
George Joseph	d7597e5148	res_pjsip_stir_shaken.c: Add checks for missing parameters * Added checks for missing session, session->channel and rdata in stir_shaken_incoming_request. * Added checks for missing session, session->channel and tdata in stir_shaken_outgoing_request. Resolves: #645	1 year ago
Asterisk Development Team	959babc472	Update for 20.7.0-rc1	1 year ago
Naveen Albert	40fd161575	app_dial: Add dial time for progress/ringing. Add a timeout option to control the amount of time to wait if no early media is received before giving up. This allows aborting early if the destination is not being responsive. Resolves: #588 UserNote: The timeout argument to Dial now allows specifying the maximum amount of time to dial if early media is not received. (cherry picked from commit `e4adc962ca`)	1 year ago
Naveen Albert	5ade71ec9a	app_voicemail: Properly reinitialize config after unit tests. Most app_voicemail unit tests were not properly cleaning up after themselves after running. This led to test mailboxes lingering around in the system. It also meant that if any unit tests in app_voicemail that create mailboxes were executed and the module was not unloaded/loaded again prior to running the test_voicemail_vm_info unit test, Asterisk would segfault due to an attempt to copy a NULL string. The load_config test did actually have logic to reinitialize the config after the test. However, this did not work in practice since load_config() would not reload the config since voicemail.conf had not changed during the test; thus, additional logic has been added to ensure that voicemail.conf is truly reloaded, after any unit tests which modify the users list. This prevents the SEGV due to invalid mailboxes lingering around, and also ensures that the system state is restored to what it was prior to the tests running. Resolves: #629 (cherry picked from commit `082966bdad`)	1 year ago
Shaaah	395bcab787	app_queue.c : fix "queue add member" usage string Fixing bracket placement in the "queue add member" cli usage string. (cherry picked from commit `c6ff7a6a51`)	1 year ago
Naveen Albert	3469e515de	app_voicemail: Allow preventing mark messages as urgent. This adds an option to allow preventing callers from leaving messages marked as 'urgent'. Resolves: #619 UserNote: The leaveurgent mailbox option can now be used to control whether callers may leave messages marked as 'Urgent'. (cherry picked from commit `3c42b141d7`)	1 year ago
Sean Bright	f8da5a2ba3	res_pjsip: Use consistent type for boolean columns. This migrates the relevant schema objects from the `('yes', 'no')` definition to the `('0', '1', 'off', 'on', 'false', 'true', 'yes', 'no')` one. Fixes #617 (cherry picked from commit `93e40968c3`)	1 year ago
George Joseph	f02ac33364	.github: Remove timeout-minutes from gatetests (cherry picked from commit `9f182e9f58`)	1 year ago
George Joseph	44563b5043	attestation_config.c: Use ast_free instead of ast_std_free In as_check_common_config, we were calling ast_std_free on raw_key but raw_key was allocated with ast_malloc so it should be freed with ast_free. Resolves: #636 (cherry picked from commit `267348bee3`)	1 year ago

1 2 3 4 5 ...

33881 Commits (42ca53c6a93cd5f68560e5019ca88d0bc6b4681d) All Branches Search

33881 Commits (42ca53c6a93cd5f68560e5019ca88d0bc6b4681d)

All Branches