27144 Commits (32b29d7b027b43f78ffda3b85adb35653d5365b3)

 

All Branches   

Search

Author	SHA1	Message	Date
Joshua Colp	32b29d7b02	app: Queue hangup if channel is hung up during sub or macro execution. ... This issue was exposed when executing a connected line subroutine. When connected or redirected subroutines or macros are executed it is expected that the underlying applications and logic invoked are fast and do not consume frames. In practice this constraint is not enforced and if not adhered to will cause channels to continue when they shouldn't. This is because each caller of the connected or redirected logic does not check whether the channel has been hung up on return. As a result the the hung up channel continues. This change makes it so when the API to execute a subroutine or macro is invoked the channel is checked to determine if it has hung up. If it has then a hangup is queued again so the caller will see it and stop. ASTERISK-25690 #close Change-Id: I1f9a8ceb1487df0389f0d346ce0f6dcbcaf476ea	10 years ago
Joshua Colp	ace79fadad	Merge "app_queue: Add member flag "in_call" to prevent reading wrong lastcall time" into 13	10 years ago
Mark Michelson	f9a275fef4	Merge "Revert "pjsip_location: Delete contact_status object when contact is deleted"" into 13	10 years ago
Joshua Colp	77a46ac84d	Merge "pbx: Deadlock between contexts container and context_merge locks" into 13	10 years ago
Joshua Colp	8ec4d20fa9	Merge "pbx_dundi: Run cleanup on failed load." into 13	10 years ago
Joshua Colp	ddc9c1f720	Merge "res_crypto: Perform cleanup at shutdown." into 13	10 years ago
Joshua Colp	85fdbcefae	Merge "res_calendar: Cleanup scheduler context at unload." into 13	10 years ago
Joshua Colp	672920d0cf	Merge "manager: Cleanup manager_channelvars during shutdown." into 13	10 years ago
Joshua Colp	85145be4b8	Merge "devicestate: Cleanup engine thread during graceful shutdown." into 13	10 years ago
Kevin Harwell	1600ebca7d	pbx: Deadlock between contexts container and context_merge locks ... Recent changes (ASTERISK-25394 commit 2bd27d1222) introduced the possibility of a deadlock. Due to the mentioned modifications ast_change_hints now needs to keep both merge/delete and state callbacks from occurring while it executes. Unfortunately, sometimes ast_change_hints can be called with the contexts container locked. When this happens it's possible for another thread to grab the context_merge_lock before the thread calling into ast_change_hints does and then try to obtain the contexts container lock. This of course causes a deadlock between the two threads. The thread calling into ast_change_hints waits for the other thread to release context_merge_lock and the other thread is waiting on that one to release the contexts container lock. Unfortunately, there is not a great way to fix this problem. When hints change, the subsequent state callbacks cannot run at the same time as a merge/delete, nor when the usual state callbacks do. This patch alleviates the problem by having those particular callbacks (the ones run after a hint change) occur in a serialized task. By moving the context_merge_lock to a task it can now safely be attempted or held without a deadlock occurring. ASTERISK-25640 #close Reported by: Krzysztof Trempala Change-Id: If2210ea241afd1585dc2594c16faff84579bf302	10 years ago
Corey Farrell	0fc3dad965	devicestate: Cleanup engine thread during graceful shutdown. ... ASTERISK-25681 #close Change-Id: I64337c70f0ebd8c77f70792042684607c950c8f1	10 years ago
Corey Farrell	f34dd10495	manager: Cleanup manager_channelvars during shutdown. ... ASTERISK-25680 #close Change-Id: I3251d781cbc3f48a6a7e1b969ac4983f552b2446	10 years ago
Corey Farrell	1d3a1167fc	res_calendar: Cleanup scheduler context at unload. ... ASTERISK-25679 #close Change-Id: I839159bf6882cccc1b23494c7aa2bc2a2624613f	10 years ago
Joshua Colp	3a160cdbf6	res_rtp_asterisk: Revert DTLS negotiation changes. ... Due to locking issues within pjnath these changes are being reverted until pjnath can be changed. ASTERISK-25645 Revert "res_rtp_asterisk.c: Fix DTLS negotiation delays." This reverts commit 24ae124e4f. Change-Id: I2986cfb2c43dc14455c1bcaf92c3804f9da49705 Revert "res_rtp_asterisk: Resolve further timing issues with DTLS negotiation" This reverts commit 965a0eee46. Change-Id: Ie68fafde27dad4b03cb7a1e27ce2a8502c3f7bbe	10 years ago
George Joseph	4b10fc9173	Revert "pjsip_location: Delete contact_status object when contact is deleted" ... This reverts commit 0a9941de9d. Matt, This patch causes another problem and should not have been needed. Before this patch, persistent_endpoint_contact_deleted_observer WAS deleting the contact_status when ast_sip_location_delete_contact was called. By deleting it yourself in ast_sip_location_delete_contact it was gone before the observer could run and the observer therefore was throwing an error and not sending stasis/AMI/statsd messages. So, I don't think this was the cause of your original issue. I also had verified the contact AMI and statsd lifecycle and it was working. I'll double check now though. ASTERISK-25675 Reported-by: Daniel Journo Change-Id: Ib586a6b7f90acb641b0c410f659743ab90e84f1a	10 years ago
Corey Farrell	79b4309881	pbx_dundi: Run cleanup on failed load. ... During failed startup of pbx_dundi no cleanup was performed. Add a call to unload_module before returning AST_MODULE_LOAD_DECLINE. ASTERISK-25677 #close Change-Id: I8ffa226fda4365ee7068ac1f464473f1a4ebbb29	10 years ago
Corey Farrell	a5406b1f9e	res_crypto: Perform cleanup at shutdown. ... This change causes res_crypto to unregister CLI at shutdown while still preventing the module from being unloaded. ASTERISK-25673 #close Change-Id: Ie5d57338dc2752abfc0dd05d0eec86413f2304fc	10 years ago
Joshua Colp	573b37c658	Merge "include/asterisk/time.h: Renamed global declaration:tv" into 13	10 years ago
Diederik de Groot	0f79c8839b	main: Use ast_strdup instead of strdup ... Fix compile error in main/utils.c because strdup was used in dummy_start Change-Id: Id61a6cf4f3cbf235450441e10e7da101a6335793	10 years ago
Diederik de Groot	4285dee778	include/asterisk/time.h: Renamed global declaration:tv ... Renamed global declaration:tv to dummy_tv_var_for_types, which would oltherwise cause 'shadow' warnings when 'tv' was declared as a local variable elsewhere. Added comment to note that dummy_tv_var_for_types is never really exported and only used as a place holder. ASTERISK-25627 #close Change-Id: I9a6e17995006584f3627efe8988e3f8aa0f5dc28	10 years ago
Joshua Colp	01e5894388	Merge "PJSIP: Prevent deadlock due to dialog/transaction lock inversion." into 13	10 years ago
Mark Michelson	96094feab6	PJSIP: Prevent deadlock due to dialog/transaction lock inversion. ... A deadlock was observed where the monitor thread was stuck, therefore resulting in no incoming SIP traffic being processed. The problem occurred when two 200 OK responses arrived in response to a terminating NOTIFY request sent from Asterisk. The first 200 OK was dispatched to a threadpool worker, who locked the corresponding transaction. The second 200 OK arrived, resulting in the monitor thread locking the dialog. At this point, the two threads are at odds, because the monitor thread attempts to lock the transaction, and the threadpool thread loops attempting to try to lock the dialog. In this case, the fix is to not have the monitor thread attempt to hold both the dialog and transaction locks at the same time. Instead, we release the dialog lock before attempting to lock the transaction. There have also been some debug messages added to the process in an attempt to make it more clear what is going on in the process. ASTERISK-25668 #close Reported by Mark Michelson Change-Id: I4db0705f1403737b4360e33a8e6276805d086d4a	10 years ago
Corey Farrell	52e9de0016	ast_format_cap_append_by_type: Resolve codec reference leak. ... This resolves a reference leak caused by ASTERISK-25535. The pointer returned by ast_format_get_codec is saved so it can be released. ASTERISK-25664 #close Change-Id: If9941b1bf4320b2c59056546d6bce9422726d1ec	10 years ago
Joshua Colp	eb3d083551	Merge "cel/cel_radius: Fix wrong pointer." into 13	10 years ago
Joshua Colp	b1ee692568	Merge topic 'pbx-split' into 13 ... * changes: main/pbx: Move hangup handler routines to pbx_hangup_handler.c. main/pbx: Move dialplan application management routines to pbx_app.c. main/pbx: Move switch routines to pbx_switch.c.	10 years ago
Joshua Colp	2e61c3d97b	Merge "main/pbx: Move timing routines to pbx_timing.c." into 13	10 years ago
Aaron An	86eae38d7e	cel/cel_radius: Fix wrong pointer. ... The macro ADD_VENDOR_CODE defined in the cel_radius.c should use the parameter y not the address of y. I capture the radius UDP packet via tcpdump, and the AV pairs are not correct, then i review the source code and compare it with cdr/cdr_radius.c. Fix it and it works. ASTERISK-25647 #close Reported by: Aaron An Tested by: Aaron An Change-Id: I72889bccd8fde120d47aa659edc0e7e6d4d019f0	10 years ago
George Joseph	881dc862e0	asterisk.h: Add ASTERISK_REGISTER_FILE macro ... The 11/13 branches and master use 2 different file version macros. 11/13 uses ASTERISK_FILE_VERSION but master uses ASTERISK_REGISTER_FILE. This means a new file added to 11/13 can't just be cherry-picked to master because the macro has to be changed. To make cherry-picking possible, ASTERISK_REGISTER_FILE was added to asterisk.h as a simple alias for ASTERISK_FILE_VERSION(__FILE__, NULL) The "$Revision$" tag doesn't do anything since Asterisk moved to git so just passing NULL as the verison works fine. asterisk.h was also annotated to deprecate ASTERISK_FILE_VERSION and suggest using ASTERISK_REGISTER_FILE for all new files. Finally, 2 recent file additions, pbx_builtins.c and pbx_functions.c, were modified to use the new macro to make sure it actually worked. 'core show file version' showed the correct output. Change-Id: I5867ed898818d26ee49bb6e5c7d4c1a45d4789a5	10 years ago
Matt Jordan	9016e51c03	Merge "main/pbx: Move variable routines to pbx_variables.c." into 13	10 years ago
George Joseph	d228b62fd4	stasis_cache_pattern: Backport to 13 ... Somehow stasis_cache_pattern got out of sync between 13 and master and it was causing duplicate channel message issues in 13 when related to a specific endpoint. I.E. from statsd, 'endpoints.PJSIP.1174.channels 0|g' was being emitted twice. Backporting stasis_cache_pattern from master to 13 solved the issue and running the unit and testsuite tests confirmed that no new ones were created. ASTERISK-25317 #close Change-Id: Ia8707462f62d15eed14541c37f332a7bbbceb548	10 years ago
Corey Farrell	e462f0063f	main/pbx: Move hangup handler routines to pbx_hangup_handler.c. ... This is the sixth patch in a series meant to reduce the bulk of pbx.c. This moves hangup handler management functions to their own source. Change-Id: Ib25a75aa57fc7d5c4294479e5cc46775912fb104	10 years ago
Corey Farrell	ab191d124c	main/pbx: Move dialplan application management routines to pbx_app.c. ... This is the sixth patch in a series meant to reduce the bulk of pbx.c. This moves dialplan application management functions to their own source. Change-Id: I444c10fb90a3cdf9f3047605d6a8aad49c22c44c	10 years ago
Corey Farrell	09a9b93896	main/pbx: Move switch routines to pbx_switch.c. ... This is the fifth patch in a series meant to reduce the bulk of pbx.c. This moves ast_switch functions to their own source. Change-Id: Ic2592a18a5c4d8a3c2dcf9786c9a6f650a8c628e	10 years ago
Corey Farrell	c608274a39	main/pbx: Move timing routines to pbx_timing.c. ... This is the fourth patch in a series meant to reduce the bulk of pbx.c. This moves pbx timing functions to their own source. Change-Id: I05c45186cb11edfc901e95f6be4e6a8abf129cd6	10 years ago
Martin Tomec	338a8ffed6	app_queue: Add member flag "in_call" to prevent reading wrong lastcall time ... Member lastcall time is updated later than member status. There was chance to check wrapuptime for available member with wrong (old) lastcall time. New boolean flag "in_call" is set to true right before connecting call, and reset to false after update of lastcall time. Members with "in_call" set to true are treat as unavailable. ASTERISK-19820 #close Change-Id: I1923230cf9859ee51563a8ed420a0628b4d2e500	10 years ago
Rodrigo Ramírez Norambuena	e13719bff1	app_queue: Added reason pause of member ... In app_queue added value Paused Reason on QueueMemberStatus when a member on queue is paused and the reason was set. ASTERISK-25480 #close Reporte by: Rodrigo Ramírez Norambuena Change-Id: Ia5db503482f50764c15e2020196c785f59d4a68e	10 years ago
Joshua Colp	937ba51659	Merge "voicemail: Move app_voicemail / res_mwi_external conflict to runtime" into 13	10 years ago
George Joseph	4ec85a9f07	voicemail: Move app_voicemail / res_mwi_external conflict to runtime ... The menuselect conflict between app_voicemail and res_mwi_external makes it hard to package 1 version of Asterisk. There no actual build dependencies between the 2 so moving this check to runtime seems like a better solution. The ast_vm_register and ast_vm_greeter_register functions in app.c were modified to return AST_MODULE_LOAD_DECLINE instead of -1 if there is already a voicemail module registered. The modules' load_module functions were then modified to return DECLINE instead of -1 to the loader. Since -1 is interpreted by the loader as AST_MODULE_LOAD_FAILURE, the modules were incorrectly causing Asterisk to stop so this needed to be cleaned up anyway. Now you can build both and use modules.conf to decide which voicemail implementation to load. The default menuselect options still build app_voicemail and not res_mwi_external but if both ARE built, res_mwi_external will load first and become the voicemail provider unless modules.conf rules prevent it. This is noted in CHANGES. Change-Id: I7d98d4e8a3b87b8df9e51c2608f0da6ddfb89247	10 years ago
Corey Farrell	7fdcfd7724	main/pbx: Move variable routines to pbx_variables.c. ... This is the third patch in a series meant to reduce the bulk of pbx.c. This moves channel and global variable routines to their own source. Change-Id: Ibe8fb4647db11598591d443a99e3f99200a56bc6	10 years ago
Richard Mudgett	80a8b2a4cd	app_dial: Immediately exit dial if the caller is already hung up. ... If a caller hangs up before dial is executed within an AGI then the AGI has likely eaten all queued frames before executing the dial in DeadAGI mode. With the caller hung up and no pending frames from the caller's read queue, dial would not know that the call has hung up until a called channel answers. It is rather annoying to whoever just answered the non-existent call. Dial should not continue execution in DeadAGI mode, hangup handlers, or the h exten. * Added a check early in dial to abort dialing if the caller has hungup. ASTERISK-25307 #close Reported by: David Cunningham Change-Id: Icd1bc0764726ef8c809f76743ca008d0f102f418	10 years ago
Matt Jordan	f42036bf6b	Merge "main/cdr: Allow setting properties on a finalized CDR if it is the last one" into 13	10 years ago
Matt Jordan	4e1d9c4a20	Merge "main/cdr: Set the end time on a CDR if endbeforehexten is Yes" into 13	10 years ago
Matt Jordan	1087b0c6ed	main/cdr: Allow setting properties on a finalized CDR if it is the last one ... Prior to this patch, we explicitly disallowed setting any properties on a finalized CDR. This seemed like a good idea at the time; in practice, it was more restrictive. There are weird and strange scenarios where setting a property on a finalized CDR is definitely wrong. For example, we may Fork a CDR, finalizing the previous one, then change a property. In said case, the old CDR is supposed to now be 'immutable' (so to speak), and should not be updated. From the perspective of the code, a forked CDR that is finalized is just finalized. Hence why we decided these should not be updated. In practice, it is much more common to want to set a property on a CDR in the h extension or in a hangup handler. Disallowing a common scenario to make an esoteric behaviour work isn't good. This patch fixes this by allowing callers to set a property IF we are the last CDR in the chain. This preserves the finalized CDR if it was forked, while allowing the more common case to function. ASTERISK-25458 #close Change-Id: Icf3553c607b9f561152a41e6d8381d594ccdf4b9	10 years ago
Matt Jordan	1f23e65b89	main/cdr: Set the end time on a CDR if endbeforehexten is Yes ... Prior to this patch, the CDR engine attempted to set the end time on a CDR that was executing hangup logic and with endbeforehexten set to Yes by calling a function that inspects the properties on the Party A snapshot to determine if we are ready to set the end time. That always failed. This is because a Party A snapshot is not updated for CDRs that are executing hangup logic with endbeforehexten=Yes. Instead of calling a function that looks at the Party A snapshot, we just simply set the end time on the CDR. This is safe to call multiple times, and is safe to call at this point as we know that (a) we are executing hangup logic, and (b) we are supposed to set the end time at this point. ASTERISK-25458 Change-Id: I0c27b493861f9c13c43addbbb21257f79047a3b3	10 years ago
Corey Farrell	2ffade4574	main/pbx: Move custom function routines to pbx_functions.c. ... This is the second patch in a series meant to reduce the bulk of pbx.c. This moves custom function management routines to their own source. Change-Id: I34a6190282f781cdbbd3ce9d3adeac3c3805e177	10 years ago
Matt Jordan	bc7c882326	Merge "main/pbx: Move pbx_builtin dialplan applications to pbx_builtins.c" into 13	10 years ago
Matt Jordan	5a75caa9e6	Merge "res_pjsip_history: Add a module that provides PJSIP history for debugging" into 13	10 years ago
George Joseph	20b8474f20	main/pbx: Move pbx_builtin dialplan applications to pbx_builtins.c ... We joked about splitting pbx.c into multiple files but this first step was fairly easy. All of the pbx_builtin dialplan applications have been moved into pbx_builtins.c and a new pbx_private.h file was added. load_pbx_builtins() is called by asterisk.c just after load_pbx(). A few functions were renamed and are cross-exposed between the 2 source files. Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a	10 years ago
Joshua Colp	a68467d293	Merge "res_http_websocket.c: prevent avoidable disconnections caused by write errors" into 13	10 years ago
Joshua Colp	47d508e911	Merge "test_time: Provide a timeout when waiting." into 13	10 years ago