29443 Commits (24318aac454269aa60c203420936ec1047359ebd)

 

All Branches   

Search

Author	SHA1	Message	Date
Jenkins2	24318aac45	Merge "unittests: Add a unit test that causes a SEGV and..."	9 years ago
Jenkins2	d6992daaef	Merge "res_agi: Clarify 'RECORD FILE' documentation"	9 years ago
George Joseph	08edd54c1b	unittests: Add a unit test that causes a SEGV and... ... ...that can only be run by explicitly calling it with 'test execute category /DO_NOT_RUN/ name RAISE_SEGV' This allows us to more easily test CI and debugging tools that should do certain things when asterisk coredumps. To allow this a new member was added to the ast_test_info structure named 'explicit_only'. If set by a test, the test will be skipped during a 'test execute all' or 'test execute category ...'. Change-Id: Ia3a11856aae4887df9a02b6b081cc777b36eb6ed	9 years ago
Joshua Colp	2e7866ebb7	Merge "app_queue: Add QUEUE_RAISE_PENALTY feature"	9 years ago
Jenkins2	c247625012	Merge "chan_sip: Better ICE handling for RTCP-MUX"	9 years ago
Jenkins2	cd0e6a2324	Merge "res_rtp_asterisk: rtcp mux using the wrong srtp unprotecting algorithm"	9 years ago
Jenkins2	2200009099	Merge "res_format_attr_h26x: Trim blanks in fmtp attributes"	9 years ago
Sean Bright	e2e6baa8d8	res_agi: Clarify 'RECORD FILE' documentation ... Documented the 'beep' option in both the parameters list and the command description. ASTERISK-23839 #close Change-Id: I4970395c922dbdce3f7cf0f56d5b065ec9aa53ea	9 years ago
Sean Bright	8ae0227cf3	res_format_attr_h26x: Trim blanks in fmtp attributes ... Some devices separate format attributes with a semicolon followed by a space, so trim blanks before trying to match them. ASTERISK-27008 #close Change-Id: Ia44cb2e4fef5c73dc541a29da79cb0e19c22d9cc	9 years ago
Joshua Colp	faab058014	app_queue: Fix members showing as being in call when not. ... A change was done which added an 'in_call' flag to queue members that was set to true while talking to an agent. Unfortunately in practice this does not accurately reflect whether they are talking to an agent or not. If a Local channel is involved and a transfer is performed then the app_queue application would incorrectly think the agent was still in a call with the caller. This was done to fix a race condition between an agent becoming available by device state and the checking of the last call information for the wrapup time. There was a small window where the last call information would be the previous value instead of the new one. This change goes about fixing the original issue in a different way by considering the call completed if device state is received which would make the agent available and if they are currently in a call. If this occurs the last call information is updated before the agent becomes available ensuring that old information is not present when checking if the member should be called. This also improves the transfer situation by actually updating and enforcing the wrapup time. ASTERISK-26399 ASTERISK-26400 ASTERISK-26715 ASTERISK-26975 Change-Id: Ife1cb686e3173b3a6d368601adef9aff69d4beea	9 years ago
Joshua Colp	dece2eb892	Merge "res_pjsip_session : fixed wrong From Header number On Re-invite"	9 years ago
Kevin Harwell	440ff38c08	res_rtp_asterisk: rtcp mux using the wrong srtp unprotecting algorithm ... When using rtcp mux if an rtcp payload came in it would still use the srtp unprotect algorithm instead of the srtp unprotect rtcp method. Since rtcp data was being passed to the rtp unprotect method this would result in an error. This patch ensures that the correct unprotect method is chosen by making sure the passed in rtcp flag is appropriately set when rtcp mux is enabled and an rtcp payload is received. ASTERISK-26979 #close Change-Id: Ic5409f9d1a267f1d4785fc5aed867daaecca6241	9 years ago
Sean Bright	0f487978a9	chan_sip: Better ICE handling for RTCP-MUX ... If we are offered or are offering RTCP-MUX, don't consider RTCP ICE candidates. This confuses certain browsers (current Firefox for example) and causes intial audio setup delays. ASTERISK-26982 #close Change-Id: Ifeaf47e83972fe8dbe58b7fb3d6d1823400cfb91	9 years ago
Steve Davies	be4beff3e4	app_queue: Add QUEUE_RAISE_PENALTY feature ... Additional variable to work alongside QUEUE_MAX_PENALTY and QUEUE_MIN_PENALTY, including an extra parameter in queuerules.conf. This value causes lower Agent penalty values to "raise up" so that they can join higher penalty agents and be treated equally after a period of time. ASTERISK-26995 #close Change-Id: If1c6421a983667a5ac4c359f6dac25b212b4c459	9 years ago
Joshua Colp	95c6b98acf	Merge "app_queue: Fix duplicate queue_log entries for EXITEMPTY and ABANDON"	9 years ago
Joshua Colp	8a83b473f1	Merge "app_stream_echo: Added a multi-stream echo application"	9 years ago
Jenkins2	5fffb96736	Merge "core/conversions: Added string to unsigned integer and long conversions"	9 years ago
Jenkins2	b5570de7b4	Merge "res_hep_rtcp: Add support level to module info"	9 years ago
Jenkins2	7631988c3d	Merge "AST-2017-004: chan_skinny: Add EOF check in skinny_session"	9 years ago
Jenkins2	79c7067c5e	Merge "AST-2017-003: Handle zero-length body parts correctly."	9 years ago
Mark Michelson	7c0466092c	AST-2017-003: Handle zero-length body parts correctly. ... ASTERISK-26939 #close Change-Id: I7ea235ab39833a187db4e078f0788bd0af0a24fd	9 years ago
George Joseph	949e9147bf	AST-2017-004: chan_skinny: Add EOF check in skinny_session ... The while(1) loop in skinny_session wasn't checking for EOF so a packet that was longer than a header but still truncated would spin the while loop infinitely. Not only does this permanently tie up a thread and drive a core to 100% utilization, the call of ast_log() in such a tight loop eats all available process memory. Added poll with timeout to top of read loop ASTERISK-26940 #close Reported-by: Sandro Gauci Change-Id: I2ce65f3c5cb24b4943a9f75b64d545a1e2cd2898	9 years ago
Mark Michelson	2bb98d8fac	AST-2017-002: Ensure transaction key buffer is large enough. ... ASTERISK-26938 #close Change-Id: I266490792fd8896a23be7cb92f316b7e69356413	9 years ago
Sean Bright	4141748e85	res_hep_rtcp: Add support level to module info ... Change-Id: I5661478f9cf12d431f730e42be79323b62831e92	9 years ago
Kevin Harwell	a60d1f3974	app_stream_echo: Added a multi-stream echo application ... If the channel does not have multi-stream support then this application acts just like app_echo. If it does have multi-stream support then each stream is echoed back to itself (one-to-one). If a "num" is specified, then a new topology is made that contains clones (from the channel's topology) of all media types that are not equal to the given "type". If the media type differs then the first stream matching the "type" is cloned into the new topology and then up to "num" - 1 of the same stream are also cloned into it. Any additional streams from the original topology matching the "type" are subsequently ignored (i.e. not added to the new topology). For this same case when a frame is read from a stream that frame is still echoed back like before, but now that frame is also echoed out to the additional streams that matched on the specified "type". ASTERISK-26997 #close Change-Id: I254144486734178e196c7f590a26ffc13543ff2c	9 years ago
Kevin Harwell	51375686f7	core/conversions: Added string to unsigned integer and long conversions ... Added functions that convert a string to an unsigned integer or unsigned long. A couple of unit test were also created to test the routines. The reasons for adding these conversion utilities (and hopefully eventually more) are as follows: * Conversion routines are functionally contained with consistent and better error checking * The function names offer a better description of what is happening * It encourages code reuse for easier bug fixing at a single source * It's simpler to use * It's unit testable For instance, currently in a lot of places when converting to an integer or similar the "sscanf" function is used. When using "sscanf" it may not be immediately clear what's happening as it lacks semantic naming. Limited error checking is usually done as well. For example, most of the time a check is done to make sure the value converted, but does not check for overflows or negative valued conversions when converting unsigned numbers. Why use/wrap "strtoul" and not "sscanf" then? Primarily, it lacks some of the built in error handling that "strtoul" has. For instance "strtoul" contains overflow checks. Less so, but can still factor as reasons, "sscanf" is slightly more complex in its use. And maybe a bit controversial, but it may be ("big if") potentially slower than "strtoul" in some cases. Change-Id: If7eaca4a48f8c7b89cc8b5a1f4bed2852fca82bb	9 years ago
Jenkins2	e74c48a46f	Merge "res_pjsip_session.c: Process initial INVITE sooner. (key exists)"	9 years ago
Joshua Colp	aa4c800060	Merge "Fix spelling queues.conf.sample file"	9 years ago
Richard Mudgett	30fbed65f1	res_pjsip_session.c: Process initial INVITE sooner. (key exists) ... Retransmissions of an initial INVITE could be queued in the serializer before we have processed the first INVITE message. If the first INVITE message doesn't get completely processed before the retransmissions are seen then we could try to setup the same call from the retransmissions. A symptom of this is seeing a (key exists) message associated with an INVITE. An earlier change attempted to address this kind of problem by calculating a distributor serializer to use for unassociated messages. Part of that change also made incoming calls keep using that distributor serializer. (ASTERISK-26088) However, some leftover code was still deferring the INVITE processing to the session's serializer even though we were already in that serializer. This not only is unnecessary but would cause the same call resetup problem. * Removed the code to defer processing the initial INVITE to the session's serializer because we are already running in that serializer. ASTERISK-26998 #close Change-Id: I1e822d82dcc650e508bc2d40d545d5de4f3421f6	9 years ago
Joshua Colp	094093b31d	Merge "chan_sip: Change sip_get_codec() to return correct codec list"	9 years ago
Rodrigo Ramírez Norambuena	6e7b78414f	Fix spelling queues.conf.sample file ... Change-Id: Ie1c2d83af66f27a449da09a68d987e0992627fee	9 years ago
George Joseph	ce4d8dac91	Merge changes from topic 'sdp_api_adjustments' ... * changes: SDP: Make process possible multiple fmtp attributes per rtpmap. SDP: Explicitly stop a RTP instance before destoying it. SDP: Rework merge_capabilities(). SDP: Update ast_get_topology_from_sdp() to keep RTP map.	9 years ago
George Joseph	28d4e6be9b	Merge "SDP: Remove sdp_state.remote_capabilities"	9 years ago
Jenkins2	f09e079294	Merge "SDP: Add interface_address to specify our address to use."	9 years ago
Vitezslav Novy	93b7f84c1a	chan_sip: Change sip_get_codec() to return correct codec list ... Return cahnnel nativeformats to fix bridge technology selection process. Same approach as in pjsip module. ASTERISK-26143 Reported-by: Henning Holtschneider Change-Id: I64e863753954d6ad67a9e722df2ebc328705ad48	9 years ago
Jenkins2	57217e4cc2	Merge "res_hep_rtcp: Provide chan_sip Call-ID for RTCP messages."	9 years ago
Jenkins2	542dd7d795	Merge "logger: Added logger_queue_limit to the configuration options."	9 years ago
Jenkins2	8b15719a11	Merge "tcptls: Improve error messages for TLS connections."	9 years ago
Jenkins2	2cb4cdc004	Merge "Prevent Undefined Capath Crash"	9 years ago
Ivan Poddubny	045dbcc2d6	app_queue: Fix duplicate queue_log entries for EXITEMPTY and ABANDON ... There are 2 places in app_queue.c that log EXITEMPTY event: one in wait_our_turn, and another one in queue_exec in the loop trying to call an agent after wait_our_turn. In most cases it leads to logging EXITEMPTY twice. ABANDON is also logged on two places, and in the rare case when an agent and caller hang up simultaneously it's also possible to get duplicates in queue_log. This commit changes wait_our_turn to return -1 ("the caller should exit the queue") instead of 0 ("the caller's turn has arrived") in case of leaving when empty, so queue_exec skips the agent calling loop. Also, leave_queue is now executed only once in this case, because 2nd time is just a noop when the queue entry has already been removed. Also, it sets qe->handled to -1 to indicate that the call was not answered by an agent, but the necessary handling has already been done in order to avoid logging an extra ABANDON entry. ASTERISK-25665 #close Reported by: Ove Aursand Change-Id: I4578dd383bf2ac41589cf167865e8aaebcd4c11e	9 years ago
Richard Mudgett	b8659be9b0	SDP: Make process possible multiple fmtp attributes per rtpmap. ... Change-Id: Ie7511008d82b59590e0eb520a21b5e1da4bd7349	9 years ago
Richard Mudgett	c2906dfa05	SDP: Remove sdp_state.remote_capabilities ... The sdp_state.remote_capabilities was only used inside merge_sdps() and subsequent calls to merge_sdps() by re-INVITE's would leak them. Change-Id: I0ceb7838ea044cc913e8ad4a255c39c9740ae0ce	9 years ago
Richard Mudgett	16785c0908	SDP: Add interface_address to specify our address to use. ... When we optionally set the interface_address we are forcing the media to go out a specific interface address. This allows us to optionally have the media go out the interface that SIP signalling came in on or if we are configured to have the media always go out a specific address. Change-Id: I160d9fac322a075bd2557b430632544178196189	9 years ago
Richard Mudgett	367042bd3e	SDP: Explicitly stop a RTP instance before destoying it. ... * Made sdp_add_m_from_rtp_stream() and sdp_add_m_from_udptl_stream() handle generating disabled/declined streams. * Added /main/sdp/sdp_merge_asymmetric unit test. It currently does not check the offerer side negotiated SDP because that isn't the purpose of this patch and there is much to be done to handle declined/dummy streams. * Added T.38 image streams to the /main/sdp/sdp_merge_symmetric and /main/sdp/sdp_merge_crisscross unit tests. Change-Id: Ib4dcb3ca4f9a9133b376f4e3302f9a1f963f2b31	9 years ago
Richard Mudgett	be5809fac8	SDP: Rework merge_capabilities(). ... * Tried to give better variable names. * Made our SDP answer use the offer's RTP payload types as the SDP RFC says we SHOULD. * Updating the local topology now takes the stream format caps. We are likely preparing to send an offer. Change-Id: I34d3be8e3036402a8575ffcae3eebc5ce348d7c0	9 years ago
Richard Mudgett	ae7689f093	SDP: Update ast_get_topology_from_sdp() to keep RTP map. ... * Add failure exits to ast_get_topology_from_sdp(). Change-Id: I4cc85c1ede8d712766ed20f544dbcef04c8c1049	9 years ago
Joshua Colp	cbbd119c21	tcptls: Improve error messages for TLS connections. ... This change uses the functions provided by OpenSSL to query and better construct error messages for situations where the connection encounters a problem. ASTERISK-26606 Change-Id: I7ae40ce88c0dc4e185c4df1ceb3a6ccc198f075b	9 years ago
Joshua Elson	10a4439ac9	Prevent Undefined Capath Crash ... It is possible to initialize a valid config without a capath or cafile definition. This will cause a crash on a reload. This fix ensures capath is always allocated. ASTERISK-26983 #close Change-Id: I63ff715d9d9023427543a5b8a4ba7b0d82533c12	9 years ago
George Joseph	1a1c86239d	cel_odbc: Fix timestamp processing for microseconds ... When a column is of type timestamp, the fraction part of the event field's seconds was frequently parsed incorrectly especially if there were leading zeros. For instance "2017-05-23 23:55:03.023" would be parsed into an int as "23" then when the timestamp was formatted again to be inserted into the database column it'd be "2017-05-23 23:55:03.23" which is now 230 milliseconds instead of 23 milliseconds. "03.000001" would be transformed to "03.1", etc. * If the event field is 'eventtime' and the db column is timestamp, then existing processing has already correctly formatted the timestamp so now we simply use it rather than parsing it and re-printing it. This is the most common use case anyway. * If the event field is other than 'eventtime' and the db column is timestamp, we now parse the seconds, including the fractional part into a double rather than 2 ints. This preserves the magnitude and precision of the fractional part. When we print it, we now print it as a "%09.6lf" which correctly represents the input. To be honest, why we parse the string timestamp into components, test the components, then print the components back into a string timestamp is beyond me. We should use parse it, test it, then if it passes, use the original string representation in the database call. Maybe someone thought that some implementations wouldn't take a partial timestamp string like "2017-05-06" and decided to always produce a full timestamp string even if an abbreviated one was supplied. Anyway, I'm leaving it as it is. ASTERISK-25032 #close Reported-by: Etienne Lessard Change-Id: Id407e6221f79a5c1120e1a70bc7e893bbcaf1938	9 years ago
Joshua Colp	3c36c29c81	res_hep_rtcp: Provide chan_sip Call-ID for RTCP messages. ... This change adds the required logic to allow the SIP Call-ID to be placed into the HEP RTCP traffic if the chan_sip module is used. In cases where the option is enabled but the channel is not either SIP or PJSIP then the code will fallback to the channel name as done previously. Based on the change on Nir's branch at: team/nirs/hep-chan-sip-support ASTERISK-26427 Change-Id: I09ffa5f6e2fdfd99ee999650ba4e0a7aad6dc40d	9 years ago