20185 Commits (1e8c66e749a20c2c0202f0da58918e9313f0512c)

 

All Branches   

Search

Author	SHA1	Message	Date
Mark Michelson	1e8c66e749	Fix errors where incorrect address information was printed. ... ast_sockaddr_stringiy_fmt (which is call by all ast_sockaddr_stringify* functions) uses thread-local storage for storing the string that it creates. In cases where ast_sockaddr_stringify_fmt was being called twice within the same statement, the result of one call would be overwritten by the result of the other call. This usually was happening in printf-like statements and was resulting in the same stringified addressed being printed twice instead of two separate addresses. I have fixed this by using ast_strdupa on the result of stringify functions if they are used twice within the same statement. As far as I could tell, there were no instances where a pointer to the result of such a call were saved anywhere, so this is the only situation I could see where this error could occur. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276570 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	5d9aa45721	Make compile again. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276531 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	4c94d1ee23	Oops, merge reverted this fix. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276493 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	832d1296c6	Remove the old stub files, preferring the optional_api method. ... (closes issue #17475) Reported by: tilghman Review: https://reviewboard.asterisk.org/r/695/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276490 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Kevin P. Fleming	8e7d01d484	Don't try to call an embedded module's backup_globals() function until ... after confirming it exists. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276441 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	d1c9a4b366	handle special case were "200 Ok" to pending INVITE never receives ACK ... Unlike most responses, the 200 Ok to a pending INVITE Request is acknowledged by an ACK Request. If the ACK Request for this Response is not received the previous behavior was to immediately destroy the dialog and hangup the channel. Now in an effort to be more RFC compliant, instead of immediately destroying the dialog during this special case, termination is done with a BYE Request as the dialog is technically confirmed when the 200 Ok is sent even if the ACK is never received. The behavior of immediately hanging up the channel remains. This only affects how dialog termination proceeds for this one special case. RFC 3261 section 13.3.1.4 "If the server retransmits the 2xx response for 64*T1 seconds without receiving an ACK, the dialog is confirmed, but the session SHOULD be terminated. This is accomplished with a BYE, as described in Section 15." git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276439 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	cf7bbcc4c6	Expand the caller ANI field to an ast_party_id ... Expand the ani field in ast_party_caller and ast_party_connected_line to an ast_party_id. This is an extension to the ast_callerid restructuring patch in review: https://reviewboard.asterisk.org/r/702/ Review: https://reviewboard.asterisk.org/r/744/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276393 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	e2599bc42c	collapse debug code in retrans_pkt into separate lines ... I've been working in this function a bunch lately, and these huge debug strings are getting annoying. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276392 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	2cf60bb09d	Make compile again. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276391 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	f4c665ee13	Do not skip sending MWI for a peer if an address is defined. Really just a merge mistake from IPv6 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276389 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tim Ringenbach	e19a6c248f	Fix documentation for pgsql cel and cdr, and slightly improve pgsql_cel. ... Change the documented pgsql schema to use "timestamp" instead of "time", as the latter is only a time without a date. Added some missing columns for cel's pgsql schema, and corrected spelling on some others. Updated cel's uniqueid size to be the same as the cdr. Added id column to cel's pgsql schema and updated code to allow unknown columns to get their default value instead of forcing 0 or empty string. Added microseconds to the timestamp cel logs to pgsql. Review: https://reviewboard.asterisk.org/r/734 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	ec37ffbdaf	ast_callerid restructuring ... The purpose of this patch is to eliminate struct ast_callerid since it has turned into a miscellaneous collection of various party information. Eliminate struct ast_callerid and replace it with the following struct organization: struct ast_party_name { char *str; int char_set; int presentation; unsigned char valid; }; struct ast_party_number { char *str; int plan; int presentation; unsigned char valid; }; struct ast_party_subaddress { char *str; int type; unsigned char odd_even_indicator; unsigned char valid; }; struct ast_party_id { struct ast_party_name name; struct ast_party_number number; struct ast_party_subaddress subaddress; char *tag; }; struct ast_party_dialed { struct { char *str; int plan; } number; struct ast_party_subaddress subaddress; int transit_network_select; }; struct ast_party_caller { struct ast_party_id id; char *ani; int ani2; }; The new organization adds some new information as well. * The party name and number now have their own presentation value that can be manipulated independently. ISDN supplies the presentation value for the name and number at different times with the possibility that they could be different. * The party name and number now have a valid flag. Before this change the name or number string could be empty if the presentation were restricted. Most channel drivers assume that the name or number is then simply not available instead of indicating that the name or number was restricted. * The party name now has a character set value. SIP and Q.SIG have the ability to indicate what character set a name string is using so it could be presented properly. * The dialed party now has a numbering plan value that could be useful to have available. The various channel drivers will need to be updated to support the new core features as needed. They have simply been converted to supply current functionality at this time. The following items of note were either corrected or enhanced: * The CONNECTEDLINE() and REDIRECTING() dialplan functions were consolidated into func_callerid.c to share party id handling code. * CALLERPRES() is now deprecated because the name and number have their own presentation values. * Fixed app_alarmreceiver.c write_metadata(). The workstring[] could contain garbage. It also can only contain the caller id number so using ast_callerid_parse() on it is silly. There was also a typo in the CALLERNAME if test. * Fixed app_rpt.c using ast_callerid_parse() on the channel's caller id number string. ast_callerid_parse() alters the given buffer which in this case is the channel's caller id number string. Then using ast_shrink_phone_number() could alter it even more. * Fixed caller ID name and number memory leak in chan_usbradio.c. * Fixed uninitialized char arrays cid_num[] and cid_name[] in sig_analog.c. * Protected access to a caller channel with lock in chan_sip.c. * Clarified intent of code in app_meetme.c sla_ring_station() and dial_trunk(). Also made save all caller ID data instead of just the name and number strings. * Simplified cdr.c set_one_cid(). It hand coded the ast_callerid_merge() function. * Corrected some weirdness with app_privacy.c's use of caller presentation. Review: https://reviewboard.asterisk.org/r/702/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276347 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Leif Madsen	608be652ba	Merged revisions 276267 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r276267 | lmadsen | 2010-07-14 06:49:01 -0500 (Wed, 14 Jul 2010) | 1 line Update documentation for voicemail.conf externpass option. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276268 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
David Vossel	23b6e621d2	chan_sip: RFC compliant retransmission timeout ... Retransmission of packets should not be based on how many packets were sent, but instead on a timeout period. Depending on whether or not the packet is for a INVITE or NON-INVITE transaction, the number of packets sent during the retransmission timeout period will be different, so timing out based on the number of packets sent is not accurate. This patch fixes this by removing the retransmit limit and only stopping retransmission after a timeout period is reached. By default this timeout period is 64*(Timer T1) for both INVITE and non-INVITE transactions. For more information on sip timer values refer to RFC3261 Appendix A. Review: https://reviewboard.asterisk.org/r/749/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276219 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	b42c6cab17	Revert early destruction of RTP sessions ... Some code improperly assumes that the sessions are still there, so revert the change until I can find all of them and fix them. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276206 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	22dbbc6db7	Recorded merge of revisions 276126 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r276126 | russell | 2010-07-13 14:14:54 -0500 (Tue, 13 Jul 2010) | 2 lines Only reset a CDR that exists. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276127 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	8ae46b53a8	Merged revisions 276123 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r276123 | russell | 2010-07-13 14:06:53 -0500 (Tue, 13 Jul 2010) | 2 lines Use chan->cdr instead of chan_cdr (just like peer->cdr instead of peer_cdr in the last commit). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276124 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	0ae9097e3e	Oops, XML documentation fix. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276122 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	fc9efc4ff5	It really cannot fail in the places below, but the stupid compiler doesn't know that. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276120 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	e939dfea9d	Weird compiler error on Bamboo. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276118 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	50d5f134c8	FILE() now supports line-mode and writing (altering) files. ... (closes issue #16461) Reported by: skyman Patches: 20100622__issue16461.diff.txt uploaded by tilghman (license 14) Tested by: tilghman Review: https://reviewboard.asterisk.org/r/737/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276114 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	6535a1d0ed	Merged revisions 275773 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275773 | jpeeler | 2010-07-12 15:34:51 -0500 (Mon, 12 Jul 2010) | 12 lines Make user removals and traversals thread safe in meetme. Race conditions present in meetme involving the user list where a lack of locking has the potential for a user to be removed during a traversal or as in the case of the reporter after checking if the list is empty could cause a crash. Fixing this was done by convering the userlist to an ao2 container. (closes issue #17390) Reported by: Vince Review: https://reviewboard.asterisk.org/r/746/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276074 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	cb160a12b0	Destroy RTP fds when we schedule final dialog destruction ... Since we are only keeping the dialog around for retransmissions at this point and there is no possibility that we are still handling RTP, go ahead and destroy the RTP sessions. Keeping them alive for 32 past when they are used is unnecessary and can lead to problems with having too many open file descriptors, etc. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275998 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	ea1307d9ad	Merged revisions 275994 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275994 | russell | 2010-07-13 11:51:18 -0500 (Tue, 13 Jul 2010) | 14 lines Access peer->cdr directly instead of through a saved off reference. At this point in the code, it is possible that peer_cdr may be invalid. Specifically, in the blind transfer code, CDRs are swapped between channels. So, peer_cdr is no longer == peer->cdr. The scenario that exposed a crash in this code was a blind transfer that hit the system call limit, causing the transferee channel to get destroyed after the transfer attempt failed. Even if it succeeds and this code doesn't crash, this code was still trying to reset a CDR on a channel that was now owned by a different thread, which is a BadThing(tm). (ABE-2417) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275995 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	9e51ba05d5	Merged revisions 275909 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275909 | tilghman | 2010-07-13 09:47:30 -0500 (Tue, 13 Jul 2010) | 2 lines Move SQL scripts into their own database-specific directories. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275910 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	e5a3a2f1cd	Add example script for use with the externpasscheck voicemail.conf option. ... (closes issue #17628) Reported by: lmadsen Tested by: russell, lmadsen Review: https://reviewboard.asterisk.org/r/774/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275863 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	6f8832735b	Don't try to ref authpeer when it isn't set ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275816 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	30071ba71b	Add which ITU spec specifies the numbering plan. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275725 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Jeff Peeler	e710ef67b9	Merged revisions 275665 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275665 | jpeeler | 2010-07-12 11:58:39 -0500 (Mon, 12 Jul 2010) | 11 lines Change ast_write to not stop generator when called from ast_prod. For SIP channels configured with the progressinband option on, the ringback was being immediately stopped. This problem was due to ast_prod being moved for a deadlock fix in 259858. Prodding the channel after setting up the generator triggered the check in ast_write to stop the generator. The fix here should write the frame the same as was done before the call to ast_prod was moved. (closes issue #17372) Reported by: tech_admin ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275682 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Leif Madsen	0c7357c94e	cdr_pgsql does not detect when a table is found. ... This change adds an ERROR message to let you know when a failure exists to get the columns from the pgsql database, which typically means that the table does not exist. (closes issue #17478) Reported by: kobaz Patches: cdr_pgsql.patch uploaded by kobaz (license 834) Tested by: kobaz, russell, lmadsen git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275626 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Mark Michelson	b1b29e5214	Allow netsock2.c to compile on systems that do not define AI_NUMERICSERV. ... (closes issue #17617) Reported by: pprindeville Patches: asterisk-trunk-bugid17617.patch uploaded by pprindeville (license 347) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275587 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
TransNexus OSP Development	f1df8ea2bf	Added support for indirect work mode. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275551 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Eliel C. Sardanons	7eafb1a763	When creating a conference for a unit test, it is not mandatory to open a ... dahdi pseudo channel, so if we fail doing it, continue creating the conference. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275509 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	fcaac09507	Make indentation consistent, move some queue features to the queue section. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275467 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	405d6cdf31	Add support for devices with less than 3 lines on the LCD. ... (closes issue #17600) Reported by: minaguib Patches: ast_unistim_height_v2.patch uploaded by minaguib (license 1078) Tested by: minaguib git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275466 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	b4ba8548e1	Fix some issues related to dynamic feature groups in features.conf. ... The bridge handling code did not properly consider feature groups when setting parameters that would affect whether or not a native bridge would be attempted. If DYNAMIC_FEATURES only include a feature group, a native bridge would occur that may prevent features from working. Fix a bug in verbose output that would show the key mapping as empty if it was using the default mapping and not a custom mapping in the feature group. Add feature groups to the output of "features show". Adjust the feature execution logic to match that of the logic when executing a feature that was not configured through a feature group. Update features.conf.sample to show that an '=' is still required if using the default key mapping from [applicationmap]. Finally, clean up a little bit of formatting to better coform to coding guidelines while in the area. (closes issue #17589) Reported by: lmadsen Patches: issue_17589.rev4.txt uploaded by russell (license 2) Tested by: russell, lmadsen git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275424 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Mark Michelson	7b1e28c6a1	Fix error in parsing SIP registry strings from ASTdb. ... It was essentially an off-by-one error. The easiest way to fix this was to use the handy-dandy AST_NONSTANDARD_RAW_ARGS macro to parse the pieces of the registration string out. Tested and it works wonderfully. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275385 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	2fdf43f9fc	Get more information about the Bamboo test failures ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275312 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	eaaeb7a1bc	Add missing ao2_iterator_destroy(). ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275310 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	c5476ecb69	Fix compile error. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275309 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Mark Michelson	e46325f18c	Fix port parsing in check_via. ... If a Via header contained an IPv6 address, we would not properly parse the port. We would instead get the information after the first colon in the address. (closes issue #17614) Reported by: oej Patches: diff uploaded by sperreault (license 252) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275308 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Paul Belanger	d348c9aa1e	Include rdnis in msgXXXX.txt file. ... (closes issue #17566) Reported by: outcast Patches: voicemail-rdnis.patch uploaded by outcast (license 1071) Tested by: outcast git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275307 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Mark Michelson	7e6f9b4e2d	Fix an issue where the port for p->ourip was being set to 0. ... This should fix all the CDR tests that were not passing. When they would originate a call, all fields in the INVITE that contained the source port would have the port set to 0. Most troubling of these was the Contact header. Tests are passing locally now and should also pass on the bamboo build agents. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275294 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Paul Belanger	d2872c60e4	Merged revisions 275241 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275241 | pabelanger | 2010-07-09 15:20:00 -0400 (Fri, 09 Jul 2010) | 8 lines Fix logging message for stale nonce. (closes issue #17582) Reported by: kenner Patches: chan_sip.c.diff uploaded by kenner (license 1040) Tested by: lmadsen ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275249 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	d6011adab4	Weird, no output and Bamboo still fails... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275227 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	7f145eeb1b	Merged revisions 275182 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275182 | mnicholson | 2010-07-09 13:23:23 -0500 (Fri, 09 Jul 2010) | 2 lines give a better error message when attempting to unload a module that is not loaded ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275186 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	384681e182	Add some diagnostic feedback to our data tests ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275172 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	2d63b5735c	Move parking lot sample config out from the middle of dynamic features sample config. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275147 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Matthew Nicholson	3fd53f575c	Merged revisions 275143 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r275143 | mnicholson | 2010-07-09 12:50:05 -0500 (Fri, 09 Jul 2010) | 2 lines don't unload modules that returned AST_MODULE_LOAD_DECLINE when they were loaded ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275144 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Tilghman Lesher	da8450323f	Kill some startup warnings and errors and make some messages more helpful in tracking down the source. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275105 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago