22459 Commits (1ac6dfc23e3fd415012ff3530ed956543eba534d)

 

All Branches   

Search

Author	SHA1	Message	Date
Automerge script	1ac6dfc23e	Merged revisions 376726 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376726 | jrose | 2012-11-28 10:30:27 -0600 (Wed, 28 Nov 2012) | 16 lines manager: Make challenge work with allowmultiplelogin=no Prior to this patch, challenge would yield a multiple logins error if used without providing the username (which isn't really supposed to be an argument to challenge) if allowmultiplelogin was set to no because allowmultiplelogin finds a user with a zero length login name. This check is simply disabled for the challenge action when the username is empty by this patch. (closes issue ASTERISK-20677) Reported by: Vladimir Patches: challenge_action_nomultiplelogin.diff uploaded by Jonathan Rose (license 6182) ........ Merged revisions 376725 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376754 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	1f73c34505	Merged revisions 376689 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376689 | rmudgett | 2012-11-27 17:58:23 -0600 (Tue, 27 Nov 2012) | 33 lines Fix extension matching with the '-' char. The '-' char is supposed to be ignored by the dialplan extension matching. Unfortunately, it's treatment is not handled consistently throughout the extension matching code. * Made the old exten matching code consistently ignore '-' chars. * Made the old exten matching code consistently handle case in the matching. * Made ignore empty character sets. * Fixed ast_extension_cmp() to return -1, 0, or 1 as documented. The only user of it in pbx_lua.c was testing for -1. It was originally returning the strcmp() value for less than which is not usually going to be -1. * Fix character set sorting if the sets have the same number of characters and start with the same character. Character set [0-9] now sorts before [02-9a] as originally intended. * Updated some extension label and priority already in use warnings to also indicate if the extension is aliased. (closes issue ASTERISK-19205) Reported by: Philippe Lindheimer, Birger "WIMPy" Harzenetter Tested by: rmudgett Review: https://reviewboard.asterisk.org/r/2201/ ........ Merged revisions 376688 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376717 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	a2ae62c0ff	Merged revisions 376658 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376658 | rmudgett | 2012-11-27 14:36:45 -0600 (Tue, 27 Nov 2012) | 21 lines Remove unnecessary channel module references. * Removed call to ast_module_user_hangup_all() in res_config_mysql.c since it is effectively a noop. No channels can attach a reference to that module. * Removed call to ast_module_user_hangup_all() in app_celgenuserevent.c. The caller of unload_module() has already called it. * Removed redundant channel module references in pbx_dundi.c. The registered dialplan function callback dispatchers for the read/read2/write callbacks already reference the module before calling. * pbx_dundi: Moved unregistering CLI commands, DUNDi switch, and dialplan functions to the first thing the unload_module() does. This will reduce the chance of new channels using DUNDi services while the module is being torn down. ........ Merged revisions 376657 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376686 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	e5b1b8058d	Merged revisions 376628 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376628 | rmudgett | 2012-11-27 11:35:54 -0600 (Tue, 27 Nov 2012) | 7 lines Made AST_LIST_REMOVE() simpler and use better names. * Update doxygen of AST_LIST_REMOVE(). ........ Merged revisions 376627 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376656 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	7fbd562985	Merged revisions 376587 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376587 | mjordan | 2012-11-22 17:56:00 -0600 (Thu, 22 Nov 2012) | 23 lines Re-initialize logmsgs mutex upon logger initialization to prevent lock errors Similar to the patch that moved the fork earlier in the startup sequence to prevent mutex errors in the recursive mutex surrounding the read/write thread registration lock, this patch re-initializes the logmsgs mutex. Part of the start up sequence before forking the process into the background includes reading asterisk.conf; this has to occur prior to the call to daemon in order to read startup parameters. When reading in a conf file, log statements can be generated. Since this can't be avoided, the mutex instead is re-initialized to ensure a reset of any thread tracking information. This patch also includes some additional debugging to catch errors when locking or unlocking the recursive mutex that surrounds locks when the DEBUG_THREADS build option is enabled. DO_CRASH or THREAD_CRASH will cause an abort() if a mutex error is detected. (issue ASTERISK-19463) Reported by: mjordan Tesetd by: mjordan ........ Merged revisions 376586 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376614 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	6c4d084c5c	Merged revisions 376522 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376522 | mmichelson | 2012-11-20 11:01:04 -0600 (Tue, 20 Nov 2012) | 14 lines Add "Require: timer" to 200 OK responses when appropriate. The method by which the Require header is added to 200 responses is inspired by the method that Olle Johansson uses in his darjeeling-prack branch. (closes issue ASTERISK-20570) Reported by Matt Jordan, at the behest of Olle Johansson Review: https://reviewboard.asterisk.org/r/2172 ........ Merged revisions 376521 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376539 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	a7c09018fe	Merged revisions 376470 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376470 | wdoekes | 2012-11-19 13:44:58 -0600 (Mon, 19 Nov 2012) | 11 lines Fix most leftover non-opaque ast_str uses. Instead of calling str->str, one should use ast_str_buffer(str). Same goes for str->used as ast_str_strlen(str) and str->len as ast_str_size(str). Review: https://reviewboard.asterisk.org/r/2198 ........ Merged revisions 376469 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376497 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	13b65b5dce	Merged revisions 376431 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376431 | mjordan | 2012-11-18 14:18:24 -0600 (Sun, 18 Nov 2012) | 49 lines Reorder startup sequence to prevent lockups when process is sent to background Although it is very rare and timing dependent, the potential exists for the call to 'daemon' to cause what appears to be a deadlock in Asterisk during startup. This can occur when a recursive mutex is obtained prior to the daemon call executing. Since daemon uses fork to send the process into the background, any threading primitives are unsafe to re-use after the call. Implementations of pthread recursive mutexes are highly likely to store the thread identifier of the thread that previously obtained the mutex. If the mutex was locked prior to the fork, a subsequent unlock operation will potentially fail as the thread identifier is no longer valid. Since the mutex is still locked, all subsequent attempts to grab the mutex by other threads will block. This behavior exhibited itself most often when DEBUG_THREADS was enabled, as this compile time option surrounds the mutexes in Asterisk with another recursive mutex that protects the storage of thread related information. This made it much more likely that a recursive mutex would be obtained prior to daemon and unlocked after the call. This patch does the following: a) It backports a patch from Asterisk 11 that prevents the spawning of the localtime monitoring thread. This thread is now spawned after Asterisk has fully booted. b) It re-orders the startup sequence to call daemon earlier during Asterisk startup. This limits the potential of threading primitives being accessed by initialization calls before daemon is called. c) It removes calls to ast_verbose/ast_log/etc. prior to daemon being called. Developers should send error messages directly to stderr prior to daemon, as calls to ast_log may access recursive mutexes that store thread related information. d) It reorganizes when thread local storage is created for storing lock information during the creation of threads. Prior to this patch, the read/write lock protecting the list of threads in ast_register_thread would utilize the lock in the thread local storage prior to it being initialized; this patch prevents that. On a very related note, this patch will *greatly* improve the stability of the Asterisk Test Suite. Review: https://reviewboard.asterisk.org/r/2197 (closes issue ASTERISK-19463) Reported by: mjordan Tested by: mjordan ........ Merged revisions 376428 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376446 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	fa81008f3a	Merged revisions 376414 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ........ r376414 | mjordan | 2012-11-18 08:22:39 -0600 (Sun, 18 Nov 2012) | 8 lines Add a test event that reports changes in ConfBridge state This patch adds a test event to ConfBridge that reports transitions between states in ConfBridge. This is used by tests in the Asterisk Test Suite that verify state changes based on the entering/leaving of conference participants. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376427 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	e5f0de162b	Merged revisions 376390 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376390 | jrose | 2012-11-16 13:41:55 -0600 (Fri, 16 Nov 2012) | 17 lines monitor: prevent attempts to move/remove recordings skipped with 'i' and 'o'. The i and o options for monitor skip the input and output sides of a recording respectively. This patch addresses a problem in those options when monitor is called without specifying a specific filename where monitor will try to move the recording that was skipped. Since this usually doesn't exist when these options are used, it would produce a warning when it does this in most cases, but it is conceivable that there are use cases where this could result in moving/removing a file unintentionally. (closes issue ASTERISK-20641) Reported by: Jonathan Rose Review: https://reviewboard.asterisk.org/r/2190/ ........ Merged revisions 376389 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376408 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	d1d4960725	Merged revisions 376342 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376342 | dlee | 2012-11-15 18:08:56 -0600 (Thu, 15 Nov 2012) | 9 lines Fixed extconf.c breakage introduced in r376306. To quote wdoekes: > Note that I'm not confirming legitimacy of having that file in tree at > all. Is anyone using aelparse/conf2ael? ........ Merged revisions 376340 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376370 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	da618f42ea	Merged revisions 376308,376315 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376308 | jrose | 2012-11-15 16:55:04 -0600 (Thu, 15 Nov 2012) | 17 lines app_meetme: Fix channels lingering when hung up under certain conditions Channels would get stuck and MeetMe would repeatedly display an Unable to write frame to channel error in the conf_run function if hung up during certain sound prompts such as during user count announcements. This patch fixes that by reintroducing a hangup check in the meetme's main loop (also in conf_run). (closes issue ASTERISK-20486) Reported by: Michael Cargile Review: https://reviewboard.asterisk.org/r/2187/ Patches: meetme_hangup_patch_ASTERISK-20486_v3.diff uploaded by Jonathan Rose (license 6182) ........ Merged revisions 376307 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ r376315 | dlee | 2012-11-15 17:17:54 -0600 (Thu, 15 Nov 2012) | 28 lines Migrate hashtest/hashtest2 to be unit tests. Both hashtest and hashtest2 are manual testing apps that thrash hash tables (hashtab and ao2 containers, respectively), by spinning up several threads that randomly insert, delete, lookup and iterate over the hash table. If the app doesn't crash, the hash table probably passes the test. Those utils are not a part of the typical Asterisk build, so they do not usually get compiled. This all makes them less that useful. This patch removes those manual test programs and replaces them with Asterisk unit test modules (test_{hashtab,astobj2}_thrash.so). It also attempts to make the tests more deterministic. * Rather than spinning up some number of threads that operate on the hash table randomly, spin up four threads that concurrenly add, remove, lookup and iterate over the hash table. * Each thread checks the state of the hash table both during and after execution, and indicates a test failure if things are not as expected. * Each thread times out after 60 seconds to prevent deadlocking the unit test run. (closes issue ASTERISK-20505) Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2189/ ........ Merged revisions 376306 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376338 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
David M. Lee	27d03eb7a9	Reverted r376309; merged to wrong branch ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376311 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
David M. Lee	292fd22902	Migrate hashtest/hashtest2 to be unit tests. ... Both hashtest and hashtest2 are manual testing apps that thrash hash tables (hashtab and ao2 containers, respectively), by spinning up several threads that randomly insert, delete, lookup and iterate over the hash table. If the app doesn't crash, the hash table probably passes the test. Those utils are not a part of the typical Asterisk build, so they do not usually get compiled. This all makes them less that useful. This patch removes those manual test programs and replaces them with Asterisk unit test modules (test_{hashtab,astobj2}_thrash.so). It also attempts to make the tests more deterministic. * Rather than spinning up some number of threads that operate on the hash table randomly, spin up four threads that concurrenly add, remove, lookup and iterate over the hash table. * Each thread checks the state of the hash table both during and after execution, and indicates a test failure if things are not as expected. * Each thread times out after 60 seconds to prevent deadlocking the unit test run. (closes issue ASTERISK-20505) Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2189/ ........ Merged revisions 376306 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376309 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	b5239761f9	Merged revisions 376263 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376263 | newtonr | 2012-11-14 19:50:54 -0600 (Wed, 14 Nov 2012) | 10 lines (issue ASTERISK-20280) (closes issue ASTERISK-20280) Reported by: Tomo Takebe Tested by: Rusty Newton Patches: asterisk20280.patch uploaded by Rusty Newton (license 5829) ........ Merged revisions 376262 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376281 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	9f10c03f5c	Merged revisions 376233 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376233 | rmudgett | 2012-11-14 13:50:52 -0600 (Wed, 14 Nov 2012) | 19 lines Fix call files when astspooldir is relative. Future dated call files are ignored when astspooldir is relative to the current directory. The queue_file() assumed that the qdir needed to be prepended if the given filename did not start with a '/'. If astspooldir is relative it is not going to start from the root directory obviously so it will not start with a '/'. The filename used in queue_file() ultimately results in qdir prepended multiple times. * Made queue_file() not prepend qdir if the filename contains a '/'. (closes issue ASTERISK-20593) Reported by: James Le Cuirot Patches: 0004-Fix-future-call-files-from-relative-directories.patch (license #6439) patch uploaded by James Le Cuirot ........ Merged revisions 376232 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376260 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	9df6da141c	Merged revisions 376208 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376208 | beagles | 2012-11-13 12:20:13 -0600 (Tue, 13 Nov 2012) | 14 lines Patch to prevent stopping the active generator when it is not the silence generator. This patch introduces an internal helper function to safely check whether the current generator is the one that is expected before deactivating it. The current externally accessible ast_channel_stop_generator() function has been modified to be implemented in terms of the new function. (closes issue ASTERISK-19918) Reported by: Eduardo Abad ........ Merged revisions 376199 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376216 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	1bc8ecc7cb	Merged revisions 376167 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376167 | file | 2012-11-12 14:44:56 -0600 (Mon, 12 Nov 2012) | 14 lines Properly check if the "Context" and "Extension" headers are empty in a ShowDialPlan action. The code which handles the ShowDialPlan action wrongly assumed that a non-NULL return value from the function which retrieves headers from an action indicates that the header has a value. This is incorrect and the contents must be checked to see if they are blank. (closes issue ASTERISK-20628) Reported by: jkroon Patches: asterisk-showdialplan-incorrect-error.patch uploaded by jkroon ........ Merged revisions 376166 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376194 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	c6445ed8c0	Merged revisions 376143 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376143 | elguero | 2012-11-12 14:15:27 -0600 (Mon, 12 Nov 2012) | 20 lines Fix Dynamic Hints Variable Substition - Underscore Problem When adding a dynamic hint, if an extension contains an underscore no variable subsitution is being performed. This patch changes from checking if the extension contains an underscore to checking if the extension begins with an underscore. (closes issue ASTERISK-20639) Reported by: Steven T. Wheeler Tested by: Steven T. Wheeler, Michael L. Young Patches: asterisk-20639-dynamic-hint-underscore.diff uploaded by Michael L. Young (license 5026) Review: https://reviewboard.asterisk.org/r/2188/ ........ Merged revisions 376142 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376165 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	847cdb015e	Merged revisions 376088 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376088 | mmichelson | 2012-11-08 15:59:13 -0600 (Thu, 08 Nov 2012) | 12 lines Fix a "set but not used" warning on newer gccs. Turns out the "helpful" setting of ms and res in this macro is completely useless after the timeout antipattern fix. If you're a new guy looking to write code, don't write a macro like this one. ........ Merged revisions 376087 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376117 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	e2a5df153e	Merged revisions 376059 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376059 | rmudgett | 2012-11-08 15:07:09 -0600 (Thu, 08 Nov 2012) | 16 lines chan_dahdi/SS7: Made reject incoming call for an in-alarm or blocked channel. If a SS7 call comes in requesting a CIC that is in-alarm, the call is accepted and connects if the extension exists in the dialplan. The call does not have any audio. * Made release the call immediately with circuit congestion cause. (closes issue ASTERISK-20204) Reported by: Tuan Le Patches: jira_asterisk_20204_v1.8.patch (license #5621) patch uploaded by rmudgett ........ Merged revisions 376058 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	b3257643c8	Merged revisions 376030 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r376030 | rmudgett | 2012-11-08 11:08:39 -0600 (Thu, 08 Nov 2012) | 35 lines Add MALLOC_DEBUG enhancements. * Makes malloc() behave like calloc(). It will return a memory block filled with 0x55. A nonzero value. * Makes free() fill the released memory block and boundary fence's with 0xdeaddead. Any pointer use after free is going to have a pointer pointing to 0xdeaddead. The 0xdeaddead pointer is usually an invalid memory address so a crash is expected. * Puts the freed memory block into a circular array so it is not reused immediately. * When the circular array rotates out a memory block to the heap it checks that the memory has not been altered from 0xdeaddead. * Made the astmm_log message wording better. * Made crash if the DO_CRASH menuselect option is enabled and something is found. * Fixed a potential alignment issue on 64 bit systems. struct ast_region.data[] should now be aligned correctly for all platforms. * Extracted region_check_fences() from __ast_free_region() and handle_memory_show(). * Updated handle_memory_show() CLI usage help. Review: https://reviewboard.asterisk.org/r/2182/ ........ Merged revisions 376029 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376047 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	a54fdc3e43	Merged revisions 375995 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375995 | mmichelson | 2012-11-07 11:16:24 -0600 (Wed, 07 Nov 2012) | 41 lines Multiple revisions 375993-375994 ........ r375993 | mmichelson | 2012-11-07 11:01:13 -0600 (Wed, 07 Nov 2012) | 30 lines Fix misuses of timeouts throughout the code. Prior to this change, a common method for determining if a timeout was reached was to call a function such as ast_waitfor_n() and inspect the out parameter that told how many milliseconds were left, then use that as the input to ast_waitfor_n() on the next go-around. The problem with this is that in some cases, submillisecond timeouts can occur, resulting in the out parameter not decreasing any. When this happens thousands of times, the result is that the timeout takes much longer than intended to be reached. As an example, I had a situation where a 3 second timeout took multiple days to finally end since most wakeups from ast_waitfor_n() were under a millisecond. This patch seeks to fix this pattern throughout the code. Now we log the time when an operation began and find the difference in wall clock time between now and when the event started. This means that sub-millisecond timeouts now cannot play havoc when trying to determine if something has timed out. Part of this fix also includes changing the function ast_waitfor() so that it is possible for it to return less than zero when a negative timeout is given to it. This makes it actually possible to detect errors in ast_waitfor() when there is no timeout. (closes issue ASTERISK-20414) reported by David M. Lee Review: https://reviewboard.asterisk.org/r/2135/ ........ r375994 | mmichelson | 2012-11-07 11:08:44 -0600 (Wed, 07 Nov 2012) | 3 lines Remove some debugging that accidentally made it in the last commit. ........ Merged revisions 375993-375994 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@376013 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	00a9d4a50b	Merged revisions 375965 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375965 | rmudgett | 2012-11-06 12:27:19 -0600 (Tue, 06 Nov 2012) | 21 lines Fix stuck DTMF when bridge is broken. When a bridge is broken by an AMI Redirect action or the ChannelRedirect application, an in progress DTMF digit could be stuck sending forever. * Made simulate a DTMF end event when a bridge is broken and a DTMF digit was in progress. (closes issue ASTERISK-20492) Reported by: Jeremiah Gowdy Patches: bridge_end_dtmf-v3.patch.txt (license #6358) patch uploaded by Jeremiah Gowdy Modified to jira_asterisk_20492_v1.8.patch jira_asterisk_20492_v1.8.patch (license #5621) patch uploaded by rmudgett Tested by: rmudgett Review: https://reviewboard.asterisk.org/r/2169/ ........ Merged revisions 375964 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375992 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	16456df8e0	Merged revisions 375894 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375894 | mjordan | 2012-11-05 17:00:32 -0600 (Mon, 05 Nov 2012) | 28 lines Refactor ast_timer_ack to return an error and handle the error in timer users Currently, if an acknowledgement of a timer fails Asterisk will not realize that a serious error occurred and will continue attempting to use the timer's file descriptor. This can lead to situations where errors stream to the CLI/log file. This consumes significant resources, masks the actual problem that occurred (whatever caused the timer to fail in the first place), and can leave channels in odd states. This patch propagates the errors in the timing resource modules up through the timer core, and makes users of these timers handle acknowledgement failures. It also adds some defensive coding around the use of timers to prevent using bad file descriptors in off nominal code paths. Note that the patch created by the issue reporter was modified slightly for this commit and backported to 1.8, as it was originally written for Asterisk 10. Review: https://reviewboard.asterisk.org/r/2178/ (issue ASTERISK-20032) Reported by: Jeremiah Gowdy patches: jgowdy-timerfd-6-22-2012.diff uploaded by Jeremiah Gowdy (license 6358) ........ Merged revisions 375893 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375921 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	b3b15ff3b7	Merged revisions 375863 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375863 | rmudgett | 2012-11-05 15:39:00 -0600 (Mon, 05 Nov 2012) | 10 lines Add safety NULL pointer check in module user references. Made __ast_module_user_remove() check for NULL pointers. ........ Merged revision 375860 from C.3 ........ Merged revisions 375862 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375892 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	8482c913bc	Merged revisions 375846 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ........ r375846 | jrose | 2012-11-05 11:55:13 -0600 (Mon, 05 Nov 2012) | 9 lines chan_sip: Document a change to user-field encoding introduced with r303509 The change in question was added to improve compliance with RFC3261, but at the time of commit, it wasn't adequately documented in the UPGRADE notes. (closes issue ASTERISK-20561) Reported by: Deniz Review: https://reviewboard.asterisk.org/r/2177/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375858 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	e5b13b3893	Merged revisions 375794,375797,375801 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375794 | mjordan | 2012-11-03 21:30:30 -0500 (Sat, 03 Nov 2012) | 15 lines Properly clean up manager resources on exit This patch does two things: 1) It properly unregisters the manager CLI commands 2) It cleans up AMI users on exit. Prior to this patch, the AMI users were not being disposed of properly, resulting in a memory leak. (closes issue ASTERISK-20646) Reported by: Corey Farrell patches: manager_shutdown.patch uploaded by Corey Farrell (license 5909) ........ Merged revisions 375793 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ r375797 | mjordan | 2012-11-03 21:42:43 -0500 (Sat, 03 Nov 2012) | 9 lines Only deref a reserved gateway session if we actually reserved one Its perfectly acceptable to have a gateway session unreserved when we go to first allocate one. Unreffing the reserved gateway session - when its NULL - will result in an assertion error. This problem was caught by the Asterisk Test Suite (once we had enough of the debugging flags enabled) ................ r375801 | mjordan | 2012-11-03 22:08:12 -0500 (Sat, 03 Nov 2012) | 17 lines Don't attempt to purge sessions when no sessions exist Manager's tcp/tls objects have a periodic function that purge old manager sessions periodically. During shutdown, the underlying container holding those sessions can be disposed of and set to NULL before the tcp/tls periodic function is stopped. If the periodic function fires, it will attempt to iterate over a NULL container. This patch checks for whether or not the sessions container exists before attempting to purge sessions out of it. If the sessions container is NULL, we simply return. Note that this error was also caught by the Asterisk Test Suite. ........ Merged revisions 375800 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375828 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	5d25d0b9cd	Merged revisions 375759,375761 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375759 | mjordan | 2012-11-03 19:55:19 -0500 (Sat, 03 Nov 2012) | 18 lines Fix memory leak when unloading XML documentation This patch is a modified version of a patch originally committed for the Asterisk 11 branch in r375756. A portion of that patch, that fixed the memory leak during unloading XML documentation, applies to branches 1.8 and 10 as well. The patch for this issue was modified for these two branches. (issue ASTERISK-20648) Reported by: Corey Farrell Tested by: mjordan patches: xmldoc-memory_leak.patch uploaded by Corey Farrell (license 5909) ........ Merged revisions 375758 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ r375761 | mjordan | 2012-11-03 20:13:37 -0500 (Sat, 03 Nov 2012) | 15 lines Properly finalize prepared SQLite3 statements to prevent memory leak The AstDB uses prepared SQLite3 statements to retrieve data from the SQLite3 database. These statements should be finalized during Asterisk shutdown so that the SQLite3 database can be properly closed. Failure to finalize the statements results in a memory leak and a failure when closing the database. This patch fixes those issues by ensuring that all prepared statements are properly finalized at shutdown. (closes issue ASTERISK-20647) Reported by: Corey Farrell patches: astdb-sqlite3_close.patch uploaded by Corey Farrell (license 5909) ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375788 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	7b42069837	Merged revisions 375728 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375728 | mjordan | 2012-11-03 18:51:43 -0500 (Sat, 03 Nov 2012) | 16 lines Prevent multiple CDR batches from conflicting when scheduling the CDR write The Asterisk Test Suite caught an error condition where a scheduled CDR batch write can be deleted twice if two channels attempt to post their CDRs at the same time. The batch CDR mutex is locked while the CDRs are appended to the current batch list; however, it is unlocked prior to actually scheduling the CDR write. As such, two threads can attempt to remove the currently scheduled batch write at the same time, resulting in an assertion error. This patch extends the time that the mutex is locked to encompass actually scheduling the write. This prevents two threads from unscheduling the currently scheduled write at the same time. ........ Merged revisions 375727 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375755 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	adf1258a70	Merged revisions 375699 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375699 | lathama | 2012-11-02 22:15:30 -0500 (Fri, 02 Nov 2012) | 9 lines Doxygen Updates Replace links to missing text files removed in the 1.6.x series with links to the wiki. Doxygen can handle URLs fine, don't atempt to quote them. Also update the wiki link in the Readme to get everyone on the same page. (issue ASTERISK-20259) ........ Merged revisions 375698 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375719 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	c9c13c10e9	Merged revisions 375659 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375659 | rmudgett | 2012-11-02 15:53:53 -0500 (Fri, 02 Nov 2012) | 5 lines Things don't need to be that const. ........ Merged revisions 375658 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375688 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	4c51191b08	Merged revisions 375626 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375626 | rmudgett | 2012-11-02 13:42:23 -0500 (Fri, 02 Nov 2012) | 127 lines Multiple revisions 375519-375524 ........ r375519 | rmudgett | 2012-10-30 16:06:15 -0500 (Tue, 30 Oct 2012) | 11 lines chan_misdn: Timer primitives must be handled first. The frm->addr is a different "address space" than the stack/instance address of other Lx primitives. The test for B channel instance address could fail. Patches: patch01_timers.diff (license #6372) patch uploaded by Guenther Kelleter JIRA ABE-2888 ........ r375520 | rmudgett | 2012-10-30 16:14:58 -0500 (Tue, 30 Oct 2012) | 10 lines chan_misdn: Free memory in error paths and other memory leaks. The one line commented with BUG is not easily fixable because there is no de-init function one can call. Patches: patch02_memory.diff (license #6372) patch uploaded by Guenther Kelleter JIRA ABE-2888 ........ r375521 | rmudgett | 2012-10-30 16:38:41 -0500 (Tue, 30 Oct 2012) | 14 lines chan_misdn: ISDN NT L2 de-establish/establish * An NT-PTMP cannot de/establish L2 since it doesn't know the TEIs. * On NT-PTP L2 is started when L1 is finally active in handle_l1. * L2 deactivation logging cleanup. * L2 aggregate link status is unknown for NT-PTMP, show as "UNKN". * Removed unused functions and code for L2 handling. Patches: patch03_L2estab.diff (license #6372) patch uploaded by Guenther Kelleter Modified JIRA ABE-2888 ........ r375522 | rmudgett | 2012-10-30 16:56:14 -0500 (Tue, 30 Oct 2012) | 22 lines chan_misdn: Fix broken upper_id/lower_id usage. Sending PH prim via lower_id layer (3 or 1) simply does not work. For TE (3) it returns an error (len=-6) which is not evaluated by handle_l1(), so the L1 layer status ends up wrong. Instead PH must be sent via L4, only then does it reach L1 without an error message. And NT PH prims only reach L1 when they are sent to layer 2 id. --> use upper_id to send PH primitives. * Check for errors in PH_(DE)ACTIVATE | CONFIRM. * Debug messages are improved. * The lower_id is now not used for anything, except: Why is lower_id layer deleted when it wasn't created? I removed this code since it looks very wrong. Patches: patch04_l1activation.diff (license #6372) patch uploaded by Guenther Kelleter JIRA ABE-2888 ........ r375523 | rmudgett | 2012-10-30 17:29:15 -0500 (Tue, 30 Oct 2012) | 31 lines chan_misdn: Fix loss of B channels if L1 is down. If you make 2 calls out an NT PTMP port which is not connected to any phone, the B channel associated with that call becomes unusable until Asterisk is restarted. The problem is the EVENT_SETUP is queued when L1 is not up in misdn_lib_send_event(). If L1 cannot be activated the event won't be dequeued. It gets even worse when the call is hung up. The queued EVENT_SETUP will be overwritten by an EVENT_DISCONNECT. The reserved B channel then will never be freed. If later someone connects a phone to the port, L1 will eventually activate and the queued EVENT_DISCONNECT is sent down the stack. However, it is ignored because it is the wrong call state. The real fix would be that activation and queueing for a new SETUP is done by the NT stack. But since it doesn't, the workaround must be removed because it doesn't always work. Fix: The event is no longer queued but immediately sent to the stack. If L1 cannot be activated, the L3 state machine that was started by the EVENT_SETUP will do its work, i.e. a timeout will release the B channel properly. The SETUP possibly cannot be sent the first time but is resent by T303 in case L1 could be activated. Patches: patch05_bchan-loss.diff (license #6372) patch uploaded by Guenther Kelleter Modified JIRA ABE-2888 ........ r375524 | rmudgett | 2012-10-30 18:26:05 -0500 (Tue, 30 Oct 2012) | 13 lines chan_misdn: Remove some calls to exit(). Try proper cleanup when something goes wrong in misdn_lib_init(). Especially do not call exit()! * Fix memory leak because stack_destroy() does not free the stack struct. Patches: patch06_cleanup-init.diff (license #6372) patch uploaded by Guenther Kelleter Modified JIRA ABE-2888 ........ Merged revisions 375519-375524 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier ........ Merged revisions 375625 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375657 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	61410a47b4	Merged revisions 375601 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375601 | elguero | 2012-11-02 12:19:33 -0500 (Fri, 02 Nov 2012) | 14 lines Fix Wrong Result In Debug Message For SDP Origin Processing While looking at some debug logs, I noticed that it was being reported that the SDP origin line was unsupported or failed. Upon looking into this on my local machine, I found that I too was getting this debug message yet everything seemed to be getting processed properly. What was discovered is, that, the variable to determine what is displayed in the debug message for the SDP line that was processed, was not being set for the origin line when the result was successful. This patch fixes this and was tested on local machine. ........ Merged revisions 375594 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375612 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	84069f99d4	Merged revisions 375531 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375531 | mjordan | 2012-10-31 09:34:42 -0500 (Wed, 31 Oct 2012) | 24 lines Properly extract the Body information of an EWS calendar item Unlike all other calendar modules, res_calendar_ews fails to extract the Body information for a calendar item. This is due, in part, to a quirk in the schema in the XML - not only does a CalendarItem contain a Body element, but the CalendarItem exists as a descendant of a different Body element. The neon parser was erroneously skipping all Body elements. This patch fixes that by bypassing Body elements that are not a child of CalendarItem, and parsing the Body element out if it is a child. Note that the original patch by Terry Wilson only needed slight modifications to make it properly pull the Body information out; as such, while I've linked to the patch that I uploaded for Dmitry, I've attributed the patch to Terry. (closes issue ASTERISK-19738) Reported by: Dmitry Burilov Tested by: Dmitry Burilov patches: calendar_ews_body_2012_10_29.diff uploaded by Terry Wilson (license 6283) ........ Merged revisions 375528 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375558 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	6181402839	Merged revisions 375485,375496 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375485 | jrose | 2012-10-30 13:55:58 -0500 (Tue, 30 Oct 2012) | 8 lines mixmonitor: Add a test event This test event is being used to fix the mixmonitor_audiohook_inherit test. ........ Merged revisions 375484 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ r375496 | rmudgett | 2012-10-30 14:20:28 -0500 (Tue, 30 Oct 2012) | 8 lines Fix ConfBridge crash if no timing module loaded. (closes issue ASTERISK-19448) Reported by: feyfre Patches: smfix.patch (license #6099) patch uploaded by feyfre Modified for coding guidelines. ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375510 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	8919c7068e	Merged revisions 375470 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ........ r375470 | jrose | 2012-10-30 09:42:29 -0500 (Tue, 30 Oct 2012) | 7 lines confbridge: Fix a bug which made conferences not record with AMI/CLI commands (closes issue ASTERISK-20601) Reported by: Vilius Patches: confbridge_mixmonitor.diff uploaded by Jonathan Rose (license 6182) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375481 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	b7ea4e0c78	Merged revisions 375451 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375451 | mjordan | 2012-10-29 21:14:01 -0500 (Mon, 29 Oct 2012) | 14 lines Ensure that the Queue application tracks busy members in off nominal situations There are a few code paths where the Queue application fails to count a paused or in use queue member as being 'busy'. This can cause callers to get stuck in the Queue until a paused agent unpauses themselves. (closes issue ASTERISK-20623) Reported by: Bryan Walters patches: app_queue.patch uploaded by Bryan Walters (license 5851) ........ Merged revisions 375450 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375468 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	d106b3edf0	Merged revisions 375417 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375417 | mmichelson | 2012-10-29 16:09:18 -0500 (Mon, 29 Oct 2012) | 23 lines Prevent resetting of NATted realtime peer address on reload. If a "sip reload" is issued for a SIP peer, then his IP address will be cleared, thus resulting in forgetting the public IP address. Asterisk will then attempt to route SIP traffic to the private IP address. The fix here is to make "sip reload" ignore realtime peers when "host = dynamic" is spotted. Realtime peers can now only have their IP address reset if they have gone from being not dynamic to being dynamic. (closes issue ASTERISK-18203) reported by daren ferreira (closes issue ASTERISK-20572) reported by JoshE Patches: fix_nat_realtime.diff uploaded by JoshE (license #6075) ........ Merged revisions 375415 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375441 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	e86715f8ca	Merged revisions 375389 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375389 | rmudgett | 2012-10-29 14:28:38 -0500 (Mon, 29 Oct 2012) | 16 lines Fix the Park 'r' option when a channel parks itself. When a channel uses the Park appliation to park itself with the 'r' option, the channel hears music-on-hold instead of the requested ringing. * Added a missing check for the 'r' option when a channel parks itself. (closes issue ASTERISK-19382) Reported by: James Stocks Patches by: dsessions Review: https://reviewboard.asterisk.org/r/2148/ ........ Merged revisions 375388 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375414 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	f45acec195	Merged revisions 375362 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375362 | rmudgett | 2012-10-29 10:51:24 -0500 (Mon, 29 Oct 2012) | 15 lines chan_dahdi: Fix segfault dereferencing a NULL tech_pvt. The tech support customer was using the AMI Redirect action shortly after a call was placed. While the channel tried to do an ast_read(), the masquerade resulting from the channel redirect took place. The masquerade in the middle of the ast_read() resulted in the segfault. (closes issue AST-1025) Reported by: Trey Blancher Patches: jira_ast_1025_v1.8_v2.patch (license #5621) patch uploaded by rmudgett ........ Merged revisions 375361 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375387 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	3a644912e3	Merged revisions 375326 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375326 | jrose | 2012-10-23 11:21:22 -0500 (Tue, 23 Oct 2012) | 10 lines ast_tls_cert script: Better response for various exit conditions to openssl (closes issue ASTERISK-20260) Reported by: Daniel O'Connor Patches: ast_tls_cert-update.diff uploaded by Daniel O'Connor (license 6419) ........ Merged revisions 375325 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375350 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	d0b4bde150	Merged revisions 375300 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375300 | jrose | 2012-10-22 14:56:20 -0500 (Mon, 22 Oct 2012) | 14 lines core: Fix a memory leak in app.c from an early return ast_app_group_match_get_count allocates memory with the regcomp function and we previously forgot to free it when bailing out due to a regex compilation failure against category. (closes issue AST-1018) Reported by: Guenther Kelleter Patches: regcomp_memleak.diff uploaded by Guenther Kelleter (license 6372) ........ Merged revisions 375299 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375321 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	b5d03fe51a	Merged revisions 375273 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375273 | jrose | 2012-10-22 12:08:49 -0500 (Mon, 22 Oct 2012) | 10 lines GSM: Fix encoding problems with GSM (closes issue ASTERISK-20457) Reported by: Richard Miller Patches: code.patch uploaded by Richard Miller (license 5685) ........ Merged revisions 375272 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375290 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	c0bd3ca97a	Merged revisions 375243,375245 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375243 | jrose | 2012-10-18 16:35:20 -0500 (Thu, 18 Oct 2012) | 11 lines Blocked revisions 375242 ........ app_queue: add upgrade notes for 375216 Adds notes describing behavioral changes to rrmemory strategy caused by 375216 (issue AST-989) Reported by: Thomas Arimont ................ r375245 | jrose | 2012-10-18 16:39:14 -0500 (Thu, 18 Oct 2012) | 8 lines app_queue: add upgrade notes for 375216 Adds notes describing behavioral changes to rrmemory strategy caused by 375216 (issue AST-989) Reported by: Thomas Arimont ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375271 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	239161dbb5	Merged revisions 375217 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375217 | jrose | 2012-10-18 16:09:29 -0500 (Thu, 18 Oct 2012) | 15 lines app_queue: Make ordering of rrmemory/rrordered persist over add/remove members Prior to this patch, adding, removing or reloading members to rrmemory would cause the order to become completely jumbled. Now it behaves more or less like rrordered other than the fact that it stores the members on a hash table rather than a linked list. This patch also prevents removal of members and member reloads from jumbling rrordered queues. (issue AST-989) Reported by: Thomas Arimont Review: https://reviewboard.asterisk.org/r/2164/ ........ Merged revisions 375216 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375241 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	f24ded7028	Merged revisions 375190 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375190 | rmudgett | 2012-10-18 14:53:08 -0500 (Thu, 18 Oct 2012) | 36 lines build_tools: Allow Asterisk to report git SHAs in version string. Make git more attractive for managing work-in-progress. Especially convenient when a potential patch set needs to be tested on multiple platforms since one can use git to keep all the test environments in sync independent of a subversion server. Now the Asterisk version will show the exact git SHA5 that was used when building (still appended by "M" if there are local modifications) from a git clone of the Asterisk repository so the developer can more easily know what is actually under test. You will now get this: $ asterisk -V Asterisk GIT-1698298 Instead of this: $ asterisk -V Asterisk UNKNOWN__and_probably_unsupported This has zero impact for those not using git with the exception of an extra test in the configure script to gather git's path. This is necessary to prevent "sudo make install" from failing since git may not be in the path in make's shell environment. (closes issue ASTERISK-20483) Reported by: Shaun Ruffell Patches: 0001-build_tools-Allow-Asterisk-to-report-git-SHAs-in-ver.patch (license #5417) patch uploaded by Shaun Ruffell Modified ........ Merged revisions 375189 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375214 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	ce92b69386	Merged revisions 375147 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375147 | kmoore | 2012-10-17 13:58:52 -0500 (Wed, 17 Oct 2012) | 15 lines Ensure Asterisk fails TCP/TLS SIP calls when certificate checking fails When placing a call to a TCP/TLS SIP endpoint whose certificate is not signed by a configured CA certificate, Asterisk would issue a warning and continue to process the call as if there was not an issue with the certificate. Asterisk now properly fails the call if the certificate fails verification or if the certificate does not exist when certificate checking is enabled (the default behavior). (closes issue ASTERISK-20559) Review: https://reviewboard.asterisk.org/r/2163/ ........ Merged revisions 375146 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375173 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	16021c62b0	Merged revisions 375112 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375112 | wdoekes | 2012-10-16 16:43:29 -0500 (Tue, 16 Oct 2012) | 10 lines Fixes to the fd-oriented SIP TCP reads. Don't crash on large user input. Allow SIP headers without space. Optimize code a bit. Review: https://reviewboard.asterisk.org/r/2162 ........ Merged revisions 375111 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375136 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Automerge script	f8b7884735	Merged revisions 375078 via svnmerge from ... file:///srv/subversion/repos/asterisk/branches/10 ................ r375078 | wdoekes | 2012-10-16 14:22:44 -0500 (Tue, 16 Oct 2012) | 7 lines Update sip_request_call SIP dial string documentation. This was missed when merging review r1859. ........ Merged revisions 375074 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10-digiumphones@375102 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago