4259 Commits (12aa25b2e150068abe3cac98d2d85498c3194ef0)

Author	SHA1	Message	Date
Richard Mudgett	12aa25b2e1	res_pjsip.c: Split ast_sip_push_task_synchronous() to fit expectations. ... ast_sip_push_task_synchronous() did not necessarily execute the passed in task under the specified serializer. If the current thread is any registered pjsip thread then it would execute the task immediately instead of under the specified serializer. Reentrancy issues could result if the task does not execute with the right serializer. The original reason ast_sip_push_task_synchronous() checked to see if the current thread was a registered pjsip thread was because of a deadlock with masquerades and the channel technology's fixup callback (ASTERISK_22936). A subsequent masquerade deadlock fix (ASTERISK_24356) involving call pickups avoided the original deadlock situation entirely. The PJSIP channel technology's fixup callback no longer needed to call ast_sip_push_task_synchronous(). However, there are a few places where this unexpected behavior is still required to avoid deadlocks. The pjsip monitor thread executes callbacks that do calls to ast_sip_push_task_synchronous() that would deadlock if the task were actually pushed to the specified serializer. I ran into one dealing with the pubsub subscriptions where an ao2 destructor called ast_sip_push_task_synchronous(). * Split ast_sip_push_task_synchronous() into ast_sip_push_task_wait_servant() and ast_sip_push_task_wait_serializer(). ast_sip_push_task_wait_servant() has the old behavior of ast_sip_push_task_synchronous(). ast_sip_push_task_wait_serializer() has the new behavior where the task is always executed by the specified serializer or a picked serializer if one is not passed in. Both functions behave the same if the current thread is not a SIP servant. * Redirected ast_sip_push_task_synchronous() to ast_sip_push_task_wait_servant() to preserve API for released branches. ASTERISK_26806 Change-Id: Id040fa42c0e5972f4c8deef380921461d213b9f3	8 years ago
Richard Mudgett	dfdc9a2575	pjsip_scheduler.c: Fix some corner cases. ... * Fix the periodic interval wander because it may take significant time between the sched thread queueing the task in the serializer and the serializer actually executing the task. The time it takes to actually execute the task was already taken into account. * Pass a schtd ref to the serializer when we queue a scheduled task on the serializer. We don't want it going away on us while it is in the serializer queue. * Skip the scheduled task if the task was canceled between queueing the task to the serializer and the serializer actually executing the task. * Reorder struct ast_sip_sched_task to avoid unnecessary padding. Removed task_id and added next_periodic. * Hold a ref to the passed in serializer so the serializer cannot go away on the scheduled task. ASTERISK_26806 Change-Id: I6c8046b75f6953792c8c30e55b836a4291143f24	8 years ago
Jenkins2	264af6bec0	Merge "res_pjsip_notify.c: enable in-dialog NOTIFY" into 13	8 years ago
Jenkins2	dfd0529abc	Merge "pjsip_scheduler.c: Fix ao2 usage errors." into 13	8 years ago
Chris-Savinovich	724d926d46	res_pjsip_session: Rewrite o= with external_media_address. ... It now appends the external IP address on the o= line of the SDP packet. The decision was made to write the numeric IP address as opposed to the RFC that states the FQDN should be used if and when available. We believe the usage of literal IP address will help avoid potential problems. ASTERISK-27614 #close Change-Id: I84f3360f3606b8c4e8d161edb228799ec0b8a302	8 years ago
Nathan Bruning	6a4afe09ce	res_pjsip_notify.c: enable in-dialog NOTIFY ... This patch adds support to send in-dialog SIP NOTIFY commands on chan_pjsip channels, similar to the functionality recently added for chan_sip (ASTERISK_27461). This extends res_pjsip_notify to allow for in-dialog messages. ASTERISK-27697 Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29	8 years ago
Richard Mudgett	c4f02c975b	pjsip_scheduler.c: Fix ao2 usage errors. ... * Removed several invalid uses of OBJ_NOLOCK. These uses resulted in the 'tasks' container being accessed without a lock in a multi-threaded environment. A recipe for crashes. * Removed needlessly obtaining schtd object references. If the caller providing you a pointer to an object doesn't have a valid reference then you cannot safely get one from it. * Getting a ref to 'tasks' when you aren't copying the pointer into another location is useless. The 'tasks' container pointer is global. * Removed many unnecessary uses of RAII_VAR. * Make ast_sip_schedule_task() name parameter const. ASTERISK_26806 Change-Id: I5c62488e651314e2a1dbc01f5b078a15512d73db	8 years ago
Richard Mudgett	72b16ee400	res_pjsip_refer/chan_sip: Fix INVITE with replaces transfer to ConfBridge ... There is a problem when an INVITE-with-Replaces transfer targets a channel in a ConfBridge. The transfer will unconditionally swap out the ConfBridge channel. Unfortunately, the ConfBridge state will not be aware of this change. Unexpected behavior will happen as a result since ConfBridge channels currently can only be replaced by a masquerade and not normal bridge channel moves. * We just need to pretend that the channel isn't in a bridge (like other transfer methods already do) so the transfer channel will masquerade into the ConfBridge channel. Change-Id: I209beb0e748fa4f4b92a576f36afa8f495ba4c82	8 years ago
Richard Mudgett	e94f8e4a24	res_pjsip: Update authenticate_qualify documentation. ... Change-Id: I3811de0014b1ffe96d4a3b49cddd5d4ca02ee5d4	8 years ago
George Joseph	cea1a22ef3	res_pjsip: Correct usages of pjproject's timer heap ... Fix some timer heap initializations and cancels to try and prevent crashes and timer heap issues. Change-Id: I64885d190fa22097d1b55987091375541e57a7ee	8 years ago
Ross Beer	5955cdf5ae	pjsip_transport_events.c: Fix crash using stale transport pointer. ... Apparently it is possible for the transport to be destroyed without triggering the transport callback logic. As a result the transport gets destroyed and we have a stale pointer in the active_transports container. * Invoke the transport monitor callback checks when the transport is destroyed in addition to when it is disconnected and shutdown. ASTERISK-27688 Change-Id: Ia9b5469fea8f2b3f2d8476fae6b748a4d23e7261	8 years ago
Alexander Traud	0f634c1446	BuildSystem: Remove unused dependency on libltdl. ... Asterisk does not need the development package of libltdl, because it does not use any symbol of -lltdl directly. Instead, it uses the runtime package via the shared library -lodbc. On the supported platforms, that shared library declares its dependency on -lltdl correctly, otherwise AST_EXT_LIB_CHECK would have failed. ASTERISK-27745 Change-Id: Icd315809b8e7978203431f3afb66240dd3a040ba	8 years ago
Ross Beer	96eaabd920	res_pjsip_rfc3326.c: Account for more than one 'Reason' header ... ASTERISK-27741 Change-Id: I0aa59a54735c6d20b95c54db1bd095dbf93e7adf	8 years ago
Joshua Colp	acf3bdc3d5	Merge "res_srtp: Add support for libsrtp2.x on openSUSE." into 13	8 years ago
Joshua Colp	f05ac26d4a	Merge "Replace direct checks of option_debug with DEBUG_ATLEAST macro." into 13	8 years ago
Jenkins2	af79e3091f	Merge "BuildSystem: Depend not implicitly but explicitly on external libraries." into 13	8 years ago
Alexander Traud	09c43fdc1a	res_srtp: Add support for libsrtp2.x on openSUSE. ... Since ASTERISK-26976, libSRTP 2.x can be used for sRTP. However, that change added a private header which is not available on openSUSE for example. To remain compatibility with very old libSRTP versions, the affected/missing symbols AES_128_ICM and HMAC_SHA1 are defined manually. ASTERISK-27733 Change-Id: I25c5cb8fa966043d1506ebef449e5a724412b4b6	8 years ago
Jenkins2	99702af57a	Merge "res_http_post: Enable GMime in NetBSD." into 13	8 years ago
Corey Farrell	b81eadcefc	Replace direct checks of option_debug with DEBUG_ATLEAST macro. ... Checking option_debug directly is incorrect as it ignores file/module specific debug settings. This system-wide change replaces nearly all direct checks for option_debug with the DEBUG_ATLEAST macro. Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0	8 years ago
Ross Beer	ecff05d51c	res_pjsip_rfc3326: Order of 'Reason' headers break many endpoints ... ASTERISK-27554 Change-Id: If61c7faab7d2fa1031c056ed6268fe928e2391cf	8 years ago
Alexander Traud	44dbb8251d	BuildSystem: Depend not implicitly but explicitly on external libraries. ... ASTERISK-27722 Change-Id: Ie7b8c30d86cb00a54d6ac4e09e6f28f42d2bd52c	8 years ago
Alexander Traud	2d63c185f0	res_http_post: Enable GMime in NetBSD. ... ASTERISK-27719 Change-Id: I230c5f9f316b2e9465c093c13580f72ebbaf67a7	8 years ago
Jenkins2	9f56ad1673	Merge "pjproject: Add cache_pools debugging option." into 13	8 years ago
Jenkins2	d175dc794c	Merge "res_pjsip_refer.c: Fix attended transfer race condition crash." into 13	8 years ago
Richard Mudgett	104468ad3a	pjproject: Add cache_pools debugging option. ... The pool cache gets in the way of finding use after free errors of memory pool contents. Tools like valgrind and MALLOC_DEBUG don't know when a pool is released because it gets put into the cache instead of being freed. * Added the "cache_pools" option to pjproject.conf. Disabling the option helps track down pool content mismanagement when using valgrind or MALLOC_DEBUG. The cache gets in the way of determining if the pool contents are used after free and who freed it. To disable the pool caching simply disable the cache_pools option in pjproject.conf and restart Asterisk. Sample pjproject.conf setting: [startup] cache_pools=no * Made current users of the caching pool factory initialization and destruction calls call common routines to create and destroy cached pools. ASTERISK-27704 Change-Id: I64d5befbaeed2532f93aa027a51eb52347d2b828	8 years ago
Jenkins2	d0e270c973	Merge "modules: Set deprecated modules to not build by default" into 13	8 years ago
Jenkins2	5b5391d7d9	Merge "res_rtp_asterisk: Fix ICE candidate nomination" into 13	8 years ago
Richard Mudgett	3e5864bcc8	res_pjsip_refer.c: Fix attended transfer race condition crash. ... The transferrer's session channel was destroyed by the transferrer's serializer thread in a race condition with the transfer target's serializer thread during an attended transfer. The transfer target's serializer was attempting to clean up a deferred end status on behalf of the transferrer's channel when it should have passed the action to the transferrer's serializer. When the transfer target's serializer lost the race then both threads wind up trying to end the transferrer's session. * Push the ast_sip_session_end_if_deferred() call onto the transferrer's serializer to avoid a race condition that results in a crash. The session_end() function that could be called by ast_sip_session_end_if_deferred() really must be executed by the transferrer's serializer to avoid this kind of crash. ASTERISK-27568 Change-Id: Iacda724e7cb24d7520e49b2fd7e504aa398d7238	8 years ago
Sean Bright	220accb461	modules: Set deprecated modules to not build by default ... Change-Id: I09090f70224866aead6b3207fa784cfefea7d539	8 years ago
Joshua Colp	b1a0e601c9	Merge "AST-2018-004: Restrict the number of Accept headers in a SUBSCRIBE." into 13	8 years ago
George Joseph	5947fd148b	AST-2018-005: res_pjsip_transport_management: Move to core ... Since res_pjsip_transport_management provides several attack mitigation features, its functionality moved to res_pjsip and this module has been removed. This way the features will always be available if res_pjsip is loaded. ASTERISK-27618 Reported By: Sandro Gauci Change-Id: I21a2d33d9dda001452ea040d350d7a075f9acf0d	8 years ago
George Joseph	a780386dbb	AST-2018-005: Fix tdata leaks when calling pjsip_endpt_send_response(2) ... pjsip_distributor: authenticate() creates a tdata and uses it to send a challenge or failure response. When pjsip_endpt_send_response2() succeeds, it automatically decrements the tdata ref count but when it fails, it doesn't. Since we weren't checking for a return status, we weren't decrementing the count ourselves on error and were therefore leaking tdatas. res_pjsip_session: session_reinvite_on_rx_request wasn't decrementing the ref count if an error happened while sending a 491 response. pre_session_setup wasn't decrementing the ref count if while sending an error after a pjsip_inv_verify_request failure. res_pjsip: ast_sip_send_response wasn't decrementing the ref count on error. ASTERISK-27618 Reported By: Sandro Gauci Change-Id: Iab33a6c7b6fba96148ed465b690ba8534ac961bf	8 years ago
Joshua Colp	de5df002a0	AST-2018-004: Restrict the number of Accept headers in a SUBSCRIBE. ... When receiving a SUBSCRIBE request the Accept headers from it are stored locally. This operation has a fixed limit of 32 Accept headers but this limit was not enforced. As a result it was possible for memory outside of the allocated space to get written to resulting in a crash. This change enforces the limit so only 32 Accept headers are processed. ASTERISK-27640 Reported By: Sandro Gauci Change-Id: I99a814b10b554b13a6021ccf41111e5bc95e7301	8 years ago
Jenkins2	450afe655c	Merge "res_http_websocket: Don't leak memory on read failure" into 13	8 years ago
Jenkins2	e35152b550	Merge "res_pjsip_header_funcs: Various cleanups" into 13	8 years ago
Jenkins2	e34db67cfb	Merge "res_pjsip: Use pjsip_sip_uri.user_param instead of other_param" into 13	8 years ago
Sean Bright	5ebc94da02	res_http_websocket: Don't leak memory on read failure ... Change-Id: Ic449ea832bc81a1671c0e910c5fbe8c683e3da89	8 years ago
Thomas Guebels	9325de11f8	res_rtp_asterisk: Fix ICE candidate nomination ... If the ICE role is not set right away, we might have a role conflict that stays undetected and ICE finishing with successful tests and no candidate nominated. This was introduced by ASTERISK-27088. To avoid this, we set the role as soon as before but only if the ICE state permits it: still checking and not yet nominating candidates or completed. ASTERISK-27646 Change-Id: I5dbc69ad63cacbb067922850fbb113d479bd729c	8 years ago
Sean Bright	1a7ad4c9cf	res_pjsip_header_funcs: Various cleanups ... * Prefer strcasecmp() over stricmp() * Use a list with no lock since we never actually lock * Minor cleanups to error messages Change-Id: I8446f44795ee8f3072e1c1f9193c6912dfc0c42b	8 years ago
Sean Bright	9ad9433257	res_pjsip: Endpoint destruction does not free DTLS configuration ... ASTERISK-27679 #close Reported by: Mak Dee Change-Id: I89a2783a11be0763bf123d1619ed176b6225cf42	8 years ago
Alexander Traud	139dd38193	res_calendar: Specialized calendars depend on symbols of general calendar. ... ASTERISK-27680 Change-Id: Ifb77912e424fe3710a025c18526fada673ec0b79	8 years ago
Sean Bright	54efc0c637	res_pjsip: Use pjsip_sip_uri.user_param instead of other_param ... There is a dedicated slot in the pjsip_sip_uri for the 'user' parameter, so use that instead of adding to the list of generic URI parameters. Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6	8 years ago
Jenkins2	5c98924d64	Merge "endpoint identifiers: Some code cleanup." into 13	8 years ago
Jenkins2	e3a2b699db	Merge "res_pjsip/config_domain_aliases.c: Add check for missing domain." into 13	8 years ago
Richard Mudgett	da987df122	res_pjsip/config_domain_aliases.c: Add check for missing domain. ... What is the point of defining an alias and not saying what is being aliased? Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be	8 years ago
Jenkins2	88e323a2a0	Merge "res_sorcery_realtime.c: Fix ref leak if object failed to apply." into 13	8 years ago
Jenkins2	d2df34f204	Merge "res_pjsip.c: Fix documentation typos." into 13	8 years ago
Richard Mudgett	1adf90320d	endpoint identifiers: Some code cleanup. ... res_pjsip_endpoint_identifier_user.c: * Fix copy/paste error in find_endpoint(). We were using a constant "anonymous" string instead of the passed in endpoint_name when checking the transport domain for an endpoint match. * Eliminate RAII_VAR in find_endpoint(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). res_pjsip_endpoint_identifier_anonymous.c: * Eliminate RAII_VAR in anonymous_identify(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). Change-Id: I86924c31db5bd225ca0c1219c761b668c6f91189	8 years ago
Richard Mudgett	93a1ffc834	res_pjsip.c: Fix documentation typos. ... Change-Id: I82ae0b92bfa2ece84a5c684efd9eefdc83ebd068	8 years ago
Richard Mudgett	5d16cefd63	res_sorcery_realtime.c: Fix ref leak if object failed to apply. ... Change-Id: I3c7106ff77009754725cee790eadf5da44154ab6	8 years ago