29586 Commits (09932a13efa6719b481aeab0402893de230c1947)

 

All Branches   

Search

Author	SHA1	Message	Date
Jenkins2	09932a13ef	Merge "vector: multiple evaluation of elem in AST_VECTOR_ADD_SORTED." into 14	8 years ago
Jenkins2	b4ed8c4e4f	Merge "res_pjsip: Fix leak of fake_auth references." into 14	8 years ago
Corey Farrell	e71f6d4dfa	vector: multiple evaluation of elem in AST_VECTOR_ADD_SORTED. ... Use temporary variable to prevent multiple evaluations of elem argument. This resolves a memory leak in res_pjproject startup. ASTERISK-27317 #close Change-Id: Ib960d7f5576f9e1a3c478ecb48995582a574e06d	8 years ago
Jenkins2	acb53a2295	Merge "main/strings: Fix uninitialized value." into 14	8 years ago
Corey Farrell	3e2cb5a9e9	res_pjsip: Fix leak of fake_auth references. ... pjsip_distributor leaks references to fake_auth when the default realm has not changed. ASTERISK-27306 Change-Id: I3fcf103b3680ad2d1d4610dcd6738eeaebf4d202	8 years ago
Corey Farrell	3421b1de27	main/strings: Fix uninitialized value. ... ast_strings_match uses sscanf and checks for non-zero return to verify a token was parsed. This is incorrect as sscanf returns EOF (-1) for errors. ASTERISK-27318 #close Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1	8 years ago
Daniel Tryba	e8ed162941	res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy ... Currently privacy requests are only granted if the Privacy header value is exactly "id" (defined in RFC 3325). It ignores any other possible value (or a combination there of). This patch reverses the logic from testing for "id" to grant privacy, to testing for "none" and granting privacy for any other value. "none" must not be used in combination with any other value (RFC 3323 section 4.2). ASTERISK-27284 #close Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56	8 years ago
Joshua Colp	0991cb0a8f	Merge "app_queue.c: Fix announcements when announce-to-first-user not enabled." into 14	8 years ago
krells	44d443d87e	res_calendar_icalendar: Filter out occurrences superceded by another VEVENT ... When we are loading the calendars, we call libical's icalcomponent_foreach_recurrence method for each VEVENT component that we have in our calendar. That method has no knowledge concerning the existence of the other VEVENT components and will feed our callback with all ocurrences matching the requested time span. The occurrences generated by icalcomponent_foreach_recurrence while expanding a recurring VEVENT's RRULE and RDATE properties can be superceded by an other VEVENT sharing the same UID. I use an external iterator (in libical terminology) to avoid messing with the internal ones from the calling function, and search for VEVENTS which could supersede the current occurrence. The event which can invalidate this occurence needs to have: - the same UID as our recurrent component (comp) - a RECURRENCE-ID property, which represents the start time of this occurrence If one component is found, just clean and return. ASTERISK-27296 #close Reported by: Benoît Dereck-Tricot Change-Id: I8587ae3eaa765af7cb21eda3b6bf84e8a1c87af8	8 years ago
Jenkins2	752d55f719	Merge "heap.c: No need to calloc heap pointer array." into 14	8 years ago
Jenkins2	4fdc39bcfb	Merge "logger: Bring back ability to turn debug on by source file" into 14	8 years ago
Richard Mudgett	699b6a70d5	app_queue.c: Fix announcements when announce-to-first-user not enabled. ... The previous patch for ASTERISK-27216 made it so you wouldn't get any position or periodic announcements unless you had announce-to-first-user enabled. The announce-to-first-user feature was added by ASTERISK_21782 as a result of the patch which introduced the redundant announcements that ASTERISK-27216 removes. * By noting that the makeannouncement variable is used to suppresses the first user announcement, we set its initial value to the announce-to-first-user enable setting. ASTERISK-27216 Change-Id: Ieaeb7dbea8ae7073086b775fbafe0625b000b10a	8 years ago
Richard Mudgett	37935c79f6	heap.c: No need to calloc heap pointer array. ... Change-Id: I5ae2f316229f336eb90d99c7af7ed07a33097e68	8 years ago
Jenkins2	88ba803110	Merge "pjsip_message_filter: Fix regression causing bad contact address" into 14	8 years ago
George Joseph	00fc98d330	logger: Bring back ability to turn debug on by source file ... Somewhere along the way we lost the ability to debug individual source files. For modules, this wasn't a big deal but all the source files in ./main are in the one "core" module so debugging individual core capabilities was almost impossible. * Added a test to DEBUG_ATLEAST that also checks __FILE__ instead of just module name. Any source file will work even if it's in a module subdirectory. Change-Id: Icc0af41837f3b1679dec7af21fa32cd1f7469f6e	8 years ago
Joshua Colp	821927b077	Merge "pjproject: Patch to correct STUN FINGERPRINT usage" into 14	8 years ago
Jenkins2	77558d80f3	Merge "res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential." into 14	8 years ago
Richard Mudgett	de99052acb	res_pjsip_outbound_publish.c: Fix misplaced parenthesis. ... The pjsip_publishc_init() call was referenced with a misplaced parentheses. As a result, outbound publication messages went out with an expiration of 1 second. ASTERISK-27298 Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08	8 years ago
George Joseph	3c5c31f14c	pjsip_message_filter: Fix regression causing bad contact address ... The "res_pjsip: Filter out non SIP(S) requests" commit moved the filtering of messages to pjproject's PJSIP_MOD_PRIORITY_TRANSPORT_LAYER in order to filter out incoming bad uri schemes as early as possible. Since the change affected outgoing messages as well and the TRANSPORT layer is the last to be run on outgoing messages, we were overwriting the setting of external_signaling_address (which is set earlier by res_pjsip_nat) with an internal address. * pjsip_message_filter now registers itself as a pjproject module twice. Once in the TSX layer for the outgoing messages (as it was originally), then a second time in the TRANSPORT layer for the incoming messages to catch the invalid uri schemes. ASTERISK-27295 Reported by: Sean Bright Change-Id: I2c90190c43370f8a9d1c4693a19fd65840689c8c	8 years ago
Richard Mudgett	738da78786	res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential. ... The bridge_p2p_rtp_write() has potential reentrancy problems. * Accessing the bridged RTP members must be done with the instance1 lock held. The DTMF and asymmetric codec checks must be split to be done with the correct RTP instance struct locked. i.e., They must be done when working on the appropriate side of the point to point bridge. * Forcing the RTP mark bit was referencing the wrong side of the point to point bridge. The set mark bit is used everywhere else to set the mark bit when sending not receiving. The patches for ASTERISK_26745 and ASTERISK_27158 did not take into account that not everything carried by RTP uses a codec. The telephony DTMF events are not exchanged with a codec. As a result when RFC2833/RFC4733 sent digits you would crash if "core set debug 1" is enabled, the DTMF digits would always get passed to the core even though the local native RTP bridge is active, and the DTMF digits would go out using the wrong SSRC id. * Add protection for non-format payload types like DTMF when updating the lastrxformat and lasttxformat. Also protect against non-format payload types when checking for asymmetric codecs. ASTERISK-27292 Change-Id: I6344ab7de21e26f84503c4d1fca1a41579364186	8 years ago
Jenkins2	9bd204f64a	Merge "channel.c: Fix invalid reference in conditionaled out code." into 14	8 years ago
Jenkins2	9fe0803c8b	Merge "app_queue: Only do announcement logic between ringing cycles" into 14	8 years ago
Sean Bright	95eae41b37	pjproject: Patch to correct STUN FINGERPRINT usage ... Change-Id: I0e453253dff1388b0186b36c754457c1d0d12db6	8 years ago
Richard Mudgett	787fd96709	channel.c: Fix invalid reference in conditionaled out code. ... ASTERISK-27289 Change-Id: I7a415948116493050614d9f4fa91ffbe0c21ec4c	8 years ago
George Joseph	31cbc1166c	build: A few gcc 7 error fixes ... Change-Id: I7b5300fbf1af7d88d47129db13ad6dbdc9b553ec	8 years ago
StefanEng86	b197d851d8	app_queue: Only do announcement logic between ringing cycles ... This patch reverts the change by patch 2263 from old reviewboard. Note that reverting that 2263-patch still preserves the behaviour that the commit log of the 2263-patch claimed to add. The reason for this is: The function wait_for_answer is only called from try_calling which in turn is only called from the main for loop in queue_exec, and earlier in that loop we already check the things that's removed by this patch. There's no need to check those things twice each loop iteration, and I think the proper place to check it is before each ringing cycle. By checking it in wait_for_answer, you allow the issue explained in the jira - that the head caller hears announcements while the agents' sip phones are actively ringing. Reported-by: Stefan Engström Tested-by: Stefan Engström ASTERISK-27216 #close Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0	8 years ago
Sean Bright	875568c0f9	res_pjsip: Use ast_sip_is_content_type() where appropriate ... Change-Id: If3ab0d73d79ac4623308bd48508af2bfd554937d	8 years ago
Joshua Colp	ddc216f12e	Merge "res_config_pgsql: Fix removed support to previous for versions PostgreSQL 9.1" into 14	8 years ago
Jenkins2	040487b90e	Merge "res_srtp: lower log level of auth failures" into 14	9 years ago
Rodrigo Ramírez Norambuena	339676b77d	res_config_pgsql: Fix removed support to previous for versions PostgreSQL 9.1 ... In PostgreSQL 9.1 the backslash are string literals and not the escape of characters. In previous issue ASTERISK_26057 was fixed the use of escape LIKE but the support for old version of Postgresql than 9.1 was dropped. The sentence before make was "ESCAPE '\'" but in version before than 9.1 need it to be as follow "ESCAPE '\\'". ASTERISK-27283 Change-Id: I96d9ee1ed7693ab17503cb36a9cd72847165f949	9 years ago
Joshua Colp	8ee7ed020f	Merge "chan_sip: Expose read-only access to the full SIP INVITE Request-URI" into 14	9 years ago
Jenkins2	e5f911519d	Merge "bridge : Fix one-way direct-media when early bridging with native_rtp" into 14	9 years ago
Jean Aunis	d884871ca7	bridge : Fix one-way direct-media when early bridging with native_rtp ... When two channels were early bridged in a native_rtp bridge, the RTP description on one side was not updated when the other side answered. This patch forbids non-answered channels to enter a native_rtp bridge, and triggers a bridge reconfiguration when an ANSWER frame is received. ASTERISK-27257 Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df	9 years ago
George Joseph	c97eb95193	res_pjsip_pubsub: Check for Content-Type header in rx_notify_request ... pubsub_on_rx_notify_request wasn't checking for a null Content-Type header before checking that it was application/simple-message-summary. ASTERISK-27279 Reported by: Ross Beer Change-Id: Iec2a6c4d2e74af37ff779ecc9fd35644c5c4ea52	9 years ago
David J. Pryke	060cea2cca	chan_sip: Expose read-only access to the full SIP INVITE Request-URI ... Provide a way to get the contents of the the Request URI from the initial SIP INVITE in dial plan function call. (In this case "${CHANNEL(ruri)}") ASTERISK-27278 Reported by: David J. Pryke Tested by: David J. Pryke Change-Id: I1dd4d6988eed1b6c98a9701e0e833a15ef0dac3e	9 years ago
Joshua Colp	3274c13b12	Merge "AST-2017-008: Improve RTP and RTCP packet processing." into 14	9 years ago
Joshua Colp	864e76374c	Merge "res_calendar: On reload, update all configuration" into 14	9 years ago
Joshua Colp	05bb57c56f	Merge "cdr_mysql.c: Apply cdrzone to start and answer" into 14	9 years ago
Alexander Traud	393d813789	tcptls: Fixed a white space error. ... ASTERISK-26606 Change-Id: I81a7268ef7ba012d4d80d44c70b6276d48e397fa	9 years ago
Alexander Traud	73da3df7b6	res_srtp: lower log level of auth failures ... Previously, sRTP authentication failures were reported on log level WARNING. When such failures happen, each RT(C)P packet is affected, spamming the log. Now, those failures are reported at log level VERBOSE 2. Furthermore, the amount is further reduced (previously all two seconds, now all three seconds). Additionally, the new log entry informs whether media (RTP) or statistics (RTCP) are affected. ASTERISK-16898 #close Change-Id: I6c98d46b711f56e08655abeb01c951ab8e8d7fa0	9 years ago
Richard Mudgett	4a57e20d52	AST-2017-008: Improve RTP and RTCP packet processing. ... Validate RTCP packets before processing them. * Validate that the received packet is of a minimum length and apply the RFC3550 RTCP packet validation checks. * Fixed potentially reading garbage beyond the received RTCP record data. * Fixed rtp->themssrc only being set once when the remote could change the SSRC. We would effectively stop handling the RTCP statistic records. * Fixed rtp->themssrc to not treat a zero value as special by adding rtp->themssrc_valid to indicate if rtp->themssrc is available. ASTERISK-27274 Make strict RTP learning more flexible. Direct media can cause strict RTP to attempt to learn a remote address again before it has had a chance to learn the remote address the first time. Because of the rapid relearn requests, strict RTP could latch onto the first remote address and fail to latch onto the direct media remote address. As a result, you have one way audio until the call is placed on and off hold. The new algorithm learns remote addresses for a set time (1.5 seconds) before locking the remote address. In addition, we must see a configured number of remote packets from the same address in a row before switching. * Fixed strict RTP learning from always accepting the first new address packet as the new stream. * Fixed strict RTP to initialize the expected sequence number with the last received sequence number instead of the last transmitted sequence number. * Fixed the predicted next sequence number calculation in rtp_learning_rtp_seq_update() to handle overflow. ASTERISK-27252 Change-Id: Ia2d3aa6e0f22906c25971e74f10027d96525f31c	9 years ago
Jenkins2	a9160793a5	Merge "res_pjsip: Filter out non SIP(S) requests" into 14	9 years ago
Sean Bright	edd5b30387	res_calendar: On reload, update all configuration ... This changes the behavior of res_calendar to drop all existing calendars and re-create them whenever a reload is done. The Calendar API provides no way for configuration information to be pushed down to calendar 'techs' so updated settings would not take affect until a module unload/load was done or Asterisk was restarted. Asterisk 15+ already has a configuration option 'fetch_again_at_reload' that performs a similar function. Also fix a tiny memory leak in res_calendar_caldav while we're at it. ASTERISK-25524 #close Reported by: Jesper Change-Id: Ib0f8057642e9d471960f1a79fd42e5a3ce587d3b	9 years ago
Jenkins2	cdadbd3d22	Merge "res_calendar: Various fixes" into 14	9 years ago
George Joseph	cf8d1d8cc7	res_pjsip: Filter out non SIP(S) requests ... Incoming requests with non sip(s) URIs in the Request, To, From or Contact URIs are now rejected with PJSIP_SC_UNSUPPORTED_URI_SCHEME (416). This is performed in pjsip_message_filter (formerly pjsip_message_ip_updater) and is done at pjproject's "TRANSPORT" layer before a request can even reach the distributor. URIs read by res_pjsip_outbound_publish from pjsip.conf are now also checked for both length and sip(s) scheme. Those URIs read by outbound registration and aor were already being checked for scheme but their error messages needed to be updated to include scheme failure as well as length failure. Change-Id: Ibb2f9f1d2dc7549da562af4cbd9156c44ffdd460	9 years ago
Jenkins2	aa90b169df	Merge "chan_rtp: Use μ-law by default instead of signed linear" into 14	9 years ago
Sean Bright	263578f3f7	res_calendar: Various fixes ... * The way that we were looking at XML elements for CalDAV was extremely fragile, so use SAX2 for increased robustness. * Don't complain about a 'channel' not be specified if autoreminder is not set. Assume that if 'channel' is not set, we don't want to be notified. * Fix some truncated CLI output in 'calendar show calendar' and make the 'Autoreminder' description a bit more clear ASTERISK-24588 #close Reported by: Stefan Gofferje ASTERISK-25523 #close Reported by: Jesper Change-Id: I200d11afca6a47e7d97888f286977e2e69874b2c	9 years ago
alex	3e445c20d8	cdr_mysql.c: Apply cdrzone to start and answer ... Change-Id: I7de0a5adc89824a5f2b696fc22c80fc22dff36b0	9 years ago
Sean Bright	8ab2dcb4b0	chan_rtp: Use μ-law by default instead of signed linear ... Multicast/Unicast RTP do not use SDP so we need to use a format that cleanly maps to one of the static RTP payload types. Without this change, an Originate to a Multicast or Unicast channel without a format specified would produce no audio on the receiving device. ASTERISK-21399 #close Reported by: Tzafrir Cohen Change-Id: I97e332b566e85da04b0004b9b0daae746cfca0e3	9 years ago
George Joseph	35cc916e63	res_pjsip: Add handling for incoming unsolicited MWI NOTIFY ... A new endpoint parameter "incoming_mwi_mailbox" allows Asterisk to receive unsolicited MWI NOTIFY requests and make them available to other modules via the stasis message bus. res_pjsip_pubsub has a new handler "pubsub_on_rx_mwi_notify_request" that parses a simple-message-summary body and, if endpoint->incoming_mwi_account is set, calls ast_publish_mwi_state with the voice-message counts from the message. Change-Id: I08bae3d16e77af48fcccc2c936acce8fc0ef0f3c	9 years ago