asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	eb5b83b8ea	AST-2018-010: Fix length of buffer needed for SRV and NAPTR results When dn_expand was being called on SRV and NAPTR results, the return value was being used to calculate the size of the buffer needed to store the host names. Since dn_expand returns the length of the COMPRESSED name the buffer could be too short to hold the EXPANDED name. The expanded name is NULL terminated so using strlen() is the correct way to determine the length actually needed for the buffer. ASTERISK-28127 Reported by: Jan Hoffmann patches: patch.diff submitted by janhoffmann (license 6986) Change-Id: I4d35d6c431c6c6836cb61d37b1378cc47f0b414d	8 years ago
Joshua Colp	9e151413db	Merge "core: Ensure that el_end is always run when needed."	8 years ago
Corey Farrell	944d90a7ea	taskprocessor: Do not use separate allocation for stats or name. Merge storage for the stats object and name string into the main allocation for struct ast_taskprocessor. Change-Id: I74fe9a7f357f0e6d63152f163cf5eef6428218e1	8 years ago
Corey Farrell	194e40122a	core: Ensure that el_end is always run when needed. * Ignore console=yes configuration option in remote console processes. * Use new flag to tell consolethread to run el_end and exit when needed. ASTERISK-28158 Change-Id: I9e23b31d4211417ddc88c6bbfd83ea4c9f3e5438	8 years ago
Joshua Colp	e7b22ee133	Merge "bridge_softmix: Add SDP "label" attribute to streams"	8 years ago
George Joseph	07c950b2dd	Merge "say: Remove legacy language deprecation logic"	8 years ago
Richard Mudgett	1b397ebd00	logger.c: Fix default console logging when no logger.conf available. Default logging was not setup correctly when there was no logger.conf. This resulted in many expected log messages not actually getting out to the console. Change-Id: I542e61c03b2f630ff5327f9de5641d776c6fa70c	8 years ago
George Joseph	8d1c6bb6e6	bridge_softmix: Add SDP "label" attribute to streams Adding the "label" attribute used for participant info correlation was previously done in app_confbridge but it wasn't working correctly because it didn't have knowledge about which video streams belonged to which channel. Only bridge_softmix has that data so now it's set when the bridge topology is changed. ASTERISK-28107 Change-Id: Ieddeca5799d710cad083af3fcc3e677fa2a2a499	8 years ago
George Joseph	a99d48d3f3	Merge "astobj2: Eliminate legacy container allocation macros."	8 years ago
George Joseph	11b73a75c8	Merge "lock: Replace __ast_mutex_logger with private log_mutex_error."	8 years ago
Sean Bright	f940b7b63d	say: Remove legacy language deprecation logic These language codes (tw, ge, mx, and cz) were deprecated in 1.6.2. Change-Id: I18e4d2af2e83556fa91e39a7338030583ef05d50	8 years ago
Richard Mudgett	544ef21bfe	Merge "Fix 'statement' typo throughout code."	8 years ago
Richard Mudgett	d1b9a3fbcc	Merge "options.c: Remove 'internal_timing' notice"	8 years ago
Corey Farrell	687ab7aeee	astobj2: Eliminate legacy container allocation macros. These macros have been documented as legacy for a long time but are still used in new code because they exist. Remove all references to: * ao2_container_alloc_options * ao2_t_container_alloc_options * ao2_t_container_alloc These macro's are also removed. Only ao2_container_alloc remains due to it's use in over 100 places. Change-Id: I1a26258b5bf3deb081aaeed11a0baa175c933c7a	8 years ago
Corey Farrell	4c19b94968	lock: Replace __ast_mutex_logger with private log_mutex_error. __ast_mutex_logger used the variable `canlog` without accepting it as a argument. Replace with internal macro `log_mutex_error` which takes canlog as the first arguement. This will prevent confusion when working with lock.c code, many of the function declare the canlog variable and in some cases it previously appeared to be unused. Change-Id: I83b372cb0654c5c18eadc512f65a57fa6c2e9853	8 years ago
Sean Bright	be04a64c49	options.c: Remove 'internal_timing' notice Change-Id: I9882394617724a497df1d6f529a87965191be3ce	8 years ago
Richard Mudgett	467f7c6724	Fix 'statement' typo throughout code. Most were in comments. A couple were in warning messages. Pointed out by Jonathan H on the Asterisk users mailing list. Change-Id: I6286939dff5d0a27a2758140570106f1cb351855	8 years ago
Corey Farrell	5ab94d2a3e	taskprocessor: Warn on unused result from pushing task. Add attribute_warn_unused_result to ast_taskprocessor_push, ast_taskprocessor_push_local and ast_threadpool_push. This will help ensure we perform the necessary cleanup upon failure. Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d	8 years ago
George Joseph	e349bf40ca	Merge "refdebug: Create refstats.py script."	8 years ago
George Joseph	430f97f5e7	Merge "threadpool: Eliminate pointless AO2 usage."	8 years ago
Corey Farrell	79677ead28	refdebug: Create refstats.py script. This allows us to process AO2 statistics for total objects, memory usage, memory overhead and lock usage. * Install refstats.py and reflocks.py into the Asterisk scripts folder. * Enable support for reflocks.py without DEBUG_THREADS. Steal a bit from the ao2 magic to flag when an object lock is used. Remove 'lockobj' from reflocks.py since we can now record 'used' or 'unused' for those objects. Add comments to explain thread safety of the 'struct __priv_data' bitfields. Change-Id: I84e9d679cc86d772cc97c888d9d856a17e0d3a4a	8 years ago
Corey Farrell	f06de6900e	threadpool: Eliminate pointless AO2 usage. thread_worker_pair, set_size_data and task_pushed_data structures are allocated with AO2 objects, passed to a taskprocessor, then released. They never have multiple owners or use locking so AO2 only adds overhead. Change-Id: I2204d2615d9d952670fcb48e0a9c0dd1a6ba5036	8 years ago
Corey Farrell	675d8a46b4	main/astfd: Fix GCC8 format-truncation warning. The field used to store call arguments was not large enough to hold the arguments string that can be constructed for 'open'. Expand it to prevent this warning/error. Change-Id: I514927f256481bc84df10a51b19d5b5fb1bc387e	8 years ago
Jenkins2	265d91a120	Merge "loader: Flag module as declined in all cases where it fails to load."	8 years ago
neutrino88	17f4e6ad4d	core/frame: generate correct T.140 payload in ast_sendtext_data() ast_sendtext_data() would create an incorrect T.140 text frame which length include the null terminator byte. It causes ultimately RTP packets to be send with this trailing 0. The proposed fix just set the correct length to the text frame ASTERISK-28089 Reported by: Emmanuel BUU Tested by: Emmanuel BUU Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96	8 years ago
Corey Farrell	c8ee1a183f	loader: Flag module as declined in all cases where it fails to load. This has no effect on startup since AST_MODULE_LOAD_FAILURE aborts startup, but it's possible for this code to be returned on manual load of a module after startup. It is an error for a module to not have a load callback but this is not a fatal system error. In this case flag the module as declined, return AST_MODULE_LOAD_FAILURE only if a required module is broken. Expand doxygen documentation for AST_MODULE_LOAD_*. Change-Id: I3c030bb917f6e5a0dfd9d91491a4661b348cabf8	8 years ago
George Joseph	45eb9a28eb	Merge "astobj2: Comment on OBJ_NOLOCK in ao2_container_clone."	8 years ago
George Joseph	f55e20ae83	Merge "http.c: Reload TLS even if http.conf hasn't changed"	8 years ago
George Joseph	967fffb569	Merge "core/frame: Fix ast_frdup() and ast_frisolate() for empty text frames"	8 years ago
Corey Farrell	932d0a40cf	astobj2: Comment on OBJ_NOLOCK in ao2_container_clone. The test for OBJ_NOLOCK looks wrong but it isn't. Add comments to prevent confusion. Change-Id: I9662b82eb39e7627a1f1944fd18f967a2b987344	8 years ago
George Joseph	bc9a7c419c	Merge "astobj2: Record lock usage to refs log when DEBUG_THREADS is enabled."	8 years ago
George Joseph	24dc6ee8ae	Merge "loader: Fix result of module reload error."	8 years ago
George Joseph	910f5dbd44	Merge "core: Disable astobj2 locking for some common objects."	8 years ago
Sean Bright	286339aa34	http.c: Reload TLS even if http.conf hasn't changed There is currently no way to indicate to Asterisk that TLS certificates and/or keys have been updated other than by modifying http.conf or restarting Asterisk. There is already code in main/tcptls.c that determines if a reload is actually necessary based on the hashes of the certicate and dependent files, so this change merely gives us a way to request a reload without explicitly modifying http.conf. Change-Id: Ie795420dcc7eb3d91336820688a29adbcc321276	8 years ago
Corey Farrell	cacbe32534	core: Disable astobj2 locking for some common objects. * ACO options * Indications * Module loader ref_debug object * Media index info and variants * xmldoc items These allocation locations were identified using reflocks.py on the master branch. Change-Id: Ie999b9941760be3d1946cdb6e30cb85fd97504d8	8 years ago
Corey Farrell	b25a261aa5	loader: Fix result of module reload error. When a module reload fails we never set AST_MODULE_RELOAD_ERROR. This caused reload failures to incorrectly report 'No module found'. Change-Id: I5f3953e0f7d135e53ec797f24c97ee3f73f232e7	8 years ago
Corey Farrell	e4cf513f81	loader: Improve error handling. * Display list of unavailable dependencies when they cause another module to fail loading. * When a module declines to load find all modules which depend on it so they can be declined and listed together. * Prevent retry of declined modules during startup. * When a module fails to dlopen try loading it with RTLD_LAZY so we can attempt to display the list of missing dependencies. These changes are meant to reduce logger spam that is caused when a module has many dependencies and declines to load. This also fixes some error paths which failed to recognize required modules. Module load/start errors are delayed until the end of loader startup. Change-Id: I046052c71331c556c09d39f47a3b92975f3e1758	8 years ago
neutrino88	24cece660b	core/frame: Fix ast_frdup() and ast_frisolate() for empty text frames If a channel creates an AST_TEXT_FRAME with datalen == 0, the ast_frdup() and ast_frisolate() functions could create a clone frame with an invalid data.ptr which would cause a crash. The proposed fix is to make sure that for such empty text frames, ast_frdup() and ast_frisolate() return cloned text frames with a valid data.ptr. ASTERISK-28076 Reported by: Emmanuel BUU Tested by: Emmanuel BUU Change-Id: Ib882dd028598f13c4c233edbfdd7e54ad44a68e9	8 years ago
Corey Farrell	13df745278	astobj2: Record lock usage to refs log when DEBUG_THREADS is enabled. When DEBUG_THREADS is enabled we can know if the astobj2 mutex / rwlock was ever used, so it can be recorded in the REF_DEBUG destructor entry. Create contrib/scripts/reflocks.py to process locking used by allocator. This can be used to identify places where AO2_ALLOC_OPT_LOCK_NOLOCK should be used to reduce memory usage. Change-Id: I2e3cd23336a97df2692b545f548fd79b14b53bf4	8 years ago
Jenkins2	252e4a8fd4	Merge "astobj2: Reduce memory overhead."	8 years ago
Joshua Colp	69f4740fa1	Merge "lock: Improve performance of DEBUG_THREADS."	8 years ago
Corey Farrell	205c6be895	lock: Improve performance of DEBUG_THREADS. Add a volatile flag to lock tracking structures so we only need to use the global lock when first initializing tracking. Additionally add support for DEBUG_THREADS_LOOSE_ABI. This is used by astobj2.c to eliminate storage for tracking fields when DEBUG_THREADS is not defined. Change-Id: Iabd650908901843e9fff47ef1c539f0e1b8cb13b	8 years ago
George Joseph	930cbec67d	Merge "config.c: Cleanup AST_INCLUDE_GLOB"	8 years ago
Corey Farrell	62a0db2df1	astobj2: Reduce memory overhead. Reduce options to 2-bit field, magic to 30 bit field. Move ref_counter next to options and explicitly use int32_t so the fields will pack. This reduces memory overhead for every ao2 object by 8 bytes on x86_64. Change-Id: Idc1baabb35ec3b3d8de463c4fa3011eaf7fcafb5	8 years ago
Sean Bright	ac23e5ad48	config.c: Cleanup AST_INCLUDE_GLOB * In main/config.c, AST_INCLUDE_GLOB is fixed to '1' making the #ifdefs pointless. * In utils/extconf.c, AST_INCLUDE_GLOB is never defined so there is a lot of dead code. Change-Id: I1bad1a46d7466ddf90d52cc724e997195495226c	8 years ago
Corey Farrell	39bf9881e0	astobj2: Fix shutdown order. When REF_DEBUG and AO2_DEBUG are both enabled we closed the refs log before we shutdown astobj2_container. This caused the AO2_DEBUG container registration container to be reported as a leak. Change-Id: If9111c4c21c68064b22c546d5d7a41fac430430e	8 years ago
George Joseph	aa10d6d5eb	Merge "jansson: Backport fixes to bundled, use json_vsprintf if available."	8 years ago
George Joseph	de14ed0b93	Merge "rtp_engine: rtcp_report_to_json can overflow the ssrc integer value"	8 years ago
Corey Farrell	adf539b2f0	jansson: Backport fixes to bundled, use json_vsprintf if available. Use json_vsprintf from versions which contain fix for va_copy leak. Apply fixes from jansson master: * va_copy leak fix. * Avoid potential invalid memory read in json_pack. * Rename variable that shadowed another. Change-Id: I7522e462d2a52f53010ffa1e7d705c666ec35539	8 years ago
Corey Farrell	93777faf36	json: Take advantage of new API's. * Use "o" format specifier for optional fields in ast_json_party_id. Stop using ast_json_deep_copy on immutable objects, it is now thread safe to just use ast_json_ref. Additional changes to ast_json_pack calls in the vicinity: * Use "O" when an object needs to be bumped. This was previously avoided as it was not thread safe. * Use "o?" and "O?" to replace NULL with ast_json_null(). The "?" is a new feature of ast_json_pack starting with Asterisk 16. Change-Id: I8382d28d7d83ee0ce13334e51ae45dbc0bdaef48	8 years ago

1 2 3 4 5 ...

6329 Commits (02c7a061ea312efd6401be9ffa0bcffc03f2f0e2)