asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	7597082312	.github: OnPRCherryPickTest,OnPRStateChanged,OnPRRecheck: Add job summaries. ...and refactor environment variables.	2 months ago
George Joseph	f0852a2465	.github: Clean up CreateDocs	2 months ago
George Joseph	75840bd4a5	func_strings.c: Prevent SEGV in HASH single-argument mode. When in single-argument mode (very rarely used), a malformation of a column name (also very rare) could cause a NULL to be returned when retrieving the channel variable for that column. Passing that to strncat causes a SEGV. We now check for the NULL and print a warning message. Resolves: #1101	3 months ago
Sean Bright	03f1c24674	utils: Remove libdb and astdb conversion scripts. These were included with Asterisk 10 when we switched astdb from libdb to sqlite3.	3 months ago
George Joseph	453ddfce19	docs: Add version information to AGI command XML elements. This process was a bit different than the others because everything is in the same file, there's an array that contains the command names and their handler functions, and the last command was created over 15 years ago. * Dump a `git blame` of res/res_agi.c from BEFORE the handle_* prototypes were changed. * Create a command <> handler function xref by parsing the the agi_command array. * For each entry, grep the function definition line "static int handle_" from the git blame output and capture the commit. This will be the commit the command was created in. Do a `git tag --contains <commit> \| sort -V \| head -1` to get the tag the function was created in. * Add a single since/version element to the command XML. Multiple versions aren't supported here because the branching and tagging scheme changed several times in the 2000's.	3 months ago
Jeremy Lainé	bedc4328cc	docs: Fix minor typo in MixMonitor AMI action The `Options` argument was erroneously documented as lowercase `options`.	3 months ago
Naveen Albert	5c9dd380f5	utils: Disable old style definition warnings for libdb. Newer versions of gcc now warn about old style definitions, such as those in libdb, which causes compilation failure with DEVMODE enabled. Ignore these warnings for libdb. Resolves: #1085	3 months ago
fabriziopicconi	cd60142c76	rtp.conf.sample: Correct stunaddr example.	3 months ago
George Joseph	dfc8652b55	docs: Add version information to ARI resources and methods. * Dump a git blame of each file in rest-api/api-docs. * Get the commit for each "resourcePath" and "httpMethod" entry. * Find the tags for each commit (same as other processes). * Insert a "since" array after each "resourcePath" and "httpMethod" entry.	3 months ago
George Joseph	db8ae1912d	res_pjsip_authenticator_digest: Make correct error messages appear again. When an incoming request can't be matched to an endpoint, the "artificial" auth object is used to create a challenge to return in a 401 response and we emit a "No matching endpoint found" log message. If the client then responds with an Authorization header but the request still can't be matched to an endpoint, the verification will fail and, as before, we'll create a challenge to return in a 401 response and we emit a "No matching endpoint found" log message. HOWEVER, because there WAS an Authorization header and it failed verification, we should have also been emitting a "Failed to authenticate" log message but weren't because there was a check that short-circuited that it if the artificial auth was used. Since many admins use the "Failed to authenticate" message with log parsers like fail2ban, those attempts were not being recognized as suspicious. Changes: * digest_check_auth() now always emits the "Failed to authenticate" log message if verification of an Authorization header failed even if the artificial auth was used. * The verification logic was refactored to be clearer about the handling of the return codes from verify(). * Comments were added clarify what return codes digest_check_auth() should return to the distributor and the implications of changing them. Resolves: #1095	3 months ago
George Joseph	014994b19f	alembic: Database updates required. This commit doesn't actually change anything. It just adds the following upgrade notes that were omitted from the original commits. Resolves: #1097 UpgradeNote: Two commits in this release... 'Add SHA-256 and SHA-512-256 as authentication digest algorithms' 'res_pjsip: Add new AOR option "qualify_2xx_only"' ...have modified alembic scripts for the following database tables: ps_aors, ps_contacts, ps_auths, ps_globals. If you don't use the scripts to update your database, reads from those tables will succeeed but inserts into the ps_contacts table by res_pjsip_registrar will fail.	3 months ago
Sean Bright	82bef2ed90	docs: Indent <since> tags. Also updates the 'since' of applications/functions that existed before XML documentation was introduced (1.6.2.0).	3 months ago
George Joseph	32e6a30952	res_pjsip: Fix startup/reload memory leak in config_auth. An issue in config_auth.c:ast_sip_auth_digest_algorithms_vector_init() was causing double allocations for the two supported_algorithms vectors to the tune of 915 bytes. The leak only happens on startup and when a reload is done and doesn't get bigger with the number of auth objects defined. * Pre-initialized the two vectors in config_auth:auth_alloc(). * Removed the allocations in ast_sip_auth_digest_algorithms_vector_init(). * Added a note to the doc for ast_sip_auth_digest_algorithms_vector_init() noting that the vector passed in should be initialized and empty. * Simplified the create_artificial_auth() function in pjsip_distributor. * Set the vector initialization count to 0 in config_global:global_apply().	3 months ago
George Joseph	198b01c536	docs: Add version information to application and function XML elements * Do a git blame on the embedded XML application or function element. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The applications and functions defined in the following files were done by hand because the XML was extracted from the C source file relatively recently. * channels/pjsip/dialplan_functions_doc.xml * main/logger_doc.xml * main/manager_doc.xml * res/res_geolocation/geoloc_doc.xml * res/res_stir_shaken/stir_shaken_doc.xml	3 months ago
George Joseph	77d5550d14	docs: Add version information to manager event instance XML elements * Do a git blame on the embedded XML managerEvent elements. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The events defined in res/res_pjsip/pjsip_manager.xml were done by hand because the XML was extracted from the C source file relatively recently. Two bugs were fixed along the way... * The get_documentation awk script was exiting after it processed the first DOCUMENTATION block it found in a file. We have at least 1 source file with multiple DOCUMENTATION blocks so only the first one in them was being processed. The awk script was changed to continue searching rather than exiting after the first block. * Fixing the awk script revealed an issue in logger.c where the third DOCUMENTATION block contained a XML fragment that consisted only of a managerEventInstance element that wasn't wrapped in a managerEvent element. Since logger_doc.xml already existed, the remaining fragments in logger.c were moved to it and properly organized.	3 months ago
Joshua C. Colp	53e7401f95	LICENSE: Update company name, email, and address.	3 months ago
Sean Bright	b460148163	res_prometheus.c: Set Content-Type header on /metrics response. This should resolve the Prometheus error: > Error scraping target: non-compliant scrape target sending blank Content-Type and no fallback_scrape_protocol specified for target. Resolves: #1075	3 months ago
George Joseph	6384e8667c	README.md, asterisk.c: Update Copyright Dates	3 months ago
George Joseph	316693ded9	docs: Add version information to configObject and configOption XML elements Most of the configObjects and configOptions that are implemented with ACO or Sorcery now have `<since>/<version>` elements added. There are probably some that the script I used didn't catch. The version tags were determined by the following... * Do a git blame on the API call that created the object or option. * From the commit hash, grab the summary line. * Do a `git log --grep <summary>` to find the cherry-pick commits in all branches that match. * Do a `git patch-id` to ensure the commits are all related and didn't get a false match on the summary. * Do a `git tag --contains <commit>` to find the tags that contain each commit. * Weed out all tags not <major>.<minor>.0. * Sort and discard any <major>.0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the API was last touched. configObjects and configOptions elements implemented with the base ast_config APIs were just not possible to find due to the non-deterministic way they are accessed. Also note that if the API call was on modified after it was added, the version will be the one it was last modified in. Final note: The configObject and configOption elements were introduced in 12.0.0 so options created before then may not have any XML documentation.	3 months ago
George Joseph	ff0fb401ae	res_pjsip_authenticator_digest: Fix issue with missing auth and DONT_OPTIMIZE The return code fom digest_check_auth wasn't explicitly being initialized. The return code also wasn't explicitly set to CHALLENGE when challenges were sent. When optimization was turned off (DONT_OPTIMIZE), the compiler was setting it to "0"(CHALLENGE) which worked fine. However, with optimization turned on, it was setting it to "1" (SUCCESS) so if there was no incoming Authorization header, the function was returning SUCCESS to the distributor allowing the request to incorrectly succeed. The return code is now initialized correctly and is now explicitly set to CHALLENGE when we send challenges.	3 months ago
Naveen Albert	cd97f4069d	ast_tls_cert: Add option to skip passphrase for CA private key. Currently, the ast_tls_cert file is hardcoded to use the -des3 option for 3DES encryption, and the script needs to be manually modified to not require a passphrase. Add an option (-e) that disables encryption of the CA private key so no passphrase is required. Resolves: #1064	3 months ago
Naveen Albert	f6e1c163bb	chan_iax2: Avoid unnecessarily backlogging non-voice frames. Currently, when receiving an unauthenticated call, we keep track of the negotiated format in the chosenformat, which allows us to later create the channel using the right format. However, this was not done for authenticated calls. This meant that in certain circumstances, if we had not yet received a voice frame from the peer, only certain other types of frames (e.g. text), there were no variables containing the appropriate frame. This led to problems in the jitterbuffer callback where we unnecessarily bailed out of retrieving a frame from the jitterbuffer. This was logic intentionally added in commit `73103bdcd5` in response to an earlier regression, and while this prevents crashes, it also backlogs legitimate frames unnecessarily. The abort logic was initially added because at this point in the code, we did not have the negotiated format available to us. However, it should always be available to us as a last resort in chosenformat, so we now pull it from there if needed. This allows us to process frames the jitterbuffer even if voicefmt and peerfmt aren't set and still avoid the crash. The failsafe logic is retained, but now it shouldn't be triggered anymore. Resolves: #1054	3 months ago
Allan Nathanson	217e696288	config.c: fix #tryinclude being converted to #include on rewrite Correct an issue in ast_config_text_file_save2() when updating configuration files with "#tryinclude" statements. The API currently replaces "#tryinclude" with "#include". The API also creates empty template files if the referenced files do not exist. This change resolves these problems. Resolves: https://github.com/asterisk/asterisk/issues/920	3 months ago
Naveen Albert	78546868f9	sig_analog: Add Last Number Redial feature. This adds the Last Number Redial feature to simple switch. UserNote: Users can now redial the last number called if the lastnumredial setting is set to yes. Resolves: #437	3 months ago
George Joseph	114fa12f05	docs: Various XML fixes * channels/pjsip/dialplan_functions_doc.xml: Added xmlns:xi to docs element. * main/bucket.c: Removed XML completely since the "bucket" and "file" objects are internal only with no config file. * main/named_acl.c: Fixed the configFile element name. It was "named_acl.conf" and should have been "acl.conf" * res/res_geolocation/geoloc_doc.xml: Added xmlns:xi to docs element. * res/res_http_media_cache.c: Fixed the configFile element name. It was "http_media_cache.conf" and should have been "res_http_media_cache.conf".	3 months ago
Sean Bright	1047291662	strings.c: Improve numeric detection in `ast_strings_match()`. Essentially, we were treating 1234x1234 and 1234x5678 as 'equal' because we were able to convert the prefix of each of these strings to the same number. Resolves: #1028	3 months ago
George Joseph	3868f7cb47	docs: Enable since/version handling for XML, CLI and ARI documentation * Added the "since" element to the XML configObject and configOption elements in appdocsxml.dtd. * Added the "Since" section to the following CLI output: ``` config show help <module> <object> config show help <module> <object> <option> core show application <app> core show function <func> manager show command <command> manager show event <event> agi show commands topic <topic> ``` * Refactored the commands above to output their sections in the same order: Synopsis, Since, Description, Syntax, Arguments, SeeAlso * Refactored the commands above so they all use the same pattern for writing the output to the CLI. * Fixed several memory leaks caused by failure to free temporary output buffers. * Added a "since" array to the mustache template for the top-level resources (Channel, Endpoint, etc.) and to the paths/methods underneath them. These will be added to the generated markdown if present. Example: ``` "resourcePath": "/api-docs/channels.{format}", "requiresModules": [ "res_stasis_answer", "res_stasis_playback", "res_stasis_recording", "res_stasis_snoop" ], "since": [ "18.0.0", "21.0.0" ], "apis": [ { "path": "/channels", "description": "Active channels", "operations": [ { "httpMethod": "GET", "since": [ "18.6.0", "21.8.0" ], "summary": "List all active channels in Asterisk.", "nickname": "list", "responseClass": "List[Channel]" }, ``` NOTE: No versioning information is actually added in this commit. Those will be added separately and instructions for adding and maintaining them will be published on the documentation site at a later date.	3 months ago
Artem Umerov	ae106fadfe	logger.h: Fix build when AST_DEVMODE is not defined. Resolves: #1058	3 months ago
Sean Bright	88abf2207b	dialplan_functions_doc.xml: Document PJSIP_MEDIA_OFFER's `media` argument. Resolves: #1023	3 months ago
Abdelkader Boudih	831b5ec11d	samples: Use "asterisk" instead of "postgres" for username	3 months ago
Sean Bright	468601fd13	manager: Add `<since>` tags for all AMI actions.	3 months ago
Steffen Arntz	4ef68fbce8	logger.c fix: malformed JSON template this typo was mentioned before, but never got fixed. https://community.asterisk.org/t/logger-cannot-log-long-json-lines-properly/87618/6	4 months ago
Sean Bright	7b71efd172	manager.c: Rename restrictedFile to is_restricted_file. Also correct the spelling of 'privileges.'	4 months ago
Abdelkader Boudih	a24853ecdf	res_config_pgsql: normalize database connection option with cel and cdr by supporting new options name	4 months ago
Stanislav Abramenkov	f72b8aa064	res_pjproject: Fix typo (OpenmSSL->OpenSSL) Fix typo (OpenmSSL->OpenSSL) mentioned by bkford in #972	4 months ago
George Joseph	71a2e8c599	Add SHA-256 and SHA-512-256 as authentication digest algorithms * Refactored pjproject code to support the new algorithms and added a patch file to third-party/pjproject/patches * Added new parameters to the pjsip auth object: * password_digest = <algorithm>:<digest> * supported_algorithms_uac = List of algorithms to support when acting as a UAC. * supported_algorithms_uas = List of algorithms to support when acting as a UAS. See the auth object in pjsip.conf.sample for detailed info. * Updated both res_pjsip_authenticator_digest.c (for UAS) and res_pjsip_outbound_authentocator_digest.c (UAC) to suport the new algorithms. The new algorithms are only available with the bundled version of pjproject, or an external version > 2.14.1. OpenSSL version 1.1.1 or greater is required to support SHA-512-256. Resolves: #948 UserNote: The SHA-256 and SHA-512-256 algorithms are now available for authentication as both a UAS and a UAC.	4 months ago
Allan Nathanson	22b261575f	config.c: retain leading whitespace before comments Configurations loaded with the ast_config_load2() API and later written out with ast_config_text_file_save2() will have any leading whitespace stripped away. The APIs should make reasonable efforts to maintain the content and formatting of the configuration files. This change retains any leading whitespace from comment lines that start with a ";". Resolves: https://github.com/asterisk/asterisk/issues/970	4 months ago
Ben Ford	7f70190c59	manager.c: Restrict ListCategories to the configuration directory. When using the ListCategories AMI action, it was possible to traverse upwards through the directories to files outside of the configured configuration directory. This action is now restricted to the configured directory and an error will now be returned if the specified file is outside of this limitation. Resolves: #GHSA-33x6-fj46-6rfh UserNote: The ListCategories AMI action now restricts files to the configured configuration directory.	4 months ago
Sean Bright	e904ae5df0	config.c: Fix off-nominal reference leak. This was identified and fixed by @Allan-N in #918 but it is an important fix in its own right. The fix here is slightly different than Allan's in that we just move the initialization of the problematic AO2 container to where it is first used. Fixes #1046	4 months ago
Abdelkader Boudih	18573fa36e	normalize contrib/ast-db-manage/queue_log.ini.sample	4 months ago
George Joseph	62ec48cf1c	Add C++ Standard detection to configure and fix a new C++20 compile issue * The autoconf-archive package contains macros useful for detecting C++ standard and testing other C++ capabilities but that package was never included in the install_prereq script so many existing build environments won't have it. Even if it is installed, older versions won't newer C++ standards and will actually cause an error if you try to test for that version. To make it available for those environments, the ax_cxx_compile_stdcxx.m4 macro has copied from the latest release of autoconf-archive into the autoconf directory. * A convenience wrapper(ast_cxx_check_std) around ax_cxx_compile_stdcxx was also added so checking the standard version and setting the asterisk-specific PBX_ variables becomes a one-liner: `AST_CXX_CHECK_STD([std], [force_latest_std])`. Calling that with a version of `17` for instance, will set PBX_CXX17 to 0 or 1 depending on whether the current c++ compiler supports stdc++17. HAVE_CXX17 will also be 'defined" or not depending on the result. * C++ compilers hardly ever default to the latest standard they support. g++ version 14 for instance supports up to C++23 but only uses C++17 by default. If you want to use C++23, you have to add `-std=gnu++=23` to the g++ command line. If you set the second argument of AST_CXX_CHECK_STD to "yes", the macro will automatically keep the highest `-std=gnu++` value that worked and pass that to the Makefiles. * The autoconf-archive package was added to install_prereq for future use. * Updated configure.ac to use AST_CXX_CHECK_STD() to check for C++ versions 11, 14, 17, 20 and 23. * Updated configure.ac to accept the `--enable-latest-cxx-std` option which will set the second option to AST_CXX_CHECK_STD() to "yes". The default is "no". * ast_copy_string() in strings.h declares the 'sz' variable as volatile and does an `sz--` on it later. C++20 no longer allows the `++` and `--` increment and decrement operators to be used on variables declared as volatile however so that was changed to `sz -= 1`.	4 months ago
Naveen Albert	5ed7f4d152	chan_dahdi: Fix wrong channel state when RINGING recieved. Previously, when AST_CONTROL_RINGING was received by a DAHDI device, it would set its channel state to AST_STATE_RINGING. However, an analysis of the codebase and other channel drivers reveals RINGING corresponds to physical power ringing, whereas AST_STATE_RING should be used for audible ringback on the channel. This also ensures the correct device state is returned by the channel state to device state conversion. Since there seems to be confusion in various places regarding AST_STATE_RING vs. AST_STATE_RINGING, some documentation has been added or corrected to clarify the actual purposes of these two channel states, and the associated device state mapping. An edge case that prompted this fix, but isn't explicitly addressed here, is that of an incoming call to an FXO port. The channel state will be "Ring", which maps to a device state of "In Use", not "Ringing" as would be more intuitive. However, this is semantic, since technically, Asterisk is treating this the same as any other incoming call, and so "Ring" is the semantic state (put another way, Asterisk isn't ringing anything, like in the cases where channels are in the "Ringing" state). Since FXO ports don't currently support Call Waiting, a suitable workaround for the above would be to ignore the device state and instead check the channel state (e.g. IMPORT(DAHDI/1-1,CHANNEL(state))) since it will be Ring if the FXO port is idle (but a call is ringing on it) and Up if the FXO port is actually in use. (In both cases, the device state would misleadingly be "In Use".) Resolves: #1029	4 months ago
Stanislav Abramenkov	653f3c4737	Upgrade bundled pjproject to 2.15.1 Resolves: asterisk#1016 UserNote: Bundled pjproject has been upgraded to 2.15.1. For more information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.15.1	4 months ago
George Joseph	6a2a320de9	.github: Set exit 0 in CherryPick and Recheck workflow Cleanup steps	4 months ago
George Joseph	67ad0448ed	gcc14: Fix issues caught by gcc 14 * test_message.c: Fix segfaults caused by passing NULL as an sprintf fmt.	4 months ago
George Joseph	a33505b334	Header fixes for compiling C++ source files A few tweaks needed to be done to some existing header files to allow them to be compiled when included from C++ source files. logger.h had declarations for ast_register_verbose() and ast_unregister_verbose() which caused C++ issues but those functions were actually removed from logger.c many years ago so the declarations were just removed from logger.h.	4 months ago
George Joseph	92e5ed5a3a	Add ability to pass arguments to unit tests from the CLI Unit tests can now be passed custom arguments from the command line. For example, the following command would run the "mytest" test in the "/main/mycat" category with the option "myoption=54" `CLI> test execute category /main/mycat name mytest options myoption=54` You can also pass options to an entire category... `CLI> test execute category /main/mycat options myoption=54` Basically, everything after the "options" keyword is passed verbatim to the test which must decide what to do with it. * A new API ast_test_get_cli_args() was created to give the tests access to the cli_args->argc and cli_args->argv elements. * Although not needed for the option processing, a new macro ast_test_validate_cleanup_custom() was added to test.h that allows you to specify a custom error message instead of just "Condition failed". * The test_skel.c was updated to demonstrate parsing options and the use of the ast_test_validate_cleanup_custom() macro.	4 months ago
Kent	3dee037446	res_pjsip: Add new AOR option "qualify_2xx_only" Added a new option "qualify_2xx_only" to the res_pjsip AOR qualify feature to mark a contact as available only if an OPTIONS request returns a 2XX response. If the option is not specified or is false, any response to the OPTIONS request marks the contact as available. UserNote: The pjsip.conf AOR section now has a "qualify_2xx_only" option that can be set so that only 2XX responses to OPTIONS requests used to qualify a contact will mark the contact as available.	4 months ago
George Joseph	f36a736a0c	.github: Change the run name for OnPRStateChangedPriv	4 months ago
Jaco Kroon	b3d9c11b54	res_odbc: release threads from potential starvation. Whenever a slot is freed up due to a failed connection, wake up a waiter before failing. In the case of a dead connection there could be waiters, for example, let's say two threads tries to acquire objects at the same time, with one in the cached connections, one will acquire the dead connection, and the other will enter into the wait state. The thread with the dead connection will clear up the dead connection, and then attempt a re-acquire (at this point there cannot be cached connections else the other thread would have received that and tried to clean up), as such, at this point we're guaranteed that either there are no waiting threads, or that the maxconnections - connection_cnt threads will attempt to re-acquire connections, and then either succeed, using those connections, or failing, and then signalling to release more waiters. Also fix the pointer log for ODBC handle %p dead which would always reflect NULL. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 months ago

1 2 3 4 5 ...

34101 Commits (master) All Branches Search

34101 Commits (master)

All Branches