34280 Commits (20)

 

All Branches   

Search

Author	SHA1	Message	Date
Mike Bradeen	3225cd54d4	res_sorcery_memory_cache: Reduce cache lock time for sorcery memory cache populate command ... Reduce cache lock time for AMI and CLI sorcery memory cache populate commands by adding a new populate_lock to the sorcery_memory_cache struct which is locked separately from the existing cache lock so that the cache lock can be maintained for a reduced time, locking only when the cache objects are removed and re-populated. Resolves: #1700 UserNote: The AMI command sorcery memory cache populate will now return an error if there is an internal error performing the populate. The CLI command will display an error in this case as well.	4 days ago
phoneben	0e754b214b	Add comment to asterisk.conf.sample clarifying that template sections are ignored ... Add comment to asterisk.conf.sample clarifying that template sections are ignored. Resolves: #1692	4 days ago
George Joseph	a1c3677d4a	chan_websocket: Use the channel's ability to poll fds for the websocket read. ... We now add the websocket's file descriptor to the channel's fd array and let it poll for data availability instead if having a dedicated thread that does the polling. This eliminates the thread and allows removal of most explicit locking since the core channel code will lock the channel to prevent simultaneous calls to webchan_read, webchan_hangup, etc. While we were here, the hangup code was refactored to use ast_hangup_with_cause instead of directly queueing an AST_CONTROL_HANGUP frame. This allows us to set hangup causes and generate snapshots. For a bit of extra debugging, a table of websocket close codes was added to http_websocket.h with an accompanying "to string" function added to res_http_websocket.c Resolves: #1683	7 days ago
Sean Bright	36465a4ceb	asterisk.c: Allow multi-byte characters on the Asterisk CLI. ... Versions of libedit that support Unicode expect that the EL_GETCFN (the function that does character I/O) will fill in a `wchar_t` with a character, which may be multi-byte. The built-in function that libedit provides, but does not expose with a public API, does properly handle multi-byte sequences. Due to the design of Asterisk's console processing loop, Asterisk provides its own implementation which does not handle multi-byte characters. Changing Asterisk to use libedit's built-in function would be ideal, but would also require changing some fundamental things about console processing which could be fairly disruptive. Instead, we bring in libedit's `read_char` implementation and modify it to suit our specific needs. Resolves: #60	7 days ago
Sean Bright	33971a173e	func_presencestate.c: Allow `NOT_SET` to be set from CLI. ... Resolves: #1647	7 days ago
Peter Krall	13d01a86e3	res/ari/resource_bridges.c: Normalize channel_format ref handling for bridge media ... Always take an explicit reference on the format used for bridge playback and recording channels, regardless of where it was sourced, and release it after prepare_bridge_media_channel. This aligns the code paths and avoids mixing borrowed and owned references while preserving behavior. Fixes: #1648	7 days ago
George Joseph	445130eeab	res_geolocation: Fix multiple issues with XML generation. ... * 3d positions were being rendered without an enclosing `<gml:pos>` element resulting in invalid XML. * There was no way to set the `id` attribute on the enclosing `tuple`, `device` and `person` elements. * There was no way to set the value of the `deviceID` element. * Parsing of degree and radian UOMs was broken resulting in them appearing outside an XML element. * The UOM schemas for degrees and radians were reversed. * The Ellipsoid shape was missing and the Ellipse shape was defined multiple times. * The `crs` location_info parameter, although documented, didn't work. * The `pos3d` location_info parameter appears in some documentation but wasn't being parsed correctly. * The retransmission-allowed and retention-expiry sub-elements of usage-rules were using the `gp` namespace instead of the `gbp` namespace. In addition to fixing the above, several other code refactorings were performed and the unit test enhanced to include a round trip XML -> eprofile -> XML validation. Resolves: #1667 UserNote: Geolocation: Two new optional profile parameters have been added. * `pidf_element_id` which sets the value of the `id` attribute on the top-level PIDF-LO `device`, `person` or `tuple` elements. * `device_id` which sets the content of the `<deviceID>` element. Both parameters can include channel variables. UpgradeNote: Geolocation: In order to correct bugs in both code and documentation, the following changes to the parameters for GML geolocation locations are now in effect: * The documented but unimplemented `crs` (coordinate reference system) element has been added to the location_info parameter that indicates whether the `2d` or `3d` reference system is to be used. If the crs isn't valid for the shape specified, an error will be generated. The default depends on the shape specified. * The Circle, Ellipse and ArcBand shapes MUST use a `2d` crs. If crs isn't specified, it will default to `2d` for these shapes. The Sphere, Ellipsoid and Prism shapes MUST use a `3d` crs. If crs isn't specified, it will default to `3d` for these shapes. The Point and Polygon shapes may use either crs. The default crs is `2d` however so if `3d` positions are used, the crs must be explicitly set to `3d`. * The `geoloc show gml_shape_defs` CLI command has been updated to show which coordinate reference systems are valid for each shape. * The `pos3d` element has been removed in favor of allowing the `pos` element to include altitude if the crs is `3d`. The number of values in the `pos` element MUST be 2 if the crs is `2d` and 3 if the crs is `3d`. An error will be generated for any other combination. * The angle unit-of-measure for shapes that use angles should now be included in the respective parameter. The default is `degrees`. There were some inconsistent references to `orientation_uom` in some documentation but that parameter never worked and is now removed. See examples below. Examples... ``` location_info = shape="Sphere", pos="39.0 -105.0 1620", radius="20" location_info = shape="Point", crs="3d", pos="39.0 -105.0 1620" location_info = shape="Point", pos="39.0 -105.0" location_info = shape=Ellipsoid, pos="39.0 -105.0 1620", semiMajorAxis="20" semiMinorAxis="10", verticalAxis="0", orientation="25 degrees" pidf_element_id = ${CHANNEL(name)}-${EXTEN} device_id = mac:001122334455 Set(GEOLOC_PROFILE(pidf_element_id)=${CHANNEL(name)}/${EXTEN}) ```	7 days ago
George Joseph	44f61c92e2	stasis/control.c: Add destructor to timeout_datastore. ... The timeout_datastore was missing a destructor resulting in a leak of 16 bytes for every outgoing ARI call. Resolves: #1681	2 weeks ago
Sean Bright	9c7c7790d7	func_talkdetect.c: Remove reference to non-existent variables.	2 weeks ago
Nathaniel Wesley Filardo	ddee4048a9	configure.ac: use AC_PATH_TOOL for nm ... `nm` might, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: use `AC_PATH_TOOL` rather than `AC_PATH_PROG` to find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .) Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)	2 weeks ago
Alexei Gradinari	6c12996020	res_pjsip_mwi: Fix off-nominal endpoint ao2 ref leak in mwi_get_notify_data ... Delay acquisition of the ast_sip_endpoint reference in mwi_get_notify_data() to avoid an ao2 ref leak on early-return error paths. Move ast_sip_subscription_get_endpoint() to just before first use so all acquired references are properly cleaned up. Fixes: #1675	2 weeks ago
Maximilian Fridrich	ebde5ae5cb	res_pjsip_messaging: Add support for following 3xx redirects ... This commit integrates the redirect module into res_pjsip_messaging to enable following 3xx redirect responses for outgoing SIP MESSAGEs. When follow_redirect_methods contains 'message' on an endpoint, Asterisk will now follow 3xx redirect responses for MESSAGEs, similar to how it behaves for INVITE responses. Resolves: #1576 UserNote: A new pjsip endpoint option follow_redirect_methods was added. This option is a comma-delimited, case-insensitive list of SIP methods for which SIP 3XX redirect responses are followed. An alembic upgrade script has been added for adding this new option to the Asterisk database.	2 weeks ago
Maximilian Fridrich	569b3ed995	res_pjsip: Introduce redirect module for handling 3xx responses ... This commit introduces a new redirect handling module that provides infrastructure for following SIP 3xx redirect responses. The redirect functionality respects the endpoint's redirect_method setting and only follows redirects when set to 'uri_pjsip'. This infrastructure can be used by any PJSIP module that needs to handle 3xx redirect responses.	2 weeks ago
Tinet-mucw	417f21e38d	app_mixmonitor.c: Fix crash in mixmonitor_ds_remove_and_free when datastore is NULL ... The datastore may be NULL, so a null pointer check needs to be added. Resolves: #1673	2 weeks ago
Sven Kube	c955692e9c	res_pjsip_refer: don't defer session termination for ari transfer ... Allow session termination during an in progress ari handled transfer.	2 weeks ago
Naveen Albert	c59d86f3fd	chan_dahdi.conf.sample: Avoid warnings with default configs. ... callgroup and pickupgroup may only be specified for FXO-signaled channels; however, the chan_dahdi sample config had these options uncommented in the [channels] section, thus applying these settings to all channels, resulting in warnings. Comment these out so there are no warnings with an unmodified sample config. Resolves: #1552	2 weeks ago
sarangr7	057e14275e	main/dial.c: Set channel hangup cause on timeout in handle_timeout_trip ... When dial attempts timeout in the core dialing API, the channel's hangup cause was not being set before hanging up. Only the ast_dial_channel structure's internal cause field was updated, but the actual ast_channel hangup cause remained unset. This resulted in incorrect or missing hangup cause information being reported through CDRs, AMI events, and other mechanisms that read the channel's hangup cause when dial timeouts occurred via applications using the dialing API (FollowMe, Page, etc.). The fix adds proper channel locking and sets AST_CAUSE_NO_ANSWER on the channel before calling ast_hangup(), ensuring consistent hangup cause reporting across all interfaces. Resolves: #1660	2 weeks ago
Sean Bright	4a5e8b86fa	cel: Add missing manager documentation. ... The LOCAL_OPTIMIZE_BEGIN, STREAM_BEGIN, STREAM_END, and DTMF CEL events were not all documented in the CEL configuration file or the manager documentation for the CEL event.	2 weeks ago
Sean Bright	aff11dca5f	res_odbc: Use SQL_SUCCEEDED() macro where applicable. ... This is just a cleanup of some repetitive code.	2 weeks ago
Justin T. Gibbs	0e8a22caf0	rtp/rtcp: Configure dual-stack behavior via IPV6_V6ONLY ... Dual-stack behavior (simultaneous listening for IPV4 and IPV6 connections on a single socket) is required by Asterisk's ICE implementation. On systems with the IPV6_V6ONLY sockopt, set the option to 0 (dual-stack enabled) when binding to the IPV6 any address. This ensures correct behavior regardless of the system's default dual-stack configuration.	2 weeks ago
Sean Bright	c49fb3ec10	http.c: Include remote address in URI handler message. ... Resolves: #1662	2 weeks ago
Joshua C. Colp	6c047d3da5	pjsip: Move from threadpool to taskpool ... This change moves the PJSIP module from the threadpool API to the taskpool API. PJSIP-specific implementations for task usage have been removed and replaced with calls to the optimized taskpool implementations instead. The need for a pool of serializers has also been removed as taskpool inherently provides this. The default settings have also been changed to be more realistic for common usage. UpgradeNote: The threadpool_* options in pjsip.conf have now been deprecated though they continue to be read and used. They have been replaced with taskpool options that give greater control over the underlying taskpool used for PJSIP. An alembic upgrade script has been added to add these options to realtime as well.	4 weeks ago
phoneben	01deece587	Disable device state caching for ephemeral channels ... chan_audiosocket/chan_rtp/res_stasis_snoop: Disable device state caching for ephemeral channels Resolves: #1638	4 weeks ago
George Joseph	48763baa10	chan_websocket: Add locking in send_event and check for NULL websocket handle. ... On an outbound websocket connection, when the triggering caller hangs up, webchan_hangup() closes the outbound websocket session and sets the websocket session handle to NULL. If the hangup happened in the tiny window between opening the outbound websocket connection and before read_thread_handler() was able to send the MEDIA_START message, it could segfault because the websocket session handle was NULL. If it didn't actually segfault, there was also the possibility that the websocket instance wouldn't get cleaned up which could also cause the channel snapshot to not get cleaned up. That could cause memory leaks and `core show channels` to list phantom WebSocket channels. To prevent the race, the send_event() macro now locks the websocket_pvt instance and checks the websocket session handle before attempting to send the MEDIA_START message. Resolves: #1643 Resolves: #1645	4 weeks ago
phoneben	017e3409ab	Fix false null-deref warning in channel_state ... Resolve analyzer warning in channel_state by checking AST_FLAG_DEAD on snapshot, which is guaranteed non-NULL. Resolves: #1430	1 month ago
George Joseph	8f90b2fd38	endpoint.c: Plug a memory leak in ast_endpoint_shutdown(). ... Commit 26795be introduced a memory leak of ast_endpoint when ast_endpoint_shutdown() was called. The leak occurs only if a configuration change removes an endpoint and isn't related to call volume or the length of time asterisk has been running. An ao2_ref(-1) has been added to ast_endpoint_shutdown() to plug the leak. Resolves: #1635	1 month ago
Sean Bright	0a83b87b4c	Revert "func_hangupcause.c: Add access to Reason headers via HANGUPCAUSE()" ... This reverts commit 5177662990. For rationale, see #1621 and #1606	1 month ago
Sean Bright	55731e8d1f	cel_manager.c: Correct manager event mask for CEL events. ... There is no EVENT_FLAG_CEL and these events are raised with as EVENT_FLAG_CALL.	1 month ago
Sean Bright	5cff97d87e	app_queue.c: Update docs to correct QueueMemberPause event name.	1 month ago
Mike Bradeen	e016ba689a	taskprocessors: Improve logging and add new cli options ... This change makes some small changes to improve log readability in addition to the following changes: Modified 'core show taskprocessors' to now show Low time and High time for task execution. New command 'core show taskprocessor name <taskprocessor-name>' to dump taskprocessor info and current queue. Addionally, a new test was added to demonstrate the 'show taskprocessor name' functionality: test execute category /main/taskprocessor/ name taskprocessor_cli_show Setting 'core set debug 3 taskprocessor.c' will now log pushed tasks. (Warning this is will cause extremely high levels of logging at even low traffic levels.) Resolves: #1566 UserNote: New CLI command has been added - core show taskprocessor name <taskprocessor-name>	1 month ago
Michal Hajek	e1d49be69d	manager: fix double free of criteria variable when adding filter ... Signed-off-by: Michal Hajek <michal.hajek@daktela.com> Fixes: #1531	1 month ago
Sean Bright	a6539cb9af	app_stream_echo.c: Check that stream is non-NULL before dereferencing. ... Also re-order and rename the arguments of `stream_echo_write_error` to match those of `ast_write_stream` for consistency. Resolves: #1427	1 month ago
Sean Bright	c6dd98ecf2	abstract_jb.c: Remove redundant timer check per static analysis. ... While this check is technically unnecessary, it also was not harmful. The 2 other items mentioned in the linked issue are false positives and require no action. Resolves: #1417	1 month ago
phoneben	dcb8b505f7	channelstorage_cpp: Fix fallback return value in channelstorage callback ... callback returned the last iterated channel when no match existed, causing invalid channel references and potential double frees. Updated to correctly return NULL when there is no match. Resolves: #1609	1 month ago
George Joseph	1f47f6a836	ccss: Add option to ccss.conf to globally disable it. ... The Call Completion Supplementary Service feature is rarely used but many of it's functions are called by app_dial and channel.c "just in case". These functions lock and unlock the channel just to see if CCSS is enabled on it, which it isn't 99.99% of the time. UserNote: A new "enabled" parameter has been added to ccss.conf. It defaults to "yes" to preserve backwards compatibility but CCSS is rarely used so setting "enabled = no" in the "general" section can save some unneeded channel locking operations and log message spam. Disabling ccss will also prevent the func_callcompletion and chan_dahdi modules from loading. DeveloperNote: A new API ast_is_cc_enabled() has been added. It should be used to ensure that CCSS is enabled before making any other ast_cc_* calls.	1 month ago
George Joseph	0bdaf64295	app_directed_pickup.c: Change some log messages from NOTICE to VERBOSE. ... UpgradeNote: In an effort to reduce log spam, two normal progress "pickup attempted" log messages from app_directed_pickup have been changed from NOTICE to VERBOSE(3). This puts them on par with other normal dialplan progress messages.	1 month ago
Sean Bright	1cc988f9cc	chan_websocket: Fix crash on DTMF_END event. ... Resolves: #1604	1 month ago
Joe Garlick	802781db3f	chan_websocket.c: Tolerate other frame types ... Currently, if chan_websocket receives an un supported frame like comfort noise it will exit the websocket. The proposed change is to tolerate the other frames by not sending them down the websocket but instead just ignoring them. Resolves: #1587	2 months ago
Naveen Albert	403d1e5da2	app_reload: Fix Reload() without arguments. ... Calling Reload() without any arguments is supposed to reload everything (equivalent to a 'core reload'), but actually does nothing. This is because it was calling ast_module_reload with an empty string, and the argument needs to explicitly be NULL. Resolves: #1597	2 months ago
Naveen Albert	93583fb188	pbx.c: Print new context count when reloading dialplan. ... When running "dialplan reload", the number of contexts reported is initially wrong, as it is the old context count. Running "dialplan reload" a second time returns the correct number of contexts that are loaded. This can confuse users into thinking that the reload didn't work successfully the first time. This counter is currently only incremented when iterating the old contexts prior to the context merge; at the very end, get the current number of elements in the context hash table and report that instead. This way, the count is correct immediately whenever a reload occurs. Resolves: #1599	2 months ago
C. Maj	3d9fc0ffb8	Makefile: Add module-list-* targets. ... Convenience wrappers for showing modules at various support levels. * module-list-core * module-list-extended * module-list-deprecated Resolves: #1572 UserNote: Try "make module-list-deprecated" to see what modules are on their way out the door.	2 months ago
Tinet-mucw	f79b5a5b59	core_unreal.c: Use ast instead of p->chan to get the DIALSTATUS variable ... After p->chan = NULL, ast still points to the valid channel object, using ast safely accesses the channel's DIALSTATUS variable before it's fully destroyed Resolves: #1590	2 months ago
George Joseph	6ec5e19d01	ast_coredumper: Fix multiple issues ... * Fixed an issue with tarball-coredumps when asterisk was invoked without an absolute path. * Fixed an issue with gdb itself segfaulting when trying to get symbols from separate debuginfo files. The command line arguments needed to be altered such that the gdbinit files is loaded before anything else but the `dump-asterisk` command is run after full initialization. In the embedded gdbinit script: * The extract_string_symbol function needed a `char *` cast to work properly. * The s_strip function needed to be updated to continue to work with the cpp_map_name_id channel storage backend. * A new function was added to dump the channels when cpp_map_name_id was used. * The Channel object was updated to account for the new channel storage backends * The show_locks function was refactored to work correctly.	2 months ago
Daouda Taha	21fff7f362	app_mixmonitor: Add 's' (skip) option to delay recording. ... The 's' (skip) option delays MixMonitor recording until the specified number of seconds (can be fractional) have elapsed since MixMonitor was invoked. No audio is written to the recording file during this time. If the call ends before this period, no audio will be saved. This is useful for avoiding early audio such as announcements, ringback tones, or other non-essential sounds. UserNote: This change introduces a new 's(<seconds>)' (skip) option to the MixMonitor application. Example: MixMonitor(${UNIQUEID}.wav,s(3)) This skips recording for the first 3 seconds before writing audio to the file. Existing MixMonitor behavior remains unchanged when the 's' option is not used.	2 months ago
phoneben	203796f3c6	stasis: switch stasis show topics temporary container from list - RBtree ... switch stasis show topics temporary container from list to RB-tree minimizing lock time Resolves: #1585	2 months ago
Sean Bright	6cc4634e87	app_dtmfstore: Avoid a potential buffer overflow. ... Prefer snprintf() so we can readily detect if our output was truncated. Resolves: #1421	2 months ago
Sean Bright	7ac1244288	main: Explicitly mark case statement fallthrough as such. ... Resolves: #1442	2 months ago
Sean Bright	942778c99e	bridge_softmix: Return early on topology allocation failure. ... Resolves: #1446	2 months ago
Sean Bright	fec24b3e6f	bridge_simple: Increase code verbosity for clarity. ... There's no actual problem here, but I can see how it might by confusing. Resolves: #1444	2 months ago
Kristian F. Høgh	f7bfb86e12	app_queue.c: Only announce to head caller if announce_to_first_user ... Only make announcements to head caller if announce_to_first_user is true Fixes: #1568 UserNote: When announce_to_first_user is false, no announcements are played to the head caller	2 months ago