asterisk

Commit Graph

Author	SHA1	Message	Date
George Joseph	502fe9e366	doc: Make progdocs play nice with git Moved contrib/asterisk-ng-doxygen to doc/asterisk-ng-doxygen.in Changed /Makefile to copy asterisk-ng-doxygen.in to asterisk-ng-doxygen then modify it with version instead of modifying asterisk-ng-doxygen directly. Updated clean targets as well. Updated /.gitignore and doc/.gitignore. Change-Id: I38712d3e334fa4baec19d30d05de8c6f28137622	10 years ago
George Joseph	d0ad45d7a2	.gitignore: Add .gcno and .gcda Products of --enable-coverage Change-Id: Ie20882d64b60692e2c941ea8872ab82a86ce77a3	10 years ago
Matt Jordan	b841e51eee	UPGRADE: Fix upgrade notes The next expected version from the 1.8 branch is a security point release. This patch updates the Git migration notes with that version. Change-Id: I6adbd59fb8c9f8f103ac5ed63bcf9b6009804eb7	10 years ago
George Joseph	9e4508e9be	More .gitignore updates Added .pyc and .sha1 to the top-level .gitignore. Change-Id: I7dfc4f554d54d22947b38140d3305007503cc16a Tested-by: George Joseph <george.joseph@fairview5.com>	10 years ago
Matt Jordan	ebbfac24d3	Merge ".gitignore updates for 1.8" into 1.8	10 years ago
George Joseph	59af44b1a2	Backport menuselect to 12,11,1.8 Backport menuselect from 13->12->11->1.8 Change-Id: I54c4dd2bdacd3c9d858be3acab08706941f2e585	10 years ago
George Joseph	b6aa301b2f	.gitignore updates for 1.8 Added bootstrap products Added channels/h323/Makefile Change-Id: I6b3bc56bf7bdaee0554f36fc2ce3a77e9eaf8aa3	10 years ago
Mark Michelson	41a9d426ba	Merge "main/editline: Add .gitignore." into 1.8	10 years ago
Matt Jordan	b81e84ed6b	.gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz extension. This will cause git to ignore downloaded sound tarballs in the the sounds/ directory. Change-Id: Ie84f085cc0fa51262209e7bfc1b1ba8c04a1ef59	10 years ago
Corey Farrell	e80210e0fb	main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results. Change-Id: I68c7bf375ea46282689e5a706534b69fca233b5d (cherry picked from commit `5d34bce635`)	10 years ago
George Joseph	80b04d9ac7	Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can add local ignores to the .git/info/exclude file without having to do a commit. Common ignore patterns are in the top-level .gitignore file. Subdirectory-specific ignore patterns are in their own .gitignore files. Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69 Tested-by: George Joseph (cherry picked from commit `b35e184d41`)	10 years ago
Matt Jordan	5d3fc148bf	build_tools/make_version: Update version parsing for Git migration External systems - such as the Asterisk Test Suite - require knowledge of the upstream branch. Unfortunately, after moving to Git, the Asterisk version currently consists of only a 'GIT" prefix followed by an object blob, e.g., GIT-as08d7. This makes it difficult for such systems to know what features are available in a particular check out of Asterisk. This patch fixes this by hardcoding the branch in a variable in the make_version script. Since the mainline branches are not changed often - typically only once a year - this is a reasonable approach to solving the problem, and is more reliable than parsing the output of 'git branch -vv'. Branches that track off of an upstream primary branch will then get the benefit of knowing which mainline branch they are currently based off of. ASTERISK-24954 #close Change-Id: I8090d5d548b6d19e917157ed530b914b7eaf9799	10 years ago
Jonathan Rose	7cc0384be4	Security/tcptls: MitM Attack potential from certificate with NULL byte in CN. When registering to a SIP server with TLS, Asterisk will accept CA signed certificates with a common name that was signed for a domain other than the one requested if it contains a null character in the common name portion of the cert. This patch fixes that by checking that the common name length matches the the length of the content we actually read from the common name segment. Some certificate authorities automatically sign CA requests when the requesting CN isn't already taken, so an attacker could potentially register a CN with something like www.google.com\x00www.secretlyevil.net and have their certificate signed and Asterisk would accept that certificate as though it had been for www.google.com - this is a security fix and is noted in AST-2015-003. ASTERISK-24847 #close Reported by: Maciej Szmigiero Patches: asterisk-null-in-cn.patch submitted by mhej (license 6085) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@434337 65c4cc65-6c06-0410-ace0-fbb531ad65f3	10 years ago
Mark Michelson	1de648f1d1	Backport AST-2015-002 fix to 1.8. This helps to prevent Asterisk from being an attack vector for HTTP request injection attacks based on CVE-2014-8150. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@431324 65c4cc65-6c06-0410-ace0-fbb531ad65f3	10 years ago
Mark Michelson	82a0a89d38	Fix error with mixed address family ACLs. Prior to this commit, the address family of the first item in an ACL was used to compare all incoming traffic. This could lead to traffic of other IP address families bypassing ACLs. ASTERISK-24469 #close Reported by Matt Jordan Patches: ASTERISK-24469-11.diff uploaded by Matt Jordan (License #6283) AST-2014-012 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@428402 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Kevin Harwell	a36c7c9c95	AST-2014-018 - func_db: DB Dialplan function permission escalation via AMI. The DB dialplan function when executed from an external protocol (for instance AMI), could result in a privilege escalation. Asterisk now inhibits the DB function from being executed from an external interface if the live_dangerously option is set to no. ASTERISK-24534 Reported by: Gareth Palmer patches: submitted by Gareth Palmer (license 5169) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@428331 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Corey Farrell	ce7bc7a503	Fix unintential memory retention in stringfields. * Fix missing / unreachable calls to __ast_string_field_release_active. * Reset pool->used to zero when the current pool->active reaches zero. ASTERISK-24307 #close Reported by: Etienne Lessard Tested by: ibercom, Etienne Lessard Review: https://reviewboard.asterisk.org/r/4114/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@427380 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Corey Farrell	37cd8a830b	Fix ast_writestream leaks Fix cleanup in __ast_play_and_record where others[x] may be leaked. This was caught where prepend != NULL && outmsg != NULL, once realfile[x] == NULL any further others[x] would be leaked. A cleanup block was also added for prepend != NULL && outmsg == NULL. 11+: Fix leak of ast_writestream recording_fs in app_voicemail:leave_voicemail. ASTERISK-24476 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4138/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@427023 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Tzafrir Cohen	27113c09dc	Fix syntax from r426926 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426929 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Tzafrir Cohen	092e00bdb0	install init.d files on GNU/kFreeBSD Review: https://reviewboard.asterisk.org/r/4118/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426926 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	09064cd3f5	channels/sip/reqresp_parser: Fix unit tests for r426594 When r426594 was made, it did not take into account a unit test that verified that the function properly populated the unsupported buffer. The function would previously memset the buffer if it detected it had any contents; since this function can now be called iteratively on successive headers, the unit tests would now fail. This patch updates the unit tests to reset the buffer themselves between successive calls, and updates the documentation of the function to note that this is now required. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426858 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Corey Farrell	04a07d8b18	REF_DEBUG: Install refcounter.py to $(ASTDATADIR)/scripts This change ensures refcounter.py is installed to a place where it can be found by the Asterisk testsuite if REF_DEBUG is enabled. ASTERISK-24432 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4094/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426830 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	f30c13bbed	app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE. In update_messages_by_imapuser(), messages were appended to a finite array which resulted in a crash when an IMAP mailbox contained more than 256 entries. This memory is now dynamically increased as needed. Observe that this patch adds a bunch of XXX's to questionable code. See the review (url below) for more information. ASTERISK-24190 #close Reported by: Nick Adams Tested by: Nick Adams Review: https://reviewboard.asterisk.org/r/4126/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426691 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	04802b1f09	channels/chan_sip: Add improved support for 4xx error codes This patch adds support for 414, 493, 479, and a stray 400 response in REGISTER response handling. This helps interoperability in a number of scenarios. Review: https://reviewboard.asterisk.org/r/3437 patches: rb3437.patch uploaded by oej (License 5267) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426599 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	88089b089a	channels/chan_sip: Support mutltiple Supported and Required headers A SIP request may contain multiple Supported: and Required: headers. Currently, chan_sip only parses the first Supported/Required header it finds. This patch adds support for multiple Supported/Required headers for INVITE requests. Review: https://reviewboard.asterisk.org/r/2478 ASTERISK-21721 #close Reported by: Olle Johansson patches: rb2478.patch uploaded by oej (License 5267) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426594 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Malcolm Davenport	92cdf7e634	ASTERISK-23512, correct inaccurate comment in manager.conf.sample git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426460 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Malcolm Davenport	47d6b7f6d7	ASTERISK-24323, fix bug in documentation of AGI STREAM FILE CONTROL git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Malcolm Davenport	bb0f217ada	ASTERISK-24419, fix incorrect syntax for setting language in extensions.conf.sample git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426295 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	83d38ad997	res/res_srtp: Fix include issue for libsrtp 1.5.0 In libsrtp 1.5.0, crypto_get_random is no longer resolved simply by including srtp.h. Now, one must include crypto_kernel.h as well. As it turns out, this header file has been provided by the library since 2006, so this is a relatively benign change. ASTERISK-24436 #close Reported by: Patrick Laimbock git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426140 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	eec6f7951c	AST-2014-011: Fix POODLE security issues There are two aspects to the vulnerability: (1) res_jabber/res_xmpp use SSLv3 only. This patch updates the module to use TLSv1+. At this time, it does not refactor res_jabber/res_xmpp to use the TCP/TLS core, which should be done as an improvement at a latter date. (2) The TCP/TLS core, when tlsclientmethod/sslclientmethod is left unspecified, will default to the OpenSSL SSLv23_method. This method allows for all encryption methods, including SSLv2/SSLv3. A MITM can exploit this by forcing a fallback to SSLv3, which leaves the server vulnerable to POODLE. This patch adds WARNINGS if a user uses SSLv2/SSLv3 in their configuration, and explicitly disables SSLv2/SSLv3 if using SSLv23_method. For TLS clients, Asterisk will default to TLSv1+ and WARN if SSLv2 or SSLv3 is explicitly chosen. For TLS servers, Asterisk will no longer support SSLv2 or SSLv3. Much thanks to abelbeck for reporting the vulnerability and providing a patch for the res_jabber/res_xmpp modules. Review: https://reviewboard.asterisk.org/r/4096/ ASTERISK-24425 #close Reported by: abelbeck Tested by: abelbeck, opsmonitor, gtjoseph patches: asterisk-1.8-jabber-tls.patch uploaded by abelbeck (License 5903) asterisk-11-jabber-xmpp-tls.patch uploaded by abelbeck (License 5903) AST-2014-011-1.8.diff uploaded by mjordan (License 6283) AST-2014-011-11.diff uploaded by mjordan (License 6283) AST-2014-011-12.diff uploaded by mjordan (License 6283) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425985 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Matthew Jordan	86c6c1b510	channels/chan_sip: Respect outboundproxy setting when sending qualify requests The outboundproxy setting is currently ignored when sending OPTIONS requests as a result of the qualify setting. This means that if an Asterisk server is unable to send the packet directly to a peer, it is unable to qualify any non-inbound registered peer (e.g. a peer SIP Trunk). This patch grabs the outboundproxy information for a peer when a qualify attempt is being constructed and, if it finds the information, uses it when sending the OPTIONS request. Review: https://reviewboard.asterisk.org/r/3948 ASTERISK-24063 #close Reported by: Damian Ivereigh patches: outboundproxy-dai.patch uploaded by Damian Ivereigh (License 6632) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Alexandr Anikin	2840c6d68b	: Resolve module reference leak caused by reserved sessions chan_ooh323: fix rtptimeout general value checking correct condition to check rtptimeout in [general] config section ASTERISK-24393 #close Reported by: Dmitry Melekhov Tested by: Dmitry Melekhov Patches: ASTERISK-24393.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425547 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Corey Farrell	878db57ba9	res_fax: Resolve module reference leak caused by reserved sessions Remove reference to module providing reserved session after adding a reference to the final module. This re-reference is done to ensure that module references are correct even if the final session selects a different module than the reserved session. ASTERISK-18923 #close Reported by: Grigoriy Puzankin Review: https://reviewboard.asterisk.org/r/4048/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425405 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	78077fdb3a	chan_sip: Fix so asterisk won't send reINVITE after a BYE. After a reINVITE glare situation, Asterisk would re-send the reINVITE even though the call had been hung up in the mean time. This patch unschedules the reinvite when handling the BYE. ASTERISK-22791 #close Reported by: Paolo Compagnini Tested by: Paolo Compagnini Review: https://reviewboard.asterisk.org/r/4056/ (testcase is in review r4055) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425296 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	53dd56bb54	build: Relax badshell tilde test to allow for ~ in middle of DESTDIR. The main Makefile has a target test called 'badshell' that tests if DESTDIR does not happen to have an an-expanded tilde (~). This might be the case if you run: make install DESTDIR=~/somewhere/ That test also disallowed valid tildes in directory names. The test is now changed to only trigger on a tilde at the start of the path. ASTERISK-13797 #close Reported by: Tzafrir Cohen Review: https://reviewboard.asterisk.org/r/4064/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425291 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	75d04686a0	res_calendar_ews: Relax neon version check to work with 0.30 too. Allow res_calendar_ews to work not only with libneon-0.29 but also with 0.30. ASTERISK-24325 #close Reported by: Tzafrir Cohen Review: https://reviewboard.asterisk.org/r/4068/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425286 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Kinsey Moore	0ce60da2ad	CallerID: Fix parsing regression This fixes a regression in callerid parsing introduced when another bug was fixed. This bug occurred when the name was composed entirely of DTMF keys and quoted without a number section (<>). ASTERISK-24406 #close Reported by: Etienne Lessard Tested by: Etienne Lessard Patches: callerid_fix.diff uploaded by Kinsey Moore Review: https://reviewboard.asterisk.org/r/4067/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425152 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	56a5bccb3b	chan_sip: Fix dialog leak resulting from missing ACK to re-INVITE. If a device re-INVITEs at the same time as the dialog is hung up, and if then the ACK to the re-INVITE never reaches Asterisk, chan_sip would fail to destroy the dialog after a while. This resulted in (most prominently) file handle leaks. (Patch reindented by me.) ASTERISK-20784 #close ASTERISK-15879 #close Reported by: Torrey Searle, Nitesh Bansal Patches: reinvite_ack_timeout.patch uploaded by Torrey Searle (License #5334) patch_asterisk_20784.txt uploaded by Nitesh Bansal (License #6418) Reviewboard: https://reviewboard.asterisk.org/r/4052/ (testcase can be found at r4051) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425068 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	2ed08f84ef	Ouch! Accidental commit of wrong file in 424875. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@424876 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	a3032baf86	safe_asterisk: Don't automatically exceed MAXFILES value of 2^20. On systems with lots of RAM (e.g. 24GB) /proc/sys/fs/file-max divided by two can exceed the per-process file limit of 2^20. This patch ensures the value is capped. (Patch cleaned up by me.) ASTERISK-24011 #close Reported by: Michael Myles Patches: safe_asterisk-ulimit.diff uploaded by Michael Myles (License #6626) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@424875 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Corey Farrell	468381b17a	astobj2: Correct REF_DEBUG false leak report When ao2_callback is run with OBJ_MULTIPLE and not OBJ_NODATA it allocates a temporary container in a way that does not record REF_DEBUG log entries. This changes that container to correctly record unref's when the container is freed. ASTERISK-24390 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4047/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@424786 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	4102ce8dbd	chan_sip: Simplify some unref code by removing unlink_peer_from_tables. ASTERISK-22945 #related Reported by: ibercom Patches: asterisk11-chan_sip-simplifies.patch uploaded by ibercom (License #6599) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@424181 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	adf46e91c5	chan_sip: Remove excess ref of realtime peer before sip_poke_peer. The peer is referenced at the end of sip_poke_peer, it should not get an extra ref before the call to sip_poke_peer. This fixes a memory leak. ASTERISK-22945 #close Reported by: ibercom Tested by: Yuriy Gorlichenko Patches: asterisk11.patch uploaded by ibercom (License #6599) Review: https://reviewboard.asterisk.org/r/4031/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@424176 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Richard Mudgett	70e5a1c1d1	res_fax: Fix out of bounds error in update_modem_bits(). ASTERISK-24357 #close Reported by: Jeremy Laine Patches: res_fax_bounds.patch (license #6561) patch uploaded by Jeremy Laine Modified patch to not use magic numbers. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423979 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	72183d96ee	docs: Escape unescaped minus sign in asterisk.8 manpage. ASTERISK-23768 #close Reported by: Jeremy Lainé Patches: escape_manpage_hyphen.patch uploaded by Jeremy Lainé (License #6561) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423915 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	50369441cf	chan_sip: Unref outbound proxy structure on dialog/pvt destruction. Make sure outbound proxy refs are always unreffed on dialog destruction. Review: https://reviewboard.asterisk.org/r/4016/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423800 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	0fef06f8ab	chan_sip: On INVITE retransmission, don't add an extra 503 response. INVITE arrives to asterisk, asterisk responds Busy(). If the INVITE is retransmitted, asterisk would generate a 503 in addition to the 486. Thanks Torrey Searle for providing a working regression test. ASTERISK-24335 #close Review: https://reviewboard.asterisk.org/r/4003/ Patches: retrans_486_invite.patch uploaded by Torrey Searle (License #5334) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423720 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Walter Doekes	4863b465af	cli.c: Fix tab completion "module load" when MALLOC_DEBUG is enabled. r421600 conflicted with r155763. ASTERISK-24348 #close git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423657 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
Richard Mudgett	b8c9c9a6e6	astobj2.c/refcounter.py: Fix to deal with invalid object refs. * Make astob2 REF_DEBUG output an invalid object line when an invalid ao2 object ref/unref is attempted. This is similar to the constructor/destructor lines. * Fixed refcounter.py to handle skewed objects that have constructor/destructor states. * Made refcounter.py highlight the invalid ao2 object refs by putting them in their own section of the processed output file. * Made refcounter.py highlight unreffing an object by more than one that results in a negative ref count and the object being destroyed. The abnormally destroyed object is reported in the invalid and finalized object sections of the output. Review: https://reviewboard.asterisk.org/r/3971/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago
George Joseph	b95d0c471b	config: bug: Fix SEGV in ast_category_insert when matching category isn't found If you call ast_category_insert with a match category that doesn't exist, the list traverse runs out of 'next' categories and you get a SEGV. This patch adds check for the end-of-list condition and changes the signature to return an int for success/failure indication instead of a void. The only consumer of this function is manager and it was also changed to use the return value. Tested by: George Joseph Review: https://reviewboard.asterisk.org/r/3993/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@423276 65c4cc65-6c06-0410-ace0-fbb531ad65f3	11 years ago

1 2 3 4 5 ...

22836 Commits (1.8) All Branches Search

22836 Commits (1.8)

All Branches