Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

Make sure we ring queues properly and know busy vs. no answer (bug #3114)

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4836 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.2-netsec
Mark Spencer 21 years ago
parent ee456ae10d
commit d4c553c202
1 changed files with 46 additions and 27 deletions
Show Stats Download Patch File Download Diff File

73
apps/app_queue.c
Unescape View File

@ -759,7 +759,7 @@ static int compare_weight(struct ast_call_queue *req_q, struct localuser *req_us
static int ring_entry(struct queue_ent *qe, struct localuser *tmp) static int ring_entry(struct queue_ent *qe, struct localuser *tmp, int *busies)
{ {
int res; int res;
int status; int status;
@ -773,6 +773,7 @@ static int ring_entry(struct queue_ent *qe, struct localuser *tmp)
if (qe->chan->cdr) if (qe->chan->cdr)
ast_cdr_busy(qe->chan->cdr); ast_cdr_busy(qe->chan->cdr);
tmp->stillgoing = 0; tmp->stillgoing = 0;
(*busies)++;
return 0; return 0;
} }
} }
@ -782,6 +783,7 @@ static int ring_entry(struct queue_ent *qe, struct localuser *tmp)
if (qe->chan->cdr) if (qe->chan->cdr)
ast_cdr_busy(qe->chan->cdr); ast_cdr_busy(qe->chan->cdr);
tmp->stillgoing = 0; tmp->stillgoing = 0;
(*busies)++;
return 0; return 0;
} }
@ -801,6 +803,7 @@ static int ring_entry(struct queue_ent *qe, struct localuser *tmp)
ast_cdr_busy(qe->chan->cdr); ast_cdr_busy(qe->chan->cdr);
tmp->stillgoing = 0; tmp->stillgoing = 0;
update_dial_status(qe->parent, tmp->member, status); update_dial_status(qe->parent, tmp->member, status);
(*busies)++;
return 0; return 0;
} else if (status != tmp->oldstatus) } else if (status != tmp->oldstatus)
update_dial_status(qe->parent, tmp->member, status); update_dial_status(qe->parent, tmp->member, status);
@ -841,6 +844,7 @@ static int ring_entry(struct queue_ent *qe, struct localuser *tmp)
ast_hangup(tmp->chan); ast_hangup(tmp->chan);
tmp->chan = NULL; tmp->chan = NULL;
tmp->stillgoing = 0; tmp->stillgoing = 0;
(*busies)++;
return 0; return 0;
} else { } else {
if (ast_test_flag(qe->parent, QUEUE_FLAG_EVENTWHENCALLED)) { if (ast_test_flag(qe->parent, QUEUE_FLAG_EVENTWHENCALLED)) {
@ -860,10 +864,10 @@ static int ring_entry(struct queue_ent *qe, struct localuser *tmp)
if (option_verbose > 2) if (option_verbose > 2)
ast_verbose(VERBOSE_PREFIX_3 "Called %s\n", tmp->interface); ast_verbose(VERBOSE_PREFIX_3 "Called %s\n", tmp->interface);
} }
return 0; return 1;
} }
static int ring_one(struct queue_ent *qe, struct localuser *outgoing) static int ring_one(struct queue_ent *qe, struct localuser *outgoing, int *busies)
{ {
struct localuser *cur; struct localuser *cur;
struct localuser *best; struct localuser *best;
@ -885,10 +889,10 @@ static int ring_one(struct queue_ent *qe, struct localuser *outgoing)
/* Ring everyone who shares this best metric (for ringall) */ /* Ring everyone who shares this best metric (for ringall) */
cur = outgoing; cur = outgoing;
while(cur) { while(cur) {
if (cur->stillgoing && !cur->chan && (cur->metric == bestmetric)) { if (cur->stillgoing && !cur->chan && (cur->metric <= bestmetric)) {
if (option_debug) if (option_debug)
ast_log(LOG_DEBUG, "(Parallel) Trying '%s' with metric %d\n", cur->interface, cur->metric); ast_log(LOG_DEBUG, "(Parallel) Trying '%s' with metric %d\n", cur->interface, cur->metric);
ring_entry(qe, cur); ring_entry(qe, cur, busies);
} }
cur = cur->next; cur = cur->next;
} }
@ -896,7 +900,7 @@ static int ring_one(struct queue_ent *qe, struct localuser *outgoing)
/* Ring just the best channel */ /* Ring just the best channel */
if (option_debug) if (option_debug)
ast_log(LOG_DEBUG, "Trying '%s' with metric %d\n", best->interface, best->metric); ast_log(LOG_DEBUG, "Trying '%s' with metric %d\n", best->interface, best->metric);
ring_entry(qe, best); ring_entry(qe, best, busies);
} }
} }
} while (best && !best->chan); } while (best && !best->chan);
@ -961,7 +965,27 @@ static int valid_exit(struct queue_ent *qe, char digit)
#define AST_MAX_WATCHERS 256 #define AST_MAX_WATCHERS 256
static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser *outgoing, int *to, struct ast_flags *flags, char *digit) #define BUILD_STATS do { \
o = outgoing; \
found = -1; \
pos = 1; \
numlines = 0; \
watchers[0] = in; \
while(o) { \
/* Keep track of important channels */ \
if (o->stillgoing) { \
stillgoing = 1; \
if (o->chan) { \
watchers[pos++] = o->chan; \
found = 1; \
} \
} \
o = o->next; \
numlines++; \
} \
} while(0)
static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser *outgoing, int *to, struct ast_flags *flags, char *digit, int prebusies)
{ {
char *queue = qe->parent->name; char *queue = qe->parent->name;
struct localuser *o; struct localuser *o;
@ -969,8 +993,9 @@ static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser
int numlines; int numlines;
int status; int status;
int sentringing = 0; int sentringing = 0;
int numbusies = 0; int numbusies = prebusies;
int numnochan = 0; int numnochan = 0;
int stillgoing = 0;
int orig = *to; int orig = *to;
struct ast_frame *f; struct ast_frame *f;
struct localuser *peer = NULL; struct localuser *peer = NULL;
@ -980,25 +1005,18 @@ static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser
struct ast_channel *in = qe->chan; struct ast_channel *in = qe->chan;
while(*to && !peer) { while(*to && !peer) {
o = outgoing; BUILD_STATS;
found = -1; if ((found < 0) && stillgoing && !qe->parent->strategy) {
pos = 1; /* On "ringall" strategy we only move to the next penalty level
numlines = 0; when *all* ringing phones are done in the current penalty level */
watchers[0] = in; ring_one(qe, outgoing, &numbusies);
while(o) { BUILD_STATS;
/* Keep track of important channels */
if (o->stillgoing && o->chan) {
watchers[pos++] = o->chan;
found = 1;
}
o = o->next;
numlines++;
} }
if (found < 0) { if (found < 0) {
if (numlines == (numbusies + numnochan)) { if (numlines == (numbusies + numnochan)) {
ast_log(LOG_DEBUG, "Everyone is busy at this time\n"); ast_log(LOG_DEBUG, "Everyone is busy at this time\n");
} else { } else {
ast_log(LOG_NOTICE, "No one is answering queue '%s'\n", queue); ast_log(LOG_NOTICE, "No one is answering queue '%s' (%d/%d/%d)\n", queue, numlines, numbusies, numnochan);
} }
*to = 0; *to = 0;
return NULL; return NULL;
@ -1109,7 +1127,7 @@ static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser
ast_hangup(o->chan); ast_hangup(o->chan);
o->chan = NULL; o->chan = NULL;
if (qe->parent->strategy) if (qe->parent->strategy)
ring_one(qe, outgoing); ring_one(qe, outgoing, &numbusies);
numbusies++; numbusies++;
break; break;
case AST_CONTROL_CONGESTION: case AST_CONTROL_CONGESTION:
@ -1121,7 +1139,7 @@ static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser
ast_hangup(o->chan); ast_hangup(o->chan);
o->chan = NULL; o->chan = NULL;
if (qe->parent->strategy) if (qe->parent->strategy)
ring_one(qe, outgoing); ring_one(qe, outgoing, &numbusies);
numbusies++; numbusies++;
break; break;
case AST_CONTROL_RINGING: case AST_CONTROL_RINGING:
@ -1147,7 +1165,7 @@ static struct localuser *wait_for_answer(struct queue_ent *qe, struct localuser
ast_hangup(o->chan); ast_hangup(o->chan);
o->chan = NULL; o->chan = NULL;
if (qe->parent->strategy) if (qe->parent->strategy)
ring_one(qe, outgoing); ring_one(qe, outgoing, &numbusies);
} }
} }
o = o->next; o = o->next;
@ -1328,6 +1346,7 @@ static int try_calling(struct queue_ent *qe, char *options, char *announceoverri
struct member *member; struct member *member;
int res = 0, bridge = 0; int res = 0, bridge = 0;
int zapx = 2; int zapx = 2;
int numbusies = 0;
int x=0; int x=0;
char *announce = NULL; char *announce = NULL;
char digit = 0; char digit = 0;
@ -1421,9 +1440,9 @@ static int try_calling(struct queue_ent *qe, char *options, char *announceoverri
to = qe->parent->timeout * 1000; to = qe->parent->timeout * 1000;
else else
to = -1; to = -1;
ring_one(qe, outgoing); ring_one(qe, outgoing, &numbusies);
ast_mutex_unlock(&qe->parent->lock); ast_mutex_unlock(&qe->parent->lock);
lpeer = wait_for_answer(qe, outgoing, &to, &flags, &digit); lpeer = wait_for_answer(qe, outgoing, &to, &flags, &digit, numbusies);
ast_mutex_lock(&qe->parent->lock); ast_mutex_lock(&qe->parent->lock);
if (qe->parent->strategy == QUEUE_STRATEGY_RRMEMORY) { if (qe->parent->strategy == QUEUE_STRATEGY_RRMEMORY) {
store_next(qe, outgoing); store_next(qe, outgoing);

Write Preview
Loading…
Cancel
Save