Merged revisions 124872 via svnmerge from

https://origsvn.digium.com/svn/asterisk/trunk

........
r124872 | phsultan | 2008-06-24 19:50:22 +0200 (Tue, 24 Jun 2008) | 6 lines

Subscribe to buddy's presence only if we really need to. That is, if
the corresponding roster item has a subscription value set to "none"
or "from".

Make the code more readable.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@124873 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_jabber.c

@@ -2137,26 +2137,33 @@ static int aji_filter_roster(void *data, ikspak *pak)
 				ASTOBJ_UNLOCK(iterator);
 			});
 
-			if (!flag) {
+			if (flag) {
-				buddy = ast_calloc(1, sizeof(*buddy));
+				/* found buddy, don't create a new one */
-				if (!buddy) {
+				x = iks_next(x);
-					ast_log(LOG_WARNING, "Out of memory\n");
+				continue;
-					return 0;
+			}
-				}
+			
-				ASTOBJ_INIT(buddy);
+			buddy = ast_calloc(1, sizeof(*buddy));
-				ASTOBJ_WRLOCK(buddy);
+			if (!buddy) {
-				ast_copy_string(buddy->name, iks_find_attrib(x, "jid"), sizeof(buddy->name));
+				ast_log(LOG_WARNING, "Out of memory\n");
-				ast_clear_flag(&buddy->flags, AST_FLAGS_ALL);
+				return 0;
-				if(ast_test_flag(&client->flags, AJI_AUTOPRUNE)) {
+			}
-					ast_set_flag(&buddy->flags, AJI_AUTOPRUNE);
+			ASTOBJ_INIT(buddy);
-					ASTOBJ_MARK(buddy);
+			ASTOBJ_WRLOCK(buddy);
-				} else
+			ast_copy_string(buddy->name, iks_find_attrib(x, "jid"), sizeof(buddy->name));
-					ast_set_flag(&buddy->flags, AJI_AUTOREGISTER);
+			ast_clear_flag(&buddy->flags, AST_FLAGS_ALL);
-				ASTOBJ_UNLOCK(buddy);
+			if(ast_test_flag(&client->flags, AJI_AUTOPRUNE)) {
-				if (buddy) {
+				ast_set_flag(&buddy->flags, AJI_AUTOPRUNE);
-					ASTOBJ_CONTAINER_LINK(&client->buddies, buddy);
+				ASTOBJ_MARK(buddy);
-					ASTOBJ_UNREF(buddy, aji_buddy_destroy);
+			} else if (!iks_strcmp(iks_find_attrib(x, "subscription"), "none") || !iks_strcmp(iks_find_attrib(x, "subscription"), "from")) {
-				}
+				/* subscribe to buddy's presence only 
+				   if we really need to */
+				ast_set_flag(&buddy->flags, AJI_AUTOREGISTER);
+			}
+			ASTOBJ_UNLOCK(buddy);
+			if (buddy) {
+				ASTOBJ_CONTAINER_LINK(&client->buddies, buddy);
+				ASTOBJ_UNREF(buddy, aji_buddy_destroy);
 			}
 		}
 		x = iks_next(x);