Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

Use a deep copy on strings that come from ast_events. Otherwise it is

Browse Source 
likely that after the event is freed, we no longer refer to valid memory.

(closes issue #12712)
Reported by: tomo1657
Patches:
      12712.patch uploaded by putnopvut (license 60)
Tested by: tomo1657



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.6.1
Mark Michelson 18 years ago
parent ebb4ba3b9a
commit 7e49fd2f0e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File

6
apps/app_voicemail.c
Unescape View File

@ -9166,6 +9166,8 @@ static int handle_subscribe(void *datap)
AST_RWLIST_WRLOCK(&mwi_subs); AST_RWLIST_WRLOCK(&mwi_subs);
AST_RWLIST_INSERT_TAIL(&mwi_subs, mwi_sub, entry); AST_RWLIST_INSERT_TAIL(&mwi_subs, mwi_sub, entry);
AST_RWLIST_UNLOCK(&mwi_subs); AST_RWLIST_UNLOCK(&mwi_subs);
ast_free(p->mailbox);
ast_free(p->context);
ast_free(p); ast_free(p);
return 0; return 0;
} }
@ -9200,8 +9202,8 @@ static void mwi_sub_event_cb(const struct ast_event *event, void *userdata)
ast_log(LOG_ERROR, "could not allocate a mwi_sub_task\n"); ast_log(LOG_ERROR, "could not allocate a mwi_sub_task\n");
return; return;
} }
mwist->mailbox = ast_event_get_ie_str(event, AST_EVENT_IE_MAILBOX); mwist->mailbox = ast_strdup(ast_event_get_ie_str(event, AST_EVENT_IE_MAILBOX));
mwist->context = ast_event_get_ie_str(event, AST_EVENT_IE_CONTEXT); mwist->context = ast_strdup(ast_event_get_ie_str(event, AST_EVENT_IE_CONTEXT));
mwist->uniqueid = ast_event_get_ie_uint(event, AST_EVENT_IE_UNIQUEID); mwist->uniqueid = ast_event_get_ie_uint(event, AST_EVENT_IE_UNIQUEID);
if (ast_taskprocessor_push(mwi_subscription_tps, handle_subscribe, mwist) < 0) { if (ast_taskprocessor_push(mwi_subscription_tps, handle_subscribe, mwist) < 0) {

Write Preview
Loading…
Cancel
Save