Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge "rtp_engine.c: Eliminate rtcp_report_to_json() RAII_VAR usage."

Browse Source
pull/9/head
Jenkins2 8 years ago committed by Gerrit Code Review
parent ece673f0f6 7054fb8756
commit 6bd25cad86
1 changed files with 31 additions and 29 deletions
Show Stats Download Patch File Download Diff File

60
main/rtp_engine.c
Unescape View File

@ -3092,10 +3092,10 @@ static struct ast_json *rtcp_report_to_json(struct stasis_message *msg,
const struct stasis_message_sanitizer *sanitize) const struct stasis_message_sanitizer *sanitize)
{ {
struct rtcp_message_payload *payload = stasis_message_data(msg); struct rtcp_message_payload *payload = stasis_message_data(msg);
RAII_VAR(struct ast_json *, json_rtcp_report, NULL, ast_json_unref); struct ast_json *json_rtcp_report = NULL;
RAII_VAR(struct ast_json *, json_rtcp_report_blocks, NULL, ast_json_unref); struct ast_json *json_rtcp_report_blocks;
RAII_VAR(struct ast_json *, json_rtcp_sender_info, NULL, ast_json_unref); struct ast_json *json_rtcp_sender_info = NULL;
RAII_VAR(struct ast_json *, json_channel, NULL, ast_json_unref); struct ast_json *json_channel = NULL;
int i; int i;
json_rtcp_report_blocks = ast_json_array_create(); json_rtcp_report_blocks = ast_json_array_create();
@ -3106,20 +3106,19 @@ static struct ast_json *rtcp_report_to_json(struct stasis_message *msg,
for (i = 0; i < payload->report->reception_report_count && payload->report->report_block[i]; i++) { for (i = 0; i < payload->report->reception_report_count && payload->report->report_block[i]; i++) {
struct ast_json *json_report_block; struct ast_json *json_report_block;
char str_lsr[32]; char str_lsr[32];
snprintf(str_lsr, sizeof(str_lsr), "%u", payload->report->report_block[i]->lsr); snprintf(str_lsr, sizeof(str_lsr), "%u", payload->report->report_block[i]->lsr);
json_report_block = ast_json_pack("{s: i, s: i, s: i, s: i, s: i, s: s, s: i}", json_report_block = ast_json_pack("{s: i, s: i, s: i, s: i, s: i, s: s, s: i}",
"source_ssrc", payload->report->report_block[i]->source_ssrc, "source_ssrc", payload->report->report_block[i]->source_ssrc,
"fraction_lost", payload->report->report_block[i]->lost_count.fraction, "fraction_lost", payload->report->report_block[i]->lost_count.fraction,
"packets_lost", payload->report->report_block[i]->lost_count.packets, "packets_lost", payload->report->report_block[i]->lost_count.packets,
"highest_seq_no", payload->report->report_block[i]->highest_seq_no, "highest_seq_no", payload->report->report_block[i]->highest_seq_no,
"ia_jitter", payload->report->report_block[i]->ia_jitter, "ia_jitter", payload->report->report_block[i]->ia_jitter,
"lsr", str_lsr, "lsr", str_lsr,
"dlsr", payload->report->report_block[i]->dlsr); "dlsr", payload->report->report_block[i]->dlsr);
if (!json_report_block) { if (!json_report_block
return NULL; || ast_json_array_append(json_rtcp_report_blocks, json_report_block)) {
} ast_json_unref(json_rtcp_report_blocks);
if (ast_json_array_append(json_rtcp_report_blocks, json_report_block)) {
return NULL; return NULL;
} }
} }
@ -3127,25 +3126,27 @@ static struct ast_json *rtcp_report_to_json(struct stasis_message *msg,
if (payload->report->type == AST_RTP_RTCP_SR) { if (payload->report->type == AST_RTP_RTCP_SR) {
char sec[32]; char sec[32];
char usec[32]; char usec[32];
snprintf(sec, sizeof(sec), "%lu", (unsigned long)payload->report->sender_information.ntp_timestamp.tv_sec); snprintf(sec, sizeof(sec), "%lu", (unsigned long)payload->report->sender_information.ntp_timestamp.tv_sec);
snprintf(usec, sizeof(usec), "%lu", (unsigned long)payload->report->sender_information.ntp_timestamp.tv_usec); snprintf(usec, sizeof(usec), "%lu", (unsigned long)payload->report->sender_information.ntp_timestamp.tv_usec);
json_rtcp_sender_info = ast_json_pack("{s: s, s: s, s: i, s: i, s: i}", json_rtcp_sender_info = ast_json_pack("{s: s, s: s, s: i, s: i, s: i}",
"ntp_timestamp_sec", sec, "ntp_timestamp_sec", sec,
"ntp_timestamp_usec", usec, "ntp_timestamp_usec", usec,
"rtp_timestamp", payload->report->sender_information.rtp_timestamp, "rtp_timestamp", payload->report->sender_information.rtp_timestamp,
"packets", payload->report->sender_information.packet_count, "packets", payload->report->sender_information.packet_count,
"octets", payload->report->sender_information.octet_count); "octets", payload->report->sender_information.octet_count);
if (!json_rtcp_sender_info) { if (!json_rtcp_sender_info) {
ast_json_unref(json_rtcp_report_blocks);
return NULL; return NULL;
} }
} }
json_rtcp_report = ast_json_pack("{s: i, s: i, s: i, s: o, s: o}", json_rtcp_report = ast_json_pack("{s: i, s: i, s: i, s: o, s: o}",
"ssrc", payload->report->ssrc, "ssrc", payload->report->ssrc,
"type", payload->report->type, "type", payload->report->type,
"report_count", payload->report->reception_report_count, "report_count", payload->report->reception_report_count,
"sender_information", json_rtcp_sender_info ? ast_json_ref(json_rtcp_sender_info) : ast_json_ref(ast_json_null()), "sender_information", json_rtcp_sender_info ?: ast_json_null(),
"report_blocks", ast_json_ref(json_rtcp_report_blocks)); "report_blocks", json_rtcp_report_blocks);
if (!json_rtcp_report) { if (!json_rtcp_report) {
return NULL; return NULL;
} }
@ -3153,14 +3154,15 @@ static struct ast_json *rtcp_report_to_json(struct stasis_message *msg,
if (payload->snapshot) { if (payload->snapshot) {
json_channel = ast_channel_snapshot_to_json(payload->snapshot, sanitize); json_channel = ast_channel_snapshot_to_json(payload->snapshot, sanitize);
if (!json_channel) { if (!json_channel) {
ast_json_unref(json_rtcp_report);
return NULL; return NULL;
} }
} }
return ast_json_pack("{s: o, s: o, s: o}", return ast_json_pack("{s: o, s: o, s: o}",
"channel", payload->snapshot ? ast_json_ref(json_channel) : ast_json_ref(ast_json_null()), "channel", payload->snapshot ? json_channel : ast_json_null(),
"rtcp_report", ast_json_ref(json_rtcp_report), "rtcp_report", json_rtcp_report,
"blob", ast_json_deep_copy(payload->blob)); "blob", ast_json_deep_copy(payload->blob) ?: ast_json_null());
} }
static void rtp_rtcp_report_dtor(void *obj) static void rtp_rtcp_report_dtor(void *obj)

Write Preview
Loading…
Cancel
Save