Simplify the if statements used to check to see if the argument was "num"

or "number".  It is not possible to ever reach the second part of this
conditional statement.

Thanks to my brother, Brett, for pointing this out.  :)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.6.0
Russell Bryant 19 years ago
parent d3bf06f272
commit 527dbe399e

@ -54,9 +54,7 @@ static int callerid_read(struct ast_channel *chan, char *cmd, char *data,
snprintf(buf, len, "\"%s\" <%s>", name, num); snprintf(buf, len, "\"%s\" <%s>", name, num);
} else if (!strncasecmp("name", data, 4)) { } else if (!strncasecmp("name", data, 4)) {
ast_copy_string(buf, name, len); ast_copy_string(buf, name, len);
} else if (!strncasecmp("num", data, 3) || } else if (!strncasecmp("num", data, 3)) {
!strncasecmp("number", data, 6)) {
ast_copy_string(buf, num, len); ast_copy_string(buf, num, len);
} else { } else {
ast_log(LOG_ERROR, "Unknown callerid data type '%s'.\n", data); ast_log(LOG_ERROR, "Unknown callerid data type '%s'.\n", data);
@ -70,8 +68,7 @@ static int callerid_read(struct ast_channel *chan, char *cmd, char *data,
if (chan->cid.cid_name) { if (chan->cid.cid_name) {
ast_copy_string(buf, chan->cid.cid_name, len); ast_copy_string(buf, chan->cid.cid_name, len);
} }
} else if (!strncasecmp("num", data, 3) } else if (!strncasecmp("num", data, 3)) {
|| !strncasecmp("number", data, 6)) {
if (chan->cid.cid_num) { if (chan->cid.cid_num) {
ast_copy_string(buf, chan->cid.cid_num, len); ast_copy_string(buf, chan->cid.cid_num, len);
} }
@ -113,8 +110,7 @@ static int callerid_write(struct ast_channel *chan, char *cmd, char *data,
ast_set_callerid(chan, num, name, num); ast_set_callerid(chan, num, name, num);
} else if (!strncasecmp("name", data, 4)) { } else if (!strncasecmp("name", data, 4)) {
ast_set_callerid(chan, NULL, value, NULL); ast_set_callerid(chan, NULL, value, NULL);
} else if (!strncasecmp("num", data, 3) || } else if (!strncasecmp("num", data, 3)) {
!strncasecmp("number", data, 6)) {
ast_set_callerid(chan, value, NULL, NULL); ast_set_callerid(chan, value, NULL, NULL);
} else if (!strncasecmp("ani", data, 3)) { } else if (!strncasecmp("ani", data, 3)) {
ast_set_callerid(chan, NULL, NULL, value); ast_set_callerid(chan, NULL, NULL, value);

Loading…
Cancel
Save