Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix the attack shield for 1.2 too. REFER and NOTIFY can create dialogs

Browse Source 
in the world of Asterisk.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.2
Olle Johansson 19 years ago
parent 78d7b2641a
commit 4dc847a0f4
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File

23
channels/chan_sip.c
Unescape View File

@ -209,18 +209,18 @@ static const struct cfsip_methods {
enum sipmethod id; enum sipmethod id;
int need_rtp; /*!< when this is the 'primary' use for a pvt structure, does it need RTP? */ int need_rtp; /*!< when this is the 'primary' use for a pvt structure, does it need RTP? */
char * const text; char * const text;
int can_create; int can_create; /*!< 0=can't create, 1 can create, 2 can create, but not supported */
} sip_methods[] = { } sip_methods[] = {
{ SIP_UNKNOWN, RTP, "-UNKNOWN-", 0 }, { SIP_UNKNOWN, RTP, "-UNKNOWN-", 2 },
{ SIP_RESPONSE, NO_RTP, "SIP/2.0", 0 }, { SIP_RESPONSE, NO_RTP, "SIP/2.0", 0 },
{ SIP_REGISTER, NO_RTP, "REGISTER", 1 }, { SIP_REGISTER, NO_RTP, "REGISTER", 1 },
{ SIP_OPTIONS, NO_RTP, "OPTIONS", 1 }, { SIP_OPTIONS, NO_RTP, "OPTIONS", 1 },
{ SIP_NOTIFY, NO_RTP, "NOTIFY", 0 }, { SIP_NOTIFY, NO_RTP, "NOTIFY", 2 },
{ SIP_INVITE, RTP, "INVITE", 1 }, { SIP_INVITE, RTP, "INVITE", 1 },
{ SIP_ACK, NO_RTP, "ACK", 0 }, { SIP_ACK, NO_RTP, "ACK", 0 },
{ SIP_PRACK, NO_RTP, "PRACK", 0 }, { SIP_PRACK, NO_RTP, "PRACK", 2 },
{ SIP_BYE, NO_RTP, "BYE", 0 }, { SIP_BYE, NO_RTP, "BYE", 0 },
{ SIP_REFER, NO_RTP, "REFER", 0 }, { SIP_REFER, NO_RTP, "REFER", 2 },
{ SIP_SUBSCRIBE, NO_RTP, "SUBSCRIBE", 1 }, { SIP_SUBSCRIBE, NO_RTP, "SUBSCRIBE", 1 },
{ SIP_MESSAGE, NO_RTP, "MESSAGE", 1 }, { SIP_MESSAGE, NO_RTP, "MESSAGE", 1 },
{ SIP_UPDATE, NO_RTP, "UPDATE", 0 }, { SIP_UPDATE, NO_RTP, "UPDATE", 0 },
@ -3242,8 +3242,21 @@ static struct sip_pvt *find_call(struct sip_request *req, struct sockaddr_in *si
/* If this is a response and we have ignoring of out of dialog responses turned on, then drop it */ /* If this is a response and we have ignoring of out of dialog responses turned on, then drop it */
if (!sip_methods[intended_method].can_create) { if (!sip_methods[intended_method].can_create) {
/* Can't create dialog */
if (intended_method != SIP_RESPONSE) if (intended_method != SIP_RESPONSE)
transmit_response_using_temp(callid, sin, 1, intended_method, req, "481 Call leg/transaction does not exist"); transmit_response_using_temp(callid, sin, 1, intended_method, req, "481 Call leg/transaction does not exist");
} else if (sip_methods[intended_method].can_create == 2) {
char *response = "481 Call leg/transaction does not exist";
/* In theory, can create dialog. We don't support it */
if (intended_method == SIP_PRACK || intended_method == SIP_UNKNOWN)
response = "501 Method not implemented";
else if(intended_method == SIP_REFER)
response = "603 Declined (no dialog)";
else if(intended_method == SIP_NOTIFY)
response = "489 Bad event";
transmit_response_using_temp(callid, sin, 1, intended_method, req, "603 Declined (no dialog)");
} else { } else {
p = sip_alloc(callid, sin, 1, intended_method); p = sip_alloc(callid, sin, 1, intended_method);
if (p) if (p)

Write Preview
Loading…
Cancel
Save