tcptls: when disabling a server port, we should set the accept_fd to -1.

If we don't set this to -1 if the structure can be potentially re-used
later then it's possible that we'll issue a close() on an unrelated file
descriptor, breaking asterisk in other interesting ways.

I believe this to be an unlikely scenario, but it costs nothing to be
safe.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
(cherry picked from commit 4e657b6181)
pull/310/head
Jaco Kroon 2 years ago committed by Asterisk Development Team
parent 5156156443
commit 4cc8497c61

@ -837,6 +837,7 @@ void ast_tcptls_server_start(struct ast_tcptls_session_args *desc)
if (desc->accept_fd != -1) {
close(desc->accept_fd);
desc->accept_fd = -1;
}
/* If there's no new server, stop here */

Loading…
Cancel
Save