Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

res_rtp_asterisk: Ensure sufficient space for worst case NACK.

Browse Source 
ASTERISK-28790

Change-Id: I10df52f98b19ed62575f25dab36e82d136dccd99
17.4
Joshua C. Colp 5 years ago committed by Joshua Colp
parent ba47752d0d
commit 4b2729e89d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File

5
res/res_rtp_asterisk.c
Unescape View File

@ -7964,12 +7964,15 @@ static struct ast_frame *ast_rtp_read(struct ast_rtp_instance *instance, int rtc
int res = 0; int res = 0;
int ice; int ice;
int sr; int sr;
size_t data_size = AST_UUID_STR_LEN + 128 + (seqno - rtp->expectedrxseqno) / 17; size_t data_size = AST_UUID_STR_LEN + 128 + (AST_VECTOR_SIZE(&rtp->missing_seqno) * 4);
RAII_VAR(unsigned char *, rtcpheader, NULL, ast_free_ptr); RAII_VAR(unsigned char *, rtcpheader, NULL, ast_free_ptr);
RAII_VAR(struct ast_rtp_rtcp_report *, rtcp_report, RAII_VAR(struct ast_rtp_rtcp_report *, rtcp_report,
ast_rtp_rtcp_report_alloc(rtp->themssrc_valid ? 1 : 0), ast_rtp_rtcp_report_alloc(rtp->themssrc_valid ? 1 : 0),
ao2_cleanup); ao2_cleanup);
/* Sufficient space for RTCP headers and report, SDES with CNAME, NACK header,
* and worst case 4 bytes per missing sequence number.
*/
rtcpheader = ast_malloc(sizeof(*rtcpheader) + data_size); rtcpheader = ast_malloc(sizeof(*rtcpheader) + data_size);
if (!rtcpheader) { if (!rtcpheader) {
ast_debug(1, "Failed to allocate memory for NACK\n"); ast_debug(1, "Failed to allocate memory for NACK\n");

Write Preview
Loading…
Cancel
Save