Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

Resolve some errors that occur on a graceful shutdown.

Browse Source 
Don't Finalize() if Initialize() did not succeed.  This resulted in an error
about trying to Finalize() an invalid handle.

Also trim some trailing whitespace while in the area.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@271867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
certified/1.8.6
Russell Bryant 16 years ago
parent 9cc7c55578
commit 294c78a27e
2 changed files with 43 additions and 36 deletions
Show Stats Download Patch File Download Diff File

25
res/ais/clm.c
Unescape View File

@ -16,7 +16,7 @@
* at the top of the source tree. * at the top of the source tree.
*/ */
/*! /*!
* \file * \file
* \author Russell Bryant <russell@digium.com> * \author Russell Bryant <russell@digium.com>
* *
@ -24,7 +24,7 @@
* *
* \arg http://www.openais.org/ * \arg http://www.openais.org/
* *
* This file contains the code specific to the use of the CLM * This file contains the code specific to the use of the CLM
* (Cluster Membership) Service. * (Cluster Membership) Service.
*/ */
@ -46,8 +46,9 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$");
#include "asterisk/logger.h" #include "asterisk/logger.h"
SaClmHandleT clm_handle; SaClmHandleT clm_handle;
static SaAisErrorT clm_init_res;
static void clm_node_get_cb(SaInvocationT invocation, static void clm_node_get_cb(SaInvocationT invocation,
const SaClmClusterNodeT *cluster_node, SaAisErrorT error); const SaClmClusterNodeT *cluster_node, SaAisErrorT error);
static void clm_track_cb(const SaClmClusterNotificationBufferT *notif_buffer, static void clm_track_cb(const SaClmClusterNotificationBufferT *notif_buffer,
SaUint32T num_members, SaAisErrorT error); SaUint32T num_members, SaAisErrorT error);
@ -57,7 +58,7 @@ static const SaClmCallbacksT clm_callbacks = {
.saClmClusterTrackCallback = clm_track_cb, .saClmClusterTrackCallback = clm_track_cb,
}; };
static void clm_node_get_cb(SaInvocationT invocation, static void clm_node_get_cb(SaInvocationT invocation,
const SaClmClusterNodeT *cluster_node, SaAisErrorT error) const SaClmClusterNodeT *cluster_node, SaAisErrorT error)
{ {
@ -114,7 +115,7 @@ static char *ais_clm_show_members(struct ast_cli_entry *e, int cmd, struct ast_c
"=== ==> ID: 0x%x\n" "=== ==> ID: 0x%x\n"
"=== ==> Address: %s\n" "=== ==> Address: %s\n"
"=== ==> Member: %s\n", "=== ==> Member: %s\n",
(char *) node->nodeName.value, (int) node->nodeId, (char *) node->nodeName.value, (int) node->nodeId,
(char *) node->nodeAddress.value, (char *) node->nodeAddress.value,
node->member ? "Yes" : "No"); node->member ? "Yes" : "No");
@ -134,12 +135,10 @@ static struct ast_cli_entry ais_cli[] = {
int ast_ais_clm_load_module(void) int ast_ais_clm_load_module(void)
{ {
SaAisErrorT ais_res; clm_init_res = saClmInitialize(&clm_handle, &clm_callbacks, &ais_version);
if (clm_init_res != SA_AIS_OK) {
ais_res = saClmInitialize(&clm_handle, &clm_callbacks, &ais_version);
if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Could not initialize cluster membership service: %s\n", ast_log(LOG_ERROR, "Could not initialize cluster membership service: %s\n",
ais_err2str(ais_res)); ais_err2str(clm_init_res));
return -1; return -1;
} }
@ -152,11 +151,15 @@ int ast_ais_clm_unload_module(void)
{ {
SaAisErrorT ais_res; SaAisErrorT ais_res;
if (clm_init_res != SA_AIS_OK) {
return 0;
}
ast_cli_unregister_multiple(ais_cli, ARRAY_LEN(ais_cli)); ast_cli_unregister_multiple(ais_cli, ARRAY_LEN(ais_cli));
ais_res = saClmFinalize(clm_handle); ais_res = saClmFinalize(clm_handle);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Problem stopping cluster membership service: %s\n", ast_log(LOG_ERROR, "Problem stopping cluster membership service: %s\n",
ais_err2str(ais_res)); ais_err2str(ais_res));
return -1; return -1;
} }

54
res/ais/evt.c
Unescape View File

@ -16,7 +16,7 @@
* at the top of the source tree. * at the top of the source tree.
*/ */
/*! /*!
* \file * \file
* \author Russell Bryant <russell@digium.com> * \author Russell Bryant <russell@digium.com>
* *
@ -24,7 +24,7 @@
* *
* \arg http://www.openais.org/ * \arg http://www.openais.org/
* *
* This file contains the code specific to the use of the EVT * This file contains the code specific to the use of the EVT
* (Event) Service. * (Event) Service.
*/ */
@ -55,6 +55,7 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$");
#endif #endif
SaEvtHandleT evt_handle; SaEvtHandleT evt_handle;
static SaAisErrorT evt_init_res;
void evt_channel_open_cb(SaInvocationT invocation, SaEvtChannelHandleT channel_handle, void evt_channel_open_cb(SaInvocationT invocation, SaEvtChannelHandleT channel_handle,
SaAisErrorT error); SaAisErrorT error);
@ -63,7 +64,7 @@ void evt_event_deliver_cb(SaEvtSubscriptionIdT subscription_id,
static const SaEvtCallbacksT evt_callbacks = { static const SaEvtCallbacksT evt_callbacks = {
.saEvtChannelOpenCallback = evt_channel_open_cb, .saEvtChannelOpenCallback = evt_channel_open_cb,
.saEvtEventDeliverCallback = evt_event_deliver_cb, .saEvtEventDeliverCallback = evt_event_deliver_cb,
}; };
static const struct { static const struct {
@ -136,7 +137,7 @@ void evt_event_deliver_cb(SaEvtSubscriptionIdT sub_id,
ais_res = saEvtEventDataGet(event_handle, event, &len); ais_res = saEvtEventDataGet(event_handle, event, &len);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Error retrieving event payload: %s\n", ast_log(LOG_ERROR, "Error retrieving event payload: %s\n",
ais_err2str(ais_res)); ais_err2str(ais_res));
return; return;
} }
@ -148,7 +149,7 @@ void evt_event_deliver_cb(SaEvtSubscriptionIdT sub_id,
if (!(event_dup = ast_malloc(len))) if (!(event_dup = ast_malloc(len)))
return; return;
memcpy(event_dup, event, len); memcpy(event_dup, event, len);
queue_event(event_dup); queue_event(event_dup);
@ -195,8 +196,8 @@ static void ast_event_cb(const struct ast_event *ast_event, void *data)
ast_log(LOG_DEBUG, "Returning here\n"); ast_log(LOG_DEBUG, "Returning here\n");
return; return;
} }
ais_res = saClmClusterNodeGet(clm_handle, SA_CLM_LOCAL_NODE_ID, ais_res = saClmClusterNodeGet(clm_handle, SA_CLM_LOCAL_NODE_ID,
SA_TIME_ONE_SECOND, &local_node); SA_TIME_ONE_SECOND, &local_node);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Error getting local node name: %s\n", ais_err2str(ais_res)); ast_log(LOG_ERROR, "Error getting local node name: %s\n", ais_err2str(ais_res));
@ -213,8 +214,8 @@ static void ast_event_cb(const struct ast_event *ast_event, void *data)
pattern_array.patternsNumber = 1; pattern_array.patternsNumber = 1;
pattern_array.patterns = &pattern; pattern_array.patterns = &pattern;
/*! /*!
* /todo Make retention time configurable * /todo Make retention time configurable
* /todo Make event priorities configurable * /todo Make event priorities configurable
*/ */
ais_res = saEvtEventAttributesSet(event_handle, &pattern_array, ais_res = saEvtEventAttributesSet(event_handle, &pattern_array,
@ -224,7 +225,7 @@ static void ast_event_cb(const struct ast_event *ast_event, void *data)
goto return_event_free; goto return_event_free;
} }
ais_res = saEvtEventPublish(event_handle, ais_res = saEvtEventPublish(event_handle,
ast_event, ast_event_get_size(ast_event), &event_id); ast_event, ast_event_get_size(ast_event), &event_id);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Error publishing event: %s\n", ais_err2str(ais_res)); ast_log(LOG_ERROR, "Error publishing event: %s\n", ais_err2str(ais_res));
@ -273,12 +274,12 @@ static char *ais_evt_show_event_channels(struct ast_cli_entry *e, int cmd, struc
"=== Event Channel Name: %s\n", event_channel->name); "=== Event Channel Name: %s\n", event_channel->name);
AST_LIST_TRAVERSE(&event_channel->publish_events, publish_event, entry) { AST_LIST_TRAVERSE(&event_channel->publish_events, publish_event, entry) {
ast_cli(a->fd, "=== ==> Publishing Event Type: %s\n", ast_cli(a->fd, "=== ==> Publishing Event Type: %s\n",
type_to_filter_str(publish_event->type)); type_to_filter_str(publish_event->type));
} }
AST_LIST_TRAVERSE(&event_channel->subscribe_events, subscribe_event, entry) { AST_LIST_TRAVERSE(&event_channel->subscribe_events, subscribe_event, entry) {
ast_cli(a->fd, "=== ==> Subscribing to Event Type: %s\n", ast_cli(a->fd, "=== ==> Subscribing to Event Type: %s\n",
type_to_filter_str(subscribe_event->type)); type_to_filter_str(subscribe_event->type));
} }
@ -353,7 +354,7 @@ static SaAisErrorT set_egress_subscription(struct event_channel *event_channel,
filter_array.filtersNumber = 1; filter_array.filtersNumber = 1;
filter_array.filters = &filter; filter_array.filters = &filter;
ais_res = saEvtEventSubscribe(event_channel->handle, &filter_array, ais_res = saEvtEventSubscribe(event_channel->handle, &filter_array,
subscribe_event->id); subscribe_event->id);
return ais_res; return ais_res;
@ -425,7 +426,7 @@ static void build_event_channel(struct ast_config *cfg, const char *cat)
strcpy(event_channel->name, cat); strcpy(event_channel->name, cat);
ast_copy_string((char *) sa_name.value, cat, sizeof(sa_name.value)); ast_copy_string((char *) sa_name.value, cat, sizeof(sa_name.value));
sa_name.length = strlen((char *) sa_name.value); sa_name.length = strlen((char *) sa_name.value);
ais_res = saEvtChannelOpen(evt_handle, &sa_name, ais_res = saEvtChannelOpen(evt_handle, &sa_name,
SA_EVT_CHANNEL_PUBLISHER | SA_EVT_CHANNEL_SUBSCRIBER | SA_EVT_CHANNEL_CREATE, SA_EVT_CHANNEL_PUBLISHER | SA_EVT_CHANNEL_SUBSCRIBER | SA_EVT_CHANNEL_CREATE,
SA_TIME_MAX, &event_channel->handle); SA_TIME_MAX, &event_channel->handle);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
@ -477,7 +478,7 @@ static void load_config(void)
if (!strcasecmp(type, "event_channel")) { if (!strcasecmp(type, "event_channel")) {
build_event_channel(cfg, cat); build_event_channel(cfg, cat);
} else { } else {
ast_log(LOG_WARNING, "Entry in %s defined with invalid type '%s'\n", ast_log(LOG_WARNING, "Entry in %s defined with invalid type '%s'\n",
filename, type); filename, type);
} }
} }
@ -532,22 +533,21 @@ static void destroy_event_channels(void)
struct event_channel *event_channel; struct event_channel *event_channel;
AST_RWLIST_WRLOCK(&event_channels); AST_RWLIST_WRLOCK(&event_channels);
while ((event_channel = AST_RWLIST_REMOVE_HEAD(&event_channels, entry))) while ((event_channel = AST_RWLIST_REMOVE_HEAD(&event_channels, entry))) {
event_channel_destroy(event_channel); event_channel_destroy(event_channel);
}
AST_RWLIST_UNLOCK(&event_channels); AST_RWLIST_UNLOCK(&event_channels);
} }
int ast_ais_evt_load_module(void) int ast_ais_evt_load_module(void)
{ {
SaAisErrorT ais_res; evt_init_res = saEvtInitialize(&evt_handle, &evt_callbacks, &ais_version);
if (evt_init_res != SA_AIS_OK) {
ais_res = saEvtInitialize(&evt_handle, &evt_callbacks, &ais_version);
if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Could not initialize eventing service: %s\n", ast_log(LOG_ERROR, "Could not initialize eventing service: %s\n",
ais_err2str(ais_res)); ais_err2str(evt_init_res));
return -1; return -1;
} }
load_config(); load_config();
ast_cli_register_multiple(ais_cli, ARRAY_LEN(ais_cli)); ast_cli_register_multiple(ais_cli, ARRAY_LEN(ais_cli));
@ -559,14 +559,18 @@ int ast_ais_evt_unload_module(void)
{ {
SaAisErrorT ais_res; SaAisErrorT ais_res;
if (evt_init_res != SA_AIS_OK) {
return 0;
}
destroy_event_channels(); destroy_event_channels();
ais_res = saEvtFinalize(evt_handle); ais_res = saEvtFinalize(evt_handle);
if (ais_res != SA_AIS_OK) { if (ais_res != SA_AIS_OK) {
ast_log(LOG_ERROR, "Problem stopping eventing service: %s\n", ast_log(LOG_ERROR, "Problem stopping eventing service: %s\n",
ais_err2str(ais_res)); ais_err2str(ais_res));
return -1; return -1;
} }
return 0; return 0;
} }

Write Preview
Loading…
Cancel
Save