Fix minor memory leak in pval.c. Overwriting a value without freeing the previous result is bad, mmmk?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.6.0
Joshua Colp 18 years ago
parent 3a5f263bf0
commit 20a71bad79

@ -3144,7 +3144,6 @@ static void gen_prios(struct ael_extension *exten, char *label, pval *statement,
strncat(buf2,strp2+1, sizeof(buf2)-strlen(strp2+1)-2); strncat(buf2,strp2+1, sizeof(buf2)-strlen(strp2+1)-2);
strcat(buf2,"]"); strcat(buf2,"]");
for_init->appargs = strdup(buf2); for_init->appargs = strdup(buf2);
for_init->app = strdup("Set");
} else { } else {
strp2 = p->u1.for_init; strp2 = p->u1.for_init;
while (*strp2 && isspace(*strp2)) while (*strp2 && isspace(*strp2))
@ -3166,7 +3165,7 @@ static void gen_prios(struct ael_extension *exten, char *label, pval *statement,
*strp3 = 0; /* remove the closing paren */ *strp3 = 0; /* remove the closing paren */
for_init->appargs = strdup(buf2); for_init->appargs = strdup(buf2);
free(for_init->app);
for_init->app = strdup("Macro"); for_init->app = strdup("Macro");
} else { /* must be a regular app call */ } else { /* must be a regular app call */
char *strp3; char *strp3;
@ -3174,6 +3173,7 @@ static void gen_prios(struct ael_extension *exten, char *label, pval *statement,
strp3 = strchr(buf2,'('); strp3 = strchr(buf2,'(');
if (strp3) { if (strp3) {
*strp3 = 0; *strp3 = 0;
free(for_init->app);
for_init->app = strdup(buf2); for_init->app = strdup(buf2);
for_init->appargs = strdup(strp3+1); for_init->appargs = strdup(strp3+1);
strp3 = strrchr(for_init->appargs, ')'); strp3 = strrchr(for_init->appargs, ')');

Loading…
Cancel
Save