Sending a 403 after a 200 is considered very bad.

(found at SIPit)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148471 65c4cc65-6c06-0410-ace0-fbb531ad65f3

channels/chan_sip.c

@@ -11142,6 +11142,12 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct sockaddr
 				if (sip_cancel_destroy(p))
 					ast_log(LOG_WARNING, "Unable to cancel SIP destruction.  Expect bad things.\n");
 
+				if (check_request_transport(peer, req)) {
+					ast_set_flag(&p->flags[0], SIP_PENDINGBYE);
+					transmit_response_with_date(p, "403 Forbidden", req);
+					res = AUTH_BAD_TRANSPORT;
+				} else {
+
 					/* We have a successful registration attempt with proper authentication,
 				   	now, update the peer */
 					switch (parse_register_contact(p, peer, req)) {
@@ -11165,12 +11171,8 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct sockaddr
 						res = 0;
 						break;
 					}
-
-				if (check_request_transport(peer, req)) {
-					ast_set_flag(&p->flags[0], SIP_PENDINGBYE);
-					transmit_response_with_date(p, "403 Forbidden", req);
-					res = AUTH_BAD_TRANSPORT;
 				}
+
 			} 
 		}
 	}